Re: RFR:JDK-8030864:Add an efficient getDateTimeMillis method to java.time

Hi Nadeesh, Looks good Thanks, Roger On 3/29/2016 8:12 AM, nadeesh tv wrote: Hi Roger, Please see the updated webrev http://cr.openjdk.java.net/~ntv/8030864/webrev.08/ Regards, Nadeesh On 3/11/2016 9:19 PM, Roger Riggs wrote: Hi Nadeesh, Thanks for filling in the missing

Re: RFR:JDK-8030864:Add an efficient getDateTimeMillis method to java.time

Hi Roger, Please see the updated webrev http://cr.openjdk.java.net/~ntv/8030864/webrev.08/ Regards, Nadeesh On 3/11/2016 9:19 PM, Roger Riggs wrote: Hi Nadeesh, Thanks for filling in the missing DateTimeException cases. - src/java.base/share/classes/java/time/chrono/IsoChronology.java: " *

Re: RFR:JDK-8030864:Add an efficient getDateTimeMillis method to java.time

Hi Nadeesh, Thanks for filling in the missing DateTimeException cases. - src/java.base/share/classes/java/time/chrono/IsoChronology.java: " * @throws DateTimeException if the value of any field is out of range, + * or if the day-of-month is invalid for the month-of-year" refers to

Re: RFR:JDK-8030864:Add an efficient getDateTimeMillis method to java.time

Hi all, Please see the updated webrev http://cr.openjdk.java.net/~ntv/8030864/webrev.07/ Changes: + @throws DateTimeException if any of the values are out of range in Chronology.epochSecond() and new test cases related to excepted exception in TCKChronology.test_bad_epochSecond() Thanks

Re: RFR:JDK-8030864:Add an efficient getDateTimeMillis method to java.time

Look fine. Roger On 3/5/2016 7:05 AM, nadeesh tv wrote: Hi all, Please see the updated webrev http://cr.openjdk.java.net/~ntv/8030864/webrev.06/ Regards, Nadeesh On 3/4/2016 4:34 PM, Stephen Colebourne wrote: long DAYS__TO_1970 should be extracted as a private static final constant.

Re: RFR:JDK-8030864:Add an efficient getDateTimeMillis method to java.time

Hi all, Please see the updated webrev http://cr.openjdk.java.net/~ntv/8030864/webrev.06/ Regards, Nadeesh On 3/4/2016 4:34 PM, Stephen Colebourne wrote: long DAYS__TO_1970 should be extracted as a private static final constant. Otherwise looks good. Stephen On 3 March 2016 at 18:54,

Re: RFR:JDK-8030864:Add an efficient getDateTimeMillis method to java.time

long DAYS__TO_1970 should be extracted as a private static final constant. Otherwise looks good. Stephen On 3 March 2016 at 18:54, nadeesh tv wrote: > Hi, > > Roger - Thanks for the comments > > Made the necessary changes in the spec > > Please see the updated webrev

Re: RFR:JDK-8030864:Add an efficient getDateTimeMillis method to java.time

Hi, Roger - Thanks for the comments Made the necessary changes in the spec Please see the updated webrev http://cr.openjdk.java.net/~ntv/8030864/webrev.05/ On 3/3/2016 12:21 AM, nadeesh tv wrote: Hi , Please see the updated webrev http://cr.openjdk.java.net/~ntv/8030864/webrev.03/

Re: RFR:JDK-8030864:Add an efficient getDateTimeMillis method to java.time

Hi , Please see the updated webrev http://cr.openjdk.java.net/~ntv/8030864/webrev.03/ Thanks and Regards, Nadeesh On 3/3/2016 12:01 AM, Roger Riggs wrote: Hi Nadeesh, Editorial comments: Chronology.java: 716+ "Java epoch" -> "epoch" "minute, second and zoneOffset" -> "minute,

Re: RFR:JDK-8030864:Add an efficient getDateTimeMillis method to java.time

Hi Nadeesh, Editorial comments: Chronology.java: 716+ "Java epoch" -> "epoch" "minute, second and zoneOffset" -> "minute, second*,* and zoneOffset" (add a comma; two places) "caluculated using given era, prolepticYear," -> "calculated using the era, year-of-era," "to represent"

Re: RFR:JDK-8030864:Add an efficient getDateTimeMillis method to java.time

I think that this is fine now, but Roger/others should also chime in. thanks Stephen On 2 March 2016 at 15:17, nadeesh tv wrote: > Hi, > Stephen, Thanks for the comments. > Please see the updated webrev > http://cr.openjdk.java.net/~ntv/8030864/webrev.02/ > > Regards, >

Re: RFR:JDK-8030864:Add an efficient getDateTimeMillis method to java.time

Hi, Stephen, Thanks for the comments. Please see the updated webrev http://cr.openjdk.java.net/~ntv/8030864/webrev.02/ Regards, Nadeesh TV On 3/2/2016 5:41 PM, Stephen Colebourne wrote: Remove "Subclass can override the default implementation for a more efficient implementation." as it adds no

Re: RFR:JDK-8030864:Add an efficient getDateTimeMillis method to java.time

Remove "Subclass can override the default implementation for a more efficient implementation." as it adds no value. In the default implementation of epochSecond(Era era, int yearofEra, int month, int dayOfMonth, int hour, int minute, int second, ZoneOffset zoneOffset) use prolepticYear(era,

RFR:JDK-8030864:Add an efficient getDateTimeMillis method to java.time

Hi all, Please review an enhancement for a garbage free epochSecond method. Bug ID: https://bugs.openjdk.java.net/browse/JDK-8030864 webrev: http://cr.openjdk.java.net/~ntv/8030864/webrev.01