Hi Roger,
Ok. Thanks.
Regards,
Nadeesh
On 5/4/2016 7:58 PM, Roger Riggs wrote:
Hi Nadeesh,
java/time/format/DateTimeFormatterBuilder.java: 1836-1839
Correct as is, but could collapse both count ==2 and count ==3 into a
single appendValue call:
appendValue(field, count, 3,
Hi Nadeesh,
java/time/format/DateTimeFormatterBuilder.java: 1836-1839
Correct as is, but could collapse both count ==2 and count ==3 into a
single appendValue call:
appendValue(field, count, 3, SignStyle.NOT_NEGATIVE); Reviewed.
Roger
On 5/4/2016 3:15 AM, nadeesh tv wrote:
Hi,
Updated
Hi,
Updated the webev http://cr.openjdk.java.net/~ntv/8079628/webrev.04/
Regards,
Nadeesh
On 5/3/2016 8:45 PM, Stephen Colebourne wrote:
Letters "Q", "q", "M", "L", "d", "D", "F", "h", "H", "k", "K", "m",
"s" and no doubt others use NORMAL via
appendValue(field);
Changing these to use
Letters "Q", "q", "M", "L", "d", "D", "F", "h", "H", "k", "K", "m",
"s" and no doubt others use NORMAL via
appendValue(field);
Changing these to use NOT_NEGATIVE would be a big change and doesn't
seem justified.
For "D", "DD" and "DDD" these seem to be the best balance (as
discussed
Hi Nadeesh,
On 5/3/2016 3:24 AM, nadeesh tv wrote:
Hi Roger,
Please see the answers inline
On 5/3/2016 2:43 AM, Roger Riggs wrote:
Hi Nadeesh,
src/java.base/share/classes/java/time/format/DateTimeFormatterBuilder.java
line 1835: the appendValue(field) method has a sign-style of NORMAL;
Hi Roger,
Please see the answers inline
On 5/3/2016 2:43 AM, Roger Riggs wrote:
Hi Nadeesh,
src/java.base/share/classes/java/time/format/DateTimeFormatterBuilder.java
line 1835: the appendValue(field) method has a sign-style of NORMAL;
should that be NOT_NEGATIVE?
It's 'NOT_NEGATIVE'
Hi Nadeesh,
src/java.base/share/classes/java/time/format/DateTimeFormatterBuilder.java
line 1835: the appendValue(field) method has a sign-style of NORMAL;
should that be NOT_NEGATIVE?
test/java/time/tck/java/time/format/TCKDateTimeFormatterBuilder.java:
What is being tested in
Hi all,
Please see the updated webrev
http://cr.openjdk.java.net/~ntv/8079628/webrev.02/
Thanks and Regards,
Nadeesh TV
On 4/28/2016 8:17 PM, Stephen Colebourne wrote:
My mistake on the spec for "DD". It should be SignStyle.NOT_NEGATIVE,
not NORMAL.
I'd like to see a test that checks
Hi all,
Thanks Stephen for the comments.
Please see the updated webrev
http://cr.openjdk.java.net/~ntv/8079628/webrev.01/
Regards,
Nadeesh TV
On 4/26/2016 5:42 PM, Stephen Colebourne wrote:
This change introduces inconsistencies and problems. For example, it
will parse up to 19 digits for
This change introduces inconsistencies and problems. For example, it
will parse up to 19 digits for "D" but only up to 2 digits for "d".
The following would be better:
*D 1 appendValue(ChronoField.DAY_OF_YEAR)
*DD 2 appendValue(ChronoField.DAY_OF_YEAR, 2, 3,
Hi all,
Please review a fix for
Bug ID - https://bugs.openjdk.java.net/browse/JDK-8079628
Issue - Pattern 'D' is not implemented as intended by CLDR
Solution - Changed the definition of 'D' to D..D 1..3
appendValue(ChronoField.DAY_OF_YEAR, n, 19, SignStyle.NORMAL)
Webrev -
11 matches
Mail list logo
