Re: RFR[9]:java/lang/invoke/VarargsArrayTest.java miss othervm for main/bootclasspath mode

2016-05-17 Thread shilpi.rast...@oracle.com
On 5/17/2016 10:28 PM, Vladimir Ivanov wrote: Could someone please explain why it is not required for this test as i saw we are updating other tests ( http://hg.openjdk.java.net/jdk9/hs/hotspot/rev/0e2a2be60453 ) ? The test was fixed in Jigsaw repo [1] in a different way. Before the fix, the

Re: RFR[9]:java/lang/invoke/VarargsArrayTest.java miss othervm for main/bootclasspath mode

2016-05-17 Thread Vladimir Ivanov
Could someone please explain why it is not required for this test as i saw we are updating other tests ( http://hg.openjdk.java.net/jdk9/hs/hotspot/rev/0e2a2be60453 ) ? The test was fixed in Jigsaw repo [1] in a different way. Before the fix, the test class should be put on boot class path (he

Re: RFR[9]:java/lang/invoke/VarargsArrayTest.java miss othervm for main/bootclasspath mode

2016-05-17 Thread Aleksey Shipilev
On 05/17/2016 07:50 PM, shilpi.rast...@oracle.com wrote: > On 5/17/2016 7:44 PM, Alan Bateman wrote: >> >> On 17/05/2016 14:34, Martin Buchholz wrote: >>> In jdk8 the /othervm is missing. >>> http://mail.openjdk.java.net/pipermail/jtreg-use/2016-May/000478.html >>> >> Ah, I assumed we were discussi

Re: RFR[9]:java/lang/invoke/VarargsArrayTest.java miss othervm for main/bootclasspath mode

2016-05-17 Thread shilpi.rast...@oracle.com
On 5/17/2016 7:44 PM, Alan Bateman wrote: On 17/05/2016 14:34, Martin Buchholz wrote: In jdk8 the /othervm is missing. http://mail.openjdk.java.net/pipermail/jtreg-use/2016-May/000478.html Ah, I assumed we were discussing the version in jdk9/dev. BTW: My interest here is to make sure we di

Re: RFR[9]:java/lang/invoke/VarargsArrayTest.java miss othervm for main/bootclasspath mode

2016-05-17 Thread Alan Bateman
On 17/05/2016 14:34, Martin Buchholz wrote: In jdk8 the /othervm is missing. http://mail.openjdk.java.net/pipermail/jtreg-use/2016-May/000478.html Ah, I assumed we were discussing the version in jdk9/dev. BTW: My interest here is to make sure we didn't break anything with the module system r

Re: RFR[9]:java/lang/invoke/VarargsArrayTest.java miss othervm for main/bootclasspath mode

2016-05-17 Thread Martin Buchholz
In jdk8 the /othervm is missing. http://mail.openjdk.java.net/pipermail/jtreg-use/2016-May/000478.html On Tue, May 17, 2016 at 6:20 AM, Alan Bateman wrote: > > > On 17/05/2016 13:21, shilpi.rast...@oracle.com wrote: >> >> Gentle Reminder! >> >> https://bugs.openjdk.java.net/browse/JDK-8155791 >>

Re: RFR[9]:java/lang/invoke/VarargsArrayTest.java miss othervm for main/bootclasspath mode

2016-05-17 Thread Alan Bateman
On 17/05/2016 13:21, shilpi.rast...@oracle.com wrote: Gentle Reminder! https://bugs.openjdk.java.net/browse/JDK-8155791 http://cr.openjdk.java.net/~srastogi/8155791/webrev.00/ Is this test failing? I can't quite tell why it needs to be on the boot class path, -Alan.

Re: RFR[9]:java/lang/invoke/VarargsArrayTest.java miss othervm for main/bootclasspath mode

2016-05-17 Thread David Holmes
On 17/05/2016 10:58 PM, Aleksey Shipilev wrote: On 05/17/2016 03:45 PM, shilpi.rast...@oracle.com wrote: On 5/17/2016 6:00 PM, Aleksey Shipilev wrote: On 05/17/2016 03:21 PM, shilpi.rast...@oracle.com wrote: https://bugs.openjdk.java.net/browse/JDK-8155791 http://cr.openjdk.java.net/~srastogi/

Re: RFR[9]:java/lang/invoke/VarargsArrayTest.java miss othervm for main/bootclasspath mode

2016-05-17 Thread Aleksey Shipilev
On 05/17/2016 03:45 PM, shilpi.rast...@oracle.com wrote: > On 5/17/2016 6:00 PM, Aleksey Shipilev wrote: >> On 05/17/2016 03:21 PM, shilpi.rast...@oracle.com wrote: >>> https://bugs.openjdk.java.net/browse/JDK-8155791 >>> http://cr.openjdk.java.net/~srastogi/8155791/webrev.00/ > Parse Exception

Re: RFR[9]:java/lang/invoke/VarargsArrayTest.java miss othervm for main/bootclasspath mode

2016-05-17 Thread shilpi.rast...@oracle.com
On 5/17/2016 6:00 PM, Aleksey Shipilev wrote: On 05/17/2016 03:21 PM, shilpi.rast...@oracle.com wrote: Gentle Reminder! https://bugs.openjdk.java.net/browse/JDK-8155791 http://cr.openjdk.java.net/~srastogi/8155791/webrev.00/ Parse Exception: [-esa]: vm option(s) found, need to specify /other

Re: RFR[9]:java/lang/invoke/VarargsArrayTest.java miss othervm for main/bootclasspath mode

2016-05-17 Thread Aleksey Shipilev
On 05/17/2016 03:21 PM, shilpi.rast...@oracle.com wrote: > Gentle Reminder! > > https://bugs.openjdk.java.net/browse/JDK-8155791 > http://cr.openjdk.java.net/~srastogi/8155791/webrev.00/ >>> Parse Exception: [-esa]: vm option(s) found, need to specify /othervm Still not getting this. The message

Re: RFR[9]:java/lang/invoke/VarargsArrayTest.java miss othervm for main/bootclasspath mode

2016-05-17 Thread shilpi.rast...@oracle.com
Gentle Reminder! https://bugs.openjdk.java.net/browse/JDK-8155791 http://cr.openjdk.java.net/~srastogi/8155791/webrev.00/ On 5/12/2016 3:06 PM, Michael Haupt wrote: Hi Shilpi, thanks for the clarification. OK by me then - please note this is a lower-case review. Best, Michael Am 11.05.2

Re: RFR[9]:java/lang/invoke/VarargsArrayTest.java miss othervm for main/bootclasspath mode

2016-05-12 Thread Michael Haupt
Hi Shilpi, thanks for the clarification. OK by me then - please note this is a lower-case review. Best, Michael > Am 11.05.2016 um 15:55 schrieb shilpi.rast...@oracle.com: > > Thank You Michael for comments! > > It was fixed for VarargsArrayTest.java but not fixed for > java/lang/invoke/Cu

Re: RFR[9]:java/lang/invoke/VarargsArrayTest.java miss othervm for main/bootclasspath mode

2016-05-11 Thread shilpi.rast...@oracle.com
Thank You Michael for comments! It was fixed for VarargsArrayTest.java but not fixed for java/lang/invoke/CustomizedLambdaFormTest.java. Boris Molodenkov added a comment -2016-05-02 02:37-Restricted toConfidential One mo

Re: RFR[9]:java/lang/invoke/VarargsArrayTest.java miss othervm for main/bootclasspath mode

2016-05-11 Thread Michael Haupt
Hi Shilpi, not a review - the bug mentions that this issue is fixed in Jake already and that the bug should be closed once the fix from Jake propagates to dev. What is the status of that? Best, Michael > Am 11.05.2016 um 13:24 schrieb shilpi.rast...@oracle.com: > > Hi All, > > Please review

RFR[9]:java/lang/invoke/VarargsArrayTest.java miss othervm for main/bootclasspath mode

2016-05-11 Thread shilpi.rast...@oracle.com
Hi All, Please review one small fix for https://bugs.openjdk.java.net/browse/JDK-8155791 http://cr.openjdk.java.net/~srastogi/8155791/webrev.00/ Thanks, Shilpi