On 3/20/2014 8:40 AM, Lance Andersen - Oracle wrote:
I think this OK.
The comments with the o--o did not do much for me though and found them a bit
confusing but perhaps I need more coffee this morning ?
Black or white? :-)
It illustrates an intersection. For example, the result of the foll
I think this OK.
The comments with the o--o did not do much for me though and found them a bit
confusing but perhaps I need more coffee this morning ?
Also, not sure we need the @author tag but I think its usage varies in the
workspace
Best
Lance
On Mar 19, 2014, at 7:10 PM, David Li wrote:
>
Hi,
This is an update from Xerces for file
impl/xpath/regex/TokenRange.java. For details, please refer to:
https://bugs.openjdk.java.net/browse/JDK-8035577.
Webrevs: http://cr.openjdk.java.net/~joehw/jdk9/8035577/webrev/
Existing tests: JAXP SQE and unit tests passed.
Test cases added for
Yeah, the test passes without the patch. That is my error. The test I
wrote is for testing the correctness of the code I added. It doesn't
test the specific change. I can add another test for the change.
I can also move the bug I filed to this bug fix.
-David
On 3/14/2014 2:02 PM, huizhe
I may be wrong, but the test passes without the patch. It looks like we
may need to fix the bug David found:
https://bugs.openjdk.java.net/browse/JDK-8037324
-Joe
On 3/14/2014 10:01 AM, huizhe wang wrote:
On 3/14/2014 7:38 AM, Alan Bateman wrote:
On 13/03/2014 23:07, David Li wrote:
Hi,
On 3/14/2014 7:38 AM, Alan Bateman wrote:
On 13/03/2014 23:07, David Li wrote:
Hi,
This is an update from Xerces for file
impl/xpath/regex/TokenRange.java. For details, please refer to:
https://bugs.openjdk.java.net/browse/JDK-8035577.
Webrevs: http://cr.openjdk.java.net/~joehw/jdk9/80355
On 13/03/2014 23:07, David Li wrote:
Hi,
This is an update from Xerces for file
impl/xpath/regex/TokenRange.java. For details, please refer to:
https://bugs.openjdk.java.net/browse/JDK-8035577.
Webrevs: http://cr.openjdk.java.net/~joehw/jdk9/8035577/webrev/
New test case was added for code
Thanks David for the update!
Joe
On 3/13/2014 4:07 PM, David Li wrote:
Hi,
This is an update from Xerces for file
impl/xpath/regex/TokenRange.java. For details, please refer to:
https://bugs.openjdk.java.net/browse/JDK-8035577.
Webrevs: http://cr.openjdk.java.net/~joehw/jdk9/8035577/webre
Hi,
This is an update from Xerces for file
impl/xpath/regex/TokenRange.java. For details, please refer to:
https://bugs.openjdk.java.net/browse/JDK-8035577.
Webrevs: http://cr.openjdk.java.net/~joehw/jdk9/8035577/webrev/
New test case was added for code change in RangeToken.intersectRanges.
On 3/6/2014 12:31 AM, Alan Bateman wrote:
On 05/03/2014 22:17, huizhe wang wrote:
On 3/5/2014 1:38 PM, Alan Bateman wrote:
On 05/03/2014 20:18, David Li wrote:
Hi,
This is an update from Xerces for file
impl/xpath/regex/TokenRange.java. For details, please refer to:
https://bugs.openjdk.
On 05/03/2014 22:17, huizhe wang wrote:
On 3/5/2014 1:38 PM, Alan Bateman wrote:
On 05/03/2014 20:18, David Li wrote:
Hi,
This is an update from Xerces for file
impl/xpath/regex/TokenRange.java. For details, please refer to:
https://bugs.openjdk.java.net/browse/JDK-8035577.
Webrevs: http
On Mar 5, 2014, at 5:10 PM, huizhe wang wrote:
>
> On 3/5/2014 12:46 PM, Lance Andersen - Oracle wrote:
>> On Mar 5, 2014, at 3:37 PM, Xueming Shen wrote:
>>
>>> nitpicking,
>>>
>>> (1) shouldn't the variable at #468 to be updated to "lch" instead of "uch"
>>> as well?
>> I would agree given
On 3/5/2014 1:38 PM, Alan Bateman wrote:
On 05/03/2014 20:18, David Li wrote:
Hi,
This is an update from Xerces for file
impl/xpath/regex/TokenRange.java. For details, please refer to:
https://bugs.openjdk.java.net/browse/JDK-8035577.
Webrevs: http://cr.openjdk.java.net/~joehw/jdk9/803557
On 3/5/2014 12:46 PM, Lance Andersen - Oracle wrote:
On Mar 5, 2014, at 3:37 PM, Xueming Shen wrote:
nitpicking,
(1) shouldn't the variable at #468 to be updated to "lch" instead of "uch" as
well?
I would agree given you are now calling Character.toLowerCase
Also, at line 463 and 464, it
On 05/03/2014 20:18, David Li wrote:
Hi,
This is an update from Xerces for file
impl/xpath/regex/TokenRange.java. For details, please refer to:
https://bugs.openjdk.java.net/browse/JDK-8035577.
Webrevs: http://cr.openjdk.java.net/~joehw/jdk9/8035577/webrev/
No new tests. There were none a
On Mar 5, 2014, at 3:37 PM, Xueming Shen wrote:
> nitpicking,
>
> (1) shouldn't the variable at #468 to be updated to "lch" instead of "uch" as
> well?
I would agree given you are now calling Character.toLowerCase
> (2) StringBuilder can be used to replace the StringBuffer in toString().
Agree
nitpicking,
(1) shouldn't the variable at #468 to be updated to "lch" instead of "uch" as
well?
(2) StringBuilder can be used to replace the StringBuffer in toString().
-Sherman
On 03/05/2014 12:18 PM, David Li wrote:
Hi,
This is an update from Xerces for file impl/xpath/regex/TokenRange.jav
Hi,
This is an update from Xerces for file
impl/xpath/regex/TokenRange.java. For details, please refer to:
https://bugs.openjdk.java.net/browse/JDK-8035577.
Webrevs: http://cr.openjdk.java.net/~joehw/jdk9/8035577/webrev/
No new tests. There were none added in Xerces.
Existing tests: JAXP
18 matches
Mail list logo
