Re: RFR (M) 8140802 - Clean up and refactor of class loading code for CDS

The modules.xml change and boot.modules change looks okay to me. Mandy > On Nov 10, 2015, at 4:30 PM, Ioi Lam wrote: > > A "final" webrev (before I go on vacation :-) > > http://cr.openjdk.java.net/~iklam/8140802-cds-refactoring.v03/ > > There's a single line changed

Re: RFR (M) 8140802 - Clean up and refactor of class loading code for CDS

A "final" webrev (before I go on vacation :-) http://cr.openjdk.java.net/~iklam/8140802-cds-refactoring.v03/ There's a single line changed from the previous webrev: http://cr.openjdk.java.net/~iklam/8140802-cds-refactoring.v03/root/modules.xml.sdiff.html The reason is to allow the use of

Re: RFR (M) 8140802 - Clean up and refactor of class loading code for CDS

On 10/30/15 1:23 PM, Jiangli Zhou wrote: Hi Ioi, The change looks pretty clean. The new src/share/vm/classfile/systemDictionary_ext.hpp and src/share/vm/classfile/vmSymbols_ext.hpp do not have copyright header. Please add the copyright headers. Please also fix the copyright year for the

Re: RFR (M) 8140802 - Clean up and refactor of class loading code for CDS

On 11/2/15 1:57 PM, Ioi Lam wrote: On 10/30/15 1:31 PM, Coleen Phillimore wrote: On 10/30/15 4:18 PM, Karen Kinnear wrote: Coleen, Question for you below please ... On Oct 30, 2015, at 3:44 PM, Coleen Phillimore wrote: Hi Ioi, This is a manageable code

Re: RFR (M) 8140802 - Clean up and refactor of class loading code for CDS

On 10/30/15 12:44 PM, Coleen Phillimore wrote: Hi Ioi, This is a manageable code change. http://cr.openjdk.java.net/~iklam/8140802-cds-refactoring.v01/hotspot/src/share/vm/classfile/classListParser.hpp.html You forward declare Klass* but don't use it in this header file. Also can you add a

Re: RFR (M) 8140802 - Clean up and refactor of class loading code for CDS

On 10/30/15 1:31 PM, Coleen Phillimore wrote: On 10/30/15 4:18 PM, Karen Kinnear wrote: Coleen, Question for you below please ... On Oct 30, 2015, at 3:44 PM, Coleen Phillimore wrote: Hi Ioi, This is a manageable code change.

Re: RFR (M) 8140802 - Clean up and refactor of class loading code for CDS

Coleen, Question for you below please ... > On Oct 30, 2015, at 3:44 PM, Coleen Phillimore > wrote: > > > Hi Ioi, > This is a manageable code change. > >

Re: RFR (M) 8140802 - Clean up and refactor of class loading code for CDS

On 10/30/15 4:18 PM, Karen Kinnear wrote: Coleen, Question for you below please ... On Oct 30, 2015, at 3:44 PM, Coleen Phillimore wrote: Hi Ioi, This is a manageable code change.

Re: RFR (M) 8140802 - Clean up and refactor of class loading code for CDS

Hi Ioi, The change looks pretty clean. The new src/share/vm/classfile/systemDictionary_ext.hpp and src/share/vm/classfile/vmSymbols_ext.hpp do not have copyright header. Please add the copyright headers. Please also fix the copyright year for the modified files prior to pushing. In

Re: RFR (M) 8140802 - Clean up and refactor of class loading code for CDS

Hi Ioi, This is a manageable code change. http://cr.openjdk.java.net/~iklam/8140802-cds-refactoring.v01/hotspot/src/share/vm/classfile/classListParser.hpp.html You forward declare Klass* but don't use it in this header file. Also can you add a comment to #endif to say what it's endifing. ie.

RFR (M) 8140802 - Clean up and refactor of class loading code for CDS

Please review the following fix: http://cr.openjdk.java.net/~iklam/8140802-cds-refactoring.v01/ Bug: Clean up and refactor of class loading code for CDS https://bugs.openjdk.java.net/browse/JDK-8140802 Summary of fix: We need to clean up and refactor the class loading code in order