Re: RFR (S) CR 7177472: JSR292: MethodType interning penalizes scalability

2013-06-13 Thread Christian Thalinger
On Jun 11, 2013, at 7:16 PM, Christian Thalinger christian.thalin...@oracle.com wrote: On Jun 11, 2013, at 2:21 PM, Aleksey Shipilev aleksey.shipi...@oracle.com wrote: On 06/11/2013 10:24 PM, Christian Thalinger wrote: On Jun 11, 2013, at 9:08 AM, Aleksey Shipilev

Re: RFR (S) CR 7177472: JSR292: MethodType interning penalizes scalability

2013-06-13 Thread Aleksey Shipilev
On 06/13/2013 09:51 PM, Christian Thalinger wrote: While preparing the push I noticed the new code gives a warning: src/share/classes/java/lang/invoke/MethodType.java:1106: warning: [unchecked] unchecked cast T that = ((WeakEntryT) obj).get();

Re: RFR (S) CR 7177472: JSR292: MethodType interning penalizes scalability

2013-06-13 Thread Christian Thalinger
On Jun 13, 2013, at 12:09 PM, Aleksey Shipilev aleksey.shipi...@oracle.com wrote: On 06/13/2013 09:51 PM, Christian Thalinger wrote: While preparing the push I noticed the new code gives a warning: src/share/classes/java/lang/invoke/MethodType.java:1106: warning: [unchecked] unchecked

Re: RFR (S) CR 7177472: JSR292: MethodType interning penalizes scalability

2013-06-11 Thread Aleksey Shipilev
On 06/11/2013 02:52 AM, Christian Thalinger wrote: This looks good to me. Thanks for the review! Could you run RegExp with Nashorn again with and without your changes? Being single-threaded, the benchmark will not show much of the improvement. Also, the results are rather flaky. Before:

Re: RFR (S) CR 7177472: JSR292: MethodType interning penalizes scalability

2013-06-11 Thread Christian Thalinger
On Jun 11, 2013, at 1:47 AM, Aleksey Shipilev aleksey.shipi...@oracle.com wrote: On 06/11/2013 02:52 AM, Christian Thalinger wrote: This looks good to me. Thanks for the review! Could you run RegExp with Nashorn again with and without your changes? Being single-threaded, the

Re: RFR (S) CR 7177472: JSR292: MethodType interning penalizes scalability

2013-06-11 Thread Aleksey Shipilev
On 06/11/2013 07:43 PM, Christian Thalinger wrote: Thanks for this but I was thinking running it with -Xprof to see whether some of the table methods show up on the profile. I put little trust into this kind of profiling, but here's the sample output from JMH -prof stack, while running with 4

Re: RFR (S) CR 7177472: JSR292: MethodType interning penalizes scalability

2013-06-11 Thread Christian Thalinger
On Jun 11, 2013, at 9:03 AM, Aleksey Shipilev aleksey.shipi...@oracle.com wrote: On 06/11/2013 07:43 PM, Christian Thalinger wrote: Thanks for this but I was thinking running it with -Xprof to see whether some of the table methods show up on the profile. I put little trust into this kind

Re: RFR (S) CR 7177472: JSR292: MethodType interning penalizes scalability

2013-06-11 Thread Aleksey Shipilev
On 06/11/2013 08:06 PM, Christian Thalinger wrote: Anyway, let's push this. Do you want me any other testing done? vm.mlvm.testlist is OK, but I haven't done the full JPRT test cycle, only the build one. -Aleksey.

Re: RFR (S) CR 7177472: JSR292: MethodType interning penalizes scalability

2013-06-11 Thread Aleksey Shipilev
On 06/11/2013 10:24 PM, Christian Thalinger wrote: On Jun 11, 2013, at 9:08 AM, Aleksey Shipilev aleksey.shipi...@oracle.com wrote: On 06/11/2013 08:06 PM, Christian Thalinger wrote: Anyway, let's push this. Do you want me any other testing done? vm.mlvm.testlist is OK, but I haven't

Re: RFR (S) CR 7177472: JSR292: MethodType interning penalizes scalability

2013-06-11 Thread Christian Thalinger
On Jun 11, 2013, at 2:21 PM, Aleksey Shipilev aleksey.shipi...@oracle.com wrote: On 06/11/2013 10:24 PM, Christian Thalinger wrote: On Jun 11, 2013, at 9:08 AM, Aleksey Shipilev aleksey.shipi...@oracle.com wrote: On 06/11/2013 08:06 PM, Christian Thalinger wrote: Anyway, let's push

Re: RFR (S) CR 7177472: JSR292: MethodType interning penalizes scalability

2013-06-10 Thread Peter Levart
On 06/08/2013 10:25 PM, Peter Levart wrote: On 06/08/2013 10:17 PM, Peter Levart wrote: On 06/08/2013 12:21 PM, Remi Forax wrote: On 06/07/2013 12:01 PM, Aleksey Shipilev wrote: (posting this to hotspot-dev@ and cc-ing core-libs-dev@, as Christian T. suggested offline) Hi guys, Hi

Re: RFR (S) CR 7177472: JSR292: MethodType interning penalizes scalability

2013-06-10 Thread Peter Levart
On 06/08/2013 10:17 PM, Peter Levart wrote: On 06/08/2013 12:21 PM, Remi Forax wrote: On 06/07/2013 12:01 PM, Aleksey Shipilev wrote: (posting this to hotspot-dev@ and cc-ing core-libs-dev@, as Christian T. suggested offline) Hi guys, Hi Aleksey, The fix for scalability problem is

Re: RFR (S) CR 7177472: JSR292: MethodType interning penalizes scalability

2013-06-10 Thread Peter Levart
On 06/08/2013 12:21 PM, Remi Forax wrote: On 06/07/2013 12:01 PM, Aleksey Shipilev wrote: (posting this to hotspot-dev@ and cc-ing core-libs-dev@, as Christian T. suggested offline) Hi guys, Hi Aleksey, The fix for scalability problem is here:

Re: RFR (S) CR 7177472: JSR292: MethodType interning penalizes scalability

2013-06-08 Thread Remi Forax
On 06/07/2013 12:01 PM, Aleksey Shipilev wrote: (posting this to hotspot-dev@ and cc-ing core-libs-dev@, as Christian T. suggested offline) Hi guys, Hi Aleksey, The fix for scalability problem is here: http://cr.openjdk.java.net/~shade/7177472/webrev.00/ in add, the do/while does

Re: RFR (S) CR 7177472: JSR292: MethodType interning penalizes scalability

2013-06-08 Thread Aleksey Shipilev
(copying hotspot-dev@ back, the patch is theirs) Thanks Remi! On 06/08/2013 02:21 PM, Remi Forax wrote: in add, the do/while does something a little weird, if putIfAbsent returns null, interned is equals to elem, there is no need to do a e.get() in that case, Oh yes, that a nice

RFR (S) CR 7177472: JSR292: MethodType interning penalizes scalability

2013-06-07 Thread Aleksey Shipilev
(posting this to hotspot-dev@ and cc-ing core-libs-dev@, as Christian T. suggested offline) Hi guys, The fix for scalability problem is here: http://cr.openjdk.java.net/~shade/7177472/webrev.00/ Testing: - Linux x86_64 builds OK - Linux x86_64 java/lang/invoke/ jtreg passes OK Since this