Re: RFR : 8013712 : (XS) Add Objects.nonNull and Objects.isNull

2013-06-25 Thread Mike Duigou
I am sympathetic to this naming issue (actually indifferent is more accurate) but it will have to wait until I return from vacation. I have tagged this thread and will follow up when I am back in the office. Please be patient, it will be addressed. Mike On Jun 20 2013, at 07:10 , Remi Forax

Re: RFR : 8013712 : (XS) Add Objects.nonNull and Objects.isNull

2013-06-24 Thread Jack Moxley
Really depends about whether you want the method to be bad English, or really bad English. :-). All this double negativity gets me down. What's wrong with exists() ? Sent from my iPhone On 20 Jun 2013, at 08:24, Howard Lovatt howard.lov...@gmail.com wrote: I would say not needed, !isNull()

Re: RFR : 8013712 : (XS) Add Objects.nonNull and Objects.isNull

2013-06-24 Thread Howard Lovatt
I would say not needed, !isNull() is sufficient. If included isNotNull() is the better name. On 5 May 2013 01:09, Ulf Zibis ulf.zi...@cosoco.de wrote: Am 04.05.2013 04:28, schrieb Mike Duigou: I have updated the webrev to include incorporate the feedback I have received.

Re: RFR : 8013712 : (XS) Add Objects.nonNull and Objects.isNull

2013-06-20 Thread Stephen Colebourne
Like others, I would prefer isNotNull() to notNull(). Mainly for consistency, but also for dicoverability is IDE autocomplete (as the methods would then be next to one another) Stephen On 30 April 2013 23:45, Mike Duigou mike.dui...@oracle.com wrote: Hello all; Another changeset coming from

Re: RFR : 8013712 : (XS) Add Objects.nonNull and Objects.isNull

2013-06-20 Thread Remi Forax
Yes, a fine idea. RĂ©mi On 06/20/2013 11:44 AM, Stephen Colebourne wrote: Like others, I would prefer isNotNull() to notNull(). Mainly for consistency, but also for dicoverability is IDE autocomplete (as the methods would then be next to one another) Stephen On 30 April 2013 23:45, Mike

Re: RFR : 8013712 : (XS) Add Objects.nonNull and Objects.isNull

2013-05-04 Thread Ulf Zibis
Am 04.05.2013 04:28, schrieb Mike Duigou: I have updated the webrev to include incorporate the feedback I have received. http://cr.openjdk.java.net/~mduigou/JDK-8013712/1/webrev/ Regarding the naming of the nonNull method. I originally added this method in 2011 but I've forgotten since then

Re: RFR : 8013712 : (XS) Add Objects.nonNull and Objects.isNull

2013-05-03 Thread Mike Duigou
I have updated the webrev to include incorporate the feedback I have received. http://cr.openjdk.java.net/~mduigou/JDK-8013712/1/webrev/ Regarding the naming of the nonNull method. I originally added this method in 2011 but I've forgotten since then why it has the name it does. As best as I

Re: RFR : 8013712 : (XS) Add Objects.nonNull and Objects.isNull

2013-05-02 Thread Jeff Hain
Hello. nonNull could be renamed into isNonNull, else people might use it instead of requireNonNull, especially if they are already used to a pre-Java 7 requireNonNull that would be called nonNull. (example:

RFR : 8013712 : (XS) Add Objects.nonNull and Objects.isNull

2013-04-30 Thread Mike Duigou
Hello all; Another changeset coming from the lambda libraries effort. This one is two small additions to the Objects class. The introduced methods are not really intended to be used directly, comparison operators work better in imperative logic, but the methods will be very useful as

Re: RFR : 8013712 : (XS) Add Objects.nonNull and Objects.isNull

2013-04-30 Thread Mandy Chung
On 4/30/2013 3:45 PM, Mike Duigou wrote: Hello all; Another changeset coming from the lambda libraries effort. This one is two small additions to the Objects class. The introduced methods are not really intended to be used directly, comparison operators work better in imperative logic, but

Re: RFR : 8013712 : (XS) Add Objects.nonNull and Objects.isNull

2013-04-30 Thread Mike Duigou
I will make both suggested changes. Thank you. Mike On Apr 30 2013, at 20:34 , Mandy Chung wrote: On 4/30/2013 3:45 PM, Mike Duigou wrote: Hello all; Another changeset coming from the lambda libraries effort. This one is two small additions to the Objects class. The introduced methods