On 8/26/20 4:00 AM, Alan Bateman wrote:
On 21/08/2020 19:23, Joe Wang wrote:
Pelase review a patch to add the missing @return, @throws, @param
statements in the java.xml package (excluding the DOM component).
JBS: https://bugs.openjdk.java.net/browse/JDK-8251561
CSR:
On 21/08/2020 19:23, Joe Wang wrote:
Pelase review a patch to add the missing @return, @throws, @param
statements in the java.xml package (excluding the DOM component).
JBS: https://bugs.openjdk.java.net/browse/JDK-8251561
CSR: https://bugs.openjdk.java.net/browse/JDK-8251995
webrev:
Ah, I was looking for that kind of information in the bug report, but
couldn't find any.
/Erik
On 2020-08-25 13:20, Joe Wang wrote:
Hi Erik,
We're acting on a report Jon generated separately. The warnings checks
are currently disabled (see line 106 JAVADOC_DISABLED_DOCLINT :=
accessibility
Hi Erik,
We're acting on a report Jon generated separately. The warnings checks
are currently disabled (see line 106 JAVADOC_DISABLED_DOCLINT :=
accessibility html missing syntax reference).
-Joe
On 8/25/20 12:39 PM, Erik Joelsson wrote:
On 2020-08-25 12:21, Roger Riggs wrote:
Hi Erik,
Hi Erik,
We're in a cleanup phase of the source before re-enabling disabled warnings.
The warnings for "missing" comments are disabled:
Docs.gmk:
106: JAVADOC_DISABLED_DOCLINT := accessibility html missing syntax reference
Roger
On 8/25/20 3:39 PM, Erik Joelsson wrote:
On 2020-08-25
+1
Naoto
On 8/25/20 11:47 AM, Joe Wang wrote:
Cc-ing build-...@openjdk.java.net (makefile change: make/Docs.gmk)
Updated webrev: http://cr.openjdk.java.net/~joehw/jdk16/8251561/webrev_04/
Thanks Roger! Please see inline comments.
On 8/25/20 8:09 AM, Roger Riggs wrote:
Hi Joe,
Eliminating
On 2020-08-25 12:21, Roger Riggs wrote:
Hi Erik,
org.w3c is in third party code that is not being updated. There is a
balance between
ignoring the warnings and doing a bunch of editing that would
overwritten by a future update.
Yes, I get that part, but why are those warnings not
Hi Joe,
The updates to those files are fine, I mixed up the two packages.
Roger
On 8/25/20 2:47 PM, Joe Wang wrote:
org/xml/...: If we're suppressing the warnings for org/xml/... then
the files changes are unnecessary?
Did you mean org/w3c? We're only suppressing the warnings for org/w3c
Hi Erik,
org.w3c is in third party code that is not being updated. There is a
balance between
ignoring the warnings and doing a bunch of editing that would
overwritten by a future update.
$.02, Roger
On 8/25/20 2:58 PM, Erik Joelsson wrote:
Build change looks ok, but why is it needed? You
Build change looks ok, but why is it needed? You are fixing a bunch of
warnings in one part of the source and disabling them in another part.
Is there some other change incoming that will enable more warning
categories by default?
/Erik
On 2020-08-25 11:47, Joe Wang wrote:
Cc-ing
Cc-ing build-...@openjdk.java.net (makefile change: make/Docs.gmk)
Updated webrev: http://cr.openjdk.java.net/~joehw/jdk16/8251561/webrev_04/
Thanks Roger! Please see inline comments.
On 8/25/20 8:09 AM, Roger Riggs wrote:
Hi Joe,
Eliminating the checking for warnings in org.w3c is fine.
Hi Joe,
Eliminating the checking for warnings in org.w3c is fine. Please be more
specific in the comment.
"Ignore the doclint warnings in the W3C DOM package"
org/xml/...: If we're suppressing the warnings for org/xml/... then the
files changes are unnecessary?
Remove the addition of
Thanks again Lance, Naoto! And sorry for yet another review request! I
saw Jon's comment on the other doclint thread about replacing @exception
with @throws. As it happens, we have 172 of them in the sax package as
well. Please note the changes are all in the org/xml/sax packages:
Looks OK Joe
> On Aug 24, 2020, at 5:44 PM, Joe Wang wrote:
>
> Hi all, adding Roger's comment for the make file to webrev_02 (the only
> change to webrev_01 is Docs.gmk):
>
> http://cr.openjdk.java.net/~joehw/jdk16/8251561/webrev_02/
>
> Thanks,
> Joe
>
> On 8/21/20 12:49 PM,
Still looks good.
Naoto
On 8/24/20 2:44 PM, Joe Wang wrote:
Hi all, adding Roger's comment for the make file to webrev_02 (the only
change to webrev_01 is Docs.gmk):
http://cr.openjdk.java.net/~joehw/jdk16/8251561/webrev_02/
Thanks,
Joe
On 8/21/20 12:49 PM, naoto.s...@oracle.com wrote:
Hi all, adding Roger's comment for the make file to webrev_02 (the only
change to webrev_01 is Docs.gmk):
http://cr.openjdk.java.net/~joehw/jdk16/8251561/webrev_02/
Thanks,
Joe
On 8/21/20 12:49 PM, naoto.s...@oracle.com wrote:
+1
Naoto
On 8/21/20 12:24 PM, Lance Andersen wrote:
Hi Joe,
+1
Naoto
On 8/21/20 12:24 PM, Lance Andersen wrote:
Hi Joe,
This looks OK.
On Aug 21, 2020, at 2:23 PM, Joe Wang wrote:
Pelase review a patch to add the missing @return, @throws, @param statements in
the java.xml package (excluding the DOM component).
JBS:
Hi Joe,
This looks OK.
> On Aug 21, 2020, at 2:23 PM, Joe Wang wrote:
>
> Pelase review a patch to add the missing @return, @throws, @param statements
> in the java.xml package (excluding the DOM component).
>
> JBS: https://bugs.openjdk.java.net/browse/JDK-8251561
> CSR:
Pelase review a patch to add the missing @return, @throws, @param
statements in the java.xml package (excluding the DOM component).
JBS: https://bugs.openjdk.java.net/browse/JDK-8251561
CSR: https://bugs.openjdk.java.net/browse/JDK-8251995
webrev:
19 matches
Mail list logo
