On 09/26/2013 06:00 PM, Martin Buchholz wrote:
On Thu, Sep 26, 2013 at 5:45 PM, Jonathan Gibbons
mailto:jonathan.gibb...@oracle.com>> wrote:
The new diagnostics are generated by the new doclint feature which
is available from the javac and javadoc command lines.
When invoked fr
The new diagnostics are generated by the new doclint feature which is
available from the javac and javadoc command lines.
When invoked from javadoc, it only checks the comments being used for
the docs that you are generating. So, if you are generating docs for
just your public and protected me
On 9/25/13 4:03 PM, Martin Buchholz wrote:
Looks good.
I would only suggest the stylistic improvement of using proper /**
javadoc comments even for private test methods instead of /*
The comments were meant as internal documentation and not "real"
javadoc. After dabbling with some doclint cle
On 9/26/13 6:11 AM, Alan Bateman wrote:
On 25/09/2013 15:19, Brent Christian wrote:
>
The fix looks right to me.
Thanks.
One comment on the test is that testItr is
using raw types, is there any reason for thaht?
Pure laziness! Here, this one's nicer:
http://cr.openjdk.java.net/~bchristi/
On 25/09/2013 15:19, Brent Christian wrote:
Please review this change for 8025173, "HashMap.put() replacing an
existing key can trigger a resize()."
A description of the problem can be found in the bug report:
http://bugs.sun.com/view_bug.do?bug_id=8025173
Thanks to Doug Lea for sending in the
Please review this change for 8025173, "HashMap.put() replacing an
existing key can trigger a resize()."
A description of the problem can be found in the bug report:
http://bugs.sun.com/view_bug.do?bug_id=8025173
Thanks to Doug Lea for sending in the diff for HashMap.java.
Webrev is here:
http
