Re: RFR 8056249 Improve CompletableFuture resource usage

2014-09-01 Thread Paul Sandoz
On Aug 29, 2014, at 5:56 PM, Martin Buchholz marti...@google.com wrote: Looks fine. Thanks Martin Chris. Instead of using Contributed-by: for Doug's work, you should make him the hg user, as is done in previous changesets. E.g. hg import has a --user flag. Ok, i will do that. Paul.

RFR 8056249 Improve CompletableFuture resource usage

2014-08-29 Thread Paul Sandoz
Hi, Please review fixes by Doug to j.u.c.CompletableFuture to better control resources for long completion chains (e.g. avoiding stack overflows). This fix resulted in a lot of internal refactoring and clean up. There are also some doc clarifications for certain j.u.c.CompletationStage

Re: RFR 8056249 Improve CompletableFuture resource usage

2014-08-29 Thread Doug Lea
On 08/29/2014 06:01 AM, Paul Sandoz wrote: Hi, Please review fixes by Doug to j.u.c.CompletableFuture to better control resources for long completion chains (e.g. avoiding stack overflows). This fix resulted in a lot of internal refactoring and clean up. There are also some doc

Re: RFR 8056249 Improve CompletableFuture resource usage

2014-08-29 Thread Chris Hegarty
On 29/08/14 11:01, Paul Sandoz wrote: Hi, Please review fixes by Doug to j.u.c.CompletableFuture to better control resources for long completion chains (e.g. avoiding stack overflows). This fix resulted in a lot of internal refactoring and clean up. There are also some doc clarifications

Re: RFR 8056249 Improve CompletableFuture resource usage

2014-08-29 Thread Paul Sandoz
On Aug 29, 2014, at 3:35 PM, Doug Lea d...@cs.oswego.edu wrote: Is the following snippet missing from the doc updates to the methods CompletationStage.handle and handleAsync? While touching up wording, we noticed that this sentence doesn't capture all the cases that are described in the

Re: RFR 8056249 Improve CompletableFuture resource usage

2014-08-29 Thread Paul Sandoz
On Aug 29, 2014, at 3:38 PM, Chris Hegarty chris.hega...@oracle.com wrote: On 29/08/14 11:01, Paul Sandoz wrote: Hi, Please review fixes by Doug to j.u.c.CompletableFuture to better control resources for long completion chains (e.g. avoiding stack overflows). This fix resulted in a

Re: RFR 8056249 Improve CompletableFuture resource usage

2014-08-29 Thread Martin Buchholz
Looks fine. Instead of using Contributed-by: for Doug's work, you should make him the hg user, as is done in previous changesets. E.g. hg import has a --user flag. All of jsr166 CVS src/main is ready for sync'ing with openjdk9, i.e. there are no known bugs, even though some future improvements

Re: RFR 8056249 Improve CompletableFuture resource usage

2014-08-29 Thread Chris Hegarty
On 29 Aug 2014, at 16:56, Martin Buchholz marti...@google.com wrote: Looks fine. +1 -Chris. Instead of using Contributed-by: for Doug's work, you should make him the hg user, as is done in previous changesets. E.g. hg import has a --user flag. All of jsr166 CVS src/main is ready for