The changes look fine to me also Chris.
Regards,
Sean.
On 22/01/16 14:49, Chris Hegarty wrote:
On 21/01/16 22:55, Felix Yang wrote:
Hi Chris,
your fix is cool. I will assign the bug to you:)
a comment on this fix. The test changed system SecurityManager and
it is not executed with
On 21/01/16 22:55, Felix Yang wrote:
Hi Chris,
your fix is cool. I will assign the bug to you:)
a comment on this fix. The test changed system SecurityManager and
it is not executed with othervm mode. I think you need to rollback the
change after test.
I will revert the change and h
Hi Chris,
your fix is cool. I will assign the bug to you:)
a comment on this fix. The test changed system SecurityManager and it is
not executed with othervm mode. I think you need to rollback the change after
test. Otherwise it may affect other tests.
Thanks,
Felix
> On Jan 20, 2016,
On 20 Jan 2016, at 06:36, Chris Hegarty wrote:
> Felix,
>
> On 14 Jan 2016, at 06:07, Felix Yang wrote:
>
>> Hi all,
>> please review the fix for
>> test/java/net/SocketPermission/SocketPermissionTest.java, which fails
>> frequently with "java.net.BindException: Address already in use".
>>
Felix,
On 14 Jan 2016, at 06:07, Felix Yang wrote:
> Hi all,
>please review the fix for
> test/java/net/SocketPermission/SocketPermissionTest.java, which fails
> frequently with "java.net.BindException: Address already in use".
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8065076
> W
Hi all,
please review the fix for
test/java/net/SocketPermission/SocketPermissionTest.java, which fails
frequently with "java.net.BindException: Address already in use".
Bug: https://bugs.openjdk.java.net/browse/JDK-8065076
Webrev: http://cr.openjdk.java.net/~xiaofeya/8065076/webrev.00
Th