Re: RFR 8134426: Add serialVersionUID field to relevant javax.transaction classes

2015-08-26 Thread Alan Bateman
On 25/08/2015 20:30, Lance Andersen wrote: Ok, to keep things simple for now, I removed the dependency on the java/sql BaseTest webrev has been updated Okay although my comment about the previous iteration was mostly just pointing out that generic infrastructure should be in the sql direct

Re: RFR 8134426: Add serialVersionUID field to relevant javax.transaction classes

2015-08-25 Thread Lance Andersen
Ok, to keep things simple for now, I removed the dependency on the java/sql BaseTest webrev has been updated Best Lance On Aug 25, 2015, at 2:39 PM, Lance Andersen wrote: > > On Aug 25, 2015, at 2:36 PM, Alan Bateman wrote: > >> On 25/08/2015 19:29, Lance Andersen wrote: >>> Hi, >>> >>> Lo

Re: RFR 8134426: Add serialVersionUID field to relevant javax.transaction classes

2015-08-25 Thread huizhe wang
Hi Lance, The change looks good. -Joe On 8/25/2015 11:29 AM, Lance Andersen wrote: Hi, Looking for a reviewer for 8134426 This change adds a serialVersionUID field to the required javax.transaction classes as well as some basic tests. Once approved, I will work to push the same changes

Re: RFR 8134426: Add serialVersionUID field to relevant javax.transaction classes

2015-08-25 Thread Lance Andersen
On Aug 25, 2015, at 2:36 PM, Alan Bateman wrote: > On 25/08/2015 19:29, Lance Andersen wrote: >> Hi, >> >> Looking for a reviewer for 8134426 This change adds a serialVersionUID >> field to the required javax.transaction classes as well as some basic tests. >> Once approved, I will work to

Re: RFR 8134426: Add serialVersionUID field to relevant javax.transaction classes

2015-08-25 Thread Alan Bateman
On 25/08/2015 19:29, Lance Andersen wrote: Hi, Looking for a reviewer for 8134426 This change adds a serialVersionUID field to the required javax.transaction classes as well as some basic tests. Once approved, I will work to push the same changes to the relevant JTA project working with t

RFR 8134426: Add serialVersionUID field to relevant javax.transaction classes

2015-08-25 Thread Lance Andersen
Hi, Looking for a reviewer for 8134426 This change adds a serialVersionUID field to the required javax.transaction classes as well as some basic tests. Once approved, I will work to push the same changes to the relevant JTA project working with the Java EE team output from serialver: ---