Re: RFR 8147984: WindowsTerminal should support function keys

2016-05-08 Thread Jan Lahoda
Thanks - I've included both links and pushed. Jan On 4.5.2016 16:12, Florent Guillaume wrote: On Wed, May 4, 2016 at 3:29 PM, Jan Lahoda wrote: On 3.5.2016 14:58, Florent Guillaume wrote: http://www.x.org/docs/xterm/ctlseqs.pdf is probably a more canonical reference. It seems that this ver

Re: RFR 8147984: WindowsTerminal should support function keys

2016-05-04 Thread Florent Guillaume
On Wed, May 4, 2016 at 3:29 PM, Jan Lahoda wrote: > On 3.5.2016 14:58, Florent Guillaume wrote: >> http://www.x.org/docs/xterm/ctlseqs.pdf is probably a more canonical >> reference. > > It seems that this version of the document unfortunately does not specify > the codes the terminal sends for the

Re: RFR 8147984: WindowsTerminal should support function keys

2016-05-04 Thread Jan Lahoda
On 3.5.2016 14:58, Florent Guillaume wrote: Hi, http://www.x.org/docs/xterm/ctlseqs.pdf is probably a more canonical reference. It seems that this version of the document unfortunately does not specify the codes the terminal sends for the function keys? Jan Florent On Mon, May 2, 2016

Re: RFR 8147984: WindowsTerminal should support function keys

2016-05-03 Thread Florent Guillaume
Hi, http://www.x.org/docs/xterm/ctlseqs.pdf is probably a more canonical reference. Florent On Mon, May 2, 2016 at 8:31 PM, Stuart Marks wrote: > Hi Jan, > > Thanks for the update. Including the link is fine, but I'm a bit suspicious > of the durability of that website -- it appears to be the

Re: RFR 8147984: WindowsTerminal should support function keys

2016-05-02 Thread Stuart Marks
Hi Jan, Thanks for the update. Including the link is fine, but I'm a bit suspicious of the durability of that website -- it appears to be the personal website of the current maintainer. Who knows if it'll be around in a couple years. I'd suggest including in the comment the official title of

Re: RFR 8147984: WindowsTerminal should support function keys

2016-05-01 Thread Jan Lahoda
Hi Stuart, Thanks for the comments and the link! A webrev which includes the link is here: http://cr.openjdk.java.net/~jlahoda/8147984/webrev.01/ Delta webrev to the last iteration is here: http://cr.openjdk.java.net/~jlahoda/8147984/webrev.01/delta/webrev Thanks, Jan On 29.4.2016 23:49,

Re: RFR 8147984: WindowsTerminal should support function keys

2016-04-29 Thread Stuart Marks
Hi Jan, I finally got a chance to take a look at this. The change looks fine. It would be nice to have a reference to where the escape sequences are documented. There are links to the Windows VK_ codes there, which is great. But there's no reference for the escape sequences that each keypress

RFR 8147984: WindowsTerminal should support function keys

2016-01-22 Thread Jan Lahoda
Hello, I'd like to enhance the WindowsTerminal in jdk.internal.le with function keys handling. The intent is so that jshell can bind actions for shortcuts including function keys. The patch for adding the function keys support is here: http://cr.openjdk.java.net/~jlahoda/8147984/webrev.00/ A