Re: RFR 8158880: java/time/tck/java/time/format/TCKDateTimeFormatterBuilder.java fail with zh_CN locale

2016-11-21 Thread Naoto Sato
instead of Locale.UK as test parameters (variables) depend on that locale. Thank you, Bhanu -Original Message- From: nadeesh tv Sent: Friday, November 11, 2016 2:09 PM To: core-libs-dev@openjdk.java.net Subject: Re: RFR 8158880: java/time/tck/java/time/format

Re: RFR 8158880: java/time/tck/java/time/format/TCKDateTimeFormatterBuilder.java fail with zh_CN locale

2016-11-21 Thread Roger Riggs
) depend on that locale. Thank you, Bhanu -Original Message- From: nadeesh tv Sent: Friday, November 11, 2016 2:09 PM To: core-libs-dev@openjdk.java.net Subject: Re: RFR 8158880: java/time/tck/java/time/format/TCKDateTimeFormatterBuilder.java fail with zh_CN locale Hi Bhanu, I think

RE: RFR 8158880: java/time/tck/java/time/format/TCKDateTimeFormatterBuilder.java fail with zh_CN locale

2016-11-21 Thread Bhanu Gopularam
: nadeesh tv Sent: Friday, November 11, 2016 2:09 PM To: core-libs-dev@openjdk.java.net Subject: Re: RFR 8158880: java/time/tck/java/time/format/TCKDateTimeFormatterBuilder.java fail with zh_CN locale Hi Bhanu, I think adding Locale to the formatter will be better For eg: DateTimeFormatter f

Re: RFR 8158880: java/time/tck/java/time/format/TCKDateTimeFormatterBuilder.java fail with zh_CN locale

2016-11-14 Thread Roger Riggs
/time/tck/java/time/format/TCKDateTimeFormatterBuilder.java fail with zh_CN locale Hi Bhanu, It can be problematic to change the default Locale for the entire process, especially since many tests are run in the same process. It would be preferable to set the locale in the DateTimeFormatter

Re: RFR 8158880: java/time/tck/java/time/format/TCKDateTimeFormatterBuilder.java fail with zh_CN locale

2016-11-11 Thread Naoto Sato
: http://cr.openjdk.java.net/~bgopularam/JDK-8158880/webrev.01/ Thanks, Bhanu From: Roger Riggs Sent: Tuesday, June 21, 2016 8:36 PM To: Bhanu Gopularam; core-libs-dev@openjdk.java.net Cc: Stephen Colebourne Subject: Re: RFR 8158880: java/time/tck/java/time/format

Re: RFR 8158880: java/time/tck/java/time/format/TCKDateTimeFormatterBuilder.java fail with zh_CN locale

2016-11-11 Thread nadeesh tv
the updated webrev below: Webrev: http://cr.openjdk.java.net/~bgopularam/JDK-8158880/webrev.01/ Thanks, Bhanu From: Roger Riggs Sent: Tuesday, June 21, 2016 8:36 PM To: Bhanu Gopularam; core-libs-dev@openjdk.java.net Cc: Stephen Colebourne Subject: Re: RFR 8158880: java/time/tck/java/time

RE: RFR 8158880: java/time/tck/java/time/format/TCKDateTimeFormatterBuilder.java fail with zh_CN locale

2016-11-10 Thread Bhanu Gopularam
/ Thanks, Bhanu From: Roger Riggs Sent: Tuesday, June 21, 2016 8:36 PM To: Bhanu Gopularam; core-libs-dev@openjdk.java.net Cc: Stephen Colebourne Subject: Re: RFR 8158880: java/time/tck/java/time/format/TCKDateTimeFormatterBuilder.java fail with zh_CN locale Hi Bhanu, It can be problematic

Re: RFR 8158880: java/time/tck/java/time/format/TCKDateTimeFormatterBuilder.java fail with zh_CN locale

2016-06-21 Thread Roger Riggs
Hi Bhanu, It can be problematic to change the default Locale for the entire process, especially since many tests are run in the same process. It would be preferable to set the locale in the DateTimeFormatter builder instead of changing the process wide Locale. Please identify the specific

RFR 8158880: java/time/tck/java/time/format/TCKDateTimeFormatterBuilder.java fail with zh_CN locale

2016-06-21 Thread Bhanu Gopularam
Hi all, May I request you to review fix for following issue Bug id: https://bugs.openjdk.java.net/browse/JDK-8158880 Solution: To avoid test failure in non english locales, set the default locale while initial test setup Webrev: http://cr.openjdk.java.net/~bgopularam/JDK-8158880/webrev.00/