Re: RFR 8179292: a number of launcher tests fail when run with --limit-modules due to CNFE: javax.tools.ToolProvider

2017-07-26 Thread Kumar Srinivasan
+1 Kumar On 7/25/2017 6:30 PM, Andrey Nazarov wrote: Thank you! On 25 Jul 2017, at 18:20, Mandy Chung wrote: On Jul 25, 2017, at 6:18 PM, Andrey Nazarov mailto:andrey.x.naza...@oracle.com>> wrote: Updated by this line. http://cr.openjdk.java.net/~anazarov/JDK-8179292/webrev.02/webrev/

Re: RFR 8179292: a number of launcher tests fail when run with --limit-modules due to CNFE: javax.tools.ToolProvider

2017-07-25 Thread Andrey Nazarov
Thank you! > On 25 Jul 2017, at 18:20, Mandy Chung wrote: > > >> On Jul 25, 2017, at 6:18 PM, Andrey Nazarov > > wrote: >> >> >> Updated by this line. >> http://cr.openjdk.java.net/~anazarov/JDK-8179292/webrev.02/webrev/ >>

Re: RFR 8179292: a number of launcher tests fail when run with --limit-modules due to CNFE: javax.tools.ToolProvider

2017-07-25 Thread Mandy Chung
> On Jul 25, 2017, at 6:18 PM, Andrey Nazarov > wrote: > > > Updated by this line. > http://cr.openjdk.java.net/~anazarov/JDK-8179292/webrev.02/webrev/ > Looks good. Mandy

Re: RFR 8179292: a number of launcher tests fail when run with --limit-modules due to CNFE: javax.tools.ToolProvider

2017-07-25 Thread Andrey Nazarov
> On 25 Jul 2017, at 18:01, Mandy Chung wrote: > > >> On Jul 25, 2017, at 5:29 PM, Andrey Nazarov > > wrote: >> >> Thanks, Mandy >> I’ve updated patch >> http://cr.openjdk.java.net/~anazarov/JDK-8179292/webrev.01/webrev/ >>

Re: RFR 8179292: a number of launcher tests fail when run with --limit-modules due to CNFE: javax.tools.ToolProvider

2017-07-25 Thread Mandy Chung
> On Jul 25, 2017, at 5:29 PM, Andrey Nazarov > wrote: > > Thanks, Mandy > I’ve updated patch > http://cr.openjdk.java.net/~anazarov/JDK-8179292/webrev.01/webrev/ > > Thanks for the update. One suggestion: you could simpl

Re: RFR 8179292: a number of launcher tests fail when run with --limit-modules due to CNFE: javax.tools.ToolProvider

2017-07-25 Thread Andrey Nazarov
Thanks, Mandy I’ve updated patch http://cr.openjdk.java.net/~anazarov/JDK-8179292/webrev.01/webrev/ —Andrei > On 25 Jul 2017, at 16:12, Mandy Chung wrote: > > >> On Jul 21, 2017, at 6:35 PM, Andrey Nazarov >> wrote: >> >>

Re: RFR 8179292: a number of launcher tests fail when run with --limit-modules due to CNFE: javax.tools.ToolProvider

2017-07-25 Thread Mandy Chung
> On Jul 21, 2017, at 6:35 PM, Andrey Nazarov > wrote: > > Hi, > > Please review changes in launcher tests. I’ve added absent @modules jtreg > tags. > > Review: http://cr.openjdk.java.net/~anazarov/JDK-8179292/webrev.00/webrev/ >

Re: RFR 8179292: a number of launcher tests fail when run with --limit-modules due to CNFE: javax.tools.ToolProvider

2017-07-25 Thread Andrey Nazarov
Can anyone look? —Thanks, Andrei > On 21 Jul 2017, at 18:35, Andrey Nazarov wrote: > > Hi, > > Please review changes in launcher tests. I’ve added absent @modules jtreg > tags. > > Review: http://cr.openjdk.java.net/~anazarov/JDK-8179292/webrev.00/webrev/ >

RFR 8179292: a number of launcher tests fail when run with --limit-modules due to CNFE: javax.tools.ToolProvider

2017-07-21 Thread Andrey Nazarov
Hi, Please review changes in launcher tests. I’ve added absent @modules jtreg tags. Review: http://cr.openjdk.java.net/~anazarov/JDK-8179292/webrev.00/webrev/ JBS: https://bugs.openjdk.java.net/browse/JDK-8179292 —Andrei