Re: RFR 8220252: Fix Headings in java.naming

2019-03-14 Thread Daniel Fuchs
On 13/03/2019 19:13, Lance Andersen wrote: Yes you are right, I missed that but it is updated at http://cr.openjdk.java.net/~lancea/8220252/webrev.01/index.html Thanks Lance! The new version looks good. best regards, -- daniel

Re: RFR 8220252: Fix Headings in java.naming

2019-03-13 Thread Lance Andersen
Hi Daniel, > On Mar 13, 2019, at 3:05 PM, Daniel Fuchs wrote: > > Hi Lance, > > http://cr.openjdk.java.net/~lancea/8220252/webrev.00/src/java.naming/share/classes/javax/naming/ldap/LdapContext.java.frames.html > > It looks like > 78 * Context Request Controls > 100 * Connection Request Contro

Re: RFR 8220252: Fix Headings in java.naming

2019-03-13 Thread Daniel Fuchs
Hi Lance, http://cr.openjdk.java.net/~lancea/8220252/webrev.00/src/java.naming/share/classes/javax/naming/ldap/LdapContext.java.frames.html It looks like 78 * Context Request Controls 100 * Connection Request Controls 136 * Service Provider Requirements should be - it seems they are all

RFR 8220252: Fix Headings in java.naming

2019-03-13 Thread Lance Andersen
Hi all Please review the fix for 8220252, to address the javadoc header issues [1] in java.naming The webrev can be found at: http://cr.openjdk.java.net/~lancea/8220252/webrev.00/index.html Best Lance [1] https://mail.openjdk.java.net/pipermail/jdk-dev/2019-March/002671.html