Re: RFR 8231451: ZipFileInputStream::skip handling of negative values with STORED entries

2019-10-29 Thread Alan Bateman
On 25/10/2019 19:42, Lance Andersen wrote: I have updated the patch per your suggestion. The updated webrev can be found at: http://cr.openjdk.java.net/~lancea/8231451/webrev.02/index.html This version looks good. -Alan

RE: RFR 8231451: ZipFileInputStream::skip handling of negative values with STORED entries

2019-10-28 Thread Langer, Christoph
1: ZipFileInputStream::skip handling of negative > values with STORED entries > > > > On Oct 23, 2019, at 4:58 PM, Alan Bateman > wrote: > > > > On 23/10/2019 19:06, Lance Andersen wrote: > >> > >>> On Oct 22, 2019, at 2:37 PM, Alan Bat

Re: RFR 8231451: ZipFileInputStream::skip handling of negative values with STORED entries

2019-10-25 Thread Lance Andersen
> On Oct 23, 2019, at 4:58 PM, Alan Bateman wrote: > > On 23/10/2019 19:06, Lance Andersen wrote: >> >>> On Oct 22, 2019, at 2:37 PM, Alan Bateman >> > wrote: >>> >>> I assume skip(Long.MAX_VALUE) will cause n+pos to overflow and it will skip >>> backwards rat

Re: RFR 8231451: ZipFileInputStream::skip handling of negative values with STORED entries

2019-10-23 Thread Alan Bateman
On 23/10/2019 19:06, Lance Andersen wrote: On Oct 22, 2019, at 2:37 PM, Alan Bateman > wrote: I assume skip(Long.MAX_VALUE) will cause n+pos to overflow and it will skip backwards rather than to the end. That is correct.  If you prefer it to skip to the end,

Re: RFR 8231451: ZipFileInputStream::skip handling of negative values with STORED entries

2019-10-23 Thread Lance Andersen
> On Oct 22, 2019, at 2:37 PM, Alan Bateman wrote: > > On 22/10/2019 18:00, Lance Andersen wrote: >> >> Per your suggestion, I tweaked the patch to move to BOF when the negative >> skip value goes beyond BOF. I updated the release note as well. >> >> webrev can be found at: >> http://cr.op

Re: RFR 8231451: ZipFileInputStream::skip handling of negative values with STORED entries

2019-10-22 Thread Alan Bateman
On 22/10/2019 18:00, Lance Andersen wrote: Per your suggestion, I tweaked the patch to move to BOF when the negative skip value goes beyond BOF.  I updated the release note as well. webrev can be found at: http://cr.openjdk.java.net/~lancea/8231451/webrev.01/index.html I assume skip(Long.M

Re: RFR 8231451: ZipFileInputStream::skip handling of negative values with STORED entries

2019-10-22 Thread Lance Andersen
> On Oct 18, 2019, at 7:18 AM, Alan Bateman wrote: > > On 16/10/2019 18:06, Lance Andersen wrote: >> Hi all, >> >> Please review this fix to ZipFileInputStream::skip when specifying a >> negative value to the skip method when accessing a STORED entry, >> https://bugs.openjdk.java.net/browse/

Re: RFR 8231451: ZipFileInputStream::skip handling of negative values with STORED entries

2019-10-18 Thread Lance Andersen
Thank you for the feedback Alan. > On Oct 18, 2019, at 7:18 AM, Alan Bateman wrote: > > On 16/10/2019 18:06, Lance Andersen wrote: >> Hi all, >> >> Please review this fix to ZipFileInputStream::skip when specifying a >> negative value to the skip method when accessing a STORED entry, >> https:

Re: RFR 8231451: ZipFileInputStream::skip handling of negative values with STORED entries

2019-10-18 Thread Alan Bateman
On 16/10/2019 18:06, Lance Andersen wrote: Hi all, Please review this fix to ZipFileInputStream::skip when specifying a negative value to the skip method when accessing a STORED entry, https://bugs.openjdk.java.net/browse/JDK-8231451 . Prior

RFR 8231451: ZipFileInputStream::skip handling of negative values with STORED entries

2019-10-16 Thread Lance Andersen
Hi all, Please review this fix to ZipFileInputStream::skip when specifying a negative value to the skip method when accessing a STORED entry, https://bugs.openjdk.java.net/browse/JDK-8231451 . Prior to this fix, you could move past the beginni