Re: RFR JDK-8066642: Fix deprecation warnings in jdk.naming module

2014-12-15 Thread Stuart Marks
On 12/12/14 7:54 AM, Chris Hegarty wrote: On 12/12/14 15:40, Pavel Rappo wrote: Could you please review my change for JDK-8066642? http://cr.openjdk.java.net/~prappo/8066642/webrev.00/ The first change, to remove SocketSecurityException seems benign. SocketSecurityException is a subclass of

Re: RFR JDK-8066642: Fix deprecation warnings in jdk.naming module

2014-12-13 Thread Alan Bateman
On 12/12/2014 17:43, Chris Hegarty wrote: On 12 Dec 2014, at 15:51, Alan Bateman wrote: On 12/12/2014 15:40, Pavel Rappo wrote: Hi everyone, Could you please review my change for JDK-8066642? http://cr.openjdk.java.net/~prappo/8066642/webrev.00/ -Pavel This looks okay but I just wonder if

Re: RFR JDK-8066642: Fix deprecation warnings in jdk.naming module

2014-12-12 Thread Chris Hegarty
> On 12 Dec 2014, at 15:51, Alan Bateman wrote: > >> On 12/12/2014 15:40, Pavel Rappo wrote: >> Hi everyone, >> >> Could you please review my change for JDK-8066642? >> >> http://cr.openjdk.java.net/~prappo/8066642/webrev.00/ >> >> -Pavel > This looks okay but I just wonder if we have any tes

Re: RFR JDK-8066642: Fix deprecation warnings in jdk.naming module

2014-12-12 Thread Chris Hegarty
On 12/12/14 15:40, Pavel Rappo wrote: Hi everyone, Could you please review my change for JDK-8066642? http://cr.openjdk.java.net/~prappo/8066642/webrev.00/ The first change, to remove SocketSecurityException seems benign. SocketSecurityException is a subclass of ExportException, so Communic

Re: RFR JDK-8066642: Fix deprecation warnings in jdk.naming module

2014-12-12 Thread Alan Bateman
On 12/12/2014 15:40, Pavel Rappo wrote: Hi everyone, Could you please review my change for JDK-8066642? http://cr.openjdk.java.net/~prappo/8066642/webrev.00/ -Pavel This looks okay but I just wonder if we have any tests that check the for specific NamingExceptions that would help tell us if

Re: RFR JDK-8066642: Fix deprecation warnings in jdk.naming module

2014-12-12 Thread Lance Andersen
+1 On Dec 12, 2014, at 10:40 AM, Pavel Rappo wrote: > Hi everyone, > > Could you please review my change for JDK-8066642? > > http://cr.openjdk.java.net/~prappo/8066642/webrev.00/ > > -Pavel > Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1

RFR JDK-8066642: Fix deprecation warnings in jdk.naming module

2014-12-12 Thread Pavel Rappo
Hi everyone, Could you please review my change for JDK-8066642? http://cr.openjdk.java.net/~prappo/8066642/webrev.00/ -Pavel