On 16 Dec 2014, at 11:35, Pavel Rappo wrote:
> The latest webrev summing up all what we've talked so far:
>
> http://cr.openjdk.java.net/~prappo/8066867/webrev.02/
This looks good to me. Reviewed.
Just a note on the attribution. I think it should include at least the
following:
Cont
The latest webrev summing up all what we've talked so far:
http://cr.openjdk.java.net/~prappo/8066867/webrev.02/
-Pavel
> On 15 Dec 2014, at 21:39, Patrick Reinhart wrote:
>
>
> Have there been any further review being done jet?
>
>> Good catch, guys!
>>
>>> ...the method names are
Have there been any further review being done jet?
> Good catch, guys!
>
>> ...the method names are inconsistent (the methods in lower case with
>> embedded underscores)
>
> Fixed. Updated webrev: http://cr.openjdk.java.net/~prappo/8066867/webrev.01/
-Patrick
> Apologies Patrick, that's me who misread you. I assume I had a mix of your
> reply, our recent conversation and David’s question in my head.
No problem
> About your actual reply. That's probably a matter of taste, since nowhere else
> except for this particular method this thing is not used (
Apologies Patrick, that's me who misread you. I assume I had a mix of your
reply, our recent conversation and David's question in my head.
About your actual reply. That's probably a matter of taste, since nowhere else
except for this particular method this thing is not used (in java.nio.file.Files
Hi Chris,
> Am 09.12.2014 um 23:58 schrieb Chris Hegarty :
>
>
>> On 9 Dec 2014, at 22:24, Pavel Rappo wrote:
>>
>>
>>> 2) I would extract the buffer size to a constant as in the NIO Files class
>>
>> Patrick, we've discussed it already. Correct me if I wrong, but we came to
>> the
>> conclu
> On 9 Dec 2014, at 22:24, Pavel Rappo wrote:
>
>
>> 2) I would extract the buffer size to a constant as in the NIO Files class
>
> Patrick, we've discussed it already. Correct me if I wrong, but we came to the
> conclusion that there's not enough evidence to support the need for this
> metho
Hi Pavel,
>> 2) I would extract the buffer size to a constant as in the NIO Files class
>
I may expressed myself not clear in my comment. I just wanted to point out, if
the buffer size may should be extracted to a private static constant. The
java.nio.file.Files class was meant to be an exampl
> In the transferTo then transferred needs to be a long.
> „transferred“ should be a long instead of int
Good catch, guys!
> ...the method names are inconsistent (the methods in lower case with embedded
> underscores)
Fixed. Updated webrev: http://cr.openjdk.java.net/~prappo/8066867/webrev.01
> 2) I would extract the buffer size to a constant as in the NIO Files class
Patrick, we've discussed it already. Correct me if I wrong, but we came to the
conclusion that there's not enough evidence to support the need for this method.
-Pavel
On 9 Dec 2014, at 16:17, David M. Lloyd wrote:
> On 12/09/2014 09:47 AM, Pavel Rappo wrote:
>> Hi everyone,
>>
>> Could you please review my change for JDK-8066867?
>>
>> http://cr.openjdk.java.net/~prappo/8066867/webrev.00/
>
> In the NIO version of this method, it accepts a 'long' parameter
Hi Pavel,
1) „transferred“ should be a long instead of int
2) I would extract the buffer size to a constant as in the NIO Files class
-Patrick
> Hi everyone,
>
> Could you please review my change for JDK-8066867?
>
> http://cr.openjdk.java.net/~prappo/8066867/webrev.00/
>
> -
On 12/09/2014 09:47 AM, Pavel Rappo wrote:
Hi everyone,
Could you please review my change for JDK-8066867?
http://cr.openjdk.java.net/~prappo/8066867/webrev.00/
In the NIO version of this method, it accepts a 'long' parameter which
indicates how many bytes should be transferred (similar to s
On 09/12/2014 15:47, Pavel Rappo wrote:
Hi everyone,
Could you please review my change for JDK-8066867?
http://cr.openjdk.java.net/~prappo/8066867/webrev.00/
In the transferTo then transferred needs to be a long. I think I would
re-work the loop to make it a bit more readable but that is a so
Hi everyone,
Could you please review my change for JDK-8066867?
http://cr.openjdk.java.net/~prappo/8066867/webrev.00/
The task originated from discussion:
http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-November/029650
15 matches
Mail list logo
