RE: RFR JDK-8232724: Remove indirection with calling JNU_NewStringPlatform

2019-10-30 Thread Langer, Christoph
Sure. Thanks, Alexey. > -Original Message- > From: Alexey Ivanov > Sent: Mittwoch, 30. Oktober 2019 14:22 > To: Langer, Christoph ; David Holmes > ; core-libs ; > hotspot-runtime > Cc: Claes Redestad > Subject: Re: RFR JDK-8232724: Remove

Re: RFR JDK-8232724: Remove indirection with calling JNU_NewStringPlatform

2019-10-30 Thread Alexey Ivanov
riginal Message- From: David Holmes Sent: Mittwoch, 30. Oktober 2019 05:29 To: Alexey Ivanov ; core-libs ; hotspot-runtime ; Langer, Christoph Cc: Claes Redestad Subject: Re: RFR JDK-8232724: Remove indirection with calling JNU_NewStringPlatform LGTM. Thanks, David On 30/10/2019 1:04 am, Alex

RE: RFR JDK-8232724: Remove indirection with calling JNU_NewStringPlatform

2019-10-30 Thread Langer, Christoph
>; Langer, Christoph > Cc: Claes Redestad > Subject: Re: RFR JDK-8232724: Remove indirection with calling > JNU_NewStringPlatform > > LGTM. > > Thanks, > David > > On 30/10/2019 1:04 am, Alexey Ivanov wrote: > > Hi David, Christoph, > > > > Than

Re: RFR JDK-8232724: Remove indirection with calling JNU_NewStringPlatform

2019-10-29 Thread David Holmes
LGTM. Thanks, David On 30/10/2019 1:04 am, Alexey Ivanov wrote: Hi David, Christoph, Thank you for your reviews. On 29/10/2019 07:49, David Holmes wrote: Shall I remove one of them? The one in jvm.h because it's unused? Yes please remove the unused one in jvm.h. The updated webrev: http

Re: RFR JDK-8232724: Remove indirection with calling JNU_NewStringPlatform

2019-10-29 Thread Alexey Ivanov
Hi David, Christoph, Thank you for your reviews. On 29/10/2019 07:49, David Holmes wrote: Shall I remove one of them? The one in jvm.h because it's unused? Yes please remove the unused one in jvm.h. The updated webrev: http://cr.openjdk.java.net/~aivanov/8232724/webrev.01/ -- Regards, Ale

Re: RFR JDK-8232724: Remove indirection with calling JNU_NewStringPlatform

2019-10-29 Thread David Holmes
Hi Alexey, On 29/10/2019 4:46 am, Alexey Ivanov wrote: Hello, Please review the following fix which removes indirection in calling JNU_NewStringPlatform via NewStringPlatform. bug: https://bugs.openjdk.java.net/browse/JDK-8232724 webrev: http://cr.openjdk.java.net/~aivanov/8232724/webrev.00/

RE: RFR JDK-8232724: Remove indirection with calling JNU_NewStringPlatform

2019-10-28 Thread Langer, Christoph
Hi Alexey, > Please review the following fix which removes indirection in calling > JNU_NewStringPlatform via NewStringPlatform. > > bug: https://bugs.openjdk.java.net/browse/JDK-8232724 > webrev: http://cr.openjdk.java.net/~aivanov/8232724/webrev.00/ > > It is a follow-up fix to JDK-8232624 and

RFR JDK-8232724: Remove indirection with calling JNU_NewStringPlatform

2019-10-28 Thread Alexey Ivanov
Hello, Please review the following fix which removes indirection in calling JNU_NewStringPlatform via NewStringPlatform. bug: https://bugs.openjdk.java.net/browse/JDK-8232724 webrev: http://cr.openjdk.java.net/~aivanov/8232724/webrev.00/ It is a follow-up fix to JDK-8232624 and JDK-8231355. I