Hi Everyone
I am working on bug https://bugs.openjdk.java.net/browse/JDK-7190106. Based on
my research, it looks like the issue of fixed port was already addressed by
Stuart Marks in other RMI tests which are Java based. I would like to reuse his
solution, however it does not work for shell
Hi Everyone
http://cr.openjdk.java.net/~pzhang/Tristan/7190106/webrev/
Description:
1. Convert shell script test to Java program test.
2. Using random server port by reusing Darryl Mocek's work to replace
fixed server port.
3. Using java Process class to start client process.
4. Also convert ot
On 10/31/13 10:22 PM, Tristan Yan wrote:
I am working on bug https://bugs.openjdk.java.net/browse/JDK-7190106. Based
on my research, it looks like the issue of fixed port was already addressed
by Stuart Marks in other RMI tests which are Java based. I would like to
reuse his solution, however it
Hi Tristan,
Without commenting on the specifics of this test, in my estimation we
should strongly favor rewriting shell tests as Java programs, as has
already largely been done in the langtools area:
"Shelling Tests"
https://blogs.oracle.com/jjg/entry/shelling_tests
-Joe
On 10/31/20
On 11/1/13 9:18 AM, Tristan Yan wrote:
Hi Everyone
http://cr.openjdk.java.net/~pzhang/Tristan/7190106/webrev/
Description:
1. Convert shell script test to Java program test.
2. Using random server port by reusing Darryl Mocek's work to replace fixed
server port.
3. Using java Process class to
/Thank you, Stuart
There is one review point I want to ask you opinion. Which is the reason
that I moved from test/java/rmi/reliability/benchmark/bench/rmi to
test/java/rmi/reliability/benchmark is Main.java need access class
TestLibrary for supporting random port. TestLibrary is a unpackage
c
Hi Tristan,
Yes, it's kind of a problem that the RMI TestLibrary is in the unnamed package.
Classes in a named package cannot import classes from the unnamed package. We've
run into problems with this before. Eventually, we should move TestLibrary a
named package.
I think it's possible to wo
Hi Stuart
I tried your suggestion but unfortunately all the benchmarks have
dependencies to Main class because they need get stub from server. I
suggest we move the benchmark tests to unnamed package unless we do want
to put TestLibrary into a named package right now.
Please let me know if you
Hi Stuart
Also there is one more solution, which is there is one
jdk.testlibrary.Utils.getFreePort() method under test/lib. It's same
function as TestLibrary.getUnusedRandomPort() and it has named package.
Do you mind I use this one?
Since these two functions provide same functionality. Maybe w
Unfortunately we can't use jdk.testlibrary.Utils.getFreePort() for the RMI
tests, since RMI's TestLibrary.getUnusedRandomPort() respects a "reserved" port
range that's used by some RMI tests that have to used fixed ports.
s'marks
On 11/11/13 2:39 PM, Tristan Yan wrote:
Hi Stuart
Also there is
Hi Tristan,
(Sorry, for the delay; I'm traveling)
I think the current package (bench.rmi and bench.serial) organization makes good
sense, and I don't want to change it. The need to shuffle things around to
different packages indicates a factoring error. In this case the culprit is
TestLibrary
件-
发件人: Stuart Marks
发送时间: Tuesday, November 12, 2013 11:38 PM
收件人: Tristan Yan
抄送: core-libs-dev@openjdk.java.net; Alexandre (Shura) Iline
主题: Re: RFR for JDK-7190106 RMI benchmark fails intermittently because of use
of fixed port
Unfortunately we can't use jdk.testlibrary.Utils.getFreePor
106/webrev/
Thank you so much
Tristan
-邮件原件-
发件人: Stuart Marks
发送时间: Tuesday, November 12, 2013 11:38 PM
收件人: Tristan Yan
抄送: core-libs-dev@openjdk.java.net; Alexandre (Shura) Iline
主题: Re: RFR for JDK-7190106 RMI benchmark fails intermittently because of use
of fixed port
Unfortunately we
ristan Yan
发送时间: Thursday, November 14, 2013 11:09 PM
收件人: Stuart Marks
抄送: core-libs-dev@openjdk.java.net
主题: 答复: RFR for JDK-7190106 RMI benchmark fails intermittently because of use
of fixed port
Thank you Stuart
It took me a little time to correct the code. sorry be late. This is new webre
enchmark/runRmiBench.sh test.
http://cr.openjdk.java.net/~pzhang/Tristan/7190106/webrev/
Thank you so much
Tristan
-邮件原件-
发件人: Stuart Marks
发送时间: Tuesday, November 12, 2013 11:38 PM
收件人: Tristan Yan
抄送: core-libs-dev@openjdk.java.net; Alexandre (Shura) Iline
主题: Re: RFR for JDK-7190106
On 11/19/13 6:27 PM, Tristan Yan wrote:
Hi Stuart
Did you get chance to review it again.
Let me know if you have any new comments or suggestions.
Thanks
Tristan
-----邮件原件-----
发件人: Tristan Yan
发送时间: Thursday, November 14, 2013 11:09 PM
收件人: Stuart Marks
抄送: core-libs-dev@openjdk.java.net
主题: 答复: RFR
'll get to this
soon.
s'marks
On 11/19/13 6:27 PM, Tristan Yan wrote:
Hi Stuart
Did you get chance to review it again.
Let me know if you have any new comments or suggestions.
Thanks
Tristan
-----邮件原件-
发件人: Tristan Yan
发送时间: Thursday, November 14, 2013 11:09 PM
收件人: Stuart Marks
抄送
>> Description:
>>>> 1. Convert shell script test to Java program test.
>>>> 2. Using random server port by reusing Darryl Mocek's
>>>> work(TestLibrary.getUnusedRandomPort) to replace fixed server port.
>>>> 3. Because TestLibrary doesn
18 matches
Mail list logo
