Re: RFR of JDK-8176563: @since value errors in apis of java.base/java.logging module

> On Mar 15, 2017, at 7:40 PM, Hamlin Li wrote: > > Hi, > > Thank you for reviewing, as StackFramePermission was just removed in > JDK-8176815, so I remove the @since change for StackFramePermission, and the > rest code change is pushed. > Thanks. The updated change

Re: RFR of JDK-8176563: @since value errors in apis of java.base/java.logging module

Hi, Thank you for reviewing, as StackFramePermission was just removed in JDK-8176815, so I remove the @since change for StackFramePermission, and the rest code change is pushed. Thank you -Hamlin On 2017/3/15 19:55, Alan Bateman wrote: On 15/03/2017 11:35, Daniel Fuchs wrote: Hi

Re: RFR of JDK-8176563: @since value errors in apis of java.base/java.logging module

On 15/03/2017 11:35, Daniel Fuchs wrote: Hi Hamlin, The new version looks good to me. Maybe wait for review of the other interested parties ;-) This one looks right to me too. -Alan

Re: RFR of JDK-8176563: @since value errors in apis of java.base/java.logging module

Hi Hamlin, The new version looks good to me. Maybe wait for review of the other interested parties ;-) best regards, -- daniel On 15/03/2017 04:34, Hamlin Li wrote: BTW, I did *remove* the unnecessary @since for ObjectInputFilter.checkInput. :-) Thank you -Hamlin On 2017/3/15 11:34,

Re: RFR of JDK-8176563: @since value errors in apis of java.base/java.logging module

BTW, I did *remove* the unnecessary @since for ObjectInputFilter.checkInput. :-) Thank you -Hamlin On 2017/3/15 11:34, Hamlin Li wrote: Hi everyone, Thanks a lot for the patient review and comments, I think you're right to remove @since when overriding methods, I will also adjust the tool

Re: RFR of JDK-8176563: @since value errors in apis of java.base/java.logging module

Hi everyone, Thanks a lot for the patient review and comments, I think you're right to remove @since when overriding methods, I will also adjust the tool to take this into account. I have updated as everyone suggested, new webrev is at : http://cr.openjdk.java.net/~mli/8176563/webrev.01/

Re: RFR of JDK-8176563: @since value errors in apis of java.base/java.logging module

Hamlin, I have to agree with Martin here. These changes seem very misguided in places. Only NEW types or new type members should be flagged with @since. For example, adding "@since 9" to java.lang.reflect.Field.setAccessible is just WRONG! David On 15/03/2017 2:06 AM, Martin Buchholz

Re: RFR of JDK-8176563: @since value errors in apis of java.base/java.logging module

On 3/14/17 7:53 AM, Roger Riggs wrote: Hi, - The @since in ObjectInputFilter.checkInput is unnecessary; the class has @since 9 - java.util.Properties.replace @since seems unnecessary because it will not be seen. The @hidden is a bit odd too but that has its own explaination (btw, it is the

Re: RFR of JDK-8176563: @since value errors in apis of java.base/java.logging module

Hi Hamlin, I had the same remark than Roger & others about ObjectInputFilter::checkInput. The changes to LogManager are OK. How did I forget that @since? Thanks for catching that! Don't count me as Reviewer for the other java.util changes though. best regards -- daniel On 14/03/2017 06:40,

Re: RFR of JDK-8176563: @since value errors in apis of java.base/java.logging module

On Tue, Mar 14, 2017 at 12:46 AM, Hamlin Li wrote: > > @since *since-text* > > Introduced in JDK 1.1 > > Adds a *Since* heading with the specified since-text value to the > generated documentation. The text has no special internal structure. This > tag is valid in any

Re: RFR of JDK-8176563: @since value errors in apis of java.base/java.logging module

Hi, - The @since in ObjectInputFilter.checkInput is unnecessary; the class has @since 9 - java.util.Properties.replace @since seems unnecessary because it will not be seen. The @hidden is a bit odd too but that has its own explaination (btw, it is the only one in the jdk). - I agree

Re: RFR of JDK-8176563: @since value errors in apis of java.base/java.logging module

Hamlin, > On 14 Mar 2017, at 08:21, Hamlin Li wrote: > > > On 2017/3/14 15:46, Hamlin Li wrote: >> Hi Martin, >> >> >> On 2017/3/14 15:06, Martin Buchholz wrote: >>> I wouldn't put a blank line between javadoc tags. >> Will fix it. > Hi Martin, > > Just update webrev

Re: RFR of JDK-8176563: @since value errors in apis of java.base/java.logging module

On 2017/3/14 15:46, Hamlin Li wrote: Hi Martin, On 2017/3/14 15:06, Martin Buchholz wrote: I wouldn't put a blank line between javadoc tags. Will fix it. Hi Martin, Just update webrev in place to remove blank lines, webrev still at http://cr.openjdk.java.net/~mli/8176563/webrev.00/

Re: RFR of JDK-8176563: @since value errors in apis of java.base/java.logging module

Hi Martin, On 2017/3/14 15:06, Martin Buchholz wrote: I wouldn't put a blank line between javadoc tags. Will fix it. I'm not sure whether @since is justified for new specialized implementations like ArrayDeque.removeAll. It is somewhat misleading to add the @since because that method has

Re: RFR of JDK-8176563: @since value errors in apis of java.base/java.logging module

I wouldn't put a blank line between javadoc tags. I'm not sure whether @since is justified for new specialized implementations like ArrayDeque.removeAll. It is somewhat misleading to add the @since because that method has worked just fine in past releases with no substantive spec change.

RFR of JDK-8176563: @since value errors in apis of java.base/java.logging module

Would you please review the below patch? bug: https://bugs.openjdk.java.net/browse/JDK-8176563 webrev: http://cr.openjdk.java.net/~mli/8176563/webrev.00/ Thank you -Hamlin