Re: RFR: 8263668: Update java.time to use instanceof pattern variable [v6]

2021-04-21 Thread Patrick Concannon
On Wed, 21 Apr 2021 09:06:45 GMT, Daniel Fuchs wrote: >> Patrick Concannon has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Updated single letter pattern variable names > > src/java.base/share/classes/java/time/Duration.java line 723: >

Re: RFR: 8263668: Update java.time to use instanceof pattern variable [v6]

2021-04-21 Thread Patrick Concannon
On Wed, 24 Mar 2021 11:06:38 GMT, Rémi Forax wrote: >> Patrick Concannon has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Updated single letter pattern variable names > > src/java.base/share/classes/java/time/format/DateTimeFormatterBuil

Re: RFR: 8263668: Update java.time to use instanceof pattern variable [v6]

2021-04-21 Thread Daniel Fuchs
On Tue, 20 Apr 2021 17:46:38 GMT, Patrick Concannon wrote: >> Hi, >> >> Could someone please review my code for updating the code in the `java.time` >> package to make use of the `instanceof` pattern variable? >> >> Kind regards, >> Patrick > > Patrick Concannon has updated the pull request i

Re: RFR: 8263668: Update java.time to use instanceof pattern variable [v6]

2021-04-20 Thread Naoto Sato
On Tue, 20 Apr 2021 17:46:38 GMT, Patrick Concannon wrote: >> Hi, >> >> Could someone please review my code for updating the code in the `java.time` >> package to make use of the `instanceof` pattern variable? >> >> Kind regards, >> Patrick > > Patrick Concannon has updated the pull request i

Re: RFR: 8263668: Update java.time to use instanceof pattern variable [v6]

2021-04-20 Thread Roger Riggs
On Tue, 20 Apr 2021 17:46:38 GMT, Patrick Concannon wrote: >> Hi, >> >> Could someone please review my code for updating the code in the `java.time` >> package to make use of the `instanceof` pattern variable? >> >> Kind regards, >> Patrick > > Patrick Concannon has updated the pull request i

Re: RFR: 8263668: Update java.time to use instanceof pattern variable [v6]

2021-04-20 Thread Patrick Concannon
On Wed, 24 Mar 2021 10:57:11 GMT, Rémi Forax wrote: >> Patrick Concannon has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Updated single letter pattern variable names > > src/java.base/share/classes/java/time/LocalDateTime.java line 1686

Re: RFR: 8263668: Update java.time to use instanceof pattern variable [v6]

2021-04-20 Thread Patrick Concannon
> Hi, > > Could someone please review my code for updating the code in the `java.time` > package to make use of the `instanceof` pattern variable? > > Kind regards, > Patrick Patrick Concannon has updated the pull request incrementally with one additional commit since the last revision: Upd