Re: RFR [9] 8148154: JOpt Simple - a Java library for parsing command line options

2016-01-25 Thread Chris Hegarty
On 25/01/16 15:47, Alan Bateman wrote: On 25/01/2016 15:38, Chris Hegarty wrote: JOpt Simple [1] is a Java library for parsing command line options. The JDK has several different home-grown versions of command line option-parsing code. Where possible, new and existing tools in the JDK should c

Re: RFR [9] 8148154: JOpt Simple - a Java library for parsing command line options

2016-01-25 Thread Chris Hegarty
On 25/01/16 16:16, Alan Bateman wrote: On 25/01/2016 16:09, Chris Hegarty wrote: Bringing this into jdk9/dev in the advance looks good. One thing, should we add a README so that we know exactly which version of JOpt Simple this is? Good idea Alan. Added and webrev updated in-place. Thanks,

Re: RFR [9] 8148154: JOpt Simple - a Java library for parsing command line options

2016-01-25 Thread Alan Bateman
On 25/01/2016 16:09, Chris Hegarty wrote: Bringing this into jdk9/dev in the advance looks good. One thing, should we add a README so that we know exactly which version of JOpt Simple this is? Good idea Alan. Added and webrev updated in-place. Thanks, that should make it easy to identify. We

Re: RFR [9] 8148154: JOpt Simple - a Java library for parsing command line options

2016-01-25 Thread Chris Hegarty
On 25/01/16 15:45, Roger Riggs wrote: Hi Chris, Are there any tests that can be included? No, I am not planning to add specific tests for JOpt Simple. The tools that eventually use it, should provide sufficient testing. -Chris. Roger On 1/25/2016 10:39 AM, Claes Redestad wrote: +1 modul

Re: RFR [9] 8148154: JOpt Simple - a Java library for parsing command line options

2016-01-25 Thread Alan Bateman
On 25/01/2016 15:45, Chris Hegarty wrote: : "jdk.internal.opt" might be ever so slightly misleading, wouldn't "jdk.internal.joptsimple" be a better name for the module? For consistency, I took the same terse approach applied to the jdk.internal.le module. Right, and the module name is delib

Re: RFR [9] 8148154: JOpt Simple - a Java library for parsing command line options

2016-01-25 Thread Roger Riggs
Hi Chris, On 1/25/2016 10:45 AM, Chris Hegarty wrote: On 25/01/16 15:39, Claes Redestad wrote: "jdk.internal.opt" might be ever so slightly misleading, wouldn't "jdk.internal.joptsimple" be a better name for the module? For consistency, I took the same terse approach applied to the jdk.inte

Re: RFR [9] 8148154: JOpt Simple - a Java library for parsing command line options

2016-01-25 Thread Alan Bateman
On 25/01/2016 15:38, Chris Hegarty wrote: JOpt Simple [1] is a Java library for parsing command line options. The JDK has several different home-grown versions of command line option-parsing code. Where possible, new and existing tools in the JDK should consider using JOpt Simple. JOpt Simple i

Re: RFR [9] 8148154: JOpt Simple - a Java library for parsing command line options

2016-01-25 Thread Chris Hegarty
On 25/01/16 15:39, Claes Redestad wrote: +1 Thanks for looking at this Claes. module-info.java missing? No. There is an update to modules.xml. This is all that is required in jdk9/dev, for now. "jdk.internal.opt" might be ever so slightly misleading, wouldn't "jdk.internal.joptsimple" be

Re: RFR [9] 8148154: JOpt Simple - a Java library for parsing command line options

2016-01-25 Thread Roger Riggs
Hi Chris, Are there any tests that can be included? Roger On 1/25/2016 10:39 AM, Claes Redestad wrote: +1 module-info.java missing? "jdk.internal.opt" might be ever so slightly misleading, wouldn't "jdk.internal.joptsimple" be a better name for the module? /Claes On 2016-01-25 16:38, Ch

Re: RFR [9] 8148154: JOpt Simple - a Java library for parsing command line options

2016-01-25 Thread Claes Redestad
+1 module-info.java missing? "jdk.internal.opt" might be ever so slightly misleading, wouldn't "jdk.internal.joptsimple" be a better name for the module? /Claes On 2016-01-25 16:38, Chris Hegarty wrote: JOpt Simple [1] is a Java library for parsing command line options. The JDK has several