On 16/05/2013 7:07 PM, Alan Bateman wrote:
On 16/05/2013 05:08, David Holmes wrote:
Okay mea culpa - I was testing on the wrong JDK. I wrongly assumed
this would impact 7 as well but it doesn't as the bug was introduced
with the changes in 6914123.
Sorry about that.
Good to go. Has anyone offe
On 16/05/2013 05:08, David Holmes wrote:
Okay mea culpa - I was testing on the wrong JDK. I wrongly assumed
this would impact 7 as well but it doesn't as the bug was introduced
with the changes in 6914123.
Sorry about that.
Good to go. Has anyone offered to sponsor this yet?
It looks good to
Hi,
Right, the test calls the correctly synchronized method in JDK7. The fix
for 6914123 in JDK8 moves synchronization to the other method (the one
taking CharSequence as parameter type), so in JDK8 it doesn't matter
which method is called, but in JDK7 it makes a difference. The same test
cou
Okay mea culpa - I was testing on the wrong JDK. I wrongly assumed this
would impact 7 as well but it doesn't as the bug was introduced with the
changes in 6914123.
Sorry about that.
Good to go. Has anyone offered to sponsor this yet?
David
-
On 15/05/2013 5:50 PM, Peter Levart wrote:
M
Hi Peter;
I tried it on my i7 box and was able to get it to fail right away. I didn't try
the previous test on this box so can't say whether it would have also failed.
Applying the String changes resolved the issue. I think this one is ready!
Mike
On May 15 2013, at 00:50 , Peter Levart wrote:
On 15/05/2013 08:50, Peter Levart wrote:
Mike, David,
Could you try this variant of the test:
http://cr.openjdk.java.net/~plevart/jdk8-tl/String.contentEquals/webrev.05/
I tried it on 3 different machines (4-core i7 Linux, 8-core sparc T-2
Solaris, 4-core amd64 Solaris) x 2 different JDK8
Mike, David,
Could you try this variant of the test:
http://cr.openjdk.java.net/~plevart/jdk8-tl/String.contentEquals/webrev.05/
I tried it on 3 different machines (4-core i7 Linux, 8-core sparc T-2
Solaris, 4-core amd64 Solaris) x 2 different JDK8 JVMs (64bit and 32bit)
and it fails immedia
On 14/05/2013 9:34 PM, Peter Levart wrote:
On 05/14/2013 01:17 PM, David Holmes wrote:
Thanks Peter this looks good to me.
One minor thing please set the correct copyright year in the test, it
should just be
Copyright (c) 2013, Oracle ...
Ok, fixed:
http://cr.openjdk.java.net/~plevart/jdk8-
Good to see the test added. I was also unable to reproduce the failure on my
Core 2 Duo Mac laptop but the test and fix match up.
Mike
On May 14 2013, at 04:34 , Peter Levart wrote:
> On 05/14/2013 01:17 PM, David Holmes wrote:
>> Thanks Peter this looks good to me.
>>
>> One minor thing plea
On 05/14/2013 01:17 PM, David Holmes wrote:
Thanks Peter this looks good to me.
One minor thing please set the correct copyright year in the test, it
should just be
Copyright (c) 2013, Oracle ...
Ok, fixed:
http://cr.openjdk.java.net/~plevart/jdk8-tl/String.contentEquals/webrev.04/
I c
Thanks Peter this looks good to me.
One minor thing please set the correct copyright year in the test, it
should just be
Copyright (c) 2013, Oracle ...
I couldn't get the test to actually fail, but I can see that it could.
David
On 14/05/2013 9:04 PM, Peter Levart wrote:
Ok, here's the cor
11 matches
Mail list logo
