Request for review: 8005618 - TEST_BUG: java/lang/ProcessBuilder/Basic.java failing intermittently

2013-01-14 Thread Rob McKenna
Simple enough fix but to be honest I'm not sure any value will *always* work for the dead process waitFor(). Our testing infrastructure seems to glide past whatever we consider to be acceptable tolerances. http://cr.openjdk.java.net/~robm/8005618/webrev.01/

Re: Request for review: 8005618 - TEST_BUG: java/lang/ProcessBuilder/Basic.java failing intermittently

2013-01-14 Thread Martin Buchholz
Looks good! Mea culpa for some of those slow and flaky sleeps in this code, although they are tricky to avoid - there is no cross-process latches, for example. On Mon, Jan 14, 2013 at 1:12 PM, Rob McKenna wrote: > Simple enough fix but to be honest I'm not sure any value will *always* work > for

Re: Request for review: 8005618 - TEST_BUG: java/lang/ProcessBuilder/Basic.java failing intermittently

2013-01-14 Thread David Holmes
On 15/01/2013 7:12 AM, Rob McKenna wrote: Simple enough fix but to be honest I'm not sure any value will *always* work for the dead process waitFor(). Our testing infrastructure seems to glide past whatever we consider to be acceptable tolerances. http://cr.openjdk.java.net/~robm/8005618/webrev.

Re: Request for review: 8005618 - TEST_BUG: java/lang/ProcessBuilder/Basic.java failing intermittently

2013-01-14 Thread Martin Buchholz
On Mon, Jan 14, 2013 at 5:31 PM, David Holmes wrote: > On 15/01/2013 7:12 AM, Rob McKenna wrote: >> >> Simple enough fix but to be honest I'm not sure any value will *always* >> work for the dead process waitFor(). Our testing infrastructure seems to >> glide past whatever we consider to be accept

Re: Request for review: 8005618 - TEST_BUG: java/lang/ProcessBuilder/Basic.java failing intermittently

2013-01-15 Thread Alan Bateman
On 15/01/2013 01:31, David Holmes wrote: On 15/01/2013 7:12 AM, Rob McKenna wrote: Simple enough fix but to be honest I'm not sure any value will *always* work for the dead process waitFor(). Our testing infrastructure seems to glide past whatever we consider to be acceptable tolerances. http:/

Re: Request for review: 8005618 - TEST_BUG: java/lang/ProcessBuilder/Basic.java failing intermittently

2013-01-15 Thread David Holmes
On 15/01/2013 9:55 PM, Alan Bateman wrote: On 15/01/2013 01:31, David Holmes wrote: On 15/01/2013 7:12 AM, Rob McKenna wrote: Simple enough fix but to be honest I'm not sure any value will *always* work for the dead process waitFor(). Our testing infrastructure seems to glide past whatever we c