Re: Review Request 8074432: Move jdeps to jdk.compiler module

2015-05-27 Thread Alan Bateman
On 27/05/2015 07:00, Mandy Chung wrote: We discussed this offline and revised the proposal to group javap and classfile library together with jdeps in jdk.jdeps module for static analysis tools to live. The jdk.compiler module will contain the compiler and a couple of small tools. Moving o

Re: Review Request 8074432: Move jdeps to jdk.compiler module

2015-05-27 Thread Erik Joelsson
Looks good to me. /Erik On 2015-05-27 15:40, Mandy Chung wrote: It’s in my repo but missing from the webrev. diff --git a/make/launcher/Launcher-jdk.jdeps.gmk b/make/launcher/Launcher-jdk.jdeps.gmk new file mode 100644 --- /dev/null +++ b/make/launcher/Launcher-jdk.jdeps.gmk @@ -0,0 +1,36 @@

Re: Review Request 8074432: Move jdeps to jdk.compiler module

2015-05-27 Thread Mandy Chung
It’s in my repo but missing from the webrev. diff --git a/make/launcher/Launcher-jdk.jdeps.gmk b/make/launcher/Launcher-jdk.jdeps.gmk new file mode 100644 --- /dev/null +++ b/make/launcher/Launcher-jdk.jdeps.gmk @@ -0,0 +1,36 @@ +# +# Copyright (c) 2015, Oracle and/or its affiliates. All rights r

Re: Review Request 8074432: Move jdeps to jdk.compiler module

2015-05-27 Thread Erik Joelsson
Hello Mandy, I don't see a Launcher-jdk.jdeps.gmk. Should there be one? /Erik On 2015-05-27 08:00, Mandy Chung wrote: We discussed this offline and revised the proposal to group javap and classfile library together with jdeps in jdk.jdeps module for static analysis tools to live. The jdk.co

Re: Review Request 8074432: Move jdeps to jdk.compiler module

2015-05-26 Thread Mandy Chung
We discussed this offline and revised the proposal to group javap and classfile library together with jdeps in jdk.jdeps module for static analysis tools to live. The jdk.compiler module will contain the compiler and a couple of small tools. Moving out javap and classfile library save about 1.

Re: Review Request 8074432: Move jdeps to jdk.compiler module

2015-05-25 Thread Mandy Chung
Meant to include jigsaw-dev in the initial post. > On May 25, 2015, at 12:16 AM, Alan Bateman wrote: > > On 24/05/2015 05:00, Mandy Chung wrote: >> This will move jdeps to the same module as other langtools javac and javap. >> >> Webrev at: >> http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8

Re: Review Request 8074432: Move jdeps to jdk.compiler module

2015-05-25 Thread Alan Bateman
On 24/05/2015 05:00, Mandy Chung wrote: This will move jdeps to the same module as other langtools javac and javap. Webrev at: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8074432/webrev.00/ This is the final change to resolve the open issue JDK-8072601 (Re-examine jdk.runtime and jdk.de

Review Request 8074432: Move jdeps to jdk.compiler module

2015-05-23 Thread Mandy Chung
This will move jdeps to the same module as other langtools javac and javap. Webrev at: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8074432/webrev.00/ This is the final change to resolve the open issue JDK-8072601 (Re-examine jdk.runtime and jdk.dev modules) for JEP 200. Mandy