Re: Review request: JDK-7147084 (process) appA hangs when read output stream of appB which starts appC that runs forever (v.3)

2013-08-06 Thread Alan Bateman
On 06/08/2013 03:27, Alexey Utkin wrote: Here is new version of the fix: http://cr.openjdk.java.net/~uta/openjdk-webrevs/JDK-7147084/webrev.03/ Thanks for the updates, it looks good now. I think someday we might need to re-examine performC in the tests but what you have is fine for now. -Al

Review request: JDK-7147084 (process) appA hangs when read output stream of appB which starts appC that runs forever (v.3)

2013-08-06 Thread Alexey Utkin
Here is new version of the fix: http://cr.openjdk.java.net/~uta/openjdk-webrevs/JDK-7147084/webrev.03/ On 8/6/2013 8:48 AM, Alan Bateman wrote: On 05/08/2013 09:05, Alexey Utkin wrote: Here is new version of the fix: http://cr.openjdk.java.net/~uta/openjdk-webrevs/JDK-7147084/webrev.02/ Change

Re: Review request: JDK-7147084 (process) appA hangs when read output stream of appB which starts appC that runs forever (v.2)

2013-08-05 Thread Alan Bateman
On 05/08/2013 09:05, Alexey Utkin wrote: Here is new version of the fix: http://cr.openjdk.java.net/~uta/openjdk-webrevs/JDK-7147084/webrev.02/ Changes (in accordance with Alan's recommendations): -- Magic constant -1 was changed to JAVA_INVALID_HANDLE_VALUE with explanation why the macro INVA

Re: Review request: JDK-7147084 (process) appA hangs when read output stream of appB which starts appC that runs forever (v.2)

2013-08-05 Thread Alexey Utkin
Here is new version of the fix: http://cr.openjdk.java.net/~uta/openjdk-webrevs/JDK-7147084/webrev.02/ Changes (in accordance with Alan's recommendations): -- Magic constant -1 was changed to JAVA_INVALID_HANDLE_VALUE with explanation why the macro INVALID_HANDLE_VALUE is not in use. -- The com

Re: Review request: JDK-7147084 (process) appA hangs when read output stream of appB which starts appC that runs forever (v.1)

2013-07-28 Thread Alan Bateman
On 11/07/2013 02:03, Alexey Utkin wrote: : Bug description: https://jbs.oracle.com/bugs/browse/JDK-7147084 http://bugs.sun.com/view_bug.do?bug_id=7147084 Here is the suggested fix: http://cr.openjdk.java.net/~uta/openjdk-webrevs/JDK-7147084/webrev.01/ Summary for v1 changes: -- The

Re: Review request: JDK-7147084 (process) appA hangs when read output stream of appB which starts appC that runs forever (v.1)

2013-07-16 Thread Rob McKenna
Hi Alexey, I've just had a look at the webrev. Looks good. Unfortunately I'm not a reviewer here so the only benefit was for my education I'm afraid. It would be great to get Alan's input next week. For the benefit of the alias: I had asked Alexey if an intermediate launcher akin to the one

Re: Review request: JDK-7147084 (process) appA hangs when read output stream of appB which starts appC that runs forever (v.1)

2013-07-11 Thread Alexey Utkin
Rob, Could you help me with bug review. It stay in review pool too long. Nobody like to look into the native code. Here is the long problem & solution description: https://jbs.oracle.com/bugs/browse/JDK-7147084?focusedCommentId=13322689&page=com.atlassian.jira.plugin.system.issuetabpanels:comm

Review request: JDK-7147084 (process) appA hangs when read output stream of appB which starts appC that runs forever (v.1)

2013-05-16 Thread Alexey Utkin
Bug description: https://jbs.oracle.com/bugs/browse/JDK-7147084 http://bugs.sun.com/view_bug.do?bug_id=7147084 Here is the suggested fix: http://cr.openjdk.java.net/~uta/openjdk-webrevs/JDK-7147084/webrev.01/ Summary for v1 changes: -- The set of handles that need to restore the inheri

Re: Review request: JDK-7147084 (process) appA hangs when read output stream of appB which starts appC that runs forever

2013-05-13 Thread Alexey Utkin
Thanks, Martin! You are right. The approach private static String JAVA_EXE = System.getProperty("java.home") + File.separator + "bin" + File.separator + "java"; private static String[] getCommandArray(String processName) { String[] cmdArray = { JAVA_E

Re: Review request: JDK-7147084 (process) appA hangs when read output stream of appB which starts appC that runs forever

2013-05-08 Thread Martin Buchholz
Alexey, Thanks for working on the scary windows process stuff. I only have time for superficial review. It looks like you know what you're doing. +String[] cmdArray = { +"java", +"-cp", This looks like it's invoking whatever "java" is on the path. But there's no g

Review request: JDK-7147084 (process) appA hangs when read output stream of appB which starts appC that runs forever

2013-05-08 Thread Alexey Utkin
Bug description: https://jbs.oracle.com/bugs/browse/JDK-7147084 http://bugs.sun.com/view_bug.do?bug_id=7147084 Here is the suggested fix: http://cr.openjdk.java.net/~uta/openjdk-webrevs/JDK-7147084/webrev.00/ Summary: I would like to describe the bug synopsis, common Java approach to Windows ha