Re: Review request for 8038177 Eliminate unnecessary dependency to sun.security.action

2014-03-25 Thread Alan Bateman
On 25/03/2014 20:41, Mandy Chung wrote: : The ExtendedCharsets.init method has a check to ensure that the VM has been booted. Sherman can confirm that. 1170 protected void init() { 1171 if (initialized) 1172 return; 1173 if (!sun.misc.VM.isBooted()) 1174

Re: Review request for 8038177 Eliminate unnecessary dependency to sun.security.action

2014-03-25 Thread Mandy Chung
On 3/24/2014 8:15 AM, Alan Bateman wrote: On 21/03/2014 21:28, Mandy Chung wrote: This is the second patch to eliminate the dependencies to sun.security.action: https://bugs.openjdk.java.net/browse/JDK-8038177 Webrev at: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8038177/webrev.00/ I

Re: Review request for 8038177 Eliminate unnecessary dependency to sun.security.action

2014-03-24 Thread Alan Bateman
On 21/03/2014 21:28, Mandy Chung wrote: This is the second patch to eliminate the dependencies to sun.security.action: https://bugs.openjdk.java.net/browse/JDK-8038177 Webrev at: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8038177/webrev.00/ It looks good to me too. The only one that I

Re: Review request for 8038177 Eliminate unnecessary dependency to sun.security.action

2014-03-24 Thread Chris Hegarty
The changes look good to me Mandy. -Chris. On 21/03/14 21:28, Mandy Chung wrote: This is the second patch to eliminate the dependencies to sun.security.action: https://bugs.openjdk.java.net/browse/JDK-8038177 Webrev at: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8038177/webrev.00/ Ma

Review request for 8038177 Eliminate unnecessary dependency to sun.security.action

2014-03-21 Thread Mandy Chung
This is the second patch to eliminate the dependencies to sun.security.action: https://bugs.openjdk.java.net/browse/JDK-8038177 Webrev at: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8038177/webrev.00/ Mandy