Re: Review request for JDK-8051540: Convert JAXP functin tests: org.xml.sax to jtreg (testNG) tests

2014-10-15 Thread Joe Darcy
Hi Joe, Before performing the full investigation, I'm now leaning toward have a base repo which would host files currently in the jdk, langtools, and hotspot repos and then another repo for all the other library code (jaxp, jaxws, corba). Compared to moving around all the source files in

Re: Review request for JDK-8051540: Convert JAXP functin tests: org.xml.sax to jtreg (testNG) tests

2014-10-15 Thread huizhe wang
On 10/15/2014 8:35 AM, Joe Darcy wrote: Hi Joe, Before performing the full investigation, I'm now leaning toward have a base repo which would host files currently in the jdk, langtools, and hotspot repos and then another repo for all the other library code (jaxp, jaxws, corba). Something

Re: Review request for JDK-8051540: Convert JAXP functin tests: org.xml.sax to jtreg (testNG) tests

2014-08-29 Thread Alan Bateman
On 28/08/2014 08:31, Michael Kay wrote: I haven't yet had a chance to look at the JAXP tests, but this kind of message suggests to me that they don't separate what is in JAXP (the interface) from what is in Xalan and Xerces (the implementations).Would that be a correct assumption? The

Re: Review request for JDK-8051540: Convert JAXP functin tests: org.xml.sax to jtreg (testNG) tests

2014-08-28 Thread Michael Kay
: Convert JAXP functin tests: org.xml.sax to jtreg (testNG) tests On 8/27/2014 4:03 PM, Tristan Yan wrote: Hi Joe and others I updated the tests with putting them in jaxp repo. I also run these tests with security manager and they all passed http://cr.openjdk.java.net

RE: Review request for JDK-8051540: Convert JAXP functin tests: org.xml.sax to jtreg (testNG) tests

2014-08-28 Thread Frank Yuan
] Sent: Thursday, August 28, 2014 3:31 PM To: Frank Yuan Cc: huizhe wang; Tristan Yan; Core-Libs-Dev Subject: Re: Review request for JDK-8051540: Convert JAXP functin tests: org.xml.sax to jtreg (testNG) tests I haven't yet had a chance to look at the JAXP tests, but this kind of message suggests

Re: Review request for JDK-8051540: Convert JAXP functin tests: org.xml.sax to jtreg (testNG) tests

2014-08-28 Thread huizhe wang
chain. Best Regards Frank -Original Message- From: core-libs-dev [mailto:core-libs-dev-boun...@openjdk.java.net] On Behalf Of huizhe wang Sent: Thursday, August 28, 2014 7:39 AM To: Tristan Yan Cc: Core-Libs-Dev Subject: Re: Review request for JDK-8051540: Convert JAXP functin

Re: Review request for JDK-8051540: Convert JAXP functin tests: org.xml.sax to jtreg (testNG) tests

2014-08-27 Thread huizhe wang
On 8/27/2014 4:03 PM, Tristan Yan wrote: Hi Joe and others I updated the tests with putting them in jaxp repo. I also run these tests with security manager and they all passed http://cr.openjdk.java.net/~tyan/JDK-8051540/webrev01/ http://cr.openjdk.java.net/%7Etyan/JDK-8051540/webrev01/

RE: Review request for JDK-8051540: Convert JAXP functin tests: org.xml.sax to jtreg (testNG) tests

2014-08-27 Thread Frank Yuan
-Original Message- From: core-libs-dev [mailto:core-libs-dev-boun...@openjdk.java.net] On Behalf Of huizhe wang Sent: Thursday, August 28, 2014 7:39 AM To: Tristan Yan Cc: Core-Libs-Dev Subject: Re: Review request for JDK-8051540: Convert JAXP functin tests: org.xml.sax to jtreg

Re: Review request for JDK-8051540: Convert JAXP functin tests: org.xml.sax to jtreg (testNG) tests

2014-08-27 Thread huizhe wang
-libs-dev [mailto:core-libs-dev-boun...@openjdk.java.net] On Behalf Of huizhe wang Sent: Thursday, August 28, 2014 7:39 AM To: Tristan Yan Cc: Core-Libs-Dev Subject: Re: Review request for JDK-8051540: Convert JAXP functin tests: org.xml.sax to jtreg (testNG) tests On 8/27/2014 4:03 PM, Tristan

Re: Review request for JDK-8051540: Convert JAXP functin tests: org.xml.sax to jtreg (testNG) tests

2014-08-19 Thread huizhe wang
By the way, the plan has been that all of the JAXP SQE and Unit tests be migrated into [openjdk]/jaxp repo under jaxp/test. Tests currently in the jdk repo shall be moved to jaxp/test as well. I see that your webrev was generated in jdk9/dev/jdk. I hope it doesn't mean you're checking tests

Re: Review request for JDK-8051540: Convert JAXP functin tests: org.xml.sax to jtreg (testNG) tests

2014-08-19 Thread Tristan Yan
Thanks Joe. I will move the tests to [openjdk]/jaxp repo then. Tristan On Aug 19, 2014, at 10:32 AM, huizhe wang huizhe.w...@oracle.com wrote: By the way, the plan has been that all of the JAXP SQE and Unit tests be migrated into [openjdk]/jaxp repo under jaxp/test. Tests currently in the

Review request for JDK-8051540: Convert JAXP functin tests: org.xml.sax to jtreg (testNG) tests

2014-08-18 Thread Tristan Yan
Hi Joe, Alan and others We’re working on moving our internal jaxp functional tests to open idk repo(Include refactoring effort). This is the first open review I am asking for SAX and Transform. Would you please review these tests. Any comment will be appreciated. I put the webrev as follows:

Re: Review request for JDK-8051540: Convert JAXP functin tests: org.xml.sax to jtreg (testNG) tests

2014-08-18 Thread huizhe wang
Hi Tristan, Nice work! As with those converted by Eric (8051561), the new tests looked much better and cleaner than the original ones. I see that you're using jaxp.library instead of a base class as in Eric's previous webrev. Is this the final decision on the whole test structure? It

Re: Review request for JDK-8051540: Convert JAXP functin tests: org.xml.sax to jtreg (testNG) tests

2014-08-18 Thread Tristan Yan
Thanks Joe We intend to replace the base class with test library because that doesn’t look like a real base class but an utilities class. I haven’t tried to run these tests with security manager, I will run them with security manager then get back you soon. Thank you. Tristan On Aug 18, 2014,