RE: Review request for JDK-8080266: Failed to create CharInfo due to ResourceBundle update for modules

2015-06-25 Thread Frank Yuan
tavo Galimberti'; sandeep.konch...@oracle.com; 'Alexandre (Shura) Iline'; 'Alan Bateman' Subject: Re: Review request for JDK-8080266: Failed to create CharInfo due to ResourceBundle update for modules Hi Frank, I could push it for you. -- daniel On 6/25/15 5:05 AM, Fr

Re: Review request for JDK-8080266: Failed to create CharInfo due to ResourceBundle update for modules

2015-06-24 Thread Daniel Fuchs
Yuan; 'core-libs-dev'; 'Lance Andersen'; 'jibing chen'; 'Gustavo Galimberti'; sandeep.konch...@oracle.com; 'Alexandre (Shura) Iline'; 'Alan Bateman' Subject: Re: Review request for JDK-8080266: Failed to create CharInfo due to ResourceBundle

RE: Review request for JDK-8080266: Failed to create CharInfo due to ResourceBundle update for modules

2015-06-24 Thread Frank Yuan
hen'; 'Gustavo Galimberti'; sandeep.konch...@oracle.com; 'Alexandre (Shura) Iline'; 'Alan Bateman' Subject: Re: Review request for JDK-8080266: Failed to create CharInfo due to ResourceBundle update for modules +1. -Joe On 6/24/2015 1:58 AM, Daniel Fuchs wrote: > Hi Fr

Re: Review request for JDK-8080266: Failed to create CharInfo due to ResourceBundle update for modules

2015-06-24 Thread huizhe wang
+1. -Joe On 6/24/2015 1:58 AM, Daniel Fuchs wrote: Hi Frank, The proposed changes look good to me. best regards, -- daniel On 24/06/15 09:58, Frank Yuan wrote: Hi, Would you like to have a review for bug https://bugs.openjdk.java.net/browse/JDK-8080266? This bug is caused by jigsaw chang

RE: Review request for JDK-8080266: Failed to create CharInfo due to ResourceBundle update for modules

2015-06-24 Thread Frank Yuan
27;; 'Gustavo Galimberti'; sandeep.konch...@oracle.com; 'Alexandre (Shura) Iline'; 'Alan Bateman' Subject: Re: Review request for JDK-8080266: Failed to create CharInfo due to ResourceBundle update for modules Hi Frank, The proposed changes look good to me. best regards, --

Re: Review request for JDK-8080266: Failed to create CharInfo due to ResourceBundle update for modules

2015-06-24 Thread Daniel Fuchs
Hi Frank, The proposed changes look good to me. best regards, -- daniel On 24/06/15 09:58, Frank Yuan wrote: Hi, Would you like to have a review for bug https://bugs.openjdk.java.net/browse/JDK-8080266? This bug is caused by jigsaw change, the context class loader can't load internal resour

Review request for JDK-8080266: Failed to create CharInfo due to ResourceBundle update for modules

2015-06-24 Thread Frank Yuan
Hi, Would you like to have a review for bug https://bugs.openjdk.java.net/browse/JDK-8080266? This bug is caused by jigsaw change, the context class loader can't load internal resource which is in a named module any more. To fix it, LSSerializerImpl shall invoke ResourceBundle.getBundle