Re: jmx-dev RFR 6425769: jmx remote bind address

2015-11-18 Thread Severin Gehwolf
Hi, Re-posting this for review since I've done another version which duplicates some of the code in SslRMIServerSocketFactory.java but does not change API other than adding the new property. I personally don't like it, but maybe this version is preferred? Bug: https://bugs.openjdk.java.net/browse

Re: jmx-dev RFR 6425769: jmx remote bind address

2015-11-09 Thread Severin Gehwolf
On Wed, 2015-11-04 at 11:54 +0100, Severin Gehwolf wrote: > Hi, > > Updated webrev with jtreg test in Java: > http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-6425769/02/ > bug: https://bugs.openjdk.java.net/browse/JDK-6425769 > > I believe this updated webrev addresses all concerns and incorpora

Re: jmx-dev RFR 6425769: jmx remote bind address

2015-11-04 Thread Severin Gehwolf
Hi, Updated webrev with jtreg test in Java: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-6425769/02/ bug: https://bugs.openjdk.java.net/browse/JDK-6425769 I believe this updated webrev addresses all concerns and incorporates suggestions brought up by Jaroslav and Daniel. I'm still looking fo

Re: jmx-dev RFR 6425769: jmx remote bind address

2015-11-03 Thread Jaroslav Bachorik
On 2.11.2015 19:06, Severin Gehwolf wrote: Hi, Thanks Jaroslav and Daniel for the reviews! Comments inline. On Mon, 2015-11-02 at 16:54 +0100, Jaroslav Bachorik wrote: > Hi, > > On 2.11.2015 16:19, Daniel Fuchs wrote: >> Hi Severin, >> >> Adding serviceability-...@openjdk.java.net into the loop

Re: jmx-dev RFR 6425769: jmx remote bind address

2015-11-02 Thread Severin Gehwolf
Hi, Thanks Jaroslav and Daniel for the reviews! Comments inline. On Mon, 2015-11-02 at 16:54 +0100, Jaroslav Bachorik wrote: > Hi, > > On 2.11.2015 16:19, Daniel Fuchs wrote: > > Hi Severin, > > > > Adding serviceability-...@openjdk.java.net into the loop - that's > > a better alias than hotspo

Re: jmx-dev RFR 6425769: jmx remote bind address

2015-11-02 Thread Jaroslav Bachorik
Hi, On 2.11.2015 16:19, Daniel Fuchs wrote: Hi Severin, Adding serviceability-...@openjdk.java.net into the loop - that's a better alias than hotspot-dev for this kind of changes - maybe someone from serviceability-dev will offer to sponsor :-) I will let serviceability team members comment on