Re: RFR: 8245527: LDAP Cnannel Binding support for Java GSS/Kerberos

Hello Sean, The link to CSR for this feature : https://bugs.openjdk.java.net/browse/JDK-8247311 Regards Alexey > On 9 Jun 2020, at 19:50, Sean Mullan wrote: > > On 6/9/20 12:40 PM, Xuelei Fan wrote: >> About the prefix, it may follow RFC 5056 (See page 7, section 2.1). >>o Specifications

Final call Re: RFR: JDK-8230744 Several classes throw OutOfMemoryError without message

Will push if no comments by EOB. > On Jun 8, 2020, at 2:22 PM, Jim Laskey wrote: > > Revised to use a consistent error message. Modified AbstractStringBuilder and > PriorityBlockingQueue to use ArraysSupport.newLength(). Didn't modify > ByteArrayChannel and UnsyncByteArrayOutputStream since th

Re: Thread leak by LdapLoginModule

On 09/06/2020 23:21, Sean Mullan wrote: The issue is not observed with java-14, thus I assume that the fix is related to commit http://hg.openjdk.java.net/jdk/jdk/rev/6717d7e59db4 As java-11 is LTS, what is the procedure to get it fix back-ported? Hi, AFAICS the fix has already been backpor

RFR 8245302: Upgrade LogRecord to support long thread ids and remove its usage of ThreadLocal

  Hello, Request to have my fix reviewed for the issue: JDK-8245302: Upgrade LogRecord to support long thread ids and remove its usage of ThreadLocal. java.util.logging.LogRecord is updated to support long thread ids without ThreadLocal. Before the update, thread id’s did

Re: Final call Re: RFR: JDK-8230744 Several classes throw OutOfMemoryError without message

I took a look at PriorityBlockingQueue. Part of converting to ArraysSupport involves deleting the local orphan MAX_ARRAY_SIZE; that needs to be done. --- It looks like newCap > oldCap is always true, so we should delete the test? if (newCap > oldCap && queue == array) --- In Patt

RFR: JDK-8247353: jtreg tests minor issues clean up

Please review fix [2] for jpackage bug [1]. Minor jpackage jtreg tests clean up of issues uncovered during the recent local test runs. - Alexey [1] https://bugs.openjdk.java.net/browse/JDK-8247353 [2] http://cr.openjdk.java.net/~asemenyuk/8247353/webrev.00

Re: Final call Re: RFR: JDK-8230744 Several classes throw OutOfMemoryError without message

> On Jun 10, 2020, at 1:15 PM, Martin Buchholz wrote: > > I took a look at PriorityBlockingQueue. > > Part of converting to ArraysSupport involves deleting the local orphan > MAX_ARRAY_SIZE; that needs to be done. Removed. > > --- > It looks like > newCap > oldCap > is always true, so we s

RFR: JDK-8246042: Non-ASCII characters are not handled correctly in the native launcher

Please review fix [2] for jpackage bug [1]. On Windows encode arguments for JNI_Launch() call with an encoding of the current process ANSI code page instead of utf8. - Alexey [1] https://bugs.openjdk.java.net/browse/JDK-8246042 [2] http://cr.openjdk.java.net/~asemenyuk/8246042/webrev.00

RFR: JDK-8233244: Add tests for icons configuration in rpm/deb packages

Please review fix [2] for jpackage bug [1]. The fix adds verification there are `xdg-icon-resource` commands in Linux packages for file associations with icons. - Alexey [1] https://bugs.openjdk.java.net/browse/JDK-8233244 [2] http://cr.openjdk.java.net/~asemenyuk/8233244/webrev.00

Re: RFR: JDK-8247353: jtreg tests minor issues clean up

looks good. /Andy On 6/10/2020 12:21 PM, Alexey Semenyuk wrote: Please review fix [2] for jpackage bug [1]. Minor jpackage jtreg tests clean up of issues uncovered during the recent local test runs. - Alexey [1] https://bugs.openjdk.java.net/browse/JDK-8247353 [2] http://cr.openjdk.java.n

Re: Final call Re: RFR: JDK-8230744 Several classes throw OutOfMemoryError without message

On Wed, Jun 10, 2020 at 9:35 AM Jim Laskey wrote: > > --- > > It looks like > > newCap > oldCap > > is always true, so we should delete the test? > > if (newCap > oldCap && queue == array) > > --- > > If oldCap == MAX_ARRAY_SIZE wouldn't newCap == oldCap newLength's contract is t

Re: Final call Re: RFR: JDK-8230744 Several classes throw OutOfMemoryError without message

Thank you. > On Jun 10, 2020, at 2:10 PM, Martin Buchholz wrote: > > On Wed, Jun 10, 2020 at 9:35 AM Jim Laskey wrote: > >>> --- >>> It looks like >>> newCap > oldCap >>> is always true, so we should delete the test? >>>if (newCap > oldCap && queue == array) >>> --- >> >> If o

Re: RFR: JDK-8233244: Add tests for icons configuration in rpm/deb packages

looks good. /Andy On 6/10/2020 1:04 PM, Alexey Semenyuk wrote: Please review fix [2] for jpackage bug [1]. The fix adds verification there are `xdg-icon-resource` commands in Linux packages for file associations with icons. - Alexey [1] https://bugs.openjdk.java.net/browse/JDK-8233244 [2]

Re: RFR: JDK-8246042: Non-ASCII characters are not handled correctly in the native launcher

looks good. /Andy On 6/10/2020 12:41 PM, Alexey Semenyuk wrote: Please review fix [2] for jpackage bug [1]. On Windows encode arguments for JNI_Launch() call with an encoding of the current process ANSI code page instead of utf8. - Alexey [1] https://bugs.openjdk.java.net/browse/JDK-824604

Re: RFR 8247274: (test) HexPrinter cleanup

Thanks Lance On 6/10/20 12:53 PM, Lance Andersen wrote: Hi Roger, I think your changes look fine. Best Lance On Jun 9, 2020, at 6:47 PM, Roger Riggs > wrote: Please review cleanup to the test support for jdk.test.lib.hexprinter.HexPrinter. Correct issues w

Re: Final call Re: RFR: JDK-8230744 Several classes throw OutOfMemoryError without message

Hi Jim, In Unsafe.java: 632: the "Unable to allocate 98494837395: doesn't read very well. Please add " bytes" to the end. I would probably drop "array" from all the messages but at least in the String* cases. As Martin notes, the array is an implementation detail. (And i still prefer "implem

RFR: 8245788: EmptyFolderPackageTest fails on Windows 10

Please review the jpackage fix for bug [1] at [2]. To unpack msi we using /a argument which is not exactly an installation. In this mode (Administrative installation) msi will extract files and also creates .msi installer to install these files. For some reason empty folders are not created du

Re: RFR: JDK-8247353: jtreg tests minor issues clean up

Hi Alexey, Looks good. Thanks, Alexander On 6/10/20 9:21 AM, Alexey Semenyuk wrote: Please review fix [2] for jpackage bug [1]. Minor jpackage jtreg tests clean up of issues uncovered during the recent local test runs. - Alexey [1] https://bugs.openjdk.java.net/browse/JDK-8247353 [2] htt

Re: RFR: JDK-8246042: Non-ASCII characters are not handled correctly in the native launcher

Hi Alexey, Looks good. Thanks, Alexander On 6/10/20 9:41 AM, Alexey Semenyuk wrote: Please review fix [2] for jpackage bug [1]. On Windows encode arguments for JNI_Launch() call with an encoding of the current process ANSI code page instead of utf8. - Alexey [1] https://bugs.openjdk.java.

Re: RFR: 8245788: EmptyFolderPackageTest fails on Windows 10

Looks good. - Alexey On 6/10/2020 2:27 PM, Alexander Matveev wrote: Please review the jpackage fix for bug [1] at [2]. To unpack msi we using /a argument which is not exactly an installation. In this mode (Administrative installation) msi will extract files and also creates .msi installer to

Re: RFR(S) : 8183040 : update jdk/test/lib/Platform.java to use NIO file API

Hi Igor, On 06/09/2020 20:11, Igor Ignatyev wrote: Hi Alex, as far as I can see, the caller just rethrows IOException as RuntimeException, so I don't think throwing IndexOutOfBoundsException would be much different, albeit it will be a bit more cryptic. yet given the content of /proc/sys/ker

Re: RFR(S) : 8183040 : update jdk/test/lib/Platform.java to use NIO file API

Hi Alex, sure, here is the incremental diff, so now Error is thrown if bb arrays are empty -- http://cr.openjdk.java.net/~iignatyev//8183040/webrev.0-1 Thanks, -- Igor > On Jun 10, 2020, at 12:20 PM, Alex Menkov wrote: > > Hi Igor, > > On 06/09/2020 20:11, Igor Ignatyev wrote: >> Hi Alex,

RFR: 8246721: java/util/Locale/LocaleProvidersRun.java failed on Windows platforms.

Hello, Please review the fix to the following issue: https://bugs.openjdk.java.net/browse/JDK-8246721 The proposed changeset is located at: http://cr.openjdk.java.net/~naoto/8246721/webrev.00/ The test has been modified to deal with double quotes in string arguments consistently across platf

Re: RFR(S) : 8183040 : update jdk/test/lib/Platform.java to use NIO file API

Hi Igor, LGTM. --alex On 06/10/2020 12:29, Igor Ignatyev wrote: Hi Alex, sure, here is the incremental diff, so now Error is thrown if bb arrays are empty -- http://cr.openjdk.java.net/~iignatyev//8183040/webrev.0-1 Thanks, -- Igor On Jun 10, 2020, at 12:20 PM, Alex Menkov wrote: Hi Igo

Re: RFR(S) : 8183040 : update jdk/test/lib/Platform.java to use NIO file API

thanks Alex, pushed. -- Igor > On Jun 10, 2020, at 1:05 PM, Alex Menkov wrote: > > Hi Igor, > > LGTM. > > --alex > > On 06/10/2020 12:29, Igor Ignatyev wrote: >> Hi Alex, >> sure, here is the incremental diff, so now Error is thrown if bb arrays are >> empty -- http://cr.openjdk.java.net/~i

Re: RFR: 8246721: java/util/Locale/LocaleProvidersRun.java failed on Windows platforms.

Hi Naoto, The fix looks fine. Thanks, Roger On 6/10/20 3:49 PM, naoto.s...@oracle.com wrote: Hello, Please review the fix to the following issue: https://bugs.openjdk.java.net/browse/JDK-8246721 The proposed changeset is located at: http://cr.openjdk.java.net/~naoto/8246721/webrev.00/ Th

RFR: JDK-8246792: Mac signing tests failed (unsealed contents present in the bundle root)

Please review fix [2] for jpackage bug [1]. Move `.jpackage.xml` file in `app` directory of app image and keep it in all OSX packages (dmg and pkg). Resotore copying of `libjli.dylib` into `$RUNTIME/Contents/MacOS` directory in MacAppImageBuilder.java. Update jtreg test helpers accordingly. -

Re: RFR: JDK-8246792: Mac signing tests failed (unsealed contents present in the bundle root)

looks good - This works for me finally. /Andy On 6/10/2020 5:29 PM, Alexey Semenyuk wrote: Please review fix [2] for jpackage bug [1]. Move `.jpackage.xml` file in `app` directory of app image and keep it in all OSX packages (dmg and pkg). Resotore copying of `libjli.dylib` into `$RUNTIME/Co

RFR 8207936: TestZipFile.java can fail with an OOM error

Hi, Please review the fix for JDK-8207936, which addresses the OOM error when running the manual test TestZipFile.java. The fix also removes the call to "getMetaInfEntryNames” as this method was removed as part of the performance work done in JDK-8244624. The webrev can be found at: http://

Re: RFR: 8245788: EmptyFolderPackageTest fails on Windows 10

this looks good. /Andy On 6/10/2020 2:27 PM, Alexander Matveev wrote: Please review the jpackage fix for bug [1] at [2]. To unpack msi we using /a argument which is not exactly an installation. In this mode (Administrative installation) msi will extract files and also creates .msi installer

Re: RFR: JDK-8246792: Mac signing tests failed (unsealed contents present in the bundle root)

Hi Alexey, Looks good. Thanks, Alexander On 6/10/20 2:40 PM, Andy Herrick wrote: looks good - This works for me finally. /Andy On 6/10/2020 5:29 PM, Alexey Semenyuk wrote: Please review fix [2] for jpackage bug [1]. Move `.jpackage.xml` file in `app` directory of app image and keep it in

Re: Final call Re: RFR: JDK-8230744 Several classes throw OutOfMemoryError without message

Regarding the wording, I don't think either "implementation limit" or "VM limit" is correct, at least not in all the cases. If we were using ArraysSupport.newLength, the error messages are as follows: 1) Actual shortage of heap space. Hotspot generates this: OutOfMemoryError: Java hea

RFR: JDK-8246098: API for Class::permittedSubclasses should clarify if returned elements are ordered or not

Please review this small change to the API for java.lang.Class::permittedSubclasses which clarifies that no particular order of the returned elements should be assumed by clients. The related bug is at [1], the webrev at [2] and the associated CSR at [3], Thanks, Vicente [1] https://bugs.open

Re: Sometimes constraints are questionable

On 6/5/20 1:48 PM, James Laskey wrote: I’m fixing the two in java.base. The other two are in different modules and would require changes to export. So you can file on those. I've filed https://bugs.openjdk.java.net/browse/JDK-8247373 to enhance the exception message, docs, and to add a t

Re: RFR 8207936: TestZipFile.java can fail with an OOM error

Hi Lance, looks good to me! /Claes On 2020-06-10 23:47, Lance Andersen wrote: Hi, Please review the fix for JDK-8207936, which addresses the OOM error when running the manual test TestZipFile.java. The fix also removes the call to "getMetaInfEntryNames” as this method was removed as part

Re: RFR 8207936: TestZipFile.java can fail with an OOM error

Looks good to me, Lance. -Joe On 6/10/2020 2:47 PM, Lance Andersen wrote: Hi, Please review the fix for JDK-8207936, which addresses the OOM error when running the manual test TestZipFile.java. The fix also removes the call to "getMetaInfEntryNames” as this method was removed as part of th

RFR of JDK-8245620: Improve Annotation.annotationType() documentation

Hello, Please review a number of small updates to the javadoc of java.lang.annotation.Annotation to address     JDK-8245620: Improve Annotation.annotationType() documentation The use of  Annotation.annotationType() vs calling getClass on an annotation object may not be clear so the method's

Re: RFR of JDK-8245620: Improve Annotation.annotationType() documentation

On 11/06/2020 06:26, Joe Darcy wrote: Hello, Please review a number of small updates to the javadoc of java.lang.annotation.Annotation to address     JDK-8245620: Improve Annotation.annotationType() documentation The use of  Annotation.annotationType() vs calling getClass on an annotation o