Re: RFR: JDK-8230974: creating rpm, get error for relative path to the license.txt

Looks good. On 9/29/2019 4:45 PM, Alexey Semenyuk wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). Baseline for review is [3]. [1] https://bugs.openjdk.java.net/browse/JDK-8230974 [2] http:/

Re: RFR: JDK-8230920 : jpackage problems when -input dir contains any files with "cfg" extension.

9/30/2019 4:07 PM, Alexander Matveev wrote: Looks good. Do we really planning to call AppImageFile.get() with different values? I think removing or fixing is still better to avoid any potential bugs. Thanks, Alexander On 9/29/2019 1:06 PM, Alexey Semenyuk wrote: One thing that I just not

Re: RFR: JDK-8231605: Improve test helpers

Looks good. On 9/29/2019 1:50 PM, Alexey Semenyuk wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). This fix: - Improve jpackage test helpers. - Implement jdk.jpackage.internal.ApplicationLayo

Re: RFR: JDK-8231721: jpackage --install-dir should reject system dirs on Linux

Looks good. On 10/1/19 3:00 PM, Alexey Semenyuk wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). [1] https://bugs.openjdk.java.net/browse/JDK-8231721 [2] http://cr.openjdk.java.net/~asemenyuk

RFR: JDK-8215895: Verify and create tests for Mac installer specific signing options

Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). - Added two signing tests for macOS. One test checks signing app image and second checks pkg and dmg. - These test will not be run if machine is not co

RFR: JDK-8231706: Investigate if we can change "Java" dir to "app" dir in jpackage app image

Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). - Changed "Java" dir to "app" dir in jpackage app image on macOS. [1] https://bugs.openjdk.java.net/browse/JDK-8231706 [2] http://cr.openjdk.java.net/

Re: RFR: JDK-8215895: Verify and create tests for Mac installer specific signing options

r On 10/2/2019 2:34 PM, Alexander Matveev wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). - Added two signing tests for macOS. One test checks signing app image and second checks pkg and dm

Re: RFR: JDK-8231850: BasicTest test fails in jcov build

Looks good. On 10/3/2019 5:17 PM, Alexey Semenyuk wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). [1] https://bugs.openjdk.java.net/browse/JDK-8231850 [2] http://cr.openjdk.java.net/~asemeny

Re: RFR: JDK-8231882: --add-modules ALL-MODULE-PATH is not handled properly

Looks good. On 10/4/2019 12:14 PM, Alexey Semenyuk wrote: Yes, it is. Sorry, my bad, I didn't notice it. Looks good then! - Alexey On 10/4/2019 3:11 PM, Andy Herrick wrote: isn't what this change in BasicTest in this webrev does ? It passes on all platforms with Mach 5 builds. /Andy On 10/

RFR: JDK-8231856: pkg installer dialog contains background image which does not look correct

Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). - Fixed by using correct icon for pkg. - Added icon for dark theme and it will be called appName-background-darkAqua.png, for separate customization be

Re: RFR: JDK-8231910: Expose the APPDIR variable to applications that use jpackage

Hi Andy, Looks good. Thanks, Alexander On 10/8/2019 3:29 PM, Alexey Semenyuk wrote: Looks good. - Alexey On 10/8/2019 6:09 PM, Andy Herrick wrote: Minor revision after some discussion: [3]:  http://cr.openjdk.java.net/~herrick/8231910/webrev.02 /Andy On 10/8/2019 3:06 PM, Andy Herrick wr

RFR: JDK-8231858: [macos] App does not run if installed with pkg

Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). - Fixed by adding read permissions to all jars during installation. [1] https://bugs.openjdk.java.net/browse/JDK-8231858 [2] http://cr.openjdk.java.ne

RFR: JDK-8232042: [macos] Installation fails if application name contains spaces

Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). - Patch is based on JDK-8231856 fix. - Fixed by using URI to escape URLs. URLEncoder.encode() encodes form data and it will use "+" for space. pkg buil

RFR: JDK-8231857: App and Application folder icons are not aligned correctly

Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). - Not sure what problem was, but after moving hidden items at same Y value as non-hidden icons issue was resolved. Also, had to adjust Y value to alig

Re: RFR: JDK-8231862: Decouple DesktopIntegration and LinuxPackageBundler classes

Looks good. On 10/15/2019 12:27 PM, Andy Herrick wrote: A long overdue change.  Looks good as far as I can see. Thanks /Andy On 10/15/2019 2:48 PM, Alexey Semenyuk wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox

Re: RFR: JDK-8232279: Improve test helpers #2

Looks good. On 10/15/2019 12:13 PM, Alexey Semenyuk wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). Additionally migrated some tests that used the old test helpers to use the new test helper

Re: JDK-8232280: close() is not called on return value of Files.walk()

Hi Andy, Looks good. Thanks, Alexander On 10/16/2019 1:03 PM, Andy Herrick wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). Fix is to wrap all Files.walk() calls in try-with-resource blocks.

Re: RFR: JDK-8232387: tools/jpackage/share/jdk/jpackage/tests/BasicTest.java fails

Looks good. On 10/16/2019 4:56 PM, Alexey Semenyuk wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). Additionally regression in JPackageCommand class fixed. - Alexey [1] https://bugs.openjdk.

Re: RFR: JDK-8231972: Build a stable list of jpackager tests for SQE

Looks good. On 10/17/19 7:03 PM, Alexey Semenyuk wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). - Alexey [1] https://bugs.openjdk.java.net/browse/JDK-8231972 [2] http://cr.openjdk.java.net

Re: RFR: JDK-8232281, , jpackage is not always reporting an error when no main class specified

Looks good. On 10/18/2019 7:53 AM, Andy Herrick wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). This fixes the case where using runtime-image prevented checking for no main class being speci

Re: RFR: JDK-8223325: Improve wix sources generated by jpackage

Hi Alexey, http://cr.openjdk.java.net/~asemenyuk/8223325/webrev.00/src/jdk.jpackage/share/classes/jdk/jpackage/internal/AppImageFile.java.frames.html Line 180: man -> main http://cr.openjdk.java.net/~asemenyuk/8223325/webrev.00/src/jdk.jpackage/share/classes/jdk/jpackage/internal/IOUtils.java.fr

Re: RFR: JDK-8232723: make the resource file main.wxs over-ridable

Looks good. On 10/22/2019 12:34 PM, Andy Herrick wrote: There really aren't any tests for overridable resources in packages, the mechanism is only tested by testing the one resource that is overriddable in app-image build, the app icon. This the second resources overridable in windows package

RFR: JDK-8232186: Add verification for pkg and dmg tests

Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). - Removed --mac-app-store-category. - Added Hello.java test app to support file association on OS X. - Modified Hello.java to write output file to user

Re: RFR: JDK-8232073: [deb] RuntimePackageTest should not have shared folder after install

Hi Alexey, Looks good. Thanks, Alexander On 10/22/2019 2:14 PM, Alexey Semenyuk wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). Additionally: - fixes for [3], [4], [5] and [6]  bugs. - remo

Re: RFR: JDK-8230612: Debian packaging ignores version and release in custom control file

Looks good. On 10/23/2019 6:59 PM, Alexey Semenyuk wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). - Alexey [1] https://bugs.openjdk.java.net/browse/JDK-8230612 [2] http://cr.openjdk.java.n

Re: RFR: JDK-8223323: Adjust jpackage makefiles

Looks good. On 10/23/2019 7:00 PM, Alexey Semenyuk wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). - Alexey [1] https://bugs.openjdk.java.net/browse/JDK-8223323 [2] http://cr.openjdk.java.n

Re: RFR: JDK-8232186: Add verification for pkg and dmg tests

:07 AM, Andy Herrick wrote: looks ok to me /ANdy On 10/22/2019 5:29 PM, Alexander Matveev wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). - Removed --mac-app-store-category. - Added

Re: RFR: JDK-8233218: rpm uninstall errors (xdg-icon-resource: the icon size must be specified with --size)

Looks good. On 10/30/2019 12:48 PM, Alexey Semenyuk wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). - Alexey [1] https://bugs.openjdk.java.net/browse/JDK-8233218 [2] http://cr.openjdk.java.

Re: RFR: JDK-8233138: Error 2343 when using --win-dir-chooser

Hi Alexey, Looks good. Did you test it by trying to install into existing folder? I remember having issues reading some variables in libwixhelper.cpp. Thanks, Alexander On 10/30/2019 1:42 PM, Alexey Semenyuk wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK

Re: RFR: JDK-8233143: RPM errors: rpmbuild: no spec files given for build

Looks good. On 10/30/2019 3:03 PM, Alexey Semenyuk wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). - Alexey [1] https://bugs.openjdk.java.net/browse/JDK-8233143 [2] http://cr.openjdk.java.n

Re: RFR: JDK-8232186: Add verification for pkg and dmg tests

rs in a single test run. So I'd suggest to remove PackageTest.isCurrentType() at all from PackageTest class. It is not needed. - Alexey On 10/29/2019 1:19 AM, Alexander Matveev wrote: Changes since last review: http://cr.openjdk.java.net/~almatvee/8232186/webrev.03/ - Hello.java com

Re: RFR: JDK-8233333: Incorrect comparison of number version strings in ToolValidator

Looks good. On 10/31/2019 12:11 PM, Alexey Semenyuk wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). Additionally: - fixed issue with truncated log output of jtreg tests (added maxOutputSize=

Re: RFR: JDK-8233265: jpackage --add-modules cannot find additional modules with non-modular app

Looks good. On 10/31/2019 2:02 PM, Andy Herrick wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). This is a fixes a regression from the fix to JDK-8231882

Re: RFR: JDK-8232919: If user installs msi and exe, two installations are found in Add/Remove

Hi Alexey, http://cr.openjdk.java.net/~asemenyuk/8232919/webrev.00/src/jdk.jpackage/windows/classes/jdk/jpackage/internal/resources/main.wxs.frames.html This file refers to JpAllowDowngrades and JpAllowUpgrades. Code sets JpAllowUpgrades to yes always and never sets JpAllowDowngrades. Maybe I a

Re: RFR: JDK-8232919: If user installs msi and exe, two installations are found in Add/Remove

Hi Alexey, On 11/1/2019 9:00 PM, Alexey Semenyuk wrote: On 11/1/2019 9:45 PM, Alexander Matveev wrote: Hi Alexey, http://cr.openjdk.java.net/~asemenyuk/8232919/webrev.00/src/jdk.jpackage/windows/classes/jdk/jpackage/internal/resources/main.wxs.frames.html This file refers to

Re: RFR: JDK-8233592: change --package-type option name to --type and allow -t short form

Looks good. On 11/5/2019 12:39 PM, Andy Herrick wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). This changes the --package-type option to just --type , and adds the -t short form. [1] http

Re: RFR: JDK-8233594: create a new option --bind-servces to pass on to jlink

Hi Andy, http://cr.openjdk.java.net/~herrick/8233594/webrev.01/src/jdk.jpackage/share/classes/jdk/jpackage/internal/resources/HelpResources.properties.frames.html  106 \  Pass on --bind-seervices option to jlink (which will link in \n\ Spelling: --bind-seervices -> --bind-services Oth

Re: RFR: JDK-8233636: Make jpackage an incubator and remove tool provider implementation

Hi Andy, Agree with Alexey comments. Otherwise looks good. Thanks, Alexander On 11/7/2019 2:44 PM, Andy Herrick wrote: On 11/7/2019 5:38 PM, Alexey Semenyuk wrote: I guess the link for the review is https://cr.openjdk.java.net/~herrick/8233636/webrev.02 sry: yes webrev is http://cr.openjd

Re: RFR: JDK-8233636: Make jpackage an incubator and remove tool provider implementation

Looks good. On 11/8/2019 11:38 AM, Andy Herrick wrote: Please review the revised jpackage fix for bug [1] at [3]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). This webrev (webrev.03) addresses feedback from previous version (webrev.02). [1] ht

Re: RFR: JDK-8233591: Reorder jpackage help text to focus on package

Looks good. On 11/8/2019 1:31 PM, Andy Herrick wrote: revised [3] as per below suggestions. [3] http://cr.openjdk.java.net/~herrick/8233591/webrev.03 /Andy On 11/8/2019 4:07 PM, Alexey Semenyuk wrote: This is minor and not directly related to this change, but looks like we have inconsistenc

Re: RFR: JDK-8234402: revert change that stopped providing JPackageToolProvider

Looks good. On 11/19/19 4:00 PM, Andy Herrick wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). This change restores JPackageToolProvider and gets rid of the temporary factory class. [1] htt

Re: RFR: JDK-8234402: revert change that stopped providing JPackageToolProvider

Looks good. On 11/20/2019 6:36 AM, Andy Herrick wrote: webrev revised in place at [2]. /Andy On 11/19/2019 9:00 PM, Alexey Semenyuk wrote: Andy, I guess http://cr.openjdk.java.net/~herrick/8234402/webrev.02/test/jdk/tools/jpackage/helpers/jdk/jpackage/test/JavaTool.java.sdiff.html can be r

Re: RFR: JDK-8233270: Add support to jtreg helpers to unpack packages

Hi Alexey, 1) Remove this file: test/jdk/tools/jpackage/helpers/jdk/jpackage/test/JavaTool.java.rej 2) Agree with Phil, they probably should be pushed as two separate bugs. 3) Do you know how to run installer tests with new changes? It is not clear from code. Changes itself looks fine. Thanks

Re: RFR: JDK-8235453: tools/jpackage/junit/junit.java failed due to "module not found: jdk.incubator.jpackage"

Looks good, but is there better way to exclude tests on Solaris? I do not like idea adding @requires for all tests. Thanks, Alexander On 12/6/2019 10:35 AM, Alexey Semenyuk wrote: Looks good. - Alexey On 12/6/2019 1:33 PM, Andy Herrick wrote: Please review this jpackager test fix for bug [1

Re: RFR: JDK-8234867: Issue warning for mutually exclusive options on jpackage command line

Looks good. Thanks, Alexander On 12/9/2019 1:42 PM, Andy Herrick wrote: Please review simple fix [2] for jpackage bug [1] fixing error message for mutually exclusive options. /Andy [1] https://bugs.openjdk.java.net/browse/JDK-8234867 [2] http://cr.openjdk.java.net/~herrick/8234867/webrev.01

Re: RFR: JDK-8235601: redundant code in IOUtils.java

Hi Andy, Looks good. Thanks, Alexander On 12/9/2019 5:26 PM, Andy Herrick wrote: On 12/9/2019 6:53 PM, Phil Race wrote: > [2] http://cr.openjdk.java.net/~herrick/8235601/webrev.01/ This does not bring up the expected webrev My apologies - I uploaded the wrong webrev - It should be fixed n

RFR: JDK-8235252: Repair run_tests.sh by locating jtreg locally

Please review simple script fix [2] for jpackage bug [1].  - Modified script to download jtreg bundle from URL provided by environment variable JTREG_BUNDLE_URL. Thanks, Alexander [1] https://bugs.openjdk.java.net/browse/JDK-8235252 [2] http://cr.openjdk.java.net/~almatvee/8235252/webrev.00/

Re: RFR: JDK-8235667: IOUtils.copyFile() problems.

Looks good. Thanks, Alexander On 12/10/2019 12:00 PM, Andy Herrick wrote: On 12/10/2019 12:56 PM, Andy Herrick wrote: Please review the jpackage fix at [1] to issue [2]. This is a change to jpackage/internal/IOUtils.copyFile() to essentially replace it's content with a call to Files.copy()

Re: RFR: JDK-8235252: Repair run_tests.sh by locating jtreg locally

enough here? -- Jon On 12/10/19 1:35 PM, Alexander Matveev wrote: Please review simple script fix [2] for jpackage bug [1].  - Modified script to download jtreg bundle from URL provided by environment variable JTREG_BUNDLE_URL. Thanks, Alexander [1] https://bugs.openjdk.java.net/browse/JDK

RFR: JDK-8234284: [dmg] Change DMG background image to TIFF

Please review fix [2] for jpackage bug [1].  - Changed background image for DMG to TIFF format, which can be used to embed 2x image to support HiDPI displays. Thanks, Alexander [1] https://bugs.openjdk.java.net/browse/JDK-8234284 [2] http://cr.openjdk.java.net/~almatvee/8234284/webrev.00/

Re: RFR: JDK-8235252: Repair run_tests.sh by locating jtreg locally

webrev.01 is incorrect, since it uses JTREG_ prefix for variables name. Correct webrev is http://cr.openjdk.java.net/~almatvee/8235252/webrev.02/ It is identical to webrev.01, except prefix of variable names changed to JT_. Thanks, Alexander On 12/10/19 3:54 PM, Alexander Matveev wrote

RFR: JDK-8235738: tools/jpackage/macosx/NameWithSpaceTest.java failed due to exit code 134

Please review fix [2] for jpackage bug [1]. Not sure why it happens, but reading output from "hdiutil attach" was not exiting immediately after process terminated with delays upto 20 seconds always and in some case upto 10 minutes and thus test was timeout. Only possible workaround found is to

Re: RFR: JDK-8235738: tools/jpackage/macosx/NameWithSpaceTest.java failed due to exit code 134

Process or ProcessBuilder , and although it would be better to identify and resolve the underlying problem, the fix is needed now, so this change seems appropriate. /Andy On 12/13/2019 1:01 AM, Alexander Matveev wrote: Please review fix [2] for jpackage bug [1]. Not sure why it happens, but reading o

Re: RFR: 8235915: jpackage associations fail when there are spaces in file name or path

Looks good. On 12/16/2019 7:32 AM, Andy Herrick wrote: Please review this jpackage fix to [1] at [2] the change just adds quotes around the Argument element's value in WIX xml's association definition. [1] https://bugs.openjdk.java.net/browse/JDK-8235915 [2] http://cr.openjdk.java.net/~herr

Re: RFR: JDK-8236132: Add missing properties to msi installers

Hi Alexey, Can you add description for JpIcon to overrides.wxi, otherwise looks fine. Thanks, Alexander On 12/20/2019 12:16 PM, Alexey Semenyuk wrote: Please review fix [2] for jpackage bug [1]. Add properties to msi installers to properly display installation location and icon of the applic

Re: RFR: JDK-8232077: Investigate if default behavior should allow downgrade scenario

Looks good. Thanks, Alexander On 12/20/2019 8:53 AM, Andy Herrick wrote: fix looks fine. /Andy On 12/19/2019 8:02 PM, Alexey Semenyuk wrote: Please review fix [2] for jpackage bug [1]. The fix changes the default setting for Windows installers to allow downgrades. - Alexey [1] https://b

Re: RFR: JDK-8233578: Document configurable parameters of msi packages

Looks good. Thanks, Alexander On 12/20/2019 8:56 AM, Andy Herrick wrote: looks good. /Andy On 12/19/2019 8:52 PM, Alexey Semenyuk wrote: Please review fix [2] for jpackage bug [1]. Comments added to the default WiX source file explaining how the default file is expected to be overridden.

Re: RFR: JDK-8236132: Add missing properties to msi installers

t its description in the default overrides.wxi file. JpIcon is just one of WiX variables to pass configuration data from jpackage Java into WiX toolset. - Alexey On 1/6/2020 7:36 PM, Alexander Matveev wrote: Hi Alexey, Can you add description for JpIcon to overrides.wxi, otherwise looks

RFR: JDK-8235955: [dmg] DMG creation fails without error message if previous DMG was not ejected

Please review the jpackage fix for bug [1] at [2]. - Modified customization script for DMG to use location where DMG is mounted to identify image that we need to customize, instead of using name which might not be unique. [1] https://bugs.openjdk.java.net/browse/JDK-8235955 [2] http://cr.ope

RFR: JDK-8237607: [macos] Signing app bundle with jpackage fails if runtime is already signed

Please review the jpackage fix for bug [1] at [2]. - Fixed by forcing signing even if runtime already signed. - Original implementation was not taken in consideration that runtime can be signed (JDK itself is signed from which jpackage is used or runtime provided via --runtime-image). - Signatu

RFR: JDK-8235954: [dmg] Default DMG background tiff of jpackage not retina ready

Please review the jpackage fix for bug [1] at [2]. - Updated background image with one which supports retina display. [1] https://bugs.openjdk.java.net/browse/JDK-8235954 [2] http://cr.openjdk.java.net/~almatvee/8235954/webrev.00/ Thanks, Alexander

RFR: 8233166: jpackage tool skips empty directories

Please review the jpackage fix for bug [1] at [2]. - Fixed code which enumerates folders and files to include empty folders. - Added EmptyFolderTest. [1] https://bugs.openjdk.java.net/browse/JDK-8233166 [2] http://cr.openjdk.java.net/~almatvee/8233166/webrev.00/ Thanks, Alexander

Re: RFR: 8237967: No proper error message when --runtime-image points to non-existent path

Hi Andy, Fix looks good, but I think we should do same for --resource-dir. I do not think that non-existing directory should be same as empty. User might misspell directory name and it will not be clear for user why we not using information from --resource-dir. Thanks, Alexander On 2/5/2020

Re: jlink and jpackage not producing correct macOS packages

Hi James, Thank you for sharing this information. We currently investigating this issue from jpackage side as part of https://bugs.openjdk.java.net/browse/JDK-8237490. Thanks, Alexander On 2/14/2020 9:06 AM, James Elliott wrote: I’d raised some issues earlier on this list about jpackage not

Re: RFR: JDK-8238692: MacOS runtime Installer issue

Hi Andy, Looks good. Thanks, Alexander On 2/21/2020 9:10 AM, Andy Herrick wrote: After internal discussion of default values for mac-package-identifier I have removed the fix for [3] from this main fix to issue [2]. please review the revised webrev at [1] /Andy On 2/18/2020 2:46 PM, Andy H

Re: RFR: JDK-8237966,: Creating runtime pkg requires --mac-package-identifier

Hi Andy, Looks good. Thanks, Alexander On 2/26/2020 2:01 PM, Alexey Semenyuk wrote: Looks good. Minor note: I'd declare isValidBundleIdentifier() as static private. - Alexey On 2/26/2020 12:48 PM, Andy Herrick wrote: Please review the fix to issue [1] at [2]. The initial concern with defa

Re: RFR: JDK-8237490: [macos] Add support notarizing jpackage app-image and dmg

Hi Andy, http://cr.openjdk.java.net/~herrick/8237490/webrev.05/src/jdk.incubator.jpackage/macosx/classes/jdk/incubator/jpackage/internal/MacAppImageBuilder.java.frames.html Line 819,857,902 - Looks like temp debug log message. Remove it or align with rest of code. http://cr.openjdk.java.net/~h

Re: RFR: JDK-8237490: [macos] Add support notarizing jpackage app-image and dmg

, Andy Herrick wrote: On 3/27/2020 5:18 PM, Alexander Matveev wrote: Hi Andy, http://cr.openjdk.java.net/~herrick/8237490/webrev.05/src/jdk.incubator.jpackage/macosx/classes/jdk/incubator/jpackage/internal/MacAppImageBuilder.java.frames.html Line 819,857,902 - Looks like temp debug log message

Re: RFR: JDK-8241713: Linux desktop shortcuts with spaces make postinst/prerm fail

Hi Alexey, Looks good. Thanks, Alexander On 4/2/20 12:51 PM, Alexey Semenyuk wrote: Please review fix [2] for jpackage bug [1]. Replace space characters in names of files registered by jpackage with X Desktop in postinstall step of rpm and deb installers. - Alexey [1] https://bugs.openjd

Re: RFR: JDK-8237490: [macos] Add support notarizing jpackage app-image and dmg

On 3/27/2020 5:18 PM, Alexander Matveev wrote: Hi Andy, http://cr.openjdk.java.net/~herrick/8237490/webrev.05/src/jdk.incubator.jpackage/macosx/classes/jdk/incubator/jpackage/internal/MacAppImageBuilder.java.frames.html Line 819,857,902 - Looks like temp debug log message. Remove it or align

Re: RFR: JDK-8237490: [macos] Add support notarizing jpackage app-image and dmg

separate issue, and leave these checks disabled as part of JDK-8237490.  I have filed JDK-8242155 to enhance these tests, including restoring these checks. /ANdy On 4/3/2020 7:29 PM, Alexander Matveev wrote: Hi Andy, http://cr.openjdk.java.net/~herrick/8237490/webrev.07/test/jdk/tools/jpackage

Re: RFR: JDK-8242155: Enhance automated macos signing tests

Hi Andy, Looks good. Thanks, Alexander On 4/8/20 2:14 PM, Andy Herrick wrote: Please review the fix to issue [1] at [2]. [1] https://bugs.openjdk.java.net/browse/JDK-8242155 [2] http://cr.openjdk.java.net/~herrick/8242155/webrev.01/ /Andy

Re: RFR: JDK-8256475: Fix Behavior when Installer name differs from applicatio… [v4]

On Thu, 19 Nov 2020 20:45:23 GMT, Andy Herrick wrote: >> …n name. > > Andy Herrick has updated the pull request incrementally with one additional > commit since the last revision: > > JDK-8256475: Fix Behavior when Installer name differs from application name. Marked as reviewed by almatvee

Re: RFR: 8235304: JPackage Windows test should be added to set Publisher [v2]

On Thu, 19 Nov 2020 22:26:20 GMT, Alexey Semenyuk wrote: >> 8235304: JPackage Windows test should be added to set Publisher > > Alexey Semenyuk has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by

Re: RFR: JDK-8256801: tools/jpackage/share/FileAssociationsTest.java#id0 failed unpack.bat with "Exit code: 1603"

On Mon, 23 Nov 2020 20:16:58 GMT, Andy Herrick wrote: > When executing msiexec (possibly from batch script) retry on exitCode 1603 as > well as 1618 Marked as reviewed by almatvee (Committer). - PR: https://git.openjdk.java.net/jdk/pull/1400

RFR: 8255619: Localized WinResources.properties have MsiInstallerStrings_en.wxl resource

Fixed by using correct localized resources. - Commit messages: - 8255619: Localized WinResources.properties have MsiInstallerStrings_en.wxl resource Changes: https://git.openjdk.java.net/jdk/pull/1638/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=1638&range=00 Issu

Integrated: 8255619: Localized WinResources.properties have MsiInstallerStrings_en.wxl resource

On Sat, 5 Dec 2020 05:33:25 GMT, Alexander Matveev wrote: > Fixed by using correct localized resources. This pull request has now been integrated. Changeset: a265c201 Author: Alexander Matveev URL: https://git.openjdk.java.net/jdk/commit/a265c201 Stats: 2 lines in 2 files chan

Re: RFR: JDK-8257539: tools/jpackage/windows/WinL10nTest.java unpack.bat failed with Exit code: 1618

On Mon, 7 Dec 2020 20:29:56 GMT, Andy Herrick wrote: > increase retries and timeout increasing in runMsiexecWithRetries Looks like test failed due to: [Fatal Error] b.wxl:3:1: XML document structures must start and end within the same entity. So, I am not sure how increased repeat will help. Do

RFR: 8238781: [macos] jpackage tests failed due to "hdiutil: convert failed" in various ways

This is similar issue we used to have for hdiutil create/detach, but for "convert". Added same workaround to repeat command. I also added repeat for "udifrez" command just in case. - Commit messages: - 8238781: [macos] jpackage tests failed due to "hdiutil: convert failed" in vari

RFR: 8257924: Use full path when running external executable from jpackage

Changed all external executables to run via full path to avoid potential issues. - Commit messages: - 8257924: Use full path when running external executable from jpackage Changes: https://git.openjdk.java.net/jdk/pull/1710/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&p

Re: RFR: 8257924: Use full path when running external executable from jpackage

On Wed, 9 Dec 2020 18:39:14 GMT, Alexey Semenyuk wrote: >> as long as your sure these are always in /usr/bin this is fine. >> If there is any chance of them being somewhere else instead we need a >> findTool type mechanism > > What if users would like to use not the default tools with jpackage?

Integrated: 8238781: [macos] jpackage tests failed due to "hdiutil: convert failed" in various ways

On Tue, 8 Dec 2020 07:45:30 GMT, Alexander Matveev wrote: > This is similar issue we used to have for hdiutil create/detach, but for > "convert". Added same workaround to repeat command. I also added repeat for > "udifrez" command just in case. This pull re

Re: RFR: JDK-8257539: tools/jpackage/windows/WinL10nTest.java unpack.bat failed with Exit code: 1618

On Wed, 9 Dec 2020 18:58:54 GMT, Andy Herrick wrote: > Same code change as https://github.com/openjdk/jdk/pull/1676 that got messed > up with merge Marked as reviewed by almatvee (Committer). - PR: https://git.openjdk.java.net/jdk/pull/1720

Integrated: 8257924: Use full path when running external executable from jpackage

On Wed, 9 Dec 2020 08:05:17 GMT, Alexander Matveev wrote: > Changed all external executables to run via full path to avoid potential > issues. This pull request has now been integrated. Changeset: eb1c8a15 Author:Alexander Matveev URL: https://git.openjdk.java.net/jdk/

Re: RFR: 8255899: Allow uninstallation of jpackage exe bundles

On Mon, 14 Dec 2020 19:33:44 GMT, Alexey Semenyuk wrote: > Adds support for "uninstall" parameter for exe uninstallers created by > jpackage. > Added logging and error reporting to exe uninstallers. > > - jpackage jni lib (jpackage.cpp): added functionality to extract ProductCode > property fr

Re: [jdk16] RFR: 8258293: tools/jpackage/share/RuntimePackageTest.java#id0 with RuntimePackageTest.testUsrInstallDir2

On Wed, 16 Dec 2020 00:24:20 GMT, Alexey Semenyuk wrote: > Ignore files created by prefs subsystem when checking if source runtime > contains the same files as packed runtime. Marked as reviewed by almatvee (Committer). - PR: https://git.openjdk.java.net/jdk16/pull/31

Re: RFR: JDK-8223322: Improve concurrency in jpackage instances

On Thu, 17 Dec 2020 20:46:50 GMT, Andy Herrick wrote: > Remove all non final static variables in jpackage java code (using > InheritableThreadLocal for Logger and Argument instances) and remove > sychronization in JPackageToolProvider. Changes looks fine, but are we sure that external 3rd part

Re: RFR: JDK-8258755: jpackage: Invalid 32-bit exe when building app-image

On Mon, 11 Jan 2021 17:42:21 GMT, Andy Herrick wrote: > JDK-8258755: jpackage: Invalid 32-bit exe when building app-image src/jdk.jpackage/share/native/applauncher/JvmLauncher.cpp line 37: > 35: > 36: #if defined(_WIN32) && !defined(_WIN64) > 37: #define LAUNCH_FUNC "_JLI_Launch@56" Why JLI_L

Re: RFR: JDK-8259062: Remove MacAppStoreBundler

On Wed, 6 Jan 2021 15:52:07 GMT, Andy Herrick wrote: > JDK-8259062: Remove MacAppStoreBundler Marked as reviewed by almatvee (Committer). - PR: https://git.openjdk.java.net/jdk/pull/1962

Re: RFR: JDK-8259238: Clean up Log.java and remove usage of non-final static variables.

On Thu, 7 Jan 2021 16:40:26 GMT, Andy Herrick wrote: > JDK-8259238: Clean up Log.java and remove usage of non-final static variables. Marked as reviewed by almatvee (Committer). - PR: https://git.openjdk.java.net/jdk/pull/1977

Re: RFR: JDK-8258755: jpackage: Invalid 32-bit exe when building app-image

On Mon, 11 Jan 2021 17:42:21 GMT, Andy Herrick wrote: > JDK-8258755: jpackage: Invalid 32-bit exe when building app-image Marked as reviewed by almatvee (Committer). - PR: https://git.openjdk.java.net/jdk/pull/2030

Re: RFR: JDK-8260335: [macos] Running app using relative path causes problems

On Wed, 27 Jan 2021 12:43:40 GMT, Andy Herrick wrote: > Fixing FileUtils.dirname() to skip over "/.". Marked as reviewed by almatvee (Committer). - PR: https://git.openjdk.java.net/jdk/pull/2260

Re: RFR: 8260592: jpackage tests fail when Desktop is not supported

On Thu, 28 Jan 2021 23:41:44 GMT, Alexey Semenyuk wrote: >> I would prefer to have separate messages for "headless" and "desktop >> capable". I can merge these, if you insist. > > Duplicated messages are not much help in understanding control flow. I'd > change the new message or merge conditio

Re: RFR: 8254702: jpackage app launcher crashes on CentOS [v2]

On Fri, 29 Jan 2021 23:06:20 GMT, Alexey Semenyuk wrote: >> Fix for https://bugs.openjdk.java.net/browse/JDK-8254702 >> >> The fix splits Linux app launcher in app launcher and launcher shared lib. >> App launcher is pure C and doesn't have C++ code. App launcher lib >> incorporates bulk of C+

RFR: 8259570: (macos) tools/jpackage tests fails with 'hdiutil: couldn't eject "disk2" - Resource busy'

We did not able to run "hdiutil convert" due to hdiutil did not able to acquire lock on DMG image file. In this condition we got "Resource busy" from "hdiutil detach" and on repeated attempt we was getting "File Not Found" error. According to some research "Resource Busy" is normal error message

Re: RFR: 8259570: (macos) tools/jpackage tests fails with 'hdiutil: couldn't eject "disk2" - Resource busy' [v2]

d seems to solves problem as well when hdiutil cannot acquire lock on > file. I also fixed in same way detach in our test helper. Alexander Matveev has updated the pull request incrementally with one additional commit since the last revision: 8259570: (macos) tools/jpackage test

Re: RFR: 8259570: (macos) tools/jpackage tests fails with 'hdiutil: couldn't eject "disk2" - Resource busy'

On Tue, 2 Feb 2021 00:29:39 GMT, Alexey Semenyuk wrote: >> We did not able to run "hdiutil convert" due to hdiutil did not able to >> acquire lock on DMG image file. In this condition we got "Resource busy" >> from "hdiutil detach" and on repeated attempt we was getting "File Not >> Found" err

Integrated: 8259570: (macos) tools/jpackage tests fails with 'hdiutil: couldn't eject "disk2" - Resource busy'

On Mon, 1 Feb 2021 23:41:38 GMT, Alexander Matveev wrote: > We did not able to run "hdiutil convert" due to hdiutil did not able to > acquire lock on DMG image file. In this condition we got "Resource busy" from > "hdiutil detach" and on repeated

Re: RFR: JDK-8259927: Windows jpackage installer issues

On Wed, 3 Feb 2021 14:08:13 GMT, Andy Herrick wrote: > Remove lines in WixSourceBuilder that adds directive to rm-rf the parent > dir(s) of the install-dir. These directories get removed anyway if they are > empty without these lines, and should be left alone if not empty after > removing the

Re: RFR: 8261300: jpackage: rewrite while(0)/while(false) to proper blocks [v2]

On Mon, 8 Feb 2021 15:25:02 GMT, Aleksey Shipilev wrote: >> After JDK-8254702, SonarCloud instance complains about blocks like these: >> "Change this loop body so that it can be executed more than once." >> >> int initJvmlLauncherData(JvmlLauncherData* ptr) const { >> // Store path

<    1   2   3   4   5   6   >