Re: os::javaTimeSystemUTC to call nanosecond precision OS API, so Clock.systemUTC() can give nanosecond precision UTC

Hi, On 11/04/2020 00:53, David Holmes wrote: Update: It's a holiday weekend so I can't dig into this right now but we tried using a high-precision clock source for systemUTC() in the past but it didn't work because systemUTC() and currentTimeMillis() have to use the same time base, and curren

Re: Some Classes with a public void close() don't implement AutoCloseable

Hi Johannes, On 16/04/2020 08:28, Alan Bateman wrote: java/util/logging/Handler That's already logged as https://bugs.openjdk.java.net/browse/JDK-8025709 (assigned to me) I have never got to the point to start working on it because it seems to be a very niche case: Handler are usually attac

Re: RFR 8242931: Few more tests that use nashorn have been missed

Hi Sundar, I spotted a typo (generial vs generic) test/jdk/ProblemList.txt: 936 java/util/ServiceLoader/ReloadTest.java 8242935 generial-all This is not an area I know well - so maybe wait for at least another opinion (reviewer or not) but what I saw looked reasonable. You have my review.

Re: RFR 8242931: Few more tests that use nashorn have been missed

On 16/04/2020 19:00, [email protected] wrote: Thanks Daniel. Fixed it. Updated webrev: http://cr.openjdk.java.net/~sundar/8242931/webrev.02/ LGTM best regards, -- daniel PS. Submitting mach5 job concurrently. Thanks, -Sundar

Re: [15] RFR: 8242614: cleanup duplicated test ldap server in some com/sun/jndi/ldap/ tests

Hi Chris, Thanks for this cleanup. The proposed changes look reasonable and worthwhile. best regards, -- daniel On 21/04/2020 08:43, Chris Yin wrote: Hello Please review following changes to cleanup duplicated test ldap server in some com/sun/jndi/ldap/ tests, thanks Bug: https://bugs.open

Re: [15] RFR: 8243138: Enhance BaseLdapServer to support starttls extended request

On 23/04/2020 01:39, Aleks Efimov wrote: Hi Chris, The changes look good to me. Thank you for extending the LDAP test server functionality. +1 Reviewed. best regards, -- daniel

Re: RFR 15: 8243010: Test support: Customizable Hex Printer

Hi Roger, On 23/04/2020 19:46, Roger Riggs wrote: A review would be appreciated. Ship it! cheers, -- daniel

Re: RFR: 8244224: Implementation of JEP 381: Remove the Solaris and SPARC Ports - (core libraries)

Hi Mikael, I spotted another place where a residual reference to Solaris remains in a comment: src/java.base/unix/native/libnet/PlainSocketImpl.c 857 #if defined(_AIX) 858 if (errno == EINVAL) { 859 // On Solaris setsockopt will set errno to EINVAL if the socket 860

Re: RFR [LDAP]: 8062947: Fix exception message to correctly represent LDAP connection failure

Hi Aleksei, Looks good to me. best regards, -- daniel On 05/05/2020 18:23, Aleks Efimov wrote: "LDAP response read timed out, timeout used:-1ms.": https://bugs.openjdk.java.net/browse/JDK-8062947 The following fix tries to tackle this issue: http://cr.openjdk.java.net/~aefimov/8062947/00

Re: RFR: 8237834: com/sun/jndi/ldap/LdapDnsProviderTest.java failing with LDAP response read timeout

Hi Aleksei, I agree with the general idea. However, the method: 215 private static int generateUnseenPort() { 216 int port; 217 do { 218 port = + RND.nextInt(1000); 219 } while (SEEN_PORTS.contains(port)); 220 SEEN_PORTS.add(port); 221

Re: RFR: 8237834: com/sun/jndi/ldap/LdapDnsProviderTest.java failing with LDAP response read timeout

led b) The port range has been extended to [, PortConfig.getUpper()) Webrev with new version: http://cr.openjdk.java.net/~aefimov/8237834/01 With Best Regards, Aleksei On 07/05/2020 11:10, Daniel Fuchs wrote: Hi Aleksei, I agree with the general idea. However, the method:  215 pr

Re: RFR: JDK-8209774 - [TESTBUG]Refactor shell test javax/xml/jaxp/common/8035437/run.sh to java

Hi Fernando, I believe that if you simply move the patched file under a directory named javax.xml, then you can get rid of all the @compile in the test. Starting from your patch: cd test/jdk/javax/xml/jaxp/common/8035437 mkdir java.xml hg move org javax.xml hg move com javax.xml then: 31 /*

Re: RFR: JDK-8209774 - [TESTBUG]Refactor shell test javax/xml/jaxp/common/8035437/run.sh to java

On 08/05/2020 15:40, Alan Bateman wrote:   31 /*   32  * @test   33  * @bug 8035437   34  * @summary Tests that java.lang.AbstractMethodError is not thrown when   35  * serializing improper version of DocumentImpl class.   36  * @library /test/lib   * @modules javax.xml/org.w3c.dom   * 

Re: RFR: JDK-8209774 - [TESTBUG]Refactor shell test javax/xml/jaxp/common/8035437/run.sh to java

creates a temporary java.xml patch that needs to be ignored after compiling *DocumentImpl. *I am using —patch-module because it’s more flexible than @compile/module * * Hope I explained myself! On 8 May 2020, at 15:49, Daniel Fuchs <mailto:[email protected]>> wrote: On 08/05/2020

Re: RFR: JDK-8209774 - [TESTBUG]Refactor shell test javax/xml/jaxp/common/8035437/run.sh to java

Hi Fernando, That looks good to me. best regards, -- daniel On 12/05/2020 11:46, Fernando Guallini wrote: Thanks for your comments. Below you can find a new web rev version that includes a test description in a comment: http://cr.openjdk.java.net/~fyuan/fernando/8209774/webrev.01/

Re: RFR [15] 8245111: Update doc comments for improved processing by the Standard Doclet

Hi Pavel, This looks good to me - but English is not my native language ;-) cheers, -- daniel On 15/05/2020 13:35, Pavel Rappo wrote: Hello, Please review this trivial change for https://bugs.openjdk.java.net/browse/JDK-8245111: http://cr.openjdk.java.net/~prappo/8245111/webrev.00/ In

Re: [15] RFR: 8245241: Incorrect locale provider preference is not logged

Hi Naoto, Logging uses: ZonedDateTime zdt = ZonedDateTime.ofInstant( record.getInstant(), ZoneId.systemDefault()); and then String.format("%1$tb %1$td, %1$tY %1$tl:%1$tM:%1$tS %1$Tp %2$s%n%4$s: %5$s%6$s%n", ...) to format the date. If the locale provider can't be loaded, is

Re: [15] RFR: 8245241: Incorrect locale provider preference is not logged

Hi Naoto, On 21/05/2020 20:00, [email protected] wrote: In fact, this piece of code should not happen as those adapter classes are all JDK provided classes. I replaced the above code with ServiceConfigurationError, like other similar locations (e.g, HostLocaleProviderAdapter - line 64-65).

8239013: java.util.logging.Logger catalog cache keeps strong references to ResourceBundles

Hi, Please find below a fix for: 8239013: java.util.logging.Logger catalog cache keeps strong references to ResourceBundles https://bugs.openjdk.java.net/browse/JDK-8239013 webrev: http://cr.openjdk.java.net/~dfuchs/webrev_8239013/webrev.00/ java.util.logging.Logger has a `catalog` va

Re: RFR: 8245527: LDAP Cnannel Binding support for Java GSS/Kerberos

Hi Alexey, This is not a review. A few high level comments however: For that kind of change that introduce a new environment property you will need to file a CSR, and probably provide some release notes as well. Your changes seem to trigger new IllegalStateException and UnsupportedOperationExce

Re: RFR(S) 8242504: Enhance the system clock to nanosecond precision

Hi David, This is not a review for the posix code. Your webrev looks good to me and corresponds to what I expected to see. I understand that not all operating systems / platforms are expected to have the nano second precision, so your test probably can't go much beyond what is currently being te

8245867: Logger/bundleLeak/BundleTest.java fails due to "OutOfMemoryError: Java heap space"

Hi, Please find an almost trivial fix for: 8245867: Logger/bundleLeak/BundleTest.java fails due to "OutOfMemoryError: Java heap space" https://bugs.openjdk.java.net/browse/JDK-8245867 webrev: http://cr.openjdk.java.net/~dfuchs/webrev_8245867/webrev.00/ My new test for JDK-8239013 has

Re: 8245867: Logger/bundleLeak/BundleTest.java fails due to "OutOfMemoryError: Java heap space"

Hi David, Thanks for the feedback! On 29/05/2020 00:36, David Holmes wrote: This seems to be assuming that the GC will clear all SoftReferences when it needs to clear any SoftReference. I don't think that is at all guaranteed. In theory your memory eating loop could be satisfied by clearing o

Re: RFR[8245658]: 'Arrays.java has two occurrences of bad unicode constants in Javadoc.'

Looks good to me Conor! best regards, -- daniel On 29/05/2020 10:37, Conor Cleary wrote: Hi, Could someone please review my webrev for JDK-8245658 'Arrays.java has two occurrences of bad unicode constants in Javadoc.'? In Arrays.java Javadoc, there were two instances of bad Unicode format

Re: RFR(xs): 8242281: IntStream.html#reduce doc should not mention average

Hi, You should also remove the @see #average() tag. I see this was already proposed in the CSR. When you push make sure to push with 8242281 (which is the bug id) and not with 8245970 - which is the CSR id. I have corrected the subject to help archeological search of the mail archive. best rega

Re: RFR(xs): 8242281: IntStream.html#reduce doc should not mention average

Oh! Thanks for pointing that Pavel. I should read comments fully ;-) I hadn't noticed that the CSR was withdrawn - I saw it was closed and thought it had been Approved. Well - keep the @see then! best regards, -- daniel On 29/05/2020 14:27, Pavel Rappo wrote: Daniel, have you considered tha

Re: 8245867: Logger/bundleLeak/BundleTest.java fails due to "OutOfMemoryError: Java heap space"

Hi, I have updated the webrev as suggested by David: http://cr.openjdk.java.net/~dfuchs/webrev_8245867/webrev.01 Unless I hear any objection I'll push that new version if the tests come back successful. best regards, -- daniel (tier1 and 2 passed, tier5 still running) On 29/05/2020 00:36, D

Re: 8245867: Logger/bundleLeak/BundleTest.java fails due to "OutOfMemoryError: Java heap space"

On 29/05/2020 16:53, Lance Andersen wrote: Hi Daniel, Do you still need the SoftReference import given you are no longer using it with memory.add()? No - I removed it. cheers, -- daniel Best Lance

Re: 8245867: Logger/bundleLeak/BundleTest.java fails due to "OutOfMemoryError: Java heap space"

Hi David, On 01/06/2020 23:43, David Holmes wrote: Sorry the weekend got in the way :) No problem David. I pushed with your suggestion (not using SoftReference) since that appeared to be working too. If it fails again I can revisit :-) best regards, -- daniel

Re: RFR: 8245527: LDAP Cnannel Binding support for Java GSS/Kerberos

Hi Alexey, Could we move the new code from LdapClient.java and LdapCtxt.java into the com.sun.jndi.ldap.sasl package, and possibly delay its execution until the com.sun.jndi.ldap.sasl.LdapSasl.saslBind method is called? The new TlsChannelBinding class should also be preferably moved to com.sun.j

Re: RFR: 8245527: LDAP Cnannel Binding support for Java GSS/Kerberos

Hi Alexey, On 05/06/2020 17:33, Alexey Bakhtin wrote: Hi Daniel, Thank you for review Yes, I can move TlsChannelBinding class into the com.sun.jndi.ldap.sasl package and LdapClient related changes into the LdapSasl.saslBind method. Also, you are right with exceptions. I will rename them to the

Re: [PATCH] 8246633: Improve the performance of ObjectInputStream.resolveClass(ObjectStreamClass)

Hi Peter, This is not a review. I second Roger's observations. On 05/06/2020 00:08, Peter Kessler OS wrote: Tested with `make run-test-tier1` on Linux (CentOS 7) on both aarch64 and x86_64. I had one failure on each of the runs The code you are proposing to change affects RMI and JMX too. F

Re: Thread leak by LdapLoginModule

On 09/06/2020 23:21, Sean Mullan wrote: The issue is not observed with java-14, thus I assume that the fix is related to commit http://hg.openjdk.java.net/jdk/jdk/rev/6717d7e59db4 As java-11 is LTS, what is the procedure to get it fix back-ported? Hi, AFAICS the fix has already been backpor

Re: [PATCH] 8246633: Improve the performance of ObjectInputStream.resolveClass(ObjectStreamClass)

ilures on x86_64. (Can I attribute the generally higher rate of failure on aarch64 compared to x86_64 to fact that aarch64 is a new platform for Oracle?) What further testing would you recommend? ... peter -Original Message- From: Daniel Fuchs Date: Tuesday, June

Re: RFR: 8245527: LDAP Cnannel Binding support for Java GSS/Kerberos

Hi Alexey, This is starting to look good. Thank you for persisting! I have a couple of comments - on the LDAP/JNDI side. There are several places where your new code is supposed to trigger the throwing of a NamingException: LdapSasl.java: lines 76, 85, 140, 168 Please write a test to verify

Re: RFR 8245302: Upgrade LogRecord to support long thread ids and remove its usage of ThreadLocal

Hi Rahul, This looks very good. I have some comments regarding the SerializeLogRecord test: - the test speaks of JDK 15 at several places: is it really JDK 15, or should it be JDK 16? I mean - was the serialized bytes generated before your fix or after? - the generate() method (no args) sh

Re: RFR 8245302: Upgrade LogRecord to support long thread ids and remove its usage of ThreadLocal

Hi Rahul, Looks good to me as well. Reviewed. best regards, -- daniel On 19/06/2020 10:00, Rahul Yadav wrote: Thank you Alan, updated webrev. webrev : http://cr.openjdk.java.net/~ryadav/webrev_8245302/webrev.00/index.html - rahul On 19/06/2020 08:43, Alan Bateman wrote: On 18/06/2020 2

Re: RFR: 8245527: LDAP Cnannel Binding support for Java GSS/Kerberos

Hi Alexey, The JNDI/LDAP part looks mostly good. You will need someone from the security libs to review the security lib part of the changes. In the test I would recommend using the test URIBuilder to avoid strange intermittent errors if the test is run on a machine where looking up "localhost"

Re: RFR[8238286]: 'Add new flatMap stream operation that is more amenable to pushing’

Hi Rémi, On 25/06/2020 00:32, Remi Forax wrote: I get that you want to keep Consumer instead of Consumer because Consumer is not a valid target type for a lambda, but the BiConsumer should be able to take a ? super Consumer instead of just Consumer. Though I don't dispute that a strict applic

Re: RFR 8245302: Upgrade LogRecord to support long thread ids and remove its usage of ThreadLocal

Thanks for fixing that Rahul! Looks good. best regards, -- daniel On 25/06/2020 10:22, Rahul Yadav wrote: Hello, Deprecated tag in LogRecord getter and setter for threadID was missing "since" and so i have added it. webrev : http://cr.openjdk.java.net/~ryadav/webrev_8245302/webrev.00/ -

Re: RFR [1]6 8248326 Add a minimal serialization test for local records

Hi Chris, Looks good to me. It might also be beneficial to double check that the hash codes of the two objects are equal. best regards, -- daniel On 25/06/2020 16:01, Chris Hegarty wrote: While working on some record serialization changes recently, I noticed that we don’t have any coverage f

Re: RFR[8238286]: 'Add new flatMap stream operation that is more amenable to pushing’

Hi Rémi, On 25/06/2020 23:12, Remi Forax wrote: if i have already have a BiConsumer, Object>, i would like to be able to call Stream.mapMulti() with that bi-consumer as argument. and obviously, i got it wrong, Consumer is not a super-type of Consumer, it should be a BiConsumer, Object> or a Bi

Re: RFR[8238286]: 'Add new flatMap stream operation that is more amenable to pushing’

Hi Rémi! On 26/06/2020 15:38, [email protected] wrote: for your first example, the only valid value for Consumer is null, so consumer.accept(null) should work. for the second example, Consumer accepts any subtypes of String, given that String is final, the only possible type is String, so con

Re: RFR 8248412: test/jdk/java/sql/testng/test/sql/DriverManagerPermissionsTests.java can fail

Looks good to me Lance. Thanks for fixing that! best regards, -- daniel On 26/06/2020 16:25, Lance Andersen wrote: Hi all, Please review this patch for https://bugs.openjdk.java.net/browse/JDK-8248412 where DriverManagerPermissionsTests.jav

Re: RFR 8245302: Upgrade LogRecord to support long thread ids and remove its usage of ThreadLocal

Hi Rahul, The updates to the readObject API documentation look good to me. Thanks for adding the missing @Serial annotations! best regards, -- daniel On 02/07/2020 12:35, Rahul Yadav wrote: Hello, I have added comments @Serial based on csr feedback for read/writeObject methods. webrev: ht

Re: Build error with GCC 10 in NetworkInterface.c and k_standard.c

Hi, I will not comment on the changes to libfdlibm/k_standard.c Concerning NetworkInterface.c I believe the proposed changes are incorrect - and I do not see the issue with the current code. > +if (sizeof(if2.ifr_name) < sizeof(name)) { > +return -1; > +} If I'm not mistaken `s

Re: RFR: 8245527: LDAP Cnannel Binding support for Java GSS/Kerberos

Thanks Sean, Alexey, On 08/07/2020 13:25, Sean Mullan wrote: Updated webrev : http://cr.openjdk.java.net/~abakhtin/8245527/webrev.v12/ You will also need to update the CSR to remove the connection timeout property. Also, you should document the "com.sun.jndi.ldap.tls.cbtype" property in th

Re: Build error with GCC 10 in NetworkInterface.c and k_standard.c

struct ifreq if2; + +    if (sizeof(if2.ifr_name) < strlen(ifname) + 1) { +    return -1; +    } + memset((char *)&if2, 0, sizeof(if2)); -    strncpy(if2.ifr_name, ifname, sizeof(if2.ifr_name) - 1); +    strcpy(if2.ifr_name, ifname); if (ioctl(sock, SIOCGIFFLAGS, (char *)

Re: RFR: 8245527: LDAP Cnannel Binding support for Java GSS/Kerberos

Hi Alexey, On 10/07/2020 21:37, Alexey Bakhtin wrote: Updated webrev:http://cr.openjdk.java.net/~abakhtin/8245527/webrev.v14/ In what the JNDI part is concerned this looks good to me now. nit: java.naming/share/classes/com/sun/jndi/ldap/sasl/TlsChannelBinding.java: 138 }catch(NoSuch

Re: Build error with GCC 10 in NetworkInterface.c and k_standard.c

Hi Koichi, On 13/07/2020 08:03, Koichi Sakata wrote: > I understand that. I respect your idea. > I fixed the patch as follows. The changes to NetworkInterface.c look good to me. > > By the way, k_standard.c still remains. Is there a way to proceed with it? You'll need to find a reviewer that

8249774: Add java/foreign/TestMismatch.java to ProblemList.txt

Hi, Please find below a fix for: 8249774: Add java/foreign/TestMismatch.java to ProblemList.txt https://bugs.openjdk.java.net/browse/JDK-8249774 The test has failed twice in timeout on macOS in the tier1 CI. Requesting to put it into a problem list until a fix is proposed. best regards, -- d

Re: JDK 16 RFR of JDK-8250221: Address use of default constructors in java.logging

Hi Joe, LGTM. best regards, -- daniel On 23/07/2020 18:37, Joe Darcy wrote: Hello, Please review the changes for     JDK-8250221: Address use of default constructors in java.logging     webrev: http://cr.openjdk.java.net/~darcy/8250221.0/     CSR: https://bugs.openjdk.java.net/browse/JDK

Re: RFR: 8245527: LDAP Cnannel Binding support for Java GSS/Kerberos

Hi Alexey, I have added myself as a reviewer to the CSR [1]. It would be good to get someone from security-dev to do the same, and then move the CSR state to "Proposed". best regards, -- daniel [1] https://bugs.openjdk.java.net/browse/JDK-8247311 On 30/07/2020 10:17, Alexey Bakhtin wrote: Ge

Re: RFR[testbug]: 8251189: com/sun/jndi/ldap/LdapDnsProviderTest.java failed due to timeout

Hi Aleksei, Looks good to me! best regards, -- daniel On 06/08/2020 13:44, Aleks Efimov wrote: Hi, LdapDnsProviderTest was seen failing due to the timeout caused by the blocked bind operation. That could happen if there is a local process listening on the port specified in the test URL. To

Re: RFR [testbug]: 8250772: Test com/sun/jndi/ldap/NamingExceptionMessageTest.java fails intermittently with javax.naming.ServiceUnavailableException

Hi Aleksei, I agree that this is the best fix for this issue. best regards, -- daniel On 06/08/2020 23:21, Aleks Efimov wrote: Hi, Please, help to review NamingExceptionMessageTest test stabilization change: There is a race condition between the closure of connection in test LDAP server an

8251160: Fix "no comment" warnings in java.logging

Hi, Please find below a doc-only fix for: 8251160: Fix "no comment" warnings in java.logging https://bugs.openjdk.java.net/browse/JDK-8251160 CSR: https://bugs.openjdk.java.net/browse/JDK-8251534 webrev: http://cr.openjdk.java.net/~dfuchs/webrev_8251160/webrev.00/ The documentation of the ser

Re: Fix for Javadoc errors in java.base

Hi Vipin, Julia, On 13/08/2020 16:05, Julia Boes wrote: Hi Vipin, Thanks for providing this fix, I'm happy to sponsor your change. To complete the review, we still need someone to green light the remaining changes below. I'm looping in net-dev and security-dev to have a look. Changes to Soc

Re: 8251160: Fix "no comment" warnings in java.logging

Hi Mandy, Thanks for looking at this! On 13/08/2020 20:48, Mandy Chung wrote: Level The javadoc for readResolve seems internal implementation details. Would it be sufficient to say: “Returns a {@code Level} instance with the same {@code name},  {@code value}, and {@code resourceBundleName}

Re: RFR: 8245527: LDAP Cnannel Binding support for Java GSS/Kerberos

Hi Sean, Wait wait... Are they system properties really? Only system properties should be documented with @systemProperty. I can't find the place were com.sun.jndi.ldap.connect.timeout or com.sun.jndi.ldap.read.timeout is read from System. I believe they are just plain environment properties th

Re: RFR: 8245527: LDAP Cnannel Binding support for Java GSS/Kerberos

Hi Alexey, LGTM! Thanks, -- daniel On 14/08/2020 15:42, Alexey Bakhtin wrote: Sorry, That’s my bad. I have reverted @systemProperty to @code. The wording is fixed. Webrev: http://cr.openjdk.java.net/~abakhtin/8245527/webrev.v17/ Regards Alexey

Re: RFR 8251203: Fix "no comment" warnings in java.base/java.lang and java/io

On 21/08/2020 16:09, Roger Riggs wrote: Please review the addition of comments to classes and fields to resolve javadoc "no comment" warnings in the java.lang and java.io packages. The comments are derived from the existing behavior and context. Looks good to me Roger. I don't quite recall whe

Re: RFR 8251203: Fix "no comment" warnings in java.base/java.lang and java/io

Hi Roger, On 21/08/2020 17:52, Roger Riggs wrote: The @serial javadoc tag is used on any serialization related field or method. Are there some missing? I expect javac would warn if they were missing. Well I was wondering whether an @serial tag would be appropriate in the documentation of thes

Re: [16] RFR: 8251182: Fix "no comment" warnings in java.naming

Hi Aleksei, LGTM. You could also add the @Seial annotation to serialVersionUID declarations. best regards, -- daniel On 25/08/2020 16:03, Aleks Efimov wrote: Hi, The documentation of classes from "java.naming" module needs to be improved to resolve javadoc -Xdoclint "no comment" warnings.

Re: [16] RFR: 8251182: Fix "no comment" warnings in java.naming

Hi Aleksei, Thanks for taking this on. The new version looks good to me. best regards, -- daniel On 26/08/2020 12:46, Aleks Efimov wrote: Hi Roger, Lance, Daniel, Thanks for your reviews and comments! New webrev with suggested modifications can be viewed at this location: http://cr.openjdk.j

Re: RFR 8252265: Replace @exception with @throws java.util.logging package

Hi Vipin, This looks good to me. Make sure to generate the API docs locally and eyeball them to double check that nothing is amiss. best regards, -- daniel On 26/08/2020 17:38, Vipin Sharma wrote: Hi, Please review and sponsor the fix for replacing @exception with @throws in java.util.loggin

Re: RFR 8252265: Replace @exception with @throws java.util.logging package

Hi Lance, On 26/08/2020 17:55, Lance Andersen wrote: I did find it strange that FileHandler had a few methods which listed IllegalArgumentException multiple times (vs. including the possible scenarios for the exception as part of 1 @throws) as I have not noticed that elsewhere in the JDK but

Re: RFR(S): 8252407: Build failure with gcc-8+ and asan

Hi Eric, The changes to NetworkInterface.c look good to me. best regards, -- daniel On 01/09/2020 09:01, Eric Liu wrote: Hi all, Please review this simple change to fix some compile warnings. The newer gcc (gcc-8 or higher) would warn for calls to bounded string manipulation functions such

Re: RFR(S): 8252407: Build failure with gcc-8+ and asan

Hi Eric, Kim, On 01/09/2020 10:46, Kim Barrett wrote: he changes being made to getIndex and getFlags (NetworkInterface.c) are modifying lines that were changed very recently to deal with such warnings from gcc10. I'm worried that these new changes will re-trigger warnings from gcc10 (though thi

Re: RFR(S): 8252407: Build failure with gcc-8+ and asan

Hi, On 02/09/2020 08:19, Florian Weimer wrote: At least one of the bugs was in theory user-visible: the network interface code would return data for an interface that does not actually exist on the system. WRT NetworkInterface.c, I might support using `strnlen` to check the length before hand,

Re: RFR: 8252830: Correct missing javadoc comments in java.rmi module

On Tue, 8 Sep 2020 15:19:40 GMT, Roger Riggs wrote: > 8252830: Correct missing javadoc comments in java.rmi module Changes requested by dfuchs (Reviewer). src/java.rmi/share/classes/java/rmi/activation/ActivationGroupDesc.java line 321: > 319: * > 320: */ > 321: priv

Re: RFR: 8252830: Correct missing javadoc comments in java.rmi module [v2]

On Tue, 8 Sep 2020 18:55:40 GMT, Roger Riggs wrote: >> 8252830: Correct missing javadoc comments in java.rmi module > > Roger Riggs has updated the pull request incrementally with one additional > commit since the last revision: > > Added @java.io.Serial annotation to serializable methods and

Re: RFR: 8252830: Correct missing javadoc comments in java.rmi module [v3]

On Tue, 8 Sep 2020 19:44:21 GMT, Roger Riggs wrote: >> 8252830: Correct missing javadoc comments in java.rmi module > > Roger Riggs has updated the pull request incrementally with one additional > commit since the last revision: > > Added java.io.Serial to java.rmi.activation.ActivationID Ma

Re: RFR: 8252730: jlink does not create reproducible builds on different servers [v2]

On Mon, 14 Sep 2020 22:57:44 GMT, Ian Graves wrote: >> Related to [JDK-8252730 jlink does not create reproducible builds on >> different >> servers](https://bugs.openjdk.java.net/browse/JDK-8252730). Introduces >> ordering based on `Archive` module names to >> ensure stable files (and file sign

Re: RFR: 8253155: Minor cleanups and Javadoc fixes for LdapDnsProvider of java.naming

On Tue, 15 Sep 2020 07:47:54 GMT, Christoph Langer wrote: > There are some little flaws in LdapDNSProvider and auxilliary classes, mostly > in Javadoc. > > In detail: > src/java.naming/share/classes/com/sun/jndi/ldap/DefaultLdapDnsProvider.java: > Unnecessary import > src/java.naming/share/cla

Re: RFR: 6714834: JarFile.getManifest() leaves an open InputStream as an undocumented side effect [v2]

On Tue, 15 Sep 2020 15:45:05 GMT, Jaikiran Pai wrote: > I'm curious, in the context of this change, why idempotency would be a > necessity. Would there be a "double close" > somehow on this `InputStream` instance? My bad - I hadn't realised closing the input stream would also remove it from th

Re: RFR: 8251188: Update LDAP tests not to use wildcard addresses

On Fri, 18 Sep 2020 12:59:07 GMT, Aleksei Efimov wrote: > Hi, > > Please help to review > [JDK-8251188](https://bugs.openjdk.java.net/browse/JDK-8251188) fix which > helps to improve LDAP > tests stability. The list of changes: 1. Usages of wildcard address have been > replaced with loopback

Re: RFR: 8245527: LDAP Channel Binding support for Java GSS/Kerberos

On Mon, 21 Sep 2020 08:19:28 GMT, Alexey Bakhtin wrote: > Hi, > > Plaese review JDK-8245527 fix which implements LDAP Channel Binding support > for Java GSS/Kerberos. > Initial review is available at core-devs: > https://mail.openjdk.java.net/pipermail/core-libs-dev/2020-August/068197.html > T

Re: RFR: 8245527: LDAP Channel Binding support for Java GSS/Kerberos

On Mon, 21 Sep 2020 08:19:28 GMT, Alexey Bakhtin wrote: > Hi, > > Plaese review JDK-8245527 fix which implements LDAP Channel Binding support > for Java GSS/Kerberos. > Initial review is available at core-devs: > https://mail.openjdk.java.net/pipermail/core-libs-dev/2020-August/068197.html > T

Re: RFR: 8245527: LDAP Channel Binding support for Java GSS/Kerberos

On Tue, 22 Sep 2020 15:17:23 GMT, Alexey Bakhtin wrote: >> src/java.naming/share/classes/com/sun/jndi/ldap/sasl/TlsChannelBinding.java >> line 63: >> >>> 61: * Channel binding on the basis of TLS Finished message >>> 62: */ >>> 63: TLS_UNIQUE("tls-unique"), >> >> Is t

Re: RFR: 8245527: LDAP Channel Binding support for Java GSS/Kerberos [v2]

On Tue, 22 Sep 2020 20:19:21 GMT, Alexey Bakhtin wrote: >> Hi, >> >> Plaese review JDK-8245527 fix which implements LDAP Channel Binding support >> for Java GSS/Kerberos. >> Initial review is available at core-devs: >> https://mail.openjdk.java.net/pipermail/core-libs-dev/2020-August/068197.ht

Re: RFR: 8251188: Update LDAP tests not to use wildcard addresses [v2]

On Thu, 24 Sep 2020 23:46:47 GMT, Aleksei Efimov wrote: >> Hi, >> >> Please help to review >> [JDK-8251188](https://bugs.openjdk.java.net/browse/JDK-8251188) fix which >> helps to improve LDAP >> tests stability. The list of changes: 1. Usages of wildcard address have >> been replaced with lo

Re: RFR: 8253667: ProblemList tools/jlink/JLinkReproducible{, 3}Test.java on linux-aarch64

On Mon, 28 Sep 2020 16:05:48 GMT, Daniel D. Daugherty wrote: > 8253667: ProblemList tools/jlink/JLinkReproducible{,3}Test.java on > linux-aarch64 Marked as reviewed by dfuchs (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/382

Re: RFR: 8251989: Hex formatting and parsing utility [v2]

On Tue, 13 Oct 2020 19:51:30 GMT, Roger Riggs wrote: >> java.util.HexFormat utility: >> >> - Format and parse hexadecimal strings, with parameters for delimiter, >> prefix, suffix and upper/lowercase >> - Static factories and builder methods to create HexFormat copies with >> modified parame

Re: RFR: 8251989: Hex formatting and parsing utility [v2]

On Wed, 14 Oct 2020 13:38:51 GMT, Roger Riggs wrote: >> src/java.net.http/share/classes/jdk/internal/net/http/common/Utils.java line >> 1116: >> >>> 1114: } >>> 1115: >>> 1116: HexFormat format = HexFormat.of().withUpperCase(); >> >> Should/can this be a static final field in t

Re: RFR: 8188055: (ref) Add Reference::refersTo predicate [v3]

On Wed, 14 Oct 2020 18:09:16 GMT, Mandy Chung wrote: >> @mlchung I have often used a `Reference` in tests - but my main usage >> there would be to call `ref.refersTo(null)` >> which works in all cases. My main concern here however is that using `T` in >> `refersTo` seems to go against the >> a

Re: RFR: 8251989: Hex formatting and parsing utility [v3]

On Wed, 14 Oct 2020 19:12:37 GMT, Roger Riggs wrote: >> java.util.HexFormat utility: >> >> - Format and parse hexadecimal strings, with parameters for delimiter, >> prefix, suffix and upper/lowercase >> - Static factories and builder methods to create HexFormat copies with >> modified parame

Re: RFR: 8251989: Hex formatting and parsing utility [v4]

On Thu, 15 Oct 2020 16:58:37 GMT, Roger Riggs wrote: >> java.util.HexFormat utility: >> >> - Format and parse hexadecimal strings, with parameters for delimiter, >> prefix, suffix and upper/lowercase >> - Static factories and builder methods to create HexFormat copies with >> modified parame

Re: RFR: 8251989: Hex formatting and parsing utility [v5]

On Fri, 16 Oct 2020 19:56:30 GMT, Roger Riggs wrote: >> java.util.HexFormat utility: >> >> - Format and parse hexadecimal strings, with parameters for delimiter, >> prefix, suffix and upper/lowercase >> - Static factories and builder methods to create HexFormat copies with >> modified parame

Re: RFR: 8247402: Documentation for Map::compute contains confusing implementation requirements

On Sat, 17 Oct 2020 02:50:28 GMT, John Lin wrote: > This is from the mailing list: > http://mail.openjdk.java.net/pipermail/core-libs-dev/2020-June/067190.html > > - > ### Progress > - [x] Change must not contain extraneous whitespace > - [x] Commit message must refer to an issue > - [

Re: RFR: 8251989: Hex formatting and parsing utility [v6]

On Mon, 19 Oct 2020 22:52:31 GMT, Roger Riggs wrote: >> java.util.HexFormat utility: >> >> - Format and parse hexadecimal strings, with parameters for delimiter, >> prefix, suffix and upper/lowercase >> - Static factories and builder methods to create HexFormat copies with >> modified parame

Re: RFR: 8255299: Drop explicit zeroing at instantiation of Atomic* objects

On Thu, 22 Oct 2020 20:46:15 GMT, Сергей Цыпанов wrote: > As discussed in https://github.com/openjdk/jdk/pull/510 there is never a > reason to explicitly instantiate any instance of `Atomic*` class with its > default value, i.e. `new AtomicInteger(0)` could be replaced with `new > AtomicInteg

Re: RFR: 8255299: Drop explicit zeroing at instantiation of Atomic* objects

On Fri, 23 Oct 2020 08:15:00 GMT, Sergey Bylokhov wrote: >> As discussed in https://github.com/openjdk/jdk/pull/510 there is never a >> reason to explicitly instantiate any instance of `Atomic*` class with its >> default value, i.e. `new AtomicInteger(0)` could be replaced with `new >> AtomicI

Re: RFR: 8251989: Hex formatting and parsing utility [v8]

On Thu, 22 Oct 2020 15:55:30 GMT, Roger Riggs wrote: >> java.util.HexFormat utility: >> >> - Format and parse hexadecimal strings, with parameters for delimiter, >> prefix, suffix and upper/lowercase >> - Static factories and builder methods to create HexFormat copies with >> modified parame

Re: RFR: 8255299: Drop explicit zeroing at instantiation of Atomic* objects

On Fri, 23 Oct 2020 09:14:48 GMT, Daniel Fuchs wrote: >> The changes in src/java.desktop looks fine. > > Changes to `java.logging` and `java.net.http` also look good to me. Hi Sergey, I'll give it some testing and sponsor it next week unless someone else steps up. best r

Re: RFR: 8188055: (ref) Add Reference::refersTo predicate [v6]

On Wed, 28 Oct 2020 08:54:31 GMT, Peter Levart wrote: >> Some thoughts regarding the parameter type of refersTo. Summary: I think >> `refersTo(T)` is fine and that we don't want to change it to >> `refersTo(Object)`. >> >> I don't think we have a migration issue similar to generifying collecti

Re: RFR: 8255299: Drop explicit zeroing at instantiation of Atomic* objects [v2]

On Wed, 28 Oct 2020 08:56:05 GMT, Сергей Цыпанов wrote: >> FYI it is better to use merge, instead of rebase+force push. Rebase breaks >> history and all existed code comments. > > @mrserb thanks for pointing this out! Thanks for updating with latest master changes Sergey! My tests were all gre

Re: RFR: 8180352: Add Stream.toList() method

On Tue, 3 Nov 2020 01:33:32 GMT, Stuart Marks wrote: > This change introduces a new terminal operation on Stream. This looks like a > convenience method for Stream.collect(Collectors.toList()) or > Stream.collect(Collectors.toUnmodifiableList()), but it's not. Having this > method directly on

Re: RFR: 8255214 : Unsupported 'valign' attribute for 'th' tag used in j.u.l.LogManager

On Wed, 4 Nov 2020 21:52:56 GMT, Rahul Yadav wrote: > Hello, > > Request to review this small change, as HTML4 support has been dropped from > javadoc. > Have replaced valign="top" with style="vertical-align:top". LGTM Rahul. The generated javadoc looks OK too. - Marked as review

Re: RFR: 8256183: InputStream.skipNBytes is missing @since 12

On Thu, 19 Nov 2020 12:35:04 GMT, Conor Cleary wrote: > InputStream.skipNBytes is missing `@since 12` tag which was not added during > the review of [JDK-6516099](https://bugs.openjdk.java.net/browse/JDK-6516099). > > This small fix adds the `@since` tag to InputStream.skipNBytes Marked as rev

Re: RFR: 8256154: Some TestNG tests require default constructors

On Thu, 19 Nov 2020 13:50:30 GMT, Conor Cleary wrote: > In TestNG 7, it is a requirement that TestNG is able to create a Test object > using a default constructor. > > This simple fix addresses two such classes so that this requirement is > satisfied by inserting default construtors. Example:

  1   2   3   4   5   6   7   8   9   10   >