The additional patch looks fine to me.
Thanks,
Max
> On Apr 12, 2020, at 3:23 AM, Vipin Sharma wrote:
>
> Hi Pavel,
>
>> On Apr 9, 2020, at 2:45 AM, Pavel Rappo wrote:
>>
>> If your new patch addresses a similar type of problem, please send it in
>> reply to this email,
>> so that I could m
This looks fine to me. Do you need a sponsor?
Thanks,
Max
> On Apr 27, 2020, at 10:53 AM, buddyliao(廖彬) wrote:
>
> Dear all,
>
> Would you help me to review the following tiny fix? Which is used to update
> the copyright info for patch
> https://hg.openjdk.java.net/jdk/jdk/rev/3f8d03880bf5
sponsor me?
>
> BRs,
> Bin
>
> 在 2020/4/27 上午11:40，“Weijun Wang” 写入:
>
>This looks fine to me. Do you need a sponsor?
>
>Thanks,
>Max
>
>> On Apr 27, 2020, at 10:53 AM, buddyliao(廖彬) wrote:
>>
>> Dear all,
>>
>> Wo
https://hg.openjdk.java.net/jdk/jdk/rev/534855a30ef5
Thanks,
Max
> On Apr 27, 2020, at 11:56 AM, buddyliao(廖彬) wrote:
>
> Contributed-by: Bin Liao
>
> Thanks,
> Bin
>
> 在 2020/4/27 上午11:52，“Weijun Wang” 写入:
>
>Sure, please provide me a "Contri
There are several security-related files (name.contains("security")) and they
all look fine.
--Max
> On May 4, 2020, at 1:12 PM, Mikael Vidstedt
> wrote:
>
>
> Please review this change which implements part of JEP 381:
>
> JBS: https://bugs.openjdk.java.net/browse/JDK-8244224
> webrev:
>
JarFile.java:
734: extra new line?
930: Remove or rewrite the comment.
ZipFile.java:
49: seems not used
Please add links to each other between
src/java.base/share/classes/sun/security/util/SignatureFileVerifier.java::isBlockOrSF
and
src/java.base/share/classes/java/util/zip/ZipFile.java::isS
I have a question on GssKrb5Client.java:
Do you think it's a good idea to let the SASL mechanism understand what TLS
binding is? Instead of passing the whole TlsChannelBinding object through a
SASL property, is it possible to only pass the actual cbData? After all, the
name "com.sun.security.sa
sm strange. It belongs to a
different layer.
--Max
> This is a reason I create TLSChannelBinding class and calculate hash from the
> LdapClient and add “tls-server-end-point:” prefix in the JGSS/Kerberos.
>
> Alexey
>
>> On 26 May 2020, at 17:50, Weijun Wang wrote:
>>
> On May 21, 2020, at 3:35 PM, Alexey Bakhtin wrote:
>
> The hash algorithm is selected on the base of the certificate
> signature algorithm.
> Also, the client should use SHA-256 algorithm, in case of the
> certificate signature algorithm is SHA1 or MD5
According to ht
so, I’ve updated TlsChannelBinding class to select SHA-256 hash algorithm
> if it can not be derived
> from the certificate signature name.
>
> Regards
> Alexey
>
>
>> On 26 May 2020, at 17:50, Weijun Wang wrote:
>>
>> I have a question on GssKrb5Clien
a name which is even more internal.
Thanks,
Max
p.s. I see that NTLM also supports ChannelBinding. I'll see if I can improve
the NTLM SASL mech to support it.
>
> Regards
> Alexey
>
>> On 5 Jun 2020, at 06:41, Weijun Wang wrote:
>>
>> Hi Alexey,
>>
> On Jun 6, 2020, at 2:41 PM, Weijun Wang wrote:
>
>
>
>> On Jun 5, 2020, at 11:03 PM, Alexey Bakhtin wrote:
>>
>> Hello Max,
>>
>> Thank you a lot for review.
>>
>> Could you check the new version of the patch :
>> http://
> - verification of connectTimeout property is moved to LdapCtx.connect. I’ve
> found that connectionTimeout could be assigned later then cbType
>
> The test for this issue is not ready yet. I did not find any suitable test
> case that can be reused.
>
> Thank you
> Alexey
>
>&
-
src/java.base/share/classes/sun/security/provider/certpath/DistributionPointFetcher.java
@@ -248,7 +248,7 @@ private static X509CRL getCRL(URIName name) throws
CertStoreException {
debug.println("Trying to fetch CRL from DP " + uri);
}
Event.repor
The GSS and SASL changes look fine to me.
Two small questions:
1. If the change in java.security.jgss/share/classes/module-info.java is
unavoidable, can we create a sub-package for this single class so that we only
need to export it? Or, do you think we can define the sub-class inside
GssKrb5C
> On Jul 3, 2020, at 7:32 PM, Alexey Bakhtin wrote:
>
> Hello All,
>
> Thank you for review.
>
>> 1. If the change in java.security.jgss/share/classes/module-info.java is
>> unavoidable, can we create a sub-package for this single class so that we
>> only need to export it?
>
> As suggest
How about StringBuilder::appendHex instead of Encoder::encode(SB, byte[])? Then
we don’t need to break the chain when appending many different things to a
StringBuilder.
Also, are prefix and suffix really useful? One can easily add them.
Thanks,
Max
> On Aug 19, 2020, at 5:14 PM, Roger Riggs
Are you going to update the warning text or create a new one?
Thanks,
Max
> On Aug 26, 2020, at 2:26 PM, Seán Coffey wrote:
>
> This is a follow on from the recent 8218021 fix. The jarsigner tool removes
> symlink attribute data from zipfiles when signing them. jarsigner should
> preserve thi
ymlink
>> attributes detected. These attributes are ignored when signing and are not
>> protected by the signature."},
>>
>> regards,
>> Sean.
>>
>> On 26/08/2020 23:15, Weijun Wang wrote:
>>> Are you going to update the warning text or cr
> On Aug 27, 2020, at 10:36 AM, Seán Coffey wrote:
>
> Thanks for the review Max. Comments inline..
>
> On 27/08/2020 14:45, Weijun Wang wrote:
>> I’m OK with using one warning, but prefer it to a little more formal like
>> "POSIX file permission an
ew testcase added.
>
> http://cr.openjdk.java.net/~coffeys/webrev.8250968.v4/webrev/
>
> regards,
> Sean.
>
> On 27/08/2020 15:58, Weijun Wang wrote:
>>> Looks like it was a conscious design decision to only allow recording of
>>> POSIX permission bits for this field (&
ote:
>
>
> On 28/08/2020 16:18, Weijun Wang wrote:
>> 1. Add a comment on how to generate ZIPBYTES in the test. Not the byte[]
>> declaration but how the original ZIP file is generated.
> I'll add a comment block to the test:
>> /*
>> * Created using the c
On Mon, 7 Sep 2020 13:48:57 GMT, Sean Coffey wrote:
> Continuation of RFR thread from
> http://mail.openjdk.java.net/pipermail/security-dev/2020-August/022373.html
>
> CSR has been approved.
Marked as reviewed by weijun (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/56
On Sun, 20 Sep 2020 14:14:51 GMT, Roger Riggs wrote:
>> # JDK-8252523: Add ASN.1 Formatter to work with test utility HexPrinter
>>
>> Debugging functions that utilize ASN.1, DER, and BER encoded streams is
>> difficult without test utilities to show the contents.
>> The ASN.1 formatter reads a s
On Mon, 21 Sep 2020 08:19:28 GMT, Alexey Bakhtin wrote:
> Hi,
>
> Plaese review JDK-8245527 fix which implements LDAP Channel Binding support
> for Java GSS/Kerberos.
> Initial review is available at core-devs:
> https://mail.openjdk.java.net/pipermail/core-libs-dev/2020-August/068197.html
> T
Major points in CSR at https://bugs.openjdk.java.net/browse/JDK-8245274:
- new sigalg "RSASSA-PSS", "EdDSA", "Ed25519" and "Ed448" can be used in
jarsigner
- The ".RSA" and ".EC" block extension types (PKCS #7 SignedData inside a
signed JAR) are reused for new signature
algorithms
- A new Ja
On Tue, 27 Oct 2020 14:24:26 GMT, Alan Bateman wrote:
>> To access the internal security APIs to lookup known OIDs the test needs to
>> open java.base/sun.security.util.
>
> Marked as reviewed by alanb (Reviewer).
The `findMatch` method is public, maybe you can remove the `setAccessible` call
On Tue, 27 Oct 2020 15:27:39 GMT, Roger Riggs wrote:
>> To access the internal security APIs to lookup known OIDs the test needs to
>> open java.base/sun.security.util.
>
> Roger Riggs has updated the pull request incrementally with one additional
> commit since the last revision:
>
> simpli
I regret adding the `directsign` property/option to JarSigner/jarsigner. See
the bug for details.
-
Commit messages:
- 8255536: Remove the directsign property and option
Changes: https://git.openjdk.java.net/jdk/pull/915/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=
This is not a review to this change.
The super long lines in translated properties files are really unreadable. Is
it possible to reformat them like the English version? i.e. break the line at
every non-terminal \n?
Thanks,
Max
> On Jul 30, 2019, at 9:55 PM, [email protected] wrote:
>
> Hi,
Hi Philipp,
Although I also think this feature might be useless, I feel hesitated to just
remove it. How about implement it and let it stay useless? I assume this will
not break any existing test or app if no one is actually using the character.
Hopefully it's easy to implement.
On the other h
+SeanC
The wait might unnecessarily increase the test time. Maybe you can do something
like this:
int timeout = 10;
while (timeout > 0) {
sleep(one second);
verifyPortFree && return;
timeout--;
}
throw new Exception(still not freed);
And Sean, back in JDK-8016728 y
est.
>>
>> Any timeout-like value used within the test code should be sensitive to the
>> jtreg timeout factor, as done in the webrev.
>>
>> Thanks,
>>
>> -Joe
>>
>> On 10/14/2019 7:20 PM, Weijun Wang wrote:
>>> +SeanC
>>>
&g
> On Oct 15, 2019, at 5:44 PM, Hamlin Li wrote:
>
>
> On 2019/10/15 2:44 PM, Weijun Wang wrote:
>> I am OK with the change that makes this test more robust.
> Thanks Max.
>>
>> However, I am not an expert in RMI and don't know why the port cannot be
&
> On Oct 16, 2019, at 9:17 AM, Hamlin Li wrote:
>
>
> On 2019/10/15 7:50 PM, Weijun Wang wrote:
>>
>>> On Oct 15, 2019, at 5:44 PM, Hamlin Li wrote:
>>>
>>>
>>> On 2019/10/15 2:44 PM, Weijun Wang wrote:
>>>> I am O
> On Oct 16, 2019, at 9:37 AM, Hamlin Li wrote:
>
>
> On 2019/10/16 9:26 AM, Weijun Wang wrote:
>
>>>>>> Even after this bug is resolved, I'd suggest add some logging and rerun
>>>>>> this test unchanged multiple times to see what
Just curious.
Why is fs.getSpace() returning negative here? Naively, I would think it is
truncating an int128 to int64. If so, if the value exceeds 2^64, will it be
positive again?
Thanks,
Max
> On Nov 23, 2019, at 1:40 AM, Brian Burkhalter
> wrote:
>
> PING!
>
>> Begin forwarded message:
I noticed a problem of myself but do not know if update_copyright_year.sh can
deal with it more correctly.
For example,
---
old/src/java.security.jgss/share/classes/sun/security/krb5/internal/crypto/Aes128CtsHmacSha2EType.java
2019-12-22 19:00:54.0 +0300
+++
new/src/java.securit
> On Dec 27, 2019, at 1:06 AM, Philipp Kunz wrote:
>
> Hi,
>
> The Jar File Specification [1] states that,
>
>> Note: To prevent mangling of files sent via straight e-mail,
>> no header will start with the four letters "From".
>
> But I can't see that this is actually the case.
>
> After n
There is neither a test nor a noreg-* label.
I would add a regression test even if reflection is needed. Or you can make it
noreg-trivial.
Thanks,
Max
> On Dec 17, 2019, at 11:50 AM, Verghese, Clive wrote:
>
> Hi Volker,
>
> Thank you for the feedback.
>
> I have update the revision to ref
On Tue, 8 Dec 2020 12:15:38 GMT, Alan Bateman wrote:
>> Also, to clarify, for me there is a fundamental difference between
>> `src/$MODULE` and `make/modules/$MODULE`. The former is the home of files
>> that are part of the module, owned by the content team, and the `$MODULE`
>> part is essent
On Mon, 7 Dec 2020 14:27:45 GMT, Magnus Ihse Bursie wrote:
>> A lot (but not all) of the data in make/data is tied to a specific module.
>> For instance, the publicsuffixlist is used by java.base, and fontconfig by
>> java.desktop. (A few directories, like mainmanifest, is *actually* used by
>
The method is useless now since the related TLS cipher suite was removed long
ago.
-
Commit messages:
- 8258631: Remove sun.security.jgss.krb5.Krb5Util.getSubject()
Changes: https://git.openjdk.java.net/jdk/pull/1865/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=1865
On Thu, 7 Jan 2021 18:26:12 GMT, Rajan Halade wrote:
> 8039278: console.sh failed Automatically with exit code 1
Marked as reviewed by weijun (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/1981
On Thu, 14 Jan 2021 06:32:37 GMT, Jamil Nimeh wrote:
> This is the security libs portion of the effort to replace
> archaic/non-inclusive words with more neutral terms (see JDK-8253315 for
> details).
>
> Here are the changes covering core libraries code and tests. Terms were
> changed as fol
On Tue, 26 Jan 2021 18:42:02 GMT, Anton Kozlov wrote:
>> Please review the implementation of JEP 391: macOS/AArch64 Port.
>>
>> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and
>> windows/aarch64.
>>
>> Major changes are in:
>> * src/hotspot/cpu/aarch64: support of the
Fix some small errors.
-
Commit messages:
- 8260596: Comment cleanup in BigInteger
Changes: https://git.openjdk.java.net/jdk/pull/2292/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2292&range=00
Issue: https://bugs.openjdk.java.net/browse/JDK-8260596
Stats: 5 line
On Thu, 28 Jan 2021 16:19:41 GMT, Weijun Wang wrote:
> Fix some small errors.
This pull request has now been integrated.
Changeset: 2b166d81
Author: Weijun Wang
URL: https://git.openjdk.java.net/jdk/commit/2b166d81
Stats: 5 lines in 1 file changed: 0 ins; 0 del; 5 mod
8260
On Fri, 18 Dec 2020 19:20:47 GMT, Weijun Wang wrote:
> This fix covers both
>
> - [[macOS]: Remove JNF dependency from
> libosxsecurity/KeystoreImpl.m](https://bugs.openjdk.java.net/browse/JDK-8257858)
> - [[macOS]: Remove JNF dependency from
> libosxkrb5/SCDynamicSt
This fix covers both
- [[macOS]: Remove JNF dependency from
libosxsecurity/KeystoreImpl.m](https://bugs.openjdk.java.net/browse/JDK-8257858)
- [[macOS]: Remove JNF dependency from
libosxkrb5/SCDynamicStoreConfig.m](https://bugs.openjdk.java.net/browse/JDK-8257860)
-
Commit messages
> This fix covers both
>
> - [[macOS]: Remove JNF dependency from
> libosxsecurity/KeystoreImpl.m](https://bugs.openjdk.java.net/browse/JDK-8257858)
> - [[macOS]: Remove JNF dependency from
> libosxkrb5/SCDynamicStoreConfig.m](https://bugs.openjdk.java.net/browse/JDK-8257860
On Fri, 29 Jan 2021 20:51:04 GMT, Phil Race wrote:
>> Weijun Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> same behavior as before -- empty realm map
>
> make/modules/java.security.
On Fri, 29 Jan 2021 22:05:21 GMT, Phil Race wrote:
>> So I should remember how env was retrieved and only detach when it's from
>> `AttachCurrentThreadAsDaemon`? In fact, in my test the plain `GetEnv` has
>> never succeeded and it was always attached.
>
> Yes that is the idea. BTW which thread
> This fix covers both
>
> - [[macOS]: Remove JNF dependency from
> libosxsecurity/KeystoreImpl.m](https://bugs.openjdk.java.net/browse/JDK-8257858)
> - [[macOS]: Remove JNF dependency from
> libosxkrb5/SCDynamicStoreConfig.m](https://bugs.openjdk.java.net/browse/JDK-8257860
> This fix covers both
>
> - [[macOS]: Remove JNF dependency from
> libosxsecurity/KeystoreImpl.m](https://bugs.openjdk.java.net/browse/JDK-8257858)
> - [[macOS]: Remove JNF dependency from
> libosxkrb5/SCDynamicStoreConfig.m](https://bugs.openjdk.java.net/browse/JDK-8257860
> This fix covers both
>
> - [[macOS]: Remove JNF dependency from
> libosxsecurity/KeystoreImpl.m](https://bugs.openjdk.java.net/browse/JDK-8257858)
> - [[macOS]: Remove JNF dependency from
> libosxkrb5/SCDynamicStoreConfig.m](https://bugs.openjdk.java.net/browse/JDK-8257860
On Sat, 30 Jan 2021 00:06:51 GMT, Phil Race wrote:
>> Weijun Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> phil comment
>
> Marked as reviewed by prr (Reviewer).
Added a test. Unfortunately it has t
On Mon, 21 Dec 2020 09:16:11 GMT, Andrey Turbanov
wrote:
>> 8080272 Refactor I/O stream copying to use java.io.InputStream.transferTo
>
> Andrey Turbanov has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8080272: Refactor I/O stream copying
These permissions are needed so that the URIDereferencer is able to read data
from a file system or a network. As the test shows, you still have to grant the
same type of permission to your application.
-
Depends on: https://git.openjdk.java.net/jdk/pull/3181
Commit messages:
- 82
On Tue, 11 May 2021 15:04:25 GMT, Weijun Wang wrote:
> There is a tiny probability that the `Random` objects in the 2 child
> processes might be created at the same nano time and they will always produce
> the same output and the game will never end. This code change explicitly
&
There is a tiny probability that the `Random` objects in the 2 child processes
might be created at the same nano time and they will always produce the same
output and the game will never end. This code change explicitly provides them
with different seeds.
-
Commit messages:
- 8266
Please review this implementation of [JEP
411](https://openjdk.java.net/jeps/411).
The code change is divided into 3 commits. Please review them one by one.
1.
https://github.com/openjdk/jdk/commit/576161d15423f58281e384174d28c9f9be7941a1
The essential change for this JEP, including the `@Depr
On Mon, 17 May 2021 18:23:41 GMT, Weijun Wang wrote:
> Please review this implementation of [JEP
> 411](https://openjdk.java.net/jeps/411).
>
> The code change is divided into 3 commits. Please review them one by one.
>
> 1.
> https://github.c
Please review the test changes for [JEP 411](https://openjdk.java.net/jeps/411).
With JEP 411 and the default value of `-Djava.security.manager` becoming
`disallow`, tests calling `System.setSecurityManager()` need
`-Djava.security.manager=allow` when launched. This PR covers such changes for
On Tue, 18 May 2021 11:12:00 GMT, Daniel Fuchs wrote:
>> Please review the test changes for [JEP
>> 411](https://openjdk.java.net/jeps/411).
>>
>> With JEP 411 and the default value of `-Djava.security.manager` becoming
>> `disallow`, tests calling `System.setSecurityManager()` need
>> `-Dja
On Tue, 18 May 2021 05:48:56 GMT, Alan Bateman wrote:
> The changes look okay but a bit inconsistent on where -Djava...=allow is
> inserted for tests that already set other system properties or other
> parameters. Not a correctness issue, just looks odd in several places, e.g.
>
> test/jdk/jav
On Tue, 18 May 2021 17:36:55 GMT, Alan Bateman wrote:
>> Please review this implementation of [JEP
>> 411](https://openjdk.java.net/jeps/411).
>>
>> The code change is divided into 3 commits. Please review them one by one.
>>
>> 1.
>> https://github.com/openjdk/jdk/commit/576161d15423f58281e3
On Tue, 18 May 2021 18:38:52 GMT, Weijun Wang wrote:
>> src/java.base/share/classes/java/security/AccessController.java line 877:
>>
>>> 875: @CallerSensitive
>>> 876: public static T doPrivileged(PrivilegedExcept
system
> property is now "disallow", most of the tests calling
> `System.setSecurityManager()` need to launched with
> `-Djava.security.manager=allow`. This is covered in a different PR at
> https://github.com/openjdk/jdk/pull/4071.
Weijun Wang has u
; permissionTests}/DriverManagerPermissionsTests.java (93%)
> rename test/jdk/javax/sql/{testng/test/rowset/spi =>
> permissionTests}/SyncFactoryPermissionsTests.java (95%)
> ```
>
> The source change for JEP 411 is at https://github.com/openjdk/jdk/pull/4073.
Weijun Wang has updated t
On Tue, 18 May 2021 21:21:45 GMT, Weijun Wang wrote:
>> Please review this implementation of [JEP
>> 411](https://openjdk.java.net/jeps/411).
>>
>> The code change is divided into 3 commits. Please review them one by one.
>>
>> 1.
>
notations and javadoc tags, build, compiler,
> core-libs, hotspot, i18n, jmx, net, nio, security, and serviceability are
> reviewed. Rest are 2d, awt, beans, sound, and swing.
Weijun Wang has updated the pull request incrementally with one additional
commit since the last revision:
fixi
On Wed, 19 May 2021 18:26:25 GMT, Phil Race wrote:
>> Weijun Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fixing awt/datatransfer/DataFlavor/DataFlavorRemoteTest.java
>
> src/java.desktop/share/c
On Wed, 19 May 2021 18:39:10 GMT, Weijun Wang wrote:
>> src/java.desktop/share/classes/java/awt/Container.java line 97:
>>
>>> 95: * @since 1.0
>>> 96: */
>>> 97: @SuppressWarnings("removal")
>>
>> Same issue as with Component.
On Wed, 19 May 2021 18:44:06 GMT, Weijun Wang wrote:
>> Similar as the one above, it's because of
>>
>> static {
>> // Don't lazy-read because every app uses invalidate()
>> isJavaAwtSmartInvalidate = AccessController.doPrivileged(
On Wed, 19 May 2021 19:31:24 GMT, Phil Race wrote:
>> This happens when a deprecated method is called inside a static block. The
>> annotation can only be added to a declaration and here it must be the whole
>> class. The call in this file is
>>
>> s = java.security.AccessController.do
On Wed, 19 May 2021 22:04:57 GMT, Phil Race wrote:
>> Correct, there are ways to modify the code to make it more
>> annotation-friendly. We thought about whether it's good to do it before
>> adding the annotations or after it. Our decision now is to do it after
>> because it will be more easy
On Wed, 19 May 2021 23:50:04 GMT, Phil Race wrote:
>> I just made it P3 (P4 was the default value), and I will target it to 17
>> once JEP 411 is targeted 17. But I think it's probably not a good idea to
>> include it inside *this* PR. There are some middle ground where it's
>> debatable if a
On Thu, 20 May 2021 02:06:46 GMT, Weijun Wang wrote:
>> Well .. as an enhancement (P3 or otherwise) I can see it being dropped and
>> definitely if it misses the fork,
>> and I don't get why you can't do it here. And if it isn't done the JEP isn't
>>
The code change refactors classes that have a `SuppressWarnings("removal")`
annotation that covers more than 50KB of code. The big annotation is often
quite faraway from the actual deprecated API usage it is suppressing, and with
the annotation covering too big a portion it's easy to call other
cated method call to a new local
> variable and add annotation on the declaration, and then assign that value to
> the original l-value.
> 3. Put declaration and assignment into a single statement if possible.
> 4. Rewrite code to achieve #3 above.
Weijun Wang has updated the pull requ
On Fri, 21 May 2021 18:26:48 GMT, Phil Race wrote:
>> Weijun Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> adjust order of VM options
>
> test/jdk/java/awt/FontClass/CreateFont/fileaccess/FontFile
; permissionTests}/DriverManagerPermissionsTests.java (93%)
> rename test/jdk/javax/sql/{testng/test/rowset/spi =>
> permissionTests}/SyncFactoryPermissionsTests.java (95%)
> ```
>
> The source change for JEP 411 is at https://github.com/openjdk/jdk/pull/4073.
Weijun Wang has updated the
On Fri, 21 May 2021 15:35:05 GMT, Daniel Fuchs wrote:
>> Weijun Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> typo on windows
>
> src/java.base/share/classes/sun/net/ftp/impl/FtpC
On Fri, 21 May 2021 15:37:48 GMT, Daniel Fuchs wrote:
>> Weijun Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> typo on windows
>
> src/java.base/share/classes/sun/net/ftp/impl/FtpClient.java line
cated method call to a new local
> variable and add annotation on the declaration, and then assign that value to
> the original l-value.
> 3. Put declaration and assignment into a single statement if possible.
> 4. Rewrite code to achieve #3 above.
Weijun Wang has updated the pull requ
On Fri, 21 May 2021 20:43:05 GMT, Phil Race wrote:
> I haven't seen any response to this comment I made a couple of days ago and I
> suspect it got missed
>
> > Weijun Wang has updated the pull request incrementally with one additional
> > commit since the las
notations and javadoc tags, build, compiler,
> core-libs, hotspot, i18n, jmx, net, nio, security, and serviceability are
> reviewed. Rest are 2d, awt, beans, sound, and swing.
Weijun Wang has updated the pull request incrementally with one additional
commit since the last revi
On Sun, 23 May 2021 16:35:43 GMT, Sean Mullan wrote:
>> src/java.base/share/classes/java/lang/SecurityManager.java line 104:
>>
>>> 102: * method will throw an {@code UnsupportedOperationException}). If the
>>> 103: * {@systemProperty java.security.manager} system property is set to
>>> the
>
; permissionTests}/DriverManagerPermissionsTests.java (93%)
> rename test/jdk/javax/sql/{testng/test/rowset/spi =>
> permissionTests}/SyncFactoryPermissionsTests.java (95%)
> ```
>
> The source change for JEP 411 is at https://github.com/openjdk/jdk/pull/4073.
Weijun Wang has updated the pu
On Mon, 17 May 2021 17:51:36 GMT, Weijun Wang wrote:
> Please review the test changes for [JEP
> 411](https://openjdk.java.net/jeps/411).
>
> With JEP 411 and the default value of `-Djava.security.manager` becoming
> `disallow`, tests calling `System.setSecurityM
On Mon, 24 May 2021 09:00:07 GMT, Daniel Fuchs wrote:
> Thanks for taking in my suggestions for FtpClient. I have also reviewed the
> changes to java.util.logging and JMX. I wish there was a way to handle
> doPrivileged returning void more nicely. Maybe component maintainers will be
> able to
notations and javadoc tags, build, compiler,
> core-libs, hotspot, i18n, jmx, net, nio, security, and serviceability are
> reviewed. Rest are 2d, awt, beans, sound, and swing.
Weijun Wang has updated the pull request with a new target base due to a merge
or a rebase. The pull request
On Thu, 27 May 2021 20:16:25 GMT, Weijun Wang wrote:
>> Please review this implementation of [JEP
>> 411](https://openjdk.java.net/jeps/411).
>>
>> The code change is divided into 3 commits. Please review them one by one.
>>
>> 1.
>
On Thu, 27 May 2021 17:42:56 GMT, Phil Race wrote:
>> Weijun Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> update FtpClient.java
>
> src/java.desktop/share/classes/java/awt/Component.java line 63
On Fri, 28 May 2021 03:12:35 GMT, Phil Race wrote:
>> There *is* a tiny refactoring here: a new variable `s2` is introduced so the
>> 2nd `doPrivileged` call on line 636 is now also in a declaration statement
>> (for `s2`) and therefore annotatable. Without this I cannot add the
>> annotation
notations and javadoc tags, build, compiler,
> core-libs, hotspot, i18n, jmx, net, nio, security, and serviceability are
> reviewed. Rest are 2d, awt, beans, sound, and swing.
Weijun Wang has updated the pull request incrementally with one additional
commit since the last revisi
On Mon, 31 May 2021 15:02:57 GMT, Weijun Wang wrote:
>> Please review this implementation of [JEP
>> 411](https://openjdk.java.net/jeps/411).
>>
>> The code change is divided into 3 commits. Please review them one by one.
>>
>> 1.
>
notations and javadoc tags, build, compiler,
> core-libs, hotspot, i18n, jmx, net, nio, security, and serviceability are
> reviewed. Rest are 2d, awt, beans, sound, and swing.
Weijun Wang has updated the pull request incrementally with one additional
commit since the last revision:
r
notations and javadoc tags, build, compiler,
> core-libs, hotspot, i18n, jmx, net, nio, security, and serviceability are
> reviewed. Rest are 2d, awt, beans, sound, and swing.
Weijun Wang has updated the pull request with a new target base due to a merge
or a rebase. The pull request now co
1 - 100 of 599 matches
Mail list logo
