> This is an early review of changes to better model JVM access flags, that is
> "modifiers" like public, protected, etc. but explicitly at a VM level.
>
> Language level modifiers and JVM level access flags are closely related, but
> distinct. There are concepts that overlap in the two domains
> This is an early review of changes to better model JVM access flags, that is
> "modifiers" like public, protected, etc. but explicitly at a VM level.
>
> Language level modifiers and JVM level access flags are closely related, but
> distinct. There are concepts that overlap in the two domains
Run a script extracting icons from executables as PowerShell command line
rather than a script
-
Commit messages:
- 8287401: jpackage tests failing on Windows due to powershell issue
Changes: https://git.openjdk.org/jdk19/pull/26/files
Webrev: https://webrevs.openjdk.org/?repo=jdk
On Wed, 15 Jun 2022 21:30:24 GMT, Maurizio Cimadamore
wrote:
>> Avoid doing MH creation when initializing `StringConcatFactory` by lazily
>> initializing to a `@Stable` field instead.
>
> src/java.base/share/classes/java/lang/invoke/StringConcatFactory.java line
> 729:
>
>> 727: Metho
On Wed, 15 Jun 2022 18:06:44 GMT, Maurizio Cimadamore
wrote:
> This is a JDK 19 clone of: https://github.com/openjdk/jdk/pull/9017
Already reviewed in the mainline repo.
-
Marked as reviewed by jvernee (Reviewer).
PR: https://git.openjdk.org/jdk19/pull/22
On Wed, 15 Jun 2022 21:24:04 GMT, Maurizio Cimadamore
wrote:
> While playing with the API, I've realized that some of the out of bound error
> messgaes come out incorrectly.
>
> This is because the bound check is performed as follows (to avoid overflow):
>
>
> Objects.checkIndex(offset, this
On Tue, 14 Jun 2022 15:16:27 GMT, Claes Redestad wrote:
> Avoid doing MH creation when initializing `StringConcatFactory` by lazily
> initializing to a `@Stable` field instead.
src/java.base/share/classes/java/lang/invoke/StringConcatFactory.java line 729:
> 727: MethodHandle base = PR
While playing with the API, I've realized that some of the out of bound error
messgaes come out incorrectly.
This is because the bound check is performed as follows (to avoid overflow):
Objects.checkIndex(offset, this.length - length + 1);
So, if out-of-bounds access is detected, the resultin
On Tue, 14 Jun 2022 15:16:27 GMT, Claes Redestad wrote:
> Avoid doing MH creation when initializing `StringConcatFactory` by lazily
> initializing to a `@Stable` field instead.
This pull request has now been integrated.
Changeset: 6d595614
Author:Claes Redestad
URL:
https://git.ope
On Tue, 14 Jun 2022 15:16:27 GMT, Claes Redestad wrote:
> Avoid doing MH creation when initializing `StringConcatFactory` by lazily
> initializing to a `@Stable` field instead.
Thanks for reviewing!
-
PR: https://git.openjdk.org/jdk/pull/9154
Hi,
They are useful as documentation on the interface to native, making them
static would be constructive.
Thanks, Roger
On 6/15/22 2:58 PM, Andrey Turbanov wrote:
Hello.
I recently found a couple of unused constants in
java.lang.ProcessHandleImpl class.
They seem to serve only documentatio
On Tue, 14 Jun 2022 16:28:37 GMT, Paul Sandoz wrote:
> Update the code examples in the api notes of Long::compress/expand. Some
> constants need to be explicitly long values.
This pull request has now been integrated.
Changeset: 395aea30
Author:Paul Sandoz
URL:
https://git.openjdk.
On Tue, 14 Jun 2022 12:19:29 GMT, David Holmes wrote:
> @AlanBateman sorry I missed your statement "although these updates aren't
> strictly needed".
Right, I decided it would be better to just update them rather than leaving
them at _10. For the management agent then JNI_OnLoad returning any
Hello.
I recently found a couple of unused constants in
java.lang.ProcessHandleImpl class.
They seem to serve only documentation purposes. I'm I right?
If so, I think it's better to remove them or at least make them static.
/* The start time should match any value.
* Typically, this is because t
This is a JDK 19 clone of: https://github.com/openjdk/jdk/pull/9017
-
Commit messages:
- Add missing files
- Initial push
Changes: https://git.openjdk.org/jdk19/pull/22/files
Webrev: https://webrevs.openjdk.org/?repo=jdk19&pr=22&range=00
Issue: https://bugs.openjdk.org/browse/JD
On Fri, 3 Jun 2022 15:47:21 GMT, Maurizio Cimadamore
wrote:
> This is a cleanup of the memory session implementation. The main new concept
> is that `MemorySessionImpl` is split into two parts: there is an
> implementation of memory session and then there is a state abstraction
> (`MemorySess
> This is a cleanup of the memory session implementation. The main new concept
> is that `MemorySessionImpl` is split into two parts: there is an
> implementation of memory session and then there is a state abstraction
> (`MemorySessionImpl.State`). This allows to share the state across multiple
On Tue, 7 Jun 2022 13:00:37 GMT, Maurizio Cimadamore
wrote:
>> This is a cleanup of the memory session implementation. The main new concept
>> is that `MemorySessionImpl` is split into two parts: there is an
>> implementation of memory session and then there is a state abstraction
>> (`Memory
> This is a cleanup of the memory session implementation. The main new concept
> is that `MemorySessionImpl` is split into two parts: there is an
> implementation of memory session and then there is a state abstraction
> (`MemorySessionImpl.State`). This allows to share the state across multiple
On Mon, 13 Jun 2022 22:37:52 GMT, Mandy Chung wrote:
>> Xue-Lei Andrew Fan has updated the pull request with a new target base due
>> to a merge or a rebase. The pull request now contains ten commits:
>>
>> - Merge
>> - Merge master
>> - Merge
>> - add timeout parameter
>> - rollback is no
> This is a follow up update per comments in [JDK-8287384
> PR](https://github.com/openjdk/jdk/pull/8907). The tier1 and tier2 test in
> open part looks good to me. Please help to run Mach5 just case the closed
> test cases are impacted.
Xue-Lei Andrew Fan has updated the pull request increme
On Mon, 13 Jun 2022 22:21:18 GMT, Mandy Chung wrote:
>> test/lib/jdk/test/lib/util/ForceGC.java line 44:
>>
>>> 42: */
>>> 43: public static boolean wait(BooleanSupplier booleanSupplier) {
>>> 44: return wait(booleanSupplier, 1L);
>>
>> For the max waiting time, instead of
On Wed, 15 Jun 2022 14:55:56 GMT, Jorn Vernee wrote:
> I think this looks good overall, but please try to limit the accessibility of
> the methods in `State`.
Thanks, I'll take another look
-
PR: https://git.openjdk.org/jdk/pull/9017
23 matches
Mail list logo
