On Fri, 22 Jul 2022 20:51:59 GMT, Brent Christian wrote:
>> Please review this change to replace the finalizer in
>> `AbstractLdapNamingEnumeration` with a Cleaner.
>>
>> The pieces of state required for cleanup (`LdapCtx homeCtx`, `LdapResult
>> res`, and `LdapClient enumClnt`) are moved to a
On Thu, 28 Jul 2022 16:11:12 GMT, Ao Qi wrote:
> `vmTestbase/nsk/jvmti/GetThreadInfo/thrinfo001/TestDescription.java`,
> `vmTestbase/nsk/jvmti/RedefineClasses/StressRedefineVirtual/StressRedefineVirtual.java`,
> `java/beans/XMLDecoder/8028054/TestConstructorFinder.java` and
> `java/beans/XMLDe
On Tue, 19 Jul 2022 12:52:11 GMT, Aleksey Shipilev wrote:
> Some of the newly added Loom tests are long-running, and thus they delay the
> completion of otherwise very parallel tier1/jdk_loom. We can parallelize them
> a bit better to avoid these testing stalls.
>
> Improvements on Linux x86_
On Tue, 19 Jul 2022 12:52:11 GMT, Aleksey Shipilev wrote:
> Some of the newly added Loom tests are long-running, and thus they delay the
> completion of otherwise very parallel tier1/jdk_loom. We can parallelize them
> a bit better to avoid these testing stalls.
>
> Improvements on Linux x86_
> Some of the newly added Loom tests are long-running, and thus they delay the
> completion of otherwise very parallel tier1/jdk_loom. We can parallelize them
> a bit better to avoid these testing stalls.
>
> Improvements on Linux x86_64, TR 3970X, `jdk_loom hotspot_loom`:
>
>
> # release bef
On Mon, 1 Aug 2022 07:43:57 GMT, Alan Bateman wrote:
> No objection to changing these tests.
Did the changes in new commit.
-
PR: https://git.openjdk.org/jdk/pull/9554
> `vmTestbase/nsk/jvmti/GetThreadInfo/thrinfo001/TestDescription.java`,
> `vmTestbase/nsk/jvmti/RedefineClasses/StressRedefineVirtual/StressRedefineVirtual.java`,
> `java/beans/XMLDecoder/8028054/TestConstructorFinder.java` and
> `java/beans/XMLDecoder/8028054/TestMethodFinder.java` are added or
On Mon, 1 Aug 2022 07:18:52 GMT, Alan Bateman wrote:
>> `vmTestbase/nsk/jvmti/GetThreadInfo/thrinfo001/TestDescription.java`,
>> `vmTestbase/nsk/jvmti/RedefineClasses/StressRedefineVirtual/StressRedefineVirtual.java`,
>> `java/beans/XMLDecoder/8028054/TestConstructorFinder.java` and
>> `java/b
On Mon, 1 Aug 2022 08:37:11 GMT, Aleksey Shipilev wrote:
>> Some of the newly added Loom tests are long-running, and thus they delay the
>> completion of otherwise very parallel tier1/jdk_loom. We can parallelize
>> them a bit better to avoid these testing stalls.
>>
>> Improvements on Linux
8289562: Change bugs.java.com and bugreport.java.com URL's to https
-
Commit messages:
- Merge branch 'openjdk:master' into master
- changed the hrl from http to https JDK-8289562
Changes: https://git.openjdk.org/jdk/pull/9445/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr
See bug report for reproducer and error message. The warning looks quite
superficial, and I initially suspected that it complains about `int len =
(int)strlen(str)` cast of `size_t`. But what is confusing is nearly the similar
code in `newStringCp1252` apparently does not produce the warning:
On Sun, 31 Jul 2022 22:05:15 GMT, David Holmes wrote:
>> Please review this change to fix JDK-8291360. This fix adds entry points
>> getClassFileVersion() and getClassAccessFlagsRaw() to class java.lang.Class.
>> The new entry points return the current class's class file version and its
>> r
On Fri, 29 Jul 2022 16:49:36 GMT, Roger Riggs wrote:
> The test java/lang/ProcessBuilder/PipelineLeaksFD.java fails intermittently,
> usually associated with fastdebug and -Xcomp.
> It reports extra file descriptors are open that not expected.
> The test of pipelines did not explicitly use or cl
On Tue, 26 Jul 2022 20:52:20 GMT, Naoto Sato wrote:
> > I would suggest deferring the APIs for `getTransformedContentFields()` and
> > `getTransformedContentSource()`.
>
> OK, removed those two convenient APIs.
I expected much of the complexity of parsing and storing content transformed
exten
On Sat, 30 Jul 2022 07:45:31 GMT, David Holmes wrote:
>> It is usual for the Java code to do such checks and throw exceptions, so
>> that the VM assumes it is correct and only asserts incase something has been
>> missed on the Java side.
>
> Though in this case the Java code has defined behavio
On Mon, 1 Aug 2022 08:37:11 GMT, Aleksey Shipilev wrote:
>> Some of the newly added Loom tests are long-running, and thus they delay the
>> completion of otherwise very parallel tier1/jdk_loom. We can parallelize
>> them a bit better to avoid these testing stalls.
>>
>> Improvements on Linux
On Tue, 19 Jul 2022 12:52:11 GMT, Aleksey Shipilev wrote:
> Some of the newly added Loom tests are long-running, and thus they delay the
> completion of otherwise very parallel tier1/jdk_loom. We can parallelize them
> a bit better to avoid these testing stalls.
>
> Improvements on Linux x86_
On Mon, 11 Jul 2022 08:04:20 GMT, Joe wrote:
> 8289562: Change bugs.java.com and bugreport.java.com URL's to https
It is a trivial change and looks good to me (I am not a reviewer).
-
PR: https://git.openjdk.org/jdk/pull/9445
> See bug report for reproducer and error message. The warning looks quite
> superficial, and I initially suspected that it complains about `int len =
> (int)strlen(str)` cast of `size_t`. But what is confusing is nearly the
> similar code in `newStringCp1252` apparently does not produce the wa
On Sun, 31 Jul 2022 22:22:24 GMT, David Holmes wrote:
>> Please review this change to fix JDK-8291360. This fix adds entry points
>> getClassFileVersion() and getClassAccessFlagsRaw() to class java.lang.Class.
>> The new entry points return the current class's class file version and its
>> r
On Mon, 1 Aug 2022 12:02:19 GMT, Ao Qi wrote:
> Since these two kinds (`jvmti` and `XMLDecoder` tests) of the fix are a
> little different, should I split this issue into two?
I think it would be better to split them.
-
PR: https://git.openjdk.org/jdk/pull/9677
On Mon, 1 Aug 2022 06:07:29 GMT, Alan Bateman wrote:
> [...] I think will require a small update to the javadoc to make it clear
> that both an empty syntax and empty pattern are illegal.
I read the existing specification
* @throws IllegalArgumentException
* If the paramete
> `vmTestbase/nsk/jvmti/GetThreadInfo/thrinfo001/TestDescription.java`,
> `vmTestbase/nsk/jvmti/RedefineClasses/StressRedefineVirtual/StressRedefineVirtual.java`,
> `java/beans/XMLDecoder/8028054/TestConstructorFinder.java` and
> `java/beans/XMLDecoder/8028054/TestMethodFinder.java` are added or
On Mon, 1 Aug 2022 15:54:47 GMT, Alan Bateman wrote:
> > Since these two kinds (`jvmti` and `XMLDecoder` tests) of the fix are a
> > little different, should I split this issue into two?
>
> I think it would be better to split them.
XMLDecoder tests are filed: https://bugs.openjdk.org/browse/J
On Mon, 25 Jul 2022 22:04:31 GMT, Bill Huang wrote:
> Provided coverage for XPath node set functions. Functions include:
> - id()
> - last()
> - position()
> - count()
> - local-name()
> - namespace-uri()
> - name()
This pull request has now been integrated.
Changeset: 57bf603b
Author:Bill
On Fri, 29 Jul 2022 21:21:43 GMT, Roger Riggs wrote:
>> Please review this change to fix JDK-8291360. This fix adds entry points
>> getClassFileVersion() and getClassAccessFlagsRaw() to class java.lang.Class.
>> The new entry points return the current class's class file version and its
>> ra
On Fri, 29 Jul 2022 18:13:25 GMT, Alisen Chung wrote:
>> open l10n msg drop
>> All tests passed.
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the last revision:
>
> added comments in CurrencyNames root in base, moved US CurrencyNames back
> t
On Mon, 1 Aug 2022 14:04:22 GMT, Roger Riggs wrote:
>> Though in this case the Java code has defined behaviour for array types so
>> it is correct for the VM to assume this is not an array type and to assert
>> if it is.
>
> My companion question was whether the native code can for efficiently
On Thu, 28 Jul 2022 20:43:31 GMT, Joe Darcy wrote:
>> JDK-8289106: Add model of class file versions to core reflection
>
> Joe Darcy has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Appease jcheck.
src/java.base/share/classes/java/lang/refl
On Mon, 1 Aug 2022 16:44:22 GMT, Harold Seigel wrote:
>> My companion question was whether the native code can for efficiently map
>> from array class to component type than Java.
>
> I don't know whether Java or the JVM is faster but I would rather keep this
> code in Java so that I don't have
On Mon, 1 Aug 2022 16:38:48 GMT, Harold Seigel wrote:
>> test/hotspot/jtreg/runtime/ClassFile/classAccessFlagsRaw.jcod line 25:
>>
>>> 23: */
>>> 24:
>>> 25: // Class with ACC_SUPER set
>>
>> Can these classes be defined more succinctly either in Java or .asm?
>
> The jcod test files are rela
On Thu, 21 Jul 2022 19:58:50 GMT, Brian Burkhalter wrote:
>> For a `String` “s”, `s.indexOf(int)` can never return a value `>=
>> s.length()` so change the check
>>
>> int pos = syntaxAndInput.indexOf(':');
>> if (pos <= 0 || pos == syntaxAndInput.length())
>>
>> to
>>
>>
On Mon, 1 Aug 2022 16:13:49 GMT, Brian Burkhalter wrote:
> I read the existing specification
>
> ```
> * @throws IllegalArgumentException
> * If the parameter does not take the form: {@code
> syntax:pattern}
> ```
>
> as covering both cases, but I suppose one could explicit
I would like to contribute an optimized version of
`StackTraceElement#toString()` that uses a single StringBuilder throughout
creation to avoid intermediate `String` allocations.
`StackTraceElement#toString()` is used in a number of JDK code paths including
`Throwable#printStackTrace()`, as wel
On Thu, 28 Jul 2022 15:42:15 GMT, Quan Anh Mai wrote:
>> I would like to contribute an optimized version of
>> `StackTraceElement#toString()` that uses a single StringBuilder throughout
>> creation to avoid intermediate `String` allocations.
>> `StackTraceElement#toString()` is used in a numbe
On Mon, 1 Aug 2022 16:20:25 GMT, David Schlosnagle wrote:
>> If the objective of this patch is to optimise
>> `StackTraceElement::toString()`, then I would suggest the most efficient
>> method of calculating the length and encoding of the result, filling the
>> backing buffer then using the pa
On Wed, 27 Jul 2022 22:56:39 GMT, David Schlosnagle wrote:
> I would like to contribute an optimized version of
> `StackTraceElement#toString()` that uses a single StringBuilder throughout
> creation to avoid intermediate `String` allocations.
> `StackTraceElement#toString()` is used in a numb
On Thu, 28 Jul 2022 13:07:01 GMT, David Schlosnagle wrote:
>> src/java.base/share/classes/java/lang/StackTraceElement.java line 400:
>>
>>> 398: dest.append(fileName)
>>> 399: .append(':')
>>> 400: .append(Integer.toString(lineNumbe
On Wed, 27 Jul 2022 22:56:39 GMT, David Schlosnagle wrote:
> I would like to contribute an optimized version of
> `StackTraceElement#toString()` that uses a single StringBuilder throughout
> creation to avoid intermediate `String` allocations.
> `StackTraceElement#toString()` is used in a numb
On Thu, 28 Jul 2022 13:12:57 GMT, Сергей Цыпанов wrote:
>> `Appendable` does not currently have an `append(int)` method on the
>> interface, though `StringBuilder` does. We could add it to `Appendable` via
>> default method if so desired:
>>
>>
>> default Appendable append(int value) {
>>
On Thu, 28 Jul 2022 14:33:39 GMT, Сергей Цыпанов wrote:
>> If we go with the proposal above to make `appendTo(Appendable)` package
>> visible so that `Throwable.printStackTrace()` can benefit from this as well,
>> we would need to keep this as Appendable, otherwise I agree we should just
>> in
On Mon, 1 Aug 2022 17:08:12 GMT, Сергей Цыпанов wrote:
>> I would like to contribute an optimized version of
>> `StackTraceElement#toString()` that uses a single StringBuilder throughout
>> creation to avoid intermediate `String` allocations.
>> `StackTraceElement#toString()` is used in a numb
On Thu, 28 Jul 2022 14:38:50 GMT, Carter Kozak wrote:
>> `Throwable.printStackTrace()` will use `StringBuilder` as well, won't it?
>
> I don't think so, it appends directly do something like System.err (default)
> or another PrintStream/PrintWriter without fully holding the string value on
> he
On Thu, 28 Jul 2022 13:45:53 GMT, David Schlosnagle wrote:
>> I think in this case it's better to specify `StringBuilder` instead of
>> `Appendable`, because the method is private and you'd hardly ever pass there
>> anything different from SB.
>
> If we go with the proposal above to make `appen
On Thu, 28 Jul 2022 01:23:53 GMT, David Schlosnagle wrote:
>> src/java.base/share/classes/java/lang/StackTraceElement.java line 374:
>>
>>> 372: * @throws IOException If an I/O error occurs
>>> 373: */
>>> 374: private void appendTo(Appendable dest) throws IOException {
>>
>> Perh
On Thu, 28 Jul 2022 00:48:32 GMT, Carter Kozak wrote:
>> I would like to contribute an optimized version of
>> `StackTraceElement#toString()` that uses a single StringBuilder throughout
>> creation to avoid intermediate `String` allocations.
>> `StackTraceElement#toString()` is used in a numbe
> I would like to contribute an optimized version of
> `StackTraceElement#toString()` that uses a single StringBuilder throughout
> creation to avoid intermediate `String` allocations.
> `StackTraceElement#toString()` is used in a number of JDK code paths
> including `Throwable#printStackTrace(
On Thu, 21 Jul 2022 19:58:50 GMT, Brian Burkhalter wrote:
>> For a `String` “s”, `s.indexOf(int)` can never return a value `>=
>> s.length()` so change the check
>>
>> int pos = syntaxAndInput.indexOf(':');
>> if (pos <= 0 || pos == syntaxAndInput.length())
>>
>> to
>>
>>
On Wed, 27 Jul 2022 22:56:39 GMT, David Schlosnagle wrote:
> I would like to contribute an optimized version of
> `StackTraceElement#toString()` that uses a single StringBuilder throughout
> creation to avoid intermediate `String` allocations.
> `StackTraceElement#toString()` is used in a numb
On Mon, 1 Aug 2022 17:04:51 GMT, Roger Riggs wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Appease jcheck.
>
> src/java.base/share/classes/java/lang/reflect/AccessFlag.java line 101:
>
>> 99: PUBLIC(Modifier.PU
On Mon, 1 Aug 2022 17:24:48 GMT, David Schlosnagle wrote:
>> src/java.base/share/classes/java/lang/StackTraceElement.java line 366:
>>
>>> 364: if (!dropClassLoaderName() && classLoaderName != null &&
>>> !classLoaderName.isEmpty()) {
>>> 365: prefixClassLoader = true;
>>> 3
> Please review this change to fix JDK-8291360. This fix adds entry points
> getClassFileVersion() and getClassAccessFlagsRaw() to class java.lang.Class.
> The new entry points return the current class's class file version and its
> raw access flags.
>
> The fix was tested by running Mach5 ti
On Mon, 1 Aug 2022 17:35:05 GMT, David Schlosnagle wrote:
>> I would like to contribute an optimized version of
>> `StackTraceElement#toString()` that uses a single StringBuilder throughout
>> creation to avoid intermediate `String` allocations.
>> `StackTraceElement#toString()` is used in a n
On Mon, 1 Aug 2022 18:51:10 GMT, Harold Seigel wrote:
>> Please review this change to fix JDK-8291360. This fix adds entry points
>> getClassFileVersion() and getClassAccessFlagsRaw() to class java.lang.Class.
>> The new entry points return the current class's class file version and its
>> r
On Sun, 31 Jul 2022 22:02:11 GMT, David Holmes wrote:
>> Harold Seigel has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Improved tests, added mulit-dimensional array tests, simplified new
>> java.lang.Class API's
>
> src/hotspot/share/in
On Fri, 29 Jul 2022 21:08:43 GMT, Roger Riggs wrote:
>> Harold Seigel has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Improved tests, added mulit-dimensional array tests, simplified new
>> java.lang.Class API's
>
> test/hotspot/jtreg/ru
On Mon, 1 Aug 2022 17:32:28 GMT, Roger Riggs wrote:
> The existing code downstream of the check handles an empty glob or regex
> pattern as matching the empty string. If I read it correctly, it will now
> throw an exception instead of not matching. It might be safer to not change
> that behavi
On Sat, 30 Jul 2022 20:52:49 GMT, Naoto Sato wrote:
>> This PR is to propose supporting the `T` extension to the BCP 47 to which
>> `java.util.Locale` class conforms. There are two extensions to the BCP 47,
>> one is `Unicode Locale Extension` which has been supported since JDK7, the
>> other
On Sat, 30 Jul 2022 20:52:49 GMT, Naoto Sato wrote:
>> This PR is to propose supporting the `T` extension to the BCP 47 to which
>> `java.util.Locale` class conforms. There are two extensions to the BCP 47,
>> one is `Unicode Locale Extension` which has been supported since JDK7, the
>> other
On Mon, 1 Aug 2022 21:27:47 GMT, Steven R. Loomis wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Use `assertThrows`
>
> test/jdk/java/util/Locale/bcp47/TExtensionTests.java line 80:
>
>> 78: return new Obje
On Tue, 22 Sep 2020 20:19:21 GMT, Alexey Bakhtin wrote:
>> Hi,
>>
>> Plaese review JDK-8245527 fix which implements LDAP Channel Binding support
>> for Java GSS/Kerberos.
>> Initial review is available at core-devs:
>> https://mail.openjdk.java.net/pipermail/core-libs-dev/2020-August/068197.ht
On Mon, 11 Jul 2022 08:04:20 GMT, Joe wrote:
> 8289562: Change bugs.java.com and bugreport.java.com URL's to https
Looks fine to me. However the langtools / javadoc folks seem like they should
be primary reviewers since it is mostly messages from the tools.
-
Marked as reviewed by
On Mon, 1 Aug 2022 17:37:36 GMT, ExE Boss wrote:
>> src/java.base/share/classes/java/lang/reflect/AccessFlag.java line 101:
>>
>>> 99: PUBLIC(Modifier.PUBLIC, true,
>>> 100:Set.of(Location.CLASS, Location.FIELD, Location.METHOD,
>>> 101: Location.INNER_CLASS)) {
On Fri, 6 May 2022 22:05:35 GMT, liach wrote:
>> Explicitly implement `remove` and `replace` in `IdentityHashMap` to compare
>> values by identity. Updated API documentation of these two methods
>> ([Preview](https://cr.openjdk.java.net/~liach/8178355/IdentityHashMap.html#remove(java.lang.Objec
On Mon, 1 Aug 2022 17:35:05 GMT, David Schlosnagle wrote:
>> I would like to contribute an optimized version of
>> `StackTraceElement#toString()` that uses a single StringBuilder throughout
>> creation to avoid intermediate `String` allocations.
>> `StackTraceElement#toString()` is used in a n
> `vmTestbase/nsk/jvmti/GetThreadInfo/thrinfo001/TestDescription.java` and
> `vmTestbase/nsk/jvmti/RedefineClasses/StressRedefineVirtual/StressRedefineVirtual.java`
> are added or modified by
> [JDK-8284161](https://bugs.openjdk.org/browse/JDK-8284161), and they are
> failed if Loom or JVMTI is
On Mon, 1 Aug 2022 18:51:10 GMT, Harold Seigel wrote:
>> Please review this change to fix JDK-8291360. This fix adds entry points
>> getClassFileVersion() and getClassAccessFlagsRaw() to class java.lang.Class.
>> The new entry points return the current class's class file version and its
>> r
On Mon, 1 Aug 2022 13:26:29 GMT, Harold Seigel wrote:
>> src/java.base/share/classes/java/lang/Class.java line 4698:
>>
>>> 4696: *
>>> 4697: * If the class is an array type then the access flags of the
>>> component type is
>>> 4698: * returned. If the class is a primitive then
On Mon, 1 Aug 2022 13:30:21 GMT, Harold Seigel wrote:
>> src/hotspot/share/prims/jvm.cpp line 4064:
>>
>>> 4062: assert(c->is_instance_klass(), "must be");
>>> 4063: InstanceKlass* ik = InstanceKlass::cast(c);
>>> 4064: return (ik->minor_version() << 16) | ik->major_version();
>>
>> I'm c
On Mon, 1 Aug 2022 18:51:31 GMT, Harold Seigel wrote:
>> test/hotspot/jtreg/runtime/ClassFile/ClassFileVersionTest.java line 45:
>>
>>> 43: if (ver != expectedResult) {
>>> 44: throw new RuntimeException(
>>> 45: "expected " + expectedResult + ", got " + ver +
On Tue, 2 Aug 2022 06:32:09 GMT, Ao Qi wrote:
>> `vmTestbase/nsk/jvmti/GetThreadInfo/thrinfo001/TestDescription.java` and
>> `vmTestbase/nsk/jvmti/RedefineClasses/StressRedefineVirtual/StressRedefineVirtual.java`
>> are added or modified by
>> [JDK-8284161](https://bugs.openjdk.org/browse/JDK-
71 matches
Mail list logo
