Re: RFR: 8293540: [Metrics] Incorrectly detected resource limits with additional cgroup fs mounts

2022-09-15 Thread Severin Gehwolf
On Tue, 13 Sep 2022 13:06:10 GMT, Severin Gehwolf wrote: > Similar issue to the hotspot change discussed in > https://bugs.openjdk.org/browse/JDK-8293472. The Java metrics implementation > may get the resource limits wrong if there are additional cgroup fs mounts. > Apparently that's more comm

Re: RFR: 8293540: [Metrics] Incorrectly detected resource limits with additional cgroup fs mounts [v2]

2022-09-15 Thread Severin Gehwolf
> Similar issue to the hotspot change discussed in > https://bugs.openjdk.org/browse/JDK-8293472. The Java metrics implementation > may get the resource limits wrong if there are additional cgroup fs mounts. > Apparently that's more common than one might think. I've reproduced this with > these

Re: RFR: 8293540: [Metrics] Incorrectly detected resource limits with additional cgroup fs mounts [v3]

2022-09-15 Thread Severin Gehwolf
> Similar issue to the hotspot change discussed in > https://bugs.openjdk.org/browse/JDK-8293472. The Java metrics implementation > may get the resource limits wrong if there are additional cgroup fs mounts. > Apparently that's more common than one might think. I've reproduced this with > these

Integrated: 8244681: Add a warning for possibly lossy conversion in compound assignments

2022-09-15 Thread Adam Sotona
On Mon, 9 May 2022 15:56:35 GMT, Adam Sotona wrote: > Please review this patch adding new lint option, **lossy-conversions**, to > javac to warn about type casts in compound assignments with possible lossy > conversions. > > The new lint warning is shown if the type of the right-hand operand o

RFR: 8293819: sun/util/logging/PlatformLoggerTest.java failed with "RuntimeException: Retrieved backing PlatformLogger level null is not the expected CONFIG"

2022-09-15 Thread Daniel Fuchs
The sun/util/logging/PlatformLoggerTest.java is missing a couple of Reference::reachabilityFence calls to maintain loggers alive while the test is running. It has been observed failing under stress. - Commit messages: - Update Copyright year - 8293819 Changes: https://git.openjdk

Re: RFR: 8292914: Introduce a system property that enables stable names for lambda classes [v3]

2022-09-15 Thread Strahinja Stanojevic
> This PR introduces a system property that creates stable names for the lambda > classes in the JDK. Instead of using an atomic counter in the lambda name, we > can use a 32-bit hash after `$$Lambda$`. Thus, the name becomes > `lambdaCapturingClass$$Lambda$hashValue`. > Parameters used to creat

RFR: JDK-8293659: Improve UnsatisfiedLinkError error message to include dlopen error details

2022-09-15 Thread Matthias Baesken
When trying to load a x64 lib on macOS aarch64 one got previously this detailed message before [JDK-8275703](https://bugs.openjdk.org/browse/JDK-8275703): java.lang.UnsatisfiedLinkError: /testing/jco3/macOsx64/libsapjco3.dylib: dlopen(/testing/jco3/macOsx64/libsapjco3.dylib, 1): no suitable imag

Re: RFR: 8293819: sun/util/logging/PlatformLoggerTest.java failed with "RuntimeException: Retrieved backing PlatformLogger level null is not the expected CONFIG"

2022-09-15 Thread Jaikiran Pai
On Thu, 15 Sep 2022 11:29:40 GMT, Daniel Fuchs wrote: > The sun/util/logging/PlatformLoggerTest.java is missing a couple of > Reference::reachabilityFence calls to maintain loggers alive while the test > is running. It has been observed failing under stress. test/jdk/sun/util/logging/PlatformL

Re: RFR: 8278165: Clarify that ZipInputStream does not access the CEN fields for a ZipEntry [v5]

2022-09-15 Thread Alan Bateman
On Wed, 14 Sep 2022 16:54:56 GMT, Lance Andersen wrote: >> Hi, >> >> Please review this update to the ZipInputStream class description to clarify >> that ZipInputStream walks sequentially through each Zip Entry contained >> within the Zip File. As a result, the CEN header for the Zip file ent

Re: RFR: 8293819: sun/util/logging/PlatformLoggerTest.java failed with "RuntimeException: Retrieved backing PlatformLogger level null is not the expected CONFIG"

2022-09-15 Thread Daniel Fuchs
On Thu, 15 Sep 2022 13:57:37 GMT, Jaikiran Pai wrote: >> The sun/util/logging/PlatformLoggerTest.java is missing a couple of >> Reference::reachabilityFence calls to maintain loggers alive while the test >> is running. It has been observed failing under stress. > > test/jdk/sun/util/logging/Pla

Re: RFR: 8293819: sun/util/logging/PlatformLoggerTest.java failed with "RuntimeException: Retrieved backing PlatformLogger level null is not the expected CONFIG"

2022-09-15 Thread Jaikiran Pai
On Thu, 15 Sep 2022 14:38:54 GMT, Daniel Fuchs wrote: >> test/jdk/sun/util/logging/PlatformLoggerTest.java line 136: >> >>> 134: logger.getName() + " " + logger.getLevel()); >>> 135: } >>> 136: Reference.reachabilityFence(logger); >> >> Hello Daniel, I don't foll

Re: RFR: 8293819: sun/util/logging/PlatformLoggerTest.java failed with "RuntimeException: Retrieved backing PlatformLogger level null is not the expected CONFIG"

2022-09-15 Thread Jaikiran Pai
On Thu, 15 Sep 2022 11:29:40 GMT, Daniel Fuchs wrote: > The sun/util/logging/PlatformLoggerTest.java is missing a couple of > Reference::reachabilityFence calls to maintain loggers alive while the test > is running. It has been observed failing under stress. Marked as reviewed by jpai (Reviewe

Re: RFR: JDK-8293659: Improve UnsatisfiedLinkError error message to include dlopen error details

2022-09-15 Thread Mandy Chung
On Thu, 15 Sep 2022 11:54:41 GMT, Matthias Baesken wrote: > When trying to load a x64 lib on macOS aarch64 one got previously this > detailed message before > [JDK-8275703](https://bugs.openjdk.org/browse/JDK-8275703): > > java.lang.UnsatisfiedLinkError: /testing/jco3/macOsx64/libsapjco3.dylib

Re: RFR: JDK-8293659: Improve UnsatisfiedLinkError error message to include dlopen error details

2022-09-15 Thread Mandy Chung
On Thu, 15 Sep 2022 11:54:41 GMT, Matthias Baesken wrote: > When trying to load a x64 lib on macOS aarch64 one got previously this > detailed message before > [JDK-8275703](https://bugs.openjdk.org/browse/JDK-8275703): > > java.lang.UnsatisfiedLinkError: /testing/jco3/macOsx64/libsapjco3.dylib

Re: RFR: 8289508: Improve test coverage for XPath Axes: ancestor, ancestor-or-self, preceding, and preceding-sibling [v2]

2022-09-15 Thread Joe Wang
On Thu, 15 Sep 2022 06:25:53 GMT, Rahul Prabhu wrote: >> Created two files for testing XPath Axes: XPathAncestors.java tests the >> ancestor and ancestor-or-self axes, while XPathPrecedingTest.java tests the >> preceding and preceding-sibling axes. > > Rahul Prabhu has refreshed the contents of

Re: RFR: 8289508: Improve test coverage for XPath Axes: ancestor, ancestor-or-self, preceding, and preceding-sibling [v4]

2022-09-15 Thread Joe Wang
On Thu, 15 Sep 2022 06:51:34 GMT, Rahul Prabhu wrote: >> Created two files for testing XPath Axes: XPathAncestors.java tests the >> ancestor and ancestor-or-self axes, while XPathPrecedingTest.java tests the >> preceding and preceding-sibling axes. > > Rahul Prabhu has updated the pull request

RFR: JDK-8293892: Add links to JVMS 19 and 20 from ClassFileFormatVersion enum constants

2022-09-15 Thread Joe Darcy
Analogous fix to one already done for javax.lang.model.SourceVersion (JDK-8293768), the links to JVMS 19 and 20 are not currently valid, but redirect to the spec language page https://docs.oracle.com/javase/specs/index.html The URLs will become valid when 19 and 20, respectively, ship. ---

Re: RFR: JDK-8293892: Add links to JVMS 19 and 20 from ClassFileFormatVersion enum constants

2022-09-15 Thread Athijegannathan Sundararajan
On Fri, 16 Sep 2022 02:59:32 GMT, Joe Darcy wrote: > Analogous fix to one already done for javax.lang.model.SourceVersion > (JDK-8293768), the links to JVMS 19 and 20 are not currently valid, but > redirect to the spec language page > > https://docs.oracle.com/javase/specs/index.html > > The

Withdrawn: JDK-8287597: List all preview features on the javadoc PREVIEW page

2022-09-15 Thread duke
On Thu, 30 Jun 2022 15:14:40 GMT, Hannes Wallnöfer wrote: > Please review an enhancement to the preview page to add a list of preview > features and allow users to explore the preview APIs by feature. > > While the changes for the enhancement itself are not overly complex, the work > entailed

Re: RFR: 8293499: Provide jmod --compress option [v6]

2022-09-15 Thread Aleksey Shipilev
On Tue, 13 Sep 2022 17:41:04 GMT, Aleksey Shipilev wrote: >> I have been looking into `make clean-images images` performance, and >> realized jmod keeps compressing files with default compression level. Tuning >> that toward lighter compression levels improves build performance >> considerably