> Initial pass of porting FDLIBM sinh/cosh/tanh to Java. I do intend to
> refactor the regression tests a bit to reduce duplication, but the actual
> ports should be ready for review.
>
> Diff'ing the ports as before, original vs transliteration port:
>
>
> $ diff -w Hyperbolic.c
On Wed, 8 Feb 2023 00:25:32 GMT, Joe Darcy wrote:
> Next up on the FDLIBM porting countdown, the log method.
>
> Original C vs transliteration port:
>
>
> $ diff -w Log.c Log.translit.java
> 1c1
> < /* __ieee754_log(x)
> ---
>> /**
> 51,58c51,52
> <
> < #include "fdlibm.h"
> <
> <
> Next up on the FDLIBM porting countdown, the log method.
>
> Original C vs transliteration port:
>
>
> $ diff -w Log.c Log.translit.java
> 1c1
> < /* __ieee754_log(x)
> ---
>> /**
> 51,58c51,52
> <
> < #include "fdlibm.h"
> <
> < #ifdef __STDC__
> < static const double
> < #else
> <
On Fri, 10 Feb 2023 21:54:07 GMT, Joe Darcy wrote:
>> To help add assurances that the main-line port of FDLIBM to Java is working
>> correctly, added some long-running manual tests to probe that the
>> transliteration port and the corresponding StrictMath method are in
>> agreement on a large
On Thu, 9 Feb 2023 06:46:17 GMT, Joe Darcy wrote:
>> Next up on the FDLIBM porting countdown, the log method.
>>
>> Original C vs transliteration port:
>>
>>
>> $ diff -w Log.c Log.translit.java
>> 1c1
>> < /* __ieee754_log(x)
>> ---
>>> /**
>> 51,58c51,52
>> <
>> < #include "fdlibm.h"
On Thu, 9 Feb 2023 18:08:15 GMT, Scott Gibbons wrote:
>> Added code for Base64 acceleration (encode and decode) which will accelerate
>> ~4x for AVX2 platforms.
>>
>> Encode performance:
>> **Old:**
>>
>> Benchmark (maxNumBytes) Mode Cnt Score Error
>> Units
On Fri, 10 Feb 2023 22:48:24 GMT, Joe Wang wrote:
>> Update Commons BCEL in the JDK from 6.5.0 to 6.7.0.
>>
>> 1. Improvement
>>Code modernization (using relatively more modern language features),
>> normalization (such as naming), javadocs, cleanup and minor improvements
>> made up most
> Update Commons BCEL in the JDK from 6.5.0 to 6.7.0.
>
> 1. Improvement
>Code modernization (using relatively more modern language features),
> normalization (such as naming), javadocs, cleanup and minor improvements made
> up most of the changes. These changes do not change how BCEL
On Fri, 10 Feb 2023 21:54:07 GMT, Joe Darcy wrote:
>> To help add assurances that the main-line port of FDLIBM to Java is working
>> correctly, added some long-running manual tests to probe that the
>> transliteration port and the corresponding StrictMath method are in
>> agreement on a large
- Original Message -
> From: "Volker Simonis"
> To: "core-libs-dev" , "hotspot-dev"
>
> Sent: Friday, February 10, 2023 8:03:47 PM
> Subject: Re: RFR: 8302154: Hidden classes created by LambdaMetaFactory can't
> be unloaded [v2]
> On Fri, 10 Feb 2023 17:29:37 GMT, Ioi Lam wrote:
>
On Fri, 10 Feb 2023 21:54:07 GMT, Joe Darcy wrote:
>> To help add assurances that the main-line port of FDLIBM to Java is working
>> correctly, added some long-running manual tests to probe that the
>> transliteration port and the corresponding StrictMath method are in
>> agreement on a large
> To help add assurances that the main-line port of FDLIBM to Java is working
> correctly, added some long-running manual tests to probe that the
> transliteration port and the corresponding StrictMath method are in agreement
> on a large number of argument, say, all float values.
>
> To test
On Thu, 9 Feb 2023 13:46:14 GMT, Per Minborg wrote:
>> `ZoneOffset` instances are cached by the `ZoneOffset` class itself for
>> values in the range [-18h, 18h] for each second that is on an even quarter
>> of an hour (i.e. at most 2*18*4+1 = 145 values).
>>
>> Instead of using a
It can be difficult to find the cause of calls to
`java.lang.System.exit(status)` and `Runtime.exit(status)` because the Java
runtime exits.
The status value and stack trace are logged using the System Logger named
`java.lang.Runtime` with message level `System.Logger.Level.DEBUG`.
On Fri, 10 Feb 2023 17:50:40 GMT, Mark Sheppard wrote:
>> @msheppar It depends on the timing of GC and the unpredictable interactions
>> between the compiler and gc.
>> If gc is particularly aggressive (as may be stimulated by -Xcomp), it may
>> determine that the impl is no longer referenced
On Fri, 10 Feb 2023 02:11:35 GMT, Brian Burkhalter wrote:
> Replace the two occurrences of `character` with `byte`.
This pull request has now been integrated.
Changeset: 57798dd4
Author:Brian Burkhalter
URL:
On Fri, 10 Feb 2023 19:00:53 GMT, Volker Simonis wrote:
> LambdaGC$$Lambda$1 was also strongly linked to its defining class loader, but
> I don't think that's necessary to keep it alive (because it is referenced
> from the call site which is referenced from the constant pool cache).
True but
On Fri, 10 Feb 2023 17:29:37 GMT, Ioi Lam wrote:
>> Volker Simonis has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Remove assertions which insist on Lambda proxy classes being strongly
>> linked to their class loader
>> - Removed
On Fri, 10 Feb 2023 17:29:37 GMT, Ioi Lam wrote:
> Even in JDK 11, a lambda proxy classes that's referenced by the cpCache
> (i.e., from a resolved invokedynamic instruction associated with a lamda
> expression) is always kept alive.
Thanks @iklam. That's exactly what I am trying to
On Tue, 13 Dec 2022 09:32:11 GMT, Dmitry Samersoff
wrote:
> Move "unix" java_md.c cleanup, which is the prerequisites for the fix for
> JDK-8293806 (PR https://github.com/openjdk/jdk/pull/11538), to a separate PR.
>
> @AlanBateman, @dholmes-ora please, take a look to the changes.
This pull
On Thu, 9 Feb 2023 18:08:15 GMT, Scott Gibbons wrote:
>> Added code for Base64 acceleration (encode and decode) which will accelerate
>> ~4x for AVX2 platforms.
>>
>> Encode performance:
>> **Old:**
>>
>> Benchmark (maxNumBytes) Mode Cnt Score Error
>> Units
Update open/test/failure_handler/src/share/conf/linux.properties to handle core
dumps more correctly.
-
Commit messages:
- 8302226 failure_handler native.core should wait for coredump to finish on
linux
Changes: https://git.openjdk.org/jdk/pull/12515/files
Webrev:
On Fri, 10 Feb 2023 17:00:47 GMT, Roger Riggs wrote:
>> yes, this mitigates the issue within the test, and alls good.
>> BUT it still leave an open question as to why the behaviour of the test is
>> different for the -Xcomp mode and the interpretative mode?
>> I think it would be reasonable to
On Fri, 10 Feb 2023 17:38:51 GMT, Brian Burkhalter wrote:
>> `java.io.InputStream::transferTo` could conceivably return a negative value
>> if the count of bytes transferred overflows a `long`. Modify the method to
>> limit the number of bytes transferred to `Long.MAX_VALUE` per invocation.
>
On Fri, 10 Feb 2023 13:25:29 GMT, Alan Bateman wrote:
>> Brian Burkhalter has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8297632: Increment recent copyright year to 2023
>
> src/java.base/share/classes/java/io/SequenceInputStream.java
> `java.io.InputStream::transferTo` could conceivably return a negative value
> if the count of bytes transferred overflows a `long`. Modify the method to
> limit the number of bytes transferred to `Long.MAX_VALUE` per invocation.
Brian Burkhalter has updated the pull request incrementally with
On Thu, 9 Feb 2023 18:11:18 GMT, Volker Simonis wrote:
>> Prior to
>> [JDK-8239384](https://bugs.openjdk.org/browse/JDK-8239384)/[JDK-8238358](https://bugs.openjdk.org/browse/JDK-8238358)
>> LambdaMetaFactory has created VM-anonymous classes which could easily be
>> unloaded once they were
> Enhance the Java programming language with string templates, which are
> similar to string literals but contain embedded expressions. A string
> template is interpreted at run time by replacing each expression with the
> result of evaluating that expression, possibly after further validation
On Fri, 10 Feb 2023 11:12:25 GMT, Adam Sotona wrote:
>> src/java.base/share/classes/jdk/internal/classfile/constantpool/AnnotationConstantValueEntry.java
>> line 33:
>>
>>> 31: * which includes the four kinds of primitive constants, and UTF8
>>> constants.
>>> 32: */
>>> 33: public sealed
On Fri, 10 Feb 2023 13:51:24 GMT, Alan Bateman wrote:
> It seems a bit fragile to be parsing the output of `fsutil volume diskFree`
> as the output seems to vary by Windows releases and maybe configuration. So
> minimally, I think it should be changed to use ProcessTools so that the
> command
> Enhance the Java programming language with string templates, which are
> similar to string literals but contain embedded expressions. A string
> template is interpreted at run time by replacing each expression with the
> result of evaluating that expression, possibly after further validation
> Enhance the Java programming language with string templates, which are
> similar to string literals but contain embedded expressions. A string
> template is interpreted at run time by replacing each expression with the
> result of evaluating that expression, possibly after further validation
On Fri, 10 Feb 2023 12:13:13 GMT, Mark Sheppard wrote:
>> I just tested it and it really be OK, I'll submit a new commit.
>
> yes, this mitigates the issue within the test, and alls good.
> BUT it still leave an open question as to why the behaviour of the test is
> different for the -Xcomp
On Fri, 10 Feb 2023 03:03:07 GMT, SUN Guoyun wrote:
>> Hi all,
>> When -Xcomp be used, this testcase will use more codecaches, causing the GC
>> to be triggered early, then causing this test failed on LoongArch64
>> architecture.
>>
>> This PR fix the issue, Please help review it.
>>
>>
On Fri, 10 Feb 2023 16:48:08 GMT, Brian Burkhalter wrote:
>> Replace the two occurrences of `character` with `byte`.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 6595142: Refer to bytes, not characters in
On Wed, 8 Feb 2023 10:53:22 GMT, Claes Redestad wrote:
>> This patch adds special-cases to `Arrays.copyOf` and `Arrays.copyOfRange` to
>> copy arrays more efficiently when exactly the whole input array is to be
>> copied. This helps eliminate range checks and has been verified to help
>>
> Replace the two occurrences of `character` with `byte`.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
6595142: Refer to bytes, not characters in BufferedInputStream and
SequenceInputStream
-
Changes:
- all:
On Fri, 10 Feb 2023 07:25:11 GMT, Alan Bateman wrote:
> Looks okay, I assume you've done a wider search to see if there are any more.
I missed the ones that @djelinski spotted. I rescanned `java.io` and don't see
any others. Those two are fixed by 7868641a2c9558e66b51c40b49031095317c3a48.
On Fri, 10 Feb 2023 08:47:58 GMT, Daniel Jeliński wrote:
> There are similar incorrect comments in SequenceInputStream and
> BufferedInputStream. There could be others, but "character" is a very popular
> word, so they are hard to spot.
Thanks for spotting these. Fixed in
> Enhance the Java programming language with string templates, which are
> similar to string literals but contain embedded expressions. A string
> template is interpreted at run time by replacing each expression with the
> result of evaluating that expression, possibly after further validation
On Fri, 3 Feb 2023 02:02:39 GMT, Brian Burkhalter wrote:
> Modify the `Space` instances used for size comparison to be created with
> total number of bytes derived from the Windows `diskFree` utility instead of
> Cygwin’s `df`.
test/jdk/java/io/File/GetXSpace.java line 152:
> 150: }
>
On Wed, 25 Jan 2023 12:26:26 GMT, Per Minborg wrote:
> This PR proposed to reduce contention in synchronized methods mainly by doing
> I/O operations outside synch blocks.
This pull request has now been integrated.
Changeset: c25b4f46
Author:Per Minborg
URL:
> Enhance the Java programming language with string templates, which are
> similar to string literals but contain embedded expressions. A string
> template is interpreted at run time by replacing each expression with the
> result of evaluating that expression, possibly after further validation
On Tue, 7 Feb 2023 16:40:06 GMT, Brian Burkhalter wrote:
>> `java.io.InputStream::transferTo` could conceivably return a negative value
>> if the count of bytes transferred overflows a `long`. Modify the method to
>> limit the number of bytes transferred to `Long.MAX_VALUE` per invocation.
>
>
On Fri, 10 Feb 2023 01:53:18 GMT, SUN Guoyun wrote:
>> test/jdk/java/rmi/server/UnicastRemoteObject/serialFilter/FilterUROTest.java
>> line 74:
>>
>>> 72: public void useExportObject(String name, Object obj, int
>>> expectedFilterCount) throws RemoteException {
>>> 73: try {
>>>
On Fri, 10 Feb 2023 12:04:01 GMT, Jaikiran Pai wrote:
> Hello Eirik, I've create a JBS issue to track this change
> https://bugs.openjdk.org/browse/JDK-8302214.
Thanks, title changed!
-
PR: https://git.openjdk.org/jdk/pull/12488
On Thu, 9 Feb 2023 10:13:03 GMT, Eirik Bjorsnos wrote:
> The Javadocs of Arrays.compare and Arrays.mismatch uses the incorrect
> capitalization `atoIndex` and `btoIndex` when referencing the corresponding
> `aToIndex` and `bToIndex` parameters.
>
> Sample:
>
>
> * specified ranges [{@code
The Javadocs of Arrays.compare and Arrays.mismatch uses the incorrect
capitalization `atoIndex` and `btoIndex` when referencing the corresponding
`aToIndex` and `bToIndex` parameters.
Sample:
* specified ranges [{@code aFromIndex}, {@code atoIndex}) and
* [{@code bFromIndex}, {@code
On Thu, 9 Feb 2023 15:01:03 GMT, Maurizio Cimadamore
wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> AttributeElement.Kind removal (#48)
>
>
On Thu, 9 Feb 2023 14:11:36 GMT, Maurizio Cimadamore
wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> AttributeElement.Kind removal (#48)
>
>
On Thu, 9 Feb 2023 13:03:46 GMT, Maurizio Cimadamore
wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> AttributeElement.Kind removal (#48)
>
>
On Thu, 9 Feb 2023 12:45:27 GMT, Maurizio Cimadamore
wrote:
>> During the fix I found the definition that `ThrowableSig` (as a super-set of
>> `ClassTypeSig` and `TypeVarSig`) IS `Signature` - that fact is critical for
>> processing.
>> For example when `MethodSignature` is serialized
>>
On Tue, 7 Feb 2023 16:04:07 GMT, Maurizio Cimadamore
wrote:
>> Adam Sotona has updated the pull request incrementally with three additional
>> commits since the last revision:
>>
>> - javadoc fixes
>> - obsolete identifiers and unused imports cleanup
>> - TypeAnnotation.TypePathComponent
On Wed, 8 Feb 2023 11:19:32 GMT, Maurizio Cimadamore
wrote:
>> Any reference to an official specification of CharacterRangeInfo is
>> appreciated.
>> Thanks.
>
>> Any reference to an official specification of CharacterRangeInfo is
>> appreciated. Thanks.
>
> There's this - which points back
On Mon, 6 Feb 2023 14:13:36 GMT, Adam Sotona wrote:
>> src/java.base/share/classes/jdk/internal/classfile/BufWriter.java line 40:
>>
>>> 38: * to the end of the buffer, as well as to create constant pool entries.
>>> 39: */
>>> 40: public sealed interface BufWriter
>>
>> What is the
[JDK-8269667](https://bugs.openjdk.org/browse/JDK-8269667) has uncovered the
poor performance of BigDecimal.divide under certain circumstance.
We confront similar situations when benchmarking Spark3 on TPC-DS test kit.
According to the flame-graph below, it is StripZeros that spends most of the
On Fri, 10 Feb 2023 09:11:22 GMT, Per Minborg wrote:
>> This PR proposed to reduce contention in synchronized methods mainly by
>> doing I/O operations outside synch blocks.
>
> Per Minborg has updated the pull request incrementally with one additional
> commit since the last revision:
>
>
> This PR proposed to reduce contention in synchronized methods mainly by doing
> I/O operations outside synch blocks.
Per Minborg has updated the pull request incrementally with one additional
commit since the last revision:
Remove comment and rename class
-
Changes:
- all:
On Thu, 9 Feb 2023 16:27:34 GMT, Per Minborg wrote:
>> src/java.base/share/classes/java/lang/Module.java line 120:
>>
>>> 118: // memory semantics that preserves ordering and visibility across
>>> threads.
>>> 119: //
>>> 120: // Used reflectively via Unsafe
>>
>> I assume
On Thu, 9 Feb 2023 16:46:08 GMT, Per Minborg wrote:
>> This PR proposed to reduce contention in synchronized methods mainly by
>> doing I/O operations outside synch blocks.
>
> Per Minborg has updated the pull request incrementally with one additional
> commit since the last revision:
>
>
On Fri, 10 Feb 2023 02:11:35 GMT, Brian Burkhalter wrote:
> Replace the two occurrences of `character` with `byte`.
There are similar incorrect comments in SequenceInputStream and
BufferedInputStream. There could be others, but "character" is a very popular
word, so they are hard to spot.
61 matches
Mail list logo
