On Fri, 28 Apr 2023 22:16:09 GMT, Vicente Romero wrote:
>> Hannes Greule has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Move and fix test comment
>
> looks good
Thank you for your review, @vicente-romero-oracle.
-
PR Comm
On Sat, 29 Apr 2023 01:44:07 GMT, Jiangli Zhou wrote:
> > > Erik, could you please share your
> > > `support/native/java.base/java/BUILD_LAUNCHER_javastatic_static_link.cmdline`?
> > > This generated .cmdline file contains the static linking command. Here
> > > is the linking command from my b
> Initial implementation for supporting building a fully statically linked
> (with a desired set of JDK native libraries and libjvm) Java launcher
> executable, which is named as 'javastatic'.
>
> In this PR, the support is only added for the linux platform. Both gcc and
> clang can be supporte
On Fri, 28 Apr 2023 23:25:17 GMT, Erik Joelsson wrote:
> > Erik, could you please share your
> > `support/native/java.base/java/BUILD_LAUNCHER_javastatic_static_link.cmdline`?
> > This generated .cmdline file contains the static linking command. Here is
> > the linking command from my build:
>
> Fix a copy n paste error in XMLSchemaValidator. When the patch was applied
> while updating to Xerces 2.12.2, the original code was not removed, resulting
> in reporting validation error twice.
Joe Wang has updated the pull request incrementally with one additional commit
since the last revis
On Sat, 29 Apr 2023 00:09:55 GMT, Naoto Sato wrote:
>> Joe Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> removing the line that changed locale. It's not necessary as the concern
>> was the number of errors reported
>
> test/jaxp/
On Fri, 28 Apr 2023 18:28:51 GMT, Phil Race wrote:
> Umm. Does this mean you are linking both headless and xawt into the same
> image ?
For the xawt case, we statically link with libawt.a and libawt_xawt.a in our
early prototype. For headless case, we statically link with libawt.a and
libawt_
On Fri, 28 Apr 2023 18:25:14 GMT, Phil Race wrote:
> Why not ? Surely you aren't statically linking every library you find on the
> platform that's referenced by JDK ?
> I mean its fine to say that I'd prefer to statically link this library, but I
> don't understand the claim that this is the o
On Sat, 29 Apr 2023 00:03:24 GMT, Jiangli Zhou wrote:
> Based the initial feedback from you and other reviewers in the thread, I'll
> repurpose this PR for handling the .a part only. I'll split the 'javastatic'
> static linking part into a separate branch for needed discussions (including
> th
On Fri, 28 Apr 2023 19:40:34 GMT, Erik Joelsson wrote:
> I think it would be rather beneficial if this linking step could be performed
> by some variant of SetupNativeCompilation. We don't want to have to maintain
> logic for dealing with different platforms and linkers outside of the common
>
On Fri, 28 Apr 2023 17:08:10 GMT, Joe Wang wrote:
> Fix a copy n paste error in XMLSchemaValidator. When the patch was applied
> while updating to Xerces 2.12.2, the original code was not removed, resulting
> in reporting validation error twice.
test/jaxp/javax/xml/jaxp/unittest/validation/Err
On Fri, 28 Apr 2023 18:14:48 GMT, Erik Joelsson wrote:
>
> If I understand the make file changes proposed here, it runs the native
> linker to create "javastatic" with the launcher, libjvm and other JNI libs
> linked into one executable, this is generated and copied into the run-time
> image
On Fri, 28 Apr 2023 22:32:34 GMT, Jiangli Zhou wrote:
> Erik, could you please share your
> `support/native/java.base/java/BUILD_LAUNCHER_javastatic_static_link.cmdline`?
> This generated .cmdline file contains the static linking command. Here is
> the linking command from my build:
I can't s
On Fri, 28 Apr 2023 18:16:07 GMT, Erik Joelsson wrote:
> I pulled this PR and had a go at building it. For me it failed with errors
> like this:
>
> ```
> /home/erik/git/jdk/build/linux-x64/images/static-libs/lib/libjvm.a(os_linux.o):os_linux.cpp:function
> os::Linux::fast_thread_clock_init():
On Fri, 24 Mar 2023 06:42:30 GMT, Hannes Greule wrote:
>> After merging master into https://github.com/openjdk/jdk/pull/9862, we
>> encountered test failures (e.g.,
>> https://github.com/SirYwell/jdk/actions/runs/4500940829/jobs/7923018438#step:9:2541).
>> The Classfile API tries to read from
On Fri, 7 Apr 2023 14:35:41 GMT, Chen Liang wrote:
>> As John Rose has pointed out in this issue, the current j.l.r.Proxy based
>> implementation of MethodHandleProxies.asInterface has a few issues:
>> 1. Exposes too much information via Proxy supertype (and WrapperInstance
>> interface)
>> 2.
On Fri, 28 Apr 2023 04:05:21 GMT, ExE Boss wrote:
>> Textual specification clarifications.
>
> src/java.base/share/classes/java/lang/Runtime.java line 143:
>
>> 141:
>> 142: /**
>> 143: * Initiates the shutdown sequence of the
>> Java Virtual Machine.
>
> Suggestion:
>
> * Init
On Fri, 28 Apr 2023 06:40:16 GMT, Alan Bateman wrote:
>> Textual specification clarifications.
>
> src/java.base/share/classes/java/lang/Runtime.java line 146:
>
>> 144: * If a security manager is present and its {@link
>> SecurityManager#checkExit checkExit}
>> 145: * method disallow
On Thu, 27 Apr 2023 18:36:53 GMT, Stuart Marks wrote:
> …
This pull request has now been integrated.
Changeset: da9efee1
Author:Stuart Marks
URL:
https://git.openjdk.org/jdk/commit/da9efee1c25f76f80fee9065680e7d75d03c7178
Stats: 4 lines in 1 file changed: 4 ins; 0 del; 0 mod
82
On Fri, 28 Apr 2023 04:57:45 GMT, David Holmes wrote:
> @jianglizhou I thought this work was proposed to be done under the Project
> Leyden umbrella? The other static-build tweaks have been fine but this seems
> to be part of a bigger, yet unspecified, project that may need to be covered
> by
On Fri, 28 Apr 2023 01:03:28 GMT, Jiangli Zhou wrote:
> Initial implementation for supporting building a fully statically linked
> (with a desired set of JDK native libraries and libjvm) Java launcher
> executable, which is named as 'javastatic'.
>
> In this PR, the support is only added for t
On Fri, 28 Apr 2023 18:43:01 GMT, Eirik Bjorsnos wrote:
> Somewhat unrelated perhaps, but I found the example value given for
> `jdbc.drivers` in `DriverManager` javadocs to be a bit funky.
>
> `jdbc.drivers=foo.bah.Driver:wombat.sql.Driver:bad.taste.ourDriver`
>
> I know, I know, coming up wi
On Fri, 28 Apr 2023 17:28:47 GMT, Lance Andersen wrote:
> Hi all,
>
> Please review this trivial change which allows the` jdbc.drivers` system
> property to be searchable.
>
> Best.
> Lance
Marked as reviewed by joehw (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/137
On Fri, 28 Apr 2023 17:28:47 GMT, Lance Andersen wrote:
> Hi all,
>
> Please review this trivial change which allows the` jdbc.drivers` system
> property to be searchable.
>
> Best.
> Lance
Somewhat unrelated perhaps, but I found the example value given for
`jdbc.drivers` in `DriverManager`
On Fri, 28 Apr 2023 17:51:58 GMT, Jan Lahoda wrote:
>> I believe we were discussing this some time ago, and there were some
>> problems. I don't recall the exact details, but I'll try to look into this
>> later.
>
> I've sketched this:
> https://github.com/lahodaj/jdk/commit/efe55f7d354ed7bbf91
> Add flexible main methods and anonymous main classes to the Java language.
Jim Laskey has updated the pull request incrementally with two additional
commits since the last revision:
- Leave exception alone
- Unused variables
-
Changes:
- all: https://git.openjdk.org/jdk/pull/
On Thu, 27 Apr 2023 17:35:12 GMT, Mahendra Chhipa wrote:
>> Test is updated to create the binary files during test execution.
>
> Mahendra Chhipa has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Implemented the review comments.
Looks ok. Pr
On Fri, 28 Apr 2023 01:03:28 GMT, Jiangli Zhou wrote:
> Initial implementation for supporting building a fully statically linked
> (with a desired set of JDK native libraries and libjvm) Java launcher
> executable, which is named as 'javastatic'.
>
> In this PR, the support is only added for t
On Fri, 28 Apr 2023 11:59:52 GMT, Alan Bateman wrote:
> If I understand the make file changes proposed here, it runs the native
> linker to create "javastatic" with the launcher, libjvm and other JNI libs
> linked into one executable, this is generated and copied into the run-time
> image crea
On Fri, 28 Apr 2023 01:03:28 GMT, Jiangli Zhou wrote:
> Initial implementation for supporting building a fully statically linked
> (with a desired set of JDK native libraries and libjvm) Java launcher
> executable, which is named as 'javastatic'.
>
> In this PR, the support is only added for t
On Fri, 28 Apr 2023 17:28:47 GMT, Lance Andersen wrote:
> Hi all,
>
> Please review this trivial change which allows the` jdbc.drivers` system
> property to be searchable.
>
> Best.
> Lance
Marked as reviewed by naoto (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/137
On Fri, 28 Apr 2023 13:01:33 GMT, Jan Lahoda wrote:
>> I see that logic in JavaCompiler - I wonder if that's just the way it is, or
>> if there's a deeper reason as to why the sourcefile is set on the toplevel
>> unit *after* parsing (I don't think I can see any, in which case that might
>> be
Hi all,
Please review this trivial change which allows the` jdbc.drivers` system
property to be searchable.
Best.
Lance
-
Commit messages:
- Update copyright year
- Update copyright year
- Allow the jdbc.drivers system property to be searchable
Changes: https://git.openjdk.org/
Fix a copy n paste error in XMLSchemaValidator. When the patch was applied
while updating to Xerces 2.12.2, the original code was not removed, resulting
in reporting validation error twice.
-
Commit messages:
- 8298087: XML Schema Validation reports an required attribute twice via
[This should be discussed on the security alias so I am copying
security-dev and -bcc-ing core-libs-dev]
As Bernd noted, use of SHA1PRNG should ideally be replaced with a
stronger secure random algorithm, so the impact of this issue is
probably not that significant. That said, I think this is
On Tue, 21 Feb 2023 13:44:52 GMT, Madjosz wrote:
> Fixes JDK-8302983 (and duplicate JDK-8302898)
This pull request has now been integrated.
Changeset: f83e7302
Author:Madjosz <28844868+madj...@users.noreply.github.com>
Committer: Naoto Sato
URL:
https://git.openjdk.org/jdk/commit/f8
On Thu, 27 Apr 2023 18:36:53 GMT, Stuart Marks wrote:
> …
Marked as reviewed by lancea (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/13698#pullrequestreview-1406240035
> Add flexible main methods and anonymous main classes to the Java language.
Jim Laskey has updated the pull request incrementally with one additional
commit since the last revision:
Can't be invokeExact for instance main
-
Changes:
- all: https://git.openjdk.org/jdk/pull/13689
> Add flexible main methods and anonymous main classes to the Java language.
Jim Laskey has updated the pull request incrementally with one additional
commit since the last revision:
Recommended changes #1
-
Changes:
- all: https://git.openjdk.org/jdk/pull/13689/files
- new:
On Fri, 28 Apr 2023 14:26:10 GMT, Jan Lahoda wrote:
>> Jim Laskey has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 14 commits:
>>
>> - Merge branch 'master' into 8306112
>> - PreviewFeatures.isEnabled()
>> - Clean up isPreview
>
On Fri, 28 Apr 2023 13:13:57 GMT, Jan Lahoda wrote:
>> Jim Laskey has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 14 commits:
>>
>> - Merge branch 'master' into 8306112
>> - PreviewFeatures.isEnabled()
>> - Clean up isPreview
>
On Thu, 27 Apr 2023 18:21:56 GMT, Jim Laskey wrote:
>> Add flexible main methods and anonymous main classes to the Java language.
>
> Jim Laskey has updated the pull request with a new target base due to a merge
> or a rebase. The pull request now contains 14 commits:
>
> - Merge branch 'maste
On Fri, 28 Apr 2023 12:45:35 GMT, Jan Lahoda wrote:
>> Jim Laskey has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 14 commits:
>>
>> - Merge branch 'master' into 8306112
>> - PreviewFeatures.isEnabled()
>> - Clean up isPreview
>
On Thu, 27 Apr 2023 18:36:53 GMT, Stuart Marks wrote:
> …
Marked as reviewed by rriggs (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/13698#pullrequestreview-1406036844
On Thu, 27 Apr 2023 18:21:56 GMT, Jim Laskey wrote:
>> Add flexible main methods and anonymous main classes to the Java language.
>
> Jim Laskey has updated the pull request with a new target base due to a merge
> or a rebase. The pull request now contains 14 commits:
>
> - Merge branch 'maste
On Thu, 27 Apr 2023 20:34:44 GMT, Maurizio Cimadamore
wrote:
>> The source file name is not available until after parsing.
>
> I see that logic in JavaCompiler - I wonder if that's just the way it is, or
> if there's a deeper reason as to why the sourcefile is set on the toplevel
> unit *after
On Fri, 28 Apr 2023 12:59:26 GMT, Jorn Vernee wrote:
>> This patch adds a dedicated jtreg property to check which CABI is being used
>> by the JDK, which can be used both to check whether the foreign linker is
>> supported, and whether the fallback linker is being used. (and, possibly it
>> ca
> This patch adds a dedicated jtreg property to check which CABI is being used
> by the JDK, which can be used both to check whether the foreign linker is
> supported, and whether the fallback linker is being used. (and, possibly it
> can also be use to check for a particular ABI in case we want
On Thu, 27 Apr 2023 17:57:05 GMT, Antonios Printezis wrote:
> Fix is to exclude hsdis when building the buildjdk.
This pull request has now been integrated.
Changeset: 83a98c66
Author:Antonios Printezis
URL:
https://git.openjdk.org/jdk/commit/83a98c66f1747fec3da77578b646498c4cb5637d
On Thu, 27 Apr 2023 21:31:09 GMT, Erik Joelsson wrote:
>> Marked as reviewed by erikj (Reviewer).
>
>> @erikj79 Thanks! I assume the integrate command will actually squash the
>> three commits and rebase them on top of master as one commit?
>
> Yes, all you need to do is to issue the integrate
On Mon, 30 Jan 2023 08:03:38 GMT, Amit Kumar wrote:
> DeInflate.java test fails on s390x platform because size for out1 array which
> is responsible for storing the compressed data is insufficient. And being
> unable to write whole compressed data on array, on s390 whole data can't be
> recove
On Fri, 28 Apr 2023 01:03:28 GMT, Jiangli Zhou wrote:
> Initial implementation for supporting building a fully statically linked
> (with a desired set of JDK native libraries and libjvm) Java launcher
> executable, which is named as 'javastatic'.
>
> In this PR, the support is only added for t
On Fri, 28 Apr 2023 11:18:56 GMT, Amit Kumar wrote:
>> DeInflate.java test fails on s390x platform because size for out1 array
>> which is responsible for storing the compressed data is insufficient. And
>> being unable to write whole compressed data on array, on s390 whole data
>> can't be re
On Fri, 28 Apr 2023 11:18:56 GMT, Amit Kumar wrote:
>> DeInflate.java test fails on s390x platform because size for out1 array
>> which is responsible for storing the compressed data is insufficient. And
>> being unable to write whole compressed data on array, on s390 whole data
>> can't be re
On Fri, 28 Apr 2023 11:18:56 GMT, Amit Kumar wrote:
>> DeInflate.java test fails on s390x platform because size for out1 array
>> which is responsible for storing the compressed data is insufficient. And
>> being unable to write whole compressed data on array, on s390 whole data
>> can't be re
Good finding, but just a related comment: it has been customary to request sha1prng, but that practice should be re-evaluated since all new RNG mode features (including the parameters) are absent in that implementation amd it might sooner or later create compliance issues
> DeInflate.java test fails on s390x platform because size for out1 array which
> is responsible for storing the compressed data is insufficient. And being
> unable to write whole compressed data on array, on s390 whole data can't be
> recovered after compression. This PR updates the check metho
On Fri, 28 Apr 2023 10:42:32 GMT, Amit Kumar wrote:
>> DeInflate.java test fails on s390x platform because size for out1 array
>> which is responsible for storing the compressed data is insufficient. And
>> being unable to write whole compressed data on array, on s390 whole data
>> can't be re
> DeInflate.java test fails on s390x platform because size for out1 array which
> is responsible for storing the compressed data is insufficient. And being
> unable to write whole compressed data on array, on s390 whole data can't be
> recovered after compression. This PR updates the check metho
On Fri, 28 Apr 2023 09:58:59 GMT, Amit Kumar wrote:
>> DeInflate.java test fails on s390x platform because size for out1 array
>> which is responsible for storing the compressed data is insufficient. And
>> being unable to write whole compressed data on array, on s390 whole data
>> can't be re
On Sat, 22 Apr 2023 18:40:45 GMT, Chen Liang wrote:
>> Add a method `internalName` to `ClassDesc`, and unifies handling of string
>> representation of a class constant in CONSTANT_Class_info via
>> `ofInternalName` and `internalName` APIs, documented in `ClassDesc` itself.
>> In particular, `o
On Fri, 28 Apr 2023 09:33:03 GMT, Volker Simonis wrote:
>> test/jdk/java/util/zip/DeInflate.java line 164:
>>
>>> 162: out2 = baos.toByteArray();
>>> 163: if (n != len ||
>>> 164: !Arrays.equals(in, 0, len, out2, 0, len)) ||
>>
>> There's a `)` too much.
On Fri, 28 Apr 2023 09:26:52 GMT, Volker Simonis wrote:
>> Amit Kumar has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> suggestion from @simonis
>
> test/jdk/java/util/zip/DeInflate.java line 164:
>
>> 162: out2 = baos.toByteA
On Fri, 28 Apr 2023 09:23:59 GMT, Amit Kumar wrote:
>> DeInflate.java test fails on s390x platform because size for out1 array
>> which is responsible for storing the compressed data is insufficient. And
>> being unable to write whole compressed data on array, on s390 whole data
>> can't be re
> DeInflate.java test fails on s390x platform because size for out1 array which
> is responsible for storing the compressed data is insufficient. And being
> unable to write whole compressed data on array, on s390 whole data can't be
> recovered after compression. This PR updates the check metho
On Fri, 28 Apr 2023 09:08:18 GMT, Amit Kumar wrote:
>> DeInflate.java test fails on s390x platform because size for out1 array
>> which is responsible for storing the compressed data is insufficient. And
>> being unable to write whole compressed data on array, on s390 whole data
>> can't be re
> DeInflate.java test fails on s390x platform because size for out1 array which
> is responsible for storing the compressed data is insufficient. And being
> unable to write whole compressed data on array, on s390 whole data can't be
> recovered after compression. This PR updates the check metho
On Fri, 28 Apr 2023 08:31:05 GMT, Volker Simonis wrote:
>> Amit Kumar has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> changes request by @turbanoff
>
> test/jdk/java/util/zip/DeInflate.java line 164:
>
>> 162: out2 = baos.to
On Thu, 27 Apr 2023 17:05:24 GMT, Amit Kumar wrote:
>> DeInflate.java test fails on s390x platform because size for out1 array
>> which is responsible for storing the compressed data is insufficient. And
>> being unable to write whole compressed data on array, on s390 whole data
>> can't be re
On Thu, 27 Apr 2023 17:05:24 GMT, Amit Kumar wrote:
>> DeInflate.java test fails on s390x platform because size for out1 array
>> which is responsible for storing the compressed data is insufficient. And
>> being unable to write whole compressed data on array, on s390 whole data
>> can't be re
70 matches
Mail list logo
