> Summaries:
> 1. A few recommendations about updating the constant API is made at
> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-March/000233.html
> and I may update this patch shall the API changes be integrated before
> 2. One ASM library-specific test, `LambdaAsm` is removed.
On Mon, 8 May 2023 10:01:49 GMT, Viktor Klang wrote:
>> Same as we saw with `isAlive` before: `LockSupport.park` implicitly provides
>> a compiler barrier. This `done` should be at least "opaque" to carry the
>> same effect.
>
> Yes, `park()` and `unpark()` having release and acquire semantics
On Tue, 9 May 2023 02:23:51 GMT, David Holmes wrote:
>> Yes, `park()` and `unpark()` having release and acquire semantics is not
>> documented
>> [here](https://docs.oracle.com/en/java/javase/20/docs/api/java.base/java/util/concurrent/locks/LockSupport.html#park()),
>> and the documentation
On Fri, 7 Apr 2023 12:22:03 GMT, Andy-Tatman wrote:
> See https://bugs.java.com/bugdatabase/view_bug?bug_id=8305734
Re disallowing bit Integer.MAX_VALUE: I have a feeling we can do better than
this.
The first paragraph of the spec states: "The bits of a BitSet are indexed by
nonnegative
Updated processtools to check exception after join().
Tested with running CI virtual thread tests.
-
Commit messages:
- 8307486: ProcessTools.java should wait until vthread is completed before
checking exceptions
Changes: https://git.openjdk.org/jdk/pull/13873/files
Webrev:
On Fri, 7 Apr 2023 12:22:03 GMT, Andy-Tatman wrote:
> See https://bugs.java.com/bugdatabase/view_bug?bug_id=8305734
Further notes on `size()`. See this comment in
On Mon, 8 May 2023 19:07:17 GMT, Viktor Klang wrote:
>> Attempting to make the "at-most once" nature, of invoking the supplied
>> action to tryAdvance, clearer in the JavaDoc.
>
> Viktor Klang has updated the pull request incrementally with one additional
> commit since the last revision:
>
>
On Fri, 5 May 2023 20:43:41 GMT, Erik Joelsson wrote:
> Further I would like to suggest that libjvm.a gets put in the variant subdir
> under lib, just like libjvm.so does today (e.g. `lib/server/libjvm.a`). That
> way you can support building libjvm.a for all variants without worry. It will
>
On Mon, 8 May 2023 19:07:17 GMT, Viktor Klang wrote:
>> Attempting to make the "at-most once" nature, of invoking the supplied
>> action to tryAdvance, clearer in the JavaDoc.
>
> Viktor Klang has updated the pull request incrementally with one additional
> commit since the last revision:
>
>
On Mon, 8 May 2023 19:07:17 GMT, Viktor Klang wrote:
>> Attempting to make the "at-most once" nature, of invoking the supplied
>> action to tryAdvance, clearer in the JavaDoc.
>
> Viktor Klang has updated the pull request incrementally with one additional
> commit since the last revision:
>
>
On Mon, 8 May 2023 19:05:43 GMT, Raffaello Giulietti
wrote:
>> Roger Riggs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Slight perf improvement using int instead of long for local nanosDiff
>
> I think that the explanation of the
On Mon, 8 May 2023 08:57:37 GMT, Severin Gehwolf wrote:
> > All of that said, I think we can get away with a smaller subset of targets
> > and deliverables. AFAIK, graal needs the combined `graal-builder-image` as
> > input to their build anyway, so they should not have any dependency on what
> Please review this PR which adds the method `caseFoldLanguageTag(String
> languageTag)` to java.util.Locale.
>
> This method case folds a language tag to adhere to _[section 2.1.1.
> Formatting of Language Tags of
> RFC5646](https://www.rfc-editor.org/rfc/rfc5646.html#section-2.1)_. This
>
> Enhance the Java programming language with string templates, which are
> similar to string literals but contain embedded expressions. A string
> template is interpreted at run time by replacing each expression with the
> result of evaluating that expression, possibly after further validation
On Sun, 7 May 2023 17:58:26 GMT, Roger Riggs wrote:
>> The implementation of java.time.Instant.until(I2, ChronoUnit) in some cases
>> did not correctly borrow or carry from the nanos to the seconds when
>> computing using ChronoUnit.MILLIS or ChronoUnit.MICROS.
>> The errant computation was
On Mon, 8 May 2023 10:32:48 GMT, Viktor Klang wrote:
> Attempting to make the "at-most once" nature, of invoking the supplied action
> to tryAdvance, clearer in the JavaDoc.
@PaulSandoz Great suggestion, thank you Paul!
-
PR Comment:
> Attempting to make the "at-most once" nature, of invoking the supplied action
> to tryAdvance, clearer in the JavaDoc.
Viktor Klang has updated the pull request incrementally with one additional
commit since the last revision:
Update src/java.base/share/classes/java/util/Spliterator.java
On Mon, 8 May 2023 10:32:48 GMT, Viktor Klang wrote:
> Attempting to make the "at-most once" nature, of invoking the supplied action
> to tryAdvance, clearer in the JavaDoc.
src/java.base/share/classes/java/util/Spliterator.java line 307:
> 305: * an exception.
> 306: *
> 307:
On Sun, 7 May 2023 17:58:26 GMT, Roger Riggs wrote:
>> The implementation of java.time.Instant.until(I2, ChronoUnit) in some cases
>> did not correctly borrow or carry from the nanos to the seconds when
>> computing using ChronoUnit.MILLIS or ChronoUnit.MICROS.
>> The errant computation was
On Mon, 8 May 2023 16:10:37 GMT, Maurizio Cimadamore
wrote:
> This is a port of: https://git.openjdk.org/panama-foreign/pull/830
(already reviewed in the panama-foreign repo)
-
Marked as reviewed by jvernee (Reviewer).
PR Review:
This is a port of: https://git.openjdk.org/panama-foreign/pull/830
-
Commit messages:
- Initial push
Changes: https://git.openjdk.org/jdk/pull/13869/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=13869=00
Issue: https://bugs.openjdk.org/browse/JDK-8307629
Stats: 75 lines
On Mon, 8 May 2023 13:46:55 GMT, Maurizio Cimadamore
wrote:
> This is a tricky intermittent failure on one of our async file channel test.
>
> While the logic of the test is a bit hard to follow, I believe the test is
> supposed to work as follows:
>
> * in the main thread, we submit an
On Sun, 7 May 2023 17:58:26 GMT, Roger Riggs wrote:
>> The implementation of java.time.Instant.until(I2, ChronoUnit) in some cases
>> did not correctly borrow or carry from the nanos to the seconds when
>> computing using ChronoUnit.MILLIS or ChronoUnit.MICROS.
>> The errant computation was
On Mon, 8 May 2023 14:23:10 GMT, Maurizio Cimadamore
wrote:
>> Port of: https://git.openjdk.org/panama-foreign/pull/831
>
> Maurizio Cimadamore has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Address review comment
Marked as reviewed by
> JNDI `DnsClient` has a finalize method to close its internal datagram channel
> selector.
> The change proposed here replaces it with a cleaner to close the selector
> once the `DnsClient`
> instance becomes phantom reachable.
>
> The change was tested with `jdk-tier1` to `jdk-tier3` test
On Sat, 6 May 2023 12:47:21 GMT, Alan Bateman wrote:
>> src/jdk.naming.dns/share/classes/com/sun/jndi/dns/DnsClient.java line 165:
>>
>>> 163: // when this DNS client becomes phantom reachable
>>> 164: Selector sel = udpChannelSelector;
>>> 165:
On Wed, 19 Apr 2023 16:47:33 GMT, Volker Simonis wrote:
> This issue was reported by: Yakov Shafranovich
> ([yako...@amazon.com](mailto:yako...@amazon.com))
>
> Currently, `ObjectInputStream::readObject()` doesn't explicitly checks for a
> negative array length in the deserialization stream.
On Mon, 3 Apr 2023 17:43:55 GMT, Raffaello Giulietti
wrote:
> Add `split()` overloads to `String` and `java.util.regex.Pattern` that, in
> addition to the substrings returned by current `split()` variants, also
> return the delimiters matching the regular expression.
This pull request has
> Refactor the Platform class of jlink to use jdk.internal.util OperatingSystem
> and Architecture instead of os.name and os.arch.
> They are direct replacements for the Platform enums except for UNKNOWN; its
> use is refactored to report errors via exceptions.
>
> Neither os.name nor os.arch
> Port of: https://git.openjdk.org/panama-foreign/pull/831
Maurizio Cimadamore has updated the pull request incrementally with one
additional commit since the last revision:
Address review comment
-
Changes:
- all: https://git.openjdk.org/jdk/pull/13863/files
- new:
On Mon, 8 May 2023 12:17:44 GMT, Jorn Vernee wrote:
>> Maurizio Cimadamore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Address review comment
>
> src/java.base/share/classes/jdk/internal/foreign/abi/AbstractLinker.java line
> 78:
>
On Mon, 8 May 2023 14:04:27 GMT, Raffaello Giulietti
wrote:
>> Add `split()` overloads to `String` and `java.util.regex.Pattern` that, in
>> addition to the substrings returned by current `split()` variants, also
>> return the delimiters matching the regular expression.
>
> Raffaello
On Mon, 8 May 2023 10:46:34 GMT, Maurizio Cimadamore
wrote:
>> src/java.base/share/classes/java/lang/invoke/MethodHandleProxies.java line
>> 342:
>>
>>> 340:
>>> 341: // individual handle fields
>>> 342: clb.withField(ORIGINAL_TARGET_NAME, CD_MethodHandle,
>>>
On Mon, 8 May 2023 14:04:27 GMT, Raffaello Giulietti
wrote:
>> Add `split()` overloads to `String` and `java.util.regex.Pattern` that, in
>> addition to the substrings returned by current `split()` variants, also
>> return the delimiters matching the regular expression.
>
> Raffaello
On Mon, 8 May 2023 13:50:19 GMT, Roger Riggs wrote:
>> I would replace center-dot with either with "times" or "*" as being easier
>> to read and more familiar in the javadoc.
>
> In java.lang.Math I see both "*" and "" used to indicate
> multiplication.
Just replaced with ``, as used in the
> Add `split()` overloads to `String` and `java.util.regex.Pattern` that, in
> addition to the substrings returned by current `split()` variants, also
> return the delimiters matching the regular expression.
Raffaello Giulietti has updated the pull request incrementally with one
additional
On Mon, 8 May 2023 13:45:53 GMT, Roger Riggs wrote:
>> I mean the usual juxtaposition in maths to signify multiplication, like in
>> _a_ _b_ instead of _a_·_b_
>>
>>> the array's length will be no greater than 2 _limit_ - 1
>
> I would replace center-dot with either with "times" or "*" as
On Mon, 8 May 2023 12:30:45 GMT, Raffaello Giulietti
wrote:
>>> Alternatively, one could remove the multiplication sign altogether...
>>
>> Do you mean rewording it to something like:
>>
>>> the array's length will be no greater than 2 times limit - 1
>
> I mean the usual juxtaposition in
On Mon, 8 May 2023 13:14:34 GMT, Sean Coffey wrote:
> minor enhancement to have -XshowSettings launcher option display the version
> of tzdata installed in the JDK
>
> example output of the new tzdata info :
>
>
>
> Locale settings:
> default locale = English
> default display
On Tue, 2 May 2023 18:02:41 GMT, Volker Simonis wrote:
>> This issue was reported by: Yakov Shafranovich
>> ([yako...@amazon.com](mailto:yako...@amazon.com))
>>
>> Currently, `ObjectInputStream::readObject()` doesn't explicitly checks for a
>> negative array length in the deserialization
On Tue, 2 May 2023 18:02:41 GMT, Volker Simonis wrote:
>> This issue was reported by: Yakov Shafranovich
>> ([yako...@amazon.com](mailto:yako...@amazon.com))
>>
>> Currently, `ObjectInputStream::readObject()` doesn't explicitly checks for a
>> negative array length in the deserialization
minor enhancement to have -XshowSettings launcher option display the version of
tzdata installed in the JDK
example output of the new tzdata info :
Locale settings:
default locale = English
default display locale = English
default format locale = English
tzdata version =
On Sat, 6 May 2023 02:53:49 GMT, Joe Darcy wrote:
>> Jim Laskey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> CSR recommendations
>
> src/java.base/share/classes/java/lang/StringTemplate.java line 427:
>
>> 425: * {@link
On Sat, 6 May 2023 02:42:14 GMT, Joe Darcy wrote:
>> Jim Laskey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> CSR recommendations
>
> src/java.base/share/classes/java/lang/invoke/StringConcatFactory.java line
> 123:
>
>> 121:
On Mon, 8 May 2023 12:23:27 GMT, Jaikiran Pai wrote:
>>> I could replace it by the equivalent ``
>>
>> I just locally used this as a replacement to `centerdot` and regenerated the
>> javadocs. The generated javadoc HTML looks the same like the screenshot in
>> my previous comment.
>>
>> My
On Mon, 8 May 2023 12:20:25 GMT, Jaikiran Pai wrote:
>> Alternatively, one could remove the multiplication sign altogether...
>
>> I could replace it by the equivalent ``
>
> I just locally used this as a replacement to `centerdot` and regenerated the
> javadocs. The generated javadoc HTML
On Mon, 8 May 2023 12:15:57 GMT, Raffaello Giulietti
wrote:
>> The HTML named entity `` is rendered correctly by the javadoc
>> tool. However, IntelliJ IDEA currently does not recognize it
>> (https://youtrack.jetbrains.com/issue/IDEA-316843). I could replace it by
>> the equivalent ``,
On Mon, 24 Apr 2023 12:18:55 GMT, Raffaello Giulietti
wrote:
>> Add `split()` overloads to `String` and `java.util.regex.Pattern` that, in
>> addition to the substrings returned by current `split()` variants, also
>> return the delimiters matching the regular expression.
>
> Raffaello
On Mon, 8 May 2023 11:10:36 GMT, Maurizio Cimadamore
wrote:
> Port of: https://git.openjdk.org/panama-foreign/pull/831
src/java.base/share/classes/jdk/internal/foreign/abi/AbstractLinker.java line
78:
> 76: SharedUtils.checkSymbol(symbol);
> 77: return
On Mon, 8 May 2023 12:08:06 GMT, Raffaello Giulietti
wrote:
>> src/java.base/share/classes/java/lang/String.java line 3254:
>>
>>> 3252: * If the limit is positive then the pattern will
>>> be applied
>>> 3253: *at most limit-1 times, the array's
>>> length will be
>>>
On Mon, 24 Apr 2023 12:18:55 GMT, Raffaello Giulietti
wrote:
>> Add `split()` overloads to `String` and `java.util.regex.Pattern` that, in
>> addition to the substrings returned by current `split()` variants, also
>> return the delimiters matching the regular expression.
>
> Raffaello
On Mon, 8 May 2023 11:55:05 GMT, Jaikiran Pai wrote:
>> Raffaello Giulietti has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Small optimization in private split().
>> Added tests to compare String and Pattern implementations, in
On Mon, 24 Apr 2023 12:18:55 GMT, Raffaello Giulietti
wrote:
>> Add `split()` overloads to `String` and `java.util.regex.Pattern` that, in
>> addition to the substrings returned by current `split()` variants, also
>> return the delimiters matching the regular expression.
>
> Raffaello
Port of: https://git.openjdk.org/panama-foreign/pull/831
-
Commit messages:
- Cleanup code so that restricted method check is shared
- Initial push
Changes: https://git.openjdk.org/jdk/pull/13863/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=13863=00
Issue:
On Mon, 8 May 2023 11:10:36 GMT, Maurizio Cimadamore
wrote:
> Port of: https://git.openjdk.org/panama-foreign/pull/831
src/java.base/share/classes/jdk/internal/foreign/abi/AbstractLinker.java line
86:
> 84: }
> 85:
> 86: private final MethodHandle downcallHandle0(Class callerClass,
On Mon, 8 May 2023 09:32:31 GMT, Maurizio Cimadamore
wrote:
>> Chen Liang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove assertion, no longer true with teleport definition in MHP
>
>
Attempting to make the "at-most once" nature, of invoking the supplied action
to tryAdvance, clearer in the JavaDoc.
-
Commit messages:
- JDK-8133773: clarify specification of Spliterator.tryAdvance
Changes: https://git.openjdk.org/jdk/pull/13860/files
Webrev:
On Mon, 8 May 2023 09:21:54 GMT, Aleksey Shipilev wrote:
>> Yes `done` must be volatile. Surprised this even worked as expected.
>
> Same as we saw with `isAlive` before: `LockSupport.park` implicitly provides
> a compiler barrier. This `done` should be at least "opaque" to carry the same
>
On Sun, 7 May 2023 13:34:54 GMT, Chen Liang wrote:
>> As John Rose has pointed out in this issue, the current j.l.r.Proxy based
>> implementation of MethodHandleProxies.asInterface has a few issues:
>> 1. Exposes too much information via Proxy supertype (and WrapperInstance
>> interface)
>> 2.
On Mon, 8 May 2023 05:58:26 GMT, David Holmes wrote:
>> test/micro/org/openjdk/bench/java/util/concurrent/UnparkBenchSleepersAfter.java
>> line 131:
>>
>>> 129: public void run() {
>>> 130: my_thread = Thread.currentThread();
>>> 131: while (!done) {
>>
>> You
On Thu, 4 May 2023 20:17:11 GMT, Eric Caspole wrote:
> These micros were developed while investigating JDK-8305670 by myself and
> Sergey Kuksenko. The order of thread creation was important in that bug, so
> there are 2 JMH for creating sleepers before and after the worker threads.
Cursory
On Fri, 5 May 2023 20:43:41 GMT, Erik Joelsson wrote:
> All of that said, I think we can get away with a smaller subset of targets
> and deliverables. AFAIK, graal needs the combined `graal-builder-image` as
> input to their build anyway, so they should not have any dependency on what
> the
On Fri, 5 May 2023 16:52:22 GMT, Jiangli Zhou wrote:
>> This PR is branched from the makefile changes for
>> https://bugs.openjdk.org/browse/JDK-8303796 and contains the following for
>> handling the JDK/hotspot static libraries:
>>
>> - Introduce new make target(s) for creating image/bundle
On Fri, 5 May 2023 14:31:29 GMT, Alan Bateman wrote:
>> These micros were developed while investigating JDK-8305670 by myself and
>> Sergey Kuksenko. The order of thread creation was important in that bug, so
>> there are 2 JMH for creating sleepers before and after the worker threads.
>
>
64 matches
Mail list logo
