Re: RFR: 8308780: Fix the Java Integer types on Windows

2023-05-31 Thread Julian Waters
On Wed, 24 May 2023 13:56:05 GMT, Julian Waters wrote: > On Windows, the basic Java Integer types are defined as long and __int64 > respectively. In particular, the former is rather problematic since it breaks > compilation as the Visual C++ becomes stricter and more compliant with every > rel

Re: RFR: 8308803: Improve java/util/UUID/UUIDTest.java [v2]

2023-05-31 Thread Aleksey Shipilev
On Tue, 30 May 2023 20:55:39 GMT, Roger Riggs wrote: >> Aleksey Shipilev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Review comments > > test/jdk/java/util/UUID/UUIDTest.java line 79: > >> 77: } >> 78: if (!s

Re: RFR: JDK-8306584: Start of release updates for JDK 22 [v3]

2023-05-31 Thread David Holmes
On Tue, 30 May 2023 22:16:08 GMT, Joe Darcy wrote: >> Time to get JDK 22 underway... > > Joe Darcy has updated the pull request with a new target base due to a merge > or a rebase. The pull request now contains 24 commits: > > - Merge branch 'master' into JDK-8306584 > - Merge branch 'master'

Re: RFR: JDK-8308288: Fix xlc17 clang warnings in shared code [v2]

2023-05-31 Thread JoKern65
On Tue, 30 May 2023 21:44:17 GMT, JoKern65 wrote: >> src/hotspot/share/runtime/javaThread.cpp line 115: >> >>> 113: #include >>> 114: #endif >>> 115: >> >> Could these conditionals be included in globalDefinitions_xlc.hpp instead? > > In principle the `#include ` could be included in > globa

Re: RFR: 8289220: [Shenandoah] TestAllocObjectArrays fails intermittently

2023-05-31 Thread SUN Guoyun
On Tue, 30 May 2023 08:31:08 GMT, SUN Guoyun wrote: > command: make test CONF=fastdebug JTREG="VM_OPTIONS=-Xcomp" > TEST=gc/TestAllocHumongousFragment.java > error info: > > Caused by: java.lang.NullPointerException: Cannot invoke > "sun.util.locale.BaseLocale.getVariant()" because "base" is

RFR: 8304438: jcmd JVMTI.agent_load should obey EnableDynamicAgentLoading

2023-05-31 Thread Serguei Spitsyn
The VM option EnableDynamicAgentLoading was added in JDK 9, default true, to allow deployment to choose whether to allow agents to be loaded/started in the VM. The VM option does the right thing for tools using the Attach API but jcmd JVMTI.agent_load was missed. This should be fixed to disallow

Re: RFR: JDK-8027711: Unify wildcarding syntax for CompileCommand and CompileOnly [v2]

2023-05-31 Thread Christian Hagedorn
On Tue, 23 May 2023 09:08:20 GMT, Tobias Holenstein wrote: >> At the moment `CompileCommand` and `CompileOnly` use different syntax for >> matching methods. >> >> ### Old CompileOnly format >> - matching a **method name** with **class name** and **package name**: >> `-XX:CompileOnly=package/p

Re: RFR: JDK-8282797: CompileCommand parsing errors should exit VM [v3]

2023-05-31 Thread Christian Hagedorn
On Wed, 24 May 2023 11:05:01 GMT, Tobias Holenstein wrote: >> Currently, errors during compile command parsing just print an error but >> don't exit the VM. As a result, issues go unnoticed. >> >> With this PR the behavior is changed to exit the VM when an error occurs. >> >> E.g. `java -XX:

Re: RFR: 8308748: JNU_GetStringPlatformChars may write to String's internal memory array [v2]

2023-05-31 Thread Rudi Horn
On Fri, 26 May 2023 19:54:07 GMT, Rudi Horn wrote: >> This change prevents the contents of the internal string array from being >> copied back when releasing it. > > Rudi Horn has updated the pull request with a new target base due to a merge > or a rebase. The pull request now contains one com

Re: RFR: 8302987: Add uniform and spatially equidistributed bounded double streams to RandomGenerator [v10]

2023-05-31 Thread Raffaello Giulietti
> The `default` method `nextDouble(double origin, double bound)` in > `java.util.random.RandomGenerator` aims at generating a uniformly and > spatially equidistributed random `double` in the left-closed and right-open > range [`origin`, `bound`). It does so by applying the affine transform > `o

Re: RFR: 8308090: Add container tests for on-the-fly resource quota updates [v2]

2023-05-31 Thread Severin Gehwolf
On Tue, 23 May 2023 09:04:11 GMT, Severin Gehwolf wrote: >> Please review these test changes which implement automatic testing of >> container resource updates without JVM restart. Note that this merely tests >> container detection code handling this case. It doesn't do anything special >> for

Re: RFR: 6983726: Reimplement MethodHandleProxies.asInterfaceInstance [v16]

2023-05-31 Thread Johannes Kuhn
On Wed, 31 May 2023 00:49:22 GMT, Mandy Chung wrote: >>> Apparently, calling utility methods from sun.invoke, like the >>> ensureOriginalLookup in this patch, also triggers this check. >> >> It should not trigger `checkPackageAccess` if it does not implement the >> interface AFAICT. >> >> It

Re: RFR: JDK-8306112 Implementation of JEP 445: Unnamed Classes and Instance Main Methods (Preview) [v23]

2023-05-31 Thread Jim Laskey
> Add flexible main methods and anonymous main classes to the Java language. Jim Laskey has updated the pull request incrementally with one additional commit since the last revision: Remove mandated flag - Changes: - all: https://git.openjdk.org/jdk/pull/13689/files - new: ht

Re: RFR: JDK-8306112 Implementation of JEP 445: Unnamed Classes and Instance Main Methods (Preview) [v24]

2023-05-31 Thread Jim Laskey
> Add flexible main methods and anonymous main classes to the Java language. Jim Laskey has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 40 commits: - Merge branch 'master' into 8306112 - Remove mandated flag - Remove trailing white

Re: RFR: 8308803: Improve java/util/UUID/UUIDTest.java [v2]

2023-05-31 Thread Roger Riggs
On Wed, 31 May 2023 07:38:39 GMT, Aleksey Shipilev wrote: >> test/jdk/java/util/UUID/UUIDTest.java line 79: >> >>> 77: } >>> 78: if (!set.add(u)) { >>> 79: throw new Exception("UUID collision: " + u); >> >> I would be concerned that if this failure was re

Re: RFR: 8291966: SwitchBootstrap.typeSwitch could be faster [v2]

2023-05-31 Thread Francesco Nigro
On Tue, 30 May 2023 09:32:02 GMT, Jan Lahoda wrote: >> @forax >> >> Hi! Sorry for this sudden message, but this one captured my attention >> >>> and subtype checks are usually fast. >> >> And I hope this PR to be the right place to raise this. >> >> I was looking this PR to better understand

Re: RFR: 8306647: Implementation of Structured Concurrency (Preview) [v2]

2023-05-31 Thread Alan Bateman
On Tue, 30 May 2023 17:31:54 GMT, Rémi Forax wrote: > One surprising thing is that Subtask.get() give less leeway to the owner > thread than to the other virtual threads so in onComplete() storing a Subtask > to use it later by the owner thread does not work well if join() is not > called yet.

Re: RFR: 8308286 Fix clang warnings in linux code [v3]

2023-05-31 Thread Artem Semenov
> When using the clang compiler to build OpenJDk on Linux, we encounter various > "warnings as errors". > They can be fixed with small changes. Artem Semenov has updated the pull request incrementally with one additional commit since the last revision: update - Changes: - all:

Re: RFR: 8308286 Fix clang warnings in linux code [v3]

2023-05-31 Thread Artem Semenov
On Sun, 28 May 2023 03:57:40 GMT, Kim Barrett wrote: >> Artem Semenov has updated the pull request incrementally with one additional >> commit since the last revision: >> >> update > > src/java.desktop/unix/native/libawt_xawt/awt/gtk2_interface.c line 1163: > >> 1161: #if defined(__clang__)

Re: RFR: 8308286 Fix clang warnings in linux code [v2]

2023-05-31 Thread Artem Semenov
On Tue, 30 May 2023 08:14:59 GMT, Alexey Ushakov wrote: >> Artem Semenov has updated the pull request incrementally with one additional >> commit since the last revision: >> >> update > > src/jdk.hotspot.agent/linux/native/libsaproc/ps_core.c line 655: > >> 653: // linker loaded it. We

Re: RFR: 8308286 Fix clang warnings in linux code [v3]

2023-05-31 Thread Weijun Wang
On Wed, 31 May 2023 13:37:06 GMT, Artem Semenov wrote: >> When using the clang compiler to build OpenJDk on Linux, we encounter >> various "warnings as errors". >> They can be fixed with small changes. > > Artem Semenov has updated the pull request incrementally with one additional > commit sin

Re: RFR: 8308452: Extend internal Architecture enum with byte order and address size [v3]

2023-05-31 Thread Roger Riggs
> The internal enum jdk.internal.util.Architecture does not provide information > about the big or little endianness or the address size (64 or 32 bits). The > endian-ness and address size are intrinsic to the architecture. > > The values of the enum are extended to separately identify the big

Re: RFR: 8308803: Improve java/util/UUID/UUIDTest.java [v2]

2023-05-31 Thread Aleksey Shipilev
On Wed, 31 May 2023 13:11:08 GMT, Roger Riggs wrote: >> This is a non-practical concern, IMO. By spec, `UUID.randomUUID` is >> generated from the cryptographically secure random, with >120 bits of >> randomness, so the collision is extremely unlikely. Collision math involves >> birthday parado

RFR: 8308031: Linkers should reject unpromoted variadic parameters

2023-05-31 Thread Jorn Vernee
In C, arguments smaller than `int` are promoted to (`unsigned`) `int`, and `float` is promoted to `double`, when being passed as variadic argument (see e.g. https://en.cppreference.com/w/c/language/conversion#Default_argument_promotions). This patch restricts the layouts that can be used as var

Re: RFR: 8291966: SwitchBootstrap.typeSwitch could be faster [v3]

2023-05-31 Thread Jan Lahoda
On Mon, 29 May 2023 07:25:26 GMT, Jan Lahoda wrote: >> The pattern matching switches are using a bootstrap method >> `SwitchBootstrap.typeSwitch` to implement the jumps in the switch. >> Basically, for a switch like: >> >> switch (obj) { >> case String s when s.isEmpty() -> {} >> case

Re: RFR: 8308803: Improve java/util/UUID/UUIDTest.java [v2]

2023-05-31 Thread Roger Riggs
On Wed, 31 May 2023 14:05:20 GMT, Aleksey Shipilev wrote: >> My point was that its probably not practical to test (more than once). >> If it fails, it will be considered just as you propose and disregarded and >> in the meantime consumes test cycles in each of the test contexts. Either >> pro

Re: RFR: 8304914: Use OperatingSystem, Architecture, and Version in jpackage [v5]

2023-05-31 Thread Roger Riggs
> Refactor the Platform class in jdk.jpackage to use the internal > OperatingSystem, Architecture, and Version classes. > The OperatingSystem.isXXX() and Architecture.isYYY() methods replace > comparisons in the Platform class. > The checks of the os.version are replaced but may not be needed if

Re: RFR: 8304914: Use OperatingSystem, Architecture, and Version in jpackage [v6]

2023-05-31 Thread Roger Riggs
> Refactor the Platform class in jdk.jpackage to use the internal > OperatingSystem, Architecture, and Version classes. > The OperatingSystem.isXXX() and Architecture.isYYY() methods replace > comparisons in the Platform class. > The checks of the os.version are replaced but may not be needed if

Re: RFR: 8308803: Improve java/util/UUID/UUIDTest.java [v2]

2023-05-31 Thread Aleksey Shipilev
On Wed, 31 May 2023 14:17:40 GMT, Roger Riggs wrote: > Two thoughts here. The random number source (SecureRandom) should have its > own tests, UUID has a simple dependency on a generator. The test for UUID is > that it composes the bits into the UUID correctly. The randomness of the > generato

Re: RFR: 8308803: Improve java/util/UUID/UUIDTest.java [v3]

2023-05-31 Thread Aleksey Shipilev
> UUID is very important class that is used to track identities of objects in > large scale systems. Yet, the coverage in JDK test is disappointing: it tests > only 100 of UUID instances per test, which is way too small to detect > collisions due to the bad randomness for example. > > I have so

Re: RFR: 8308031: Linkers should reject unpromoted variadic parameters

2023-05-31 Thread Maurizio Cimadamore
On Wed, 31 May 2023 15:39:31 GMT, Maurizio Cimadamore wrote: >> In C, arguments smaller than `int` are promoted to (`unsigned`) `int`, and >> `float` is promoted to `double`, when being passed as variadic argument (see >> e.g. >> https://en.cppreference.com/w/c/language/conversion#Default_arg

Re: RFR: 8308031: Linkers should reject unpromoted variadic parameters

2023-05-31 Thread Maurizio Cimadamore
On Tue, 30 May 2023 17:25:35 GMT, Jorn Vernee wrote: > In C, arguments smaller than `int` are promoted to (`unsigned`) `int`, and > `float` is promoted to `double`, when being passed as variadic argument (see > e.g. > https://en.cppreference.com/w/c/language/conversion#Default_argument_promoti

Re: RFR: 8304914: Use OperatingSystem, Architecture, and Version in jpackage [v6]

2023-05-31 Thread Roger Riggs
On Wed, 31 May 2023 14:32:25 GMT, Roger Riggs wrote: >> Refactor the Platform class in jdk.jpackage to use the internal >> OperatingSystem, Architecture, and Version classes. >> The OperatingSystem.isXXX() and Architecture.isYYY() methods replace >> comparisons in the Platform class. >> The che

Re: RFR: 6983726: Reimplement MethodHandleProxies.asInterfaceInstance [v16]

2023-05-31 Thread Mandy Chung
On Wed, 31 May 2023 12:38:14 GMT, Johannes Kuhn wrote: >>> Then we still need to obtain the implemented interface and original method >>> handle information every time they are queried. Having these information >>> (or the method handle providing access) computed early is more convenient. >> >

Integrated: 8308316: Default decomposition mode in Collator

2023-05-31 Thread Naoto Sato
On Thu, 18 May 2023 18:02:32 GMT, Naoto Sato wrote: > Amending the description about the default decomposition mode in > `Collator.NO_DECOMPOSITION` javadoc. This pull request has now been integrated. Changeset: 12649025 Author:Naoto Sato URL: https://git.openjdk.org/jdk/commit/126

Re: RFR: 8308452: Extend internal Architecture enum with byte order and address size [v3]

2023-05-31 Thread Naoto Sato
On Wed, 31 May 2023 14:08:09 GMT, Roger Riggs wrote: >> The internal enum jdk.internal.util.Architecture does not provide >> information about the big or little endianness or the address size (64 or 32 >> bits). The endian-ness and address size are intrinsic to the architecture. >> >> The val

Re: RFR: 8289220: [Shenandoah] TestAllocObjectArrays fails intermittently

2023-05-31 Thread Alan Bateman
On Wed, 31 May 2023 10:00:18 GMT, SUN Guoyun wrote: > Jtreg tier1 can trigger the same error with vmoptions:"-Xcomp > -XX:+UseShenandoahGC -XX:ShenandoahGCHeuristics=aggressive > -XX:+ShenandoahOOMDuringEvacALot I found the GC occurs between when the soft > reference is assigned and when it is

Integrated: 8308022: update for deprecated sprintf for java.base

2023-05-31 Thread Xue-Lei Andrew Fan
On Fri, 12 May 2023 17:57:43 GMT, Xue-Lei Andrew Fan wrote: > Hi, > > May I have this update reviewed? > > The sprintf is deprecated in Xcode 14, and Microsoft Virtual Studio, because > of security concerns. The issue was addressed in > [JDK-8296812](https://bugs.openjdk.org/browse/JDK-829681

Integrated: 8299505: findVirtual on array classes incorrectly restricts the receiver type

2023-05-31 Thread Chen Liang
On Sat, 6 May 2023 18:15:56 GMT, Chen Liang wrote: > The access hack for array class clone is only applied to `checkAccess` but > missing before call to `restrictProtectedReceiver`, causing the array > receiver type to be incorrectly replaced by the lookupClass type. This patch > fixes that an

Re: Integrated: 8309230: ProblemList jdk/incubator/vector/Float64VectorTests.java on aarch64

2023-05-31 Thread Daniel D . Daugherty
On Wed, 31 May 2023 16:48:06 GMT, Joe Darcy wrote: >> A couple of trivial ProblemListings: >> [JDK-8309230](https://bugs.openjdk.org/browse/JDK-8309230) ProblemList >> jdk/incubator/vector/Float64VectorTests.java on aarch64 >> [JDK-8309231](https://bugs.openjdk.org/browse/JDK-8309231) ProblemLis

Integrated: 8309230: ProblemList jdk/incubator/vector/Float64VectorTests.java on aarch64

2023-05-31 Thread Daniel D . Daugherty
A couple of trivial ProblemListings: [JDK-8309230](https://bugs.openjdk.org/browse/JDK-8309230) ProblemList jdk/incubator/vector/Float64VectorTests.java on aarch64 [JDK-8309231](https://bugs.openjdk.org/browse/JDK-8309231) ProblemList vmTestbase/nsk/jvmti/scenarios/jni_interception/JI05/ji05t001/

Re: Integrated: 8309230: ProblemList jdk/incubator/vector/Float64VectorTests.java on aarch64

2023-05-31 Thread Joe Darcy
On Wed, 31 May 2023 16:40:54 GMT, Daniel D. Daugherty wrote: > A couple of trivial ProblemListings: > [JDK-8309230](https://bugs.openjdk.org/browse/JDK-8309230) ProblemList > jdk/incubator/vector/Float64VectorTests.java on aarch64 > [JDK-8309231](https://bugs.openjdk.org/browse/JDK-8309231) Pro

Integrated: 8309230: ProblemList jdk/incubator/vector/Float64VectorTests.java on aarch64

2023-05-31 Thread Daniel D . Daugherty
On Wed, 31 May 2023 16:40:54 GMT, Daniel D. Daugherty wrote: > A couple of trivial ProblemListings: > [JDK-8309230](https://bugs.openjdk.org/browse/JDK-8309230) ProblemList > jdk/incubator/vector/Float64VectorTests.java on aarch64 > [JDK-8309231](https://bugs.openjdk.org/browse/JDK-8309231) Pro

Re: RFR: 8304914: Use OperatingSystem, Architecture, and Version in jpackage [v6]

2023-05-31 Thread Alexey Semenyuk
On Wed, 31 May 2023 14:32:25 GMT, Roger Riggs wrote: >> Refactor the Platform class in jdk.jpackage to use the internal >> OperatingSystem, Architecture, and Version classes. >> The OperatingSystem.isXXX() and Architecture.isYYY() methods replace >> comparisons in the Platform class. >> The che

Re: RFR: JDK-8306584: Start of release updates for JDK 22 [v3]

2023-05-31 Thread Jan Lahoda
On Tue, 30 May 2023 22:16:08 GMT, Joe Darcy wrote: >> Time to get JDK 22 underway... > > Joe Darcy has updated the pull request with a new target base due to a merge > or a rebase. The pull request now contains 24 commits: > > - Merge branch 'master' into JDK-8306584 > - Merge branch 'master'

Re: RFR: 8308452: Extend internal Architecture enum with byte order and address size [v4]

2023-05-31 Thread Roger Riggs
> The internal enum jdk.internal.util.Architecture does not provide information > about the big or little endianness or the address size (64 or 32 bits). The > endian-ness and address size are intrinsic to the architecture. > > The values of the enum are extended to separately identify the big

Re: RFR: 8301569: list mode of jmod and jimage cannot be used normally in turkish locale

2023-05-31 Thread Mandy Chung
On Sun, 29 Jan 2023 15:37:28 GMT, Glavo wrote: > When the default Locale is `tr`, the jmod and jimage commands have the > following problems: > > * The jmod command does not correctly recognize the `list` mode typed in > lowercase; > * The jimage command cannot obtain the help information of t

Re: RFR: 8308803: Improve java/util/UUID/UUIDTest.java [v3]

2023-05-31 Thread Roger Riggs
On Wed, 31 May 2023 14:53:09 GMT, Aleksey Shipilev wrote: >> UUID is very important class that is used to track identities of objects in >> large scale systems. Yet, the coverage in JDK test is disappointing: it >> tests only 100 of UUID instances per test, which is way too small to detect >>

Re: RFR: 8308803: Improve java/util/UUID/UUIDTest.java [v2]

2023-05-31 Thread Roger Riggs
On Wed, 31 May 2023 14:46:59 GMT, Aleksey Shipilev wrote: >> Two thoughts here. >> The random number source (SecureRandom) should have its own tests, UUID has >> a simple dependency on a generator. >> The test for UUID is that it composes the bits into the UUID correctly. The >> randomness

Re: RFR: JDK-8282797: CompileCommand parsing errors should exit VM [v3]

2023-05-31 Thread Vladimir Kozlov
On Wed, 24 May 2023 11:05:01 GMT, Tobias Holenstein wrote: >> Currently, errors during compile command parsing just print an error but >> don't exit the VM. As a result, issues go unnoticed. >> >> With this PR the behavior is changed to exit the VM when an error occurs. >> >> E.g. `java -XX:

Integrated: 8304914: Use OperatingSystem, Architecture, and Version in jpackage

2023-05-31 Thread Roger Riggs
On Fri, 21 Apr 2023 17:28:54 GMT, Roger Riggs wrote: > Refactor the Platform class in jdk.jpackage to use the internal > OperatingSystem, Architecture, and Version classes. > The OperatingSystem.isXXX() and Architecture.isYYY() methods replace > comparisons in the Platform class. > The checks o

Re: RFR: 8301569: list mode of jmod and jimage cannot be used normally in turkish locale

2023-05-31 Thread Glavo
On Sun, 29 Jan 2023 23:54:21 GMT, Glavo wrote: >> When the default Locale is `tr`, the jmod and jimage commands have the >> following problems: >> >> * The jmod command does not correctly recognize the `list` mode typed in >> lowercase; >> * The jimage command cannot obtain the help informatio

Re: RFR: JDK-8308288: Fix xlc17 clang warnings in shared code [v2]

2023-05-31 Thread Phil Race
On Fri, 26 May 2023 08:31:46 GMT, JoKern65 wrote: >> When using the new xlc17 compiler (based on a recent clang) to build OpenJDk >> on AIX , we run into various "warnings as errors". >> Some of those are in shared codebase and could be addressed by small >> adjustments. >> A lot of those chang

Re: RFR: JDK-8306584: Start of release updates for JDK 22 [v4]

2023-05-31 Thread Joe Darcy
> Time to get JDK 22 underway... Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 26 commits: - Respond to review comments. - Merge branch 'master' into JDK-8306584 - Merge branch 'master' into JDK-8306584 - Merge branch

Re: RFR: JDK-8306584: Start of release updates for JDK 22 [v3]

2023-05-31 Thread Joe Darcy
On Wed, 31 May 2023 18:02:09 GMT, Jan Lahoda wrote: >> Joe Darcy has updated the pull request with a new target base due to a merge >> or a rebase. The pull request now contains 24 commits: >> >> - Merge branch 'master' into JDK-8306584 >> - Merge branch 'master' into JDK-8306584 >> - Merge

Integrated: 8309236: ProblemList java/util/concurrent/locks/Lock/OOMEInAQS.java with ZGC and Generational ZGC again

2023-05-31 Thread Daniel D . Daugherty
A trivial fix to ProblemList java/util/concurrent/locks/Lock/OOMEInAQS.java with ZGC and Generational ZGC again - Commit messages: - 8309236: ProblemList java/util/concurrent/locks/Lock/OOMEInAQS.java with ZGC and Generational ZGC again Changes: https://git.openjdk.org/jdk/pull/14

Re: Integrated: 8309236: ProblemList java/util/concurrent/locks/Lock/OOMEInAQS.java with ZGC and Generational ZGC again

2023-05-31 Thread Brian Burkhalter
On Wed, 31 May 2023 20:34:07 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList java/util/concurrent/locks/Lock/OOMEInAQS.java > with ZGC and Generational ZGC again Marked as reviewed by bpb (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/14253#pullrequestre

Re: Integrated: 8309236: ProblemList java/util/concurrent/locks/Lock/OOMEInAQS.java with ZGC and Generational ZGC again

2023-05-31 Thread Alexander Zvegintsev
On Wed, 31 May 2023 20:34:07 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList java/util/concurrent/locks/Lock/OOMEInAQS.java > with ZGC and Generational ZGC again Marked as reviewed by azvegint (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/14253#pullrequ

Re: Integrated: 8309236: ProblemList java/util/concurrent/locks/Lock/OOMEInAQS.java with ZGC and Generational ZGC again

2023-05-31 Thread Daniel D . Daugherty
On Wed, 31 May 2023 20:38:23 GMT, Brian Burkhalter wrote: >> A trivial fix to ProblemList java/util/concurrent/locks/Lock/OOMEInAQS.java >> with ZGC and Generational ZGC again > > Marked as reviewed by bpb (Reviewer). @bplb and @azvegint - Thanks for the fast reviews! - PR Comment

Integrated: 8309236: ProblemList java/util/concurrent/locks/Lock/OOMEInAQS.java with ZGC and Generational ZGC again

2023-05-31 Thread Daniel D . Daugherty
On Wed, 31 May 2023 20:34:07 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList java/util/concurrent/locks/Lock/OOMEInAQS.java > with ZGC and Generational ZGC again This pull request has now been integrated. Changeset: e42a4b65 Author:Daniel D. Daugherty URL: https://g

Re: RFR: 8303530: Redefine JAXP Configuration File [v14]

2023-05-31 Thread Joe Wang
> Add a system property, jdk.xml.config.file, to return the path to a custom > JAXP configuration file. The current configuration file, jaxp.properties, > that the JDK supports will become the default configuration file. > > CSR: https://bugs.openjdk.org/browse/JDK-8303531 > > Tests: XML SQE an

Re: RFR: 8303530: Redefine JAXP Configuration File [v14]

2023-05-31 Thread Lance Andersen
On Wed, 31 May 2023 21:09:57 GMT, Joe Wang wrote: >> Add a system property, jdk.xml.config.file, to return the path to a custom >> JAXP configuration file. The current configuration file, jaxp.properties, >> that the JDK supports will become the default configuration file. >> >> CSR: https://b

Re: RFR: 8303530: Redefine JAXP Configuration File [v14]

2023-05-31 Thread Joe Wang
On Wed, 31 May 2023 21:19:42 GMT, Lance Andersen wrote: >> Joe Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> additional javadoc update > > src/java.xml/share/classes/module-info.java line 153: > >> 151: * User-defined Configurat

Re: RFR: 8303530: Redefine JAXP Configuration File [v15]

2023-05-31 Thread Joe Wang
> Add a system property, jdk.xml.config.file, to return the path to a custom > JAXP configuration file. The current configuration file, jaxp.properties, > that the JDK supports will become the default configuration file. > > CSR: https://bugs.openjdk.org/browse/JDK-8303531 > > Tests: XML SQE an

Re: RFR: 8309191: Reduce JDK dependencies of cgroup support

2023-05-31 Thread Aleksandar Pejović
On Tue, 30 May 2023 13:48:49 GMT, Severin Gehwolf wrote: >> The current code for cgroup support in the JDK has large and expensive >> dependencies: it uses NIO, streams, and regular expressions. This leads to >> unnecessary class loading and slows down startup, especially when the code >> is e

RFR: 8309191: Reduce JDK dependencies of cgroup support

2023-05-31 Thread Aleksandar Pejović
The current code for cgroup support in the JDK has large and expensive dependencies: it uses NIO, streams, and regular expressions. This leads to unnecessary class loading and slows down startup, especially when the code is executed early during an application startup. This is especially a probl

Re: RFR: 8309191: Reduce JDK dependencies of cgroup support

2023-05-31 Thread Severin Gehwolf
On Wed, 31 May 2023 09:38:08 GMT, Aleksandar Pejović wrote: >> @pejovica Please enable GHA testing on your fork. Once enabled, please merge >> latest master into your branch so as to trigger a GHA run. Thanks! > > @jerboaa I enabled GḪA testing. Other than a couple of Windows errors (which > se

Re: RFR: 8309191: Reduce JDK dependencies of cgroup support

2023-05-31 Thread Aleksandar Pejović
On Wed, 31 May 2023 12:54:57 GMT, Severin Gehwolf wrote: > Yes, I'll try to do a review later today or tomorrow. Awesome, thanks! - PR Comment: https://git.openjdk.org/jdk/pull/14216#issuecomment-1570276516

Re: RFR: 8309191: Reduce JDK dependencies of cgroup support

2023-05-31 Thread Severin Gehwolf
On Tue, 30 May 2023 13:03:27 GMT, Aleksandar Pejović wrote: > The current code for cgroup support in the JDK has large and expensive > dependencies: it uses NIO, streams, and regular expressions. This leads to > unnecessary class loading and slows down startup, especially when the code is > ex

Re: RFR: 8309191: Reduce JDK dependencies of cgroup support

2023-05-31 Thread Aleksandar Pejović
On Wed, 31 May 2023 09:38:08 GMT, Aleksandar Pejović wrote: >> @pejovica Please enable GHA testing on your fork. Once enabled, please merge >> latest master into your branch so as to trigger a GHA run. Thanks! > > @jerboaa I enabled GḪA testing. Other than a couple of Windows errors (which > se

Re: RFR: 8309191: Reduce JDK dependencies of cgroup support

2023-05-31 Thread Severin Gehwolf
On Wed, 31 May 2023 12:21:13 GMT, Aleksandar Pejović wrote: > I guess I'll have to wait for OCA verification. Yes. > One failure is due to a lack of reviewers, so would you be able to do a > review? Yes, I'll try to do a review later today or tomorrow. Thanks! - PR Comment: htt

Re: RFR: 8308031: Linkers should reject unpromoted variadic parameters

2023-05-31 Thread Jorn Vernee
On Wed, 31 May 2023 15:39:54 GMT, Maurizio Cimadamore wrote: >> test/jdk/java/foreign/StdLibTest.java line 386: >> >>> 384: return arena.allocateUtf8String("str"); >>> 385: }, "str"), >>> 386: CHAR(int.class, C_INT, "%c", arena -> (int) 'h', (int) 'h'), >>> // promo

Re: RFR: 8308031: Linkers should reject unpromoted variadic parameters [v2]

2023-05-31 Thread Jorn Vernee
> In C, arguments smaller than `int` are promoted to (`unsigned`) `int`, and > `float` is promoted to `double`, when being passed as variadic argument (see > e.g. > https://en.cppreference.com/w/c/language/conversion#Default_argument_promotions). > This patch restricts the layouts that can be u

Re: RFR: 8308031: Linkers should reject unpromoted variadic parameters [v2]

2023-05-31 Thread Jorn Vernee
On Wed, 31 May 2023 15:37:57 GMT, Maurizio Cimadamore wrote: >> Jorn Vernee has updated the pull request incrementally with one additional >> commit since the last revision: >> >> review comments > > src/java.base/share/classes/java/lang/foreign/Linker.java line 415: > >> 413: * It should

Re: RFR: 8308748: JNU_GetStringPlatformChars may write to String's internal memory array [v2]

2023-05-31 Thread David Holmes
On Fri, 26 May 2023 19:54:07 GMT, Rudi Horn wrote: >> This change prevents the contents of the internal string array from being >> copied back when releasing it. > > Rudi Horn has updated the pull request with a new target base due to a merge > or a rebase. The pull request now contains one com

Re: RFR: 8308031: Linkers should reject unpromoted variadic parameters [v2]

2023-05-31 Thread Maurizio Cimadamore
On Wed, 31 May 2023 22:44:52 GMT, Jorn Vernee wrote: >> In C, arguments smaller than `int` are promoted to (`unsigned`) `int`, and >> `float` is promoted to `double`, when being passed as variadic argument (see >> e.g. >> https://en.cppreference.com/w/c/language/conversion#Default_argument_pro

Re: RFR: 8308031: Linkers should reject unpromoted variadic parameters [v2]

2023-05-31 Thread Maurizio Cimadamore
On Wed, 31 May 2023 23:35:08 GMT, Maurizio Cimadamore wrote: >> Jorn Vernee has updated the pull request incrementally with one additional >> commit since the last revision: >> >> review comments > > src/java.base/share/classes/java/lang/foreign/Linker.java line 368: > >> 366: * Variadic f

Re: RFR: 8308031: Linkers should reject unpromoted variadic parameters [v2]

2023-05-31 Thread Maurizio Cimadamore
On Wed, 31 May 2023 22:44:52 GMT, Jorn Vernee wrote: >> In C, arguments smaller than `int` are promoted to (`unsigned`) `int`, and >> `float` is promoted to `double`, when being passed as variadic argument (see >> e.g. >> https://en.cppreference.com/w/c/language/conversion#Default_argument_pro

Re: RFR: 8308031: Linkers should reject unpromoted variadic parameters [v2]

2023-05-31 Thread Jorn Vernee
On Wed, 31 May 2023 23:36:33 GMT, Maurizio Cimadamore wrote: >> src/java.base/share/classes/java/lang/foreign/Linker.java line 368: >> >>> 366: * Variadic functions >>> 367: * >>> 368: * Variadic functions (e.g. a C function declared with a trailing >>> ellipses {@code ...} at the end of th

Re: RFR: 8308031: Linkers should reject unpromoted variadic parameters [v2]

2023-05-31 Thread Jorn Vernee
On Wed, 31 May 2023 23:41:25 GMT, Maurizio Cimadamore wrote: >> Jorn Vernee has updated the pull request incrementally with one additional >> commit since the last revision: >> >> review comments > > src/java.base/share/classes/java/lang/foreign/Linker.java line 379: > >> 377: * type {@cod

Re: RFR: 8308748: JNU_GetStringPlatformChars may write to String's internal memory array [v2]

2023-05-31 Thread Roger Riggs
On Fri, 26 May 2023 19:54:07 GMT, Rudi Horn wrote: >> This change prevents the contents of the internal string array from being >> copied back when releasing it. > > Rudi Horn has updated the pull request with a new target base due to a merge > or a rebase. The pull request now contains one com

Re: RFR: 8308090: Add container tests for on-the-fly resource quota updates [v2]

2023-05-31 Thread David Holmes
On Wed, 31 May 2023 12:07:49 GMT, Severin Gehwolf wrote: >> Severin Gehwolf has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains three additional >>

Re: RFR: 8309191: Reduce JDK dependencies of cgroup support

2023-05-31 Thread David Holmes
On Wed, 31 May 2023 13:49:46 GMT, Aleksandar Pejović wrote: >>> I guess I'll have to wait for OCA verification. >> >> Yes. >> >>> One failure is due to a lack of reviewers, so would you be able to do a >>> review? >> >> Yes, I'll try to do a review later today or tomorrow. >> >> Thanks! > >>

Re: RFR: 8308748: JNU_GetStringPlatformChars may write to String's internal memory array [v2]

2023-05-31 Thread Alan Bateman
On Wed, 31 May 2023 11:49:00 GMT, Rudi Horn wrote: > I have not checked other uses, but they are probably not as critical yet > given the special status and frequent use of strings. I can possibly revisit > this issue in the future in a further issue / PR if I find time at some stage. Okay, we

Re: RFR: 8308748: JNU_GetStringPlatformChars may write to String's internal memory array [v2]

2023-05-31 Thread Alan Bateman
On Fri, 26 May 2023 19:54:07 GMT, Rudi Horn wrote: >> This change prevents the contents of the internal string array from being >> copied back when releasing it. > > Rudi Horn has updated the pull request with a new target base due to a merge > or a rebase. The pull request now contains one com

Re: RFR: 8309191: Reduce JDK dependencies of cgroup support

2023-05-31 Thread Alan Bateman
On Tue, 30 May 2023 13:03:27 GMT, Aleksandar Pejović wrote: > The current code for cgroup support in the JDK has large and expensive > dependencies: it uses NIO, streams, and regular expressions. This leads to > unnecessary class loading and slows down startup, especially when the code is > ex

Re: RFR: 8308090: Add container tests for on-the-fly resource quota updates [v2]

2023-05-31 Thread David Holmes
On Tue, 23 May 2023 09:04:11 GMT, Severin Gehwolf wrote: >> Please review these test changes which implement automatic testing of >> container resource updates without JVM restart. Note that this merely tests >> container detection code handling this case. It doesn't do anything special >> for

Re: RFR: 8289220: [Shenandoah] TestAllocObjectArrays fails intermittently [v2]

2023-05-31 Thread SUN Guoyun
> command: make test CONF=fastdebug JTREG="VM_OPTIONS=-Xcomp" > TEST=gc/TestAllocHumongousFragment.java > error info: > > Caused by: java.lang.NullPointerException: Cannot invoke > "sun.util.locale.BaseLocale.getVariant()" because "base" is null > at java.base/java.util.Locale.forLanguageTag(Lo