On Fri, 7 Jul 2023 19:35:53 GMT, Jorn Vernee wrote:
>> Yes, it does pass the test with above changes.
>
> Ok, please use the above changes instead then.
Sure, Thank you
-
PR Review Comment: https://git.openjdk.org/jdk/pull/14801#discussion_r1256959506
> [PR 14578 ](https://github.com/openjdk/jdk/pull/14578) still has unresolved
> discussions, continue to make improvements.
>
> # Benchmark Result
>
>
> sh make/devkit/createJMHBundle.sh
> bash configure --with-jmh=build/jmh/jars
> make test TEST="micro:java.util.UUIDBench.toString"
>
>
> ##
On Fri, 7 Jul 2023 15:09:07 GMT, Roger Riggs wrote:
>> 温绍锦 has updated the pull request incrementally with one additional commit
>> since the last revision:
>>
>> code style
>
> src/java.base/share/classes/java/util/UUID.java line 475:
>
>> 473: long msb = mostSigBits;
>> 474:
Hi Ryan,
Thanks for trying out JDK 21 early access.
The issue you raise is indeed an inconsistency, but it's not clear which way it
should be resolved, or even whether it needs to be resolved, as the consequences are
quite minor.
Specifically, when the Sequenced Collections JEP was integrate
> Can I get a preliminary review of the wording for Deque.reversed()? If the
> text is good, I'll make corresponding changes to the implSpecs of the other
> reversed() default methods, namely those in List, SortedMap, and SortedSet
> and then file the CSR.
Stuart Marks has updated the pull requ
On Fri, 7 Jul 2023 15:02:54 GMT, Roger Riggs wrote:
> Is there a significant performance difference?
Yes, see https://github.com/openjdk/jdk/pull/14745#issuecomment-1615435719 for
the revision at
https://github.com/openjdk/jdk/pull/14745/commits/425559f65a3e5f72323abdadbbf9df426e196d9b
On my d
> In java.time packages, clarify timeline order javadoc to mention "before" and
> "after" in the value of the `compareTo` method return values.
> Add javadoc @see tags to isBefore and isAfter methods
>
> Replace use of "negative" and positive with "less than zero" and "greater
> than zero" in j
> New functionality in the -XshowSettings menu to display relevant information
> about JDK security configuration
Sean Coffey has updated the pull request incrementally with two additional
commits since the last revision:
- Harden code to report lack of SSL support
- Testcase correction
On Fri, 7 Jul 2023 18:25:58 GMT, sid8606 wrote:
>> Ah, wait, now I see. The native side uses `int` as a type, but we try to
>> load it as a `JAVA_BYTE`. I think this is a bug in the test. The Java side
>> should use `JAVA_INT` instead, and the size passed to `reinterpret` should
>> be `4` (whi
On Fri, 30 Jun 2023 07:52:36 GMT, Justin Lu wrote:
> Please review this PR which refactors additional tests in Locale to use JUnit.
>
> If a test was named bugNNN.java, it was renamed to something more
> descriptive.
>
> Below is a list of all the changes
>
> - Refactor and Rename Bug4175
On Fri, 7 Jul 2023 17:55:35 GMT, Jorn Vernee wrote:
>> Since s390x runs in Big Endian mode. We get LSB on higher address of
>> integer size.
>
> Ah, wait, now I see. The native side uses `int` as a type, but we try to load
> it as a `JAVA_BYTE`. I think this is a bug in the test. The Java side
On Fri, 7 Jul 2023 17:41:02 GMT, Brian Burkhalter wrote:
>> src/java.base/share/classes/java/io/DataOutputStream.java line 44:
>>
>>> 42: * the underlying output stream, hence there is no guarantee as to
>>> 43: * the details of how the bytes are written.
>>> 44: *
>>
>> I'd drop "merely".
>
On Fri, 7 Jul 2023 14:54:54 GMT, sid8606 wrote:
>> src/hotspot/cpu/s390/upcallLinker_s390.cpp line 141:
>>
>>> 139:
>>> 140: // The Java call uses the JIT ABI, but we also call C.
>>> 141: int out_arg_area = MAX2(frame::z_jit_out_preserve_size +
>>> arg_shuffle.out_arg_bytes(), (int)frame:
On Fri, 7 Jul 2023 15:27:29 GMT, Brian Burkhalter wrote:
> Was it actually verified that things are not split up into two or more
> packets? It seems that `write(2)` could in fact return a value less than the
> number of bytes requested.
Yes, the test case included in JBS sends all 4 bytes in
On Fri, 7 Jul 2023 14:21:23 GMT, Roger Riggs wrote:
> I would not want to give any assurances about whether the bytes of an encoded
> primitive were written individually or as a group.
Would it be helpful to add further verbiage?
For example, the sequence of bytes comprising the primitive data
> Can I get a preliminary review of the wording for Deque.reversed()? If the
> text is good, I'll make corresponding changes to the implSpecs of the other
> reversed() default methods, namely those in List, SortedMap, and SortedSet
> and then file the CSR.
Stuart Marks has updated the pull requ
On Fri, 7 Jul 2023 16:31:26 GMT, Jim Laskey wrote:
>> java.lang.runtime.ReferencedKeyMap was introduced to provide a concurrent
>> caching scheme for Carrier objects. The technique used is generally useful
>> for a variety of caching schemes and is being moved to be shared in other
>> parts of
On Fri, 7 Jul 2023 16:23:37 GMT, Remi Forax wrote:
> I'm not a big fan of hiding exceptions, why not wrapping the IOException in
> an UncheckedIOException ?
>
> So closeUnchecked() means close and throw an unchecked exception if an
> exception occurs.
I am confused by this comment. That is wh
On Fri, 7 Jul 2023 06:45:46 GMT, Chen Liang wrote:
>> As John Rose has pointed out in this issue, the current j.l.r.Proxy based
>> implementation of MethodHandleProxies.asInterface has a few issues:
>> 1. Exposes too much information via Proxy supertype (and WrapperInstance
>> interface)
>> 2.
> java.lang.runtime.ReferencedKeyMap was introduced to provide a concurrent
> caching scheme for Carrier objects. The technique used is generally useful
> for a variety of caching schemes and is being moved to be shared in other
> parts of the jdk. The MethodType interning case is one example.
On Fri, 7 Jul 2023 11:49:22 GMT, Jim Laskey wrote:
>> java.lang.runtime.ReferencedKeyMap was introduced to provide a concurrent
>> caching scheme for Carrier objects. The technique used is generally useful
>> for a variety of caching schemes and is being moved to be shared in other
>> parts of
On Wed, 5 Jul 2023 17:25:24 GMT, Volker Simonis wrote:
>> As the included jtreg test demonstrates, `StackWalker.getCallerClass()` can
>> throw an `UnsupportedOperationException` if called reflectively. Currently
>> this only happens if we invoke `StackWalker.getCallerClass()` recursively
>> re
On Fri, 7 Jul 2023 08:29:06 GMT, Hamlin Li wrote:
>> The below benchmark files have scaling issues due to cache contention and
>> leads to poor scaling when run on multiple threads. The patch sets the scope
>> from benchmark level to thread level to fix the issue:
>> - org/openjdk/bench/java/io
On Fri, 7 Jul 2023 01:18:10 GMT, Chen Liang wrote:
>> Brian Burkhalter has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8066869: linkplain -> link
>
> src/java.base/share/classes/java/io/Closeable.java line 72:
>
>> 70: * Therefore
> Add a default method `java.io.Closeable::closeUnchecked` which is equivalent
> to `Closeable::close` except that it instead throws
> `java.io.UncheckedIOException`.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
8066869: link
On Wed, 5 Jul 2023 19:14:07 GMT, Mandy Chung wrote:
>> Volker Simonis has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Rename new parameter according to the HS coding conventions
>
> Thanks for catching this issue.I agree that `Method
> Add a disclaimer to `java.io.DataOutputStream` to the effect that it makes no
> guarantee as to how the underlying output stream actually writes the bytes
> provided to it.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
81559
On Thu, 6 Jul 2023 21:40:38 GMT, Brian Burkhalter wrote:
> Add a disclaimer to `java.io.DataOutputStream` to the effect that it makes no
> guarantee as to how the underlying output stream actually writes the bytes
> provided to it.
> This issue is reported against JDK 8 and 9. It was fixed in
On Sat, 1 Jul 2023 14:42:07 GMT, 温绍锦 wrote:
>> [PR 14578 ](https://github.com/openjdk/jdk/pull/14578) still has unresolved
>> discussions, continue to make improvements.
>>
>> # Benchmark Result
>>
>>
>> sh make/devkit/createJMHBundle.sh
>> bash configure --with-jmh=build/jmh/jars
>> make tes
On Fri, 7 Jul 2023 12:15:39 GMT, Jorn Vernee wrote:
>> sid8606 has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Address Amit's review comments
>
> src/hotspot/cpu/s390/upcallLinker_s390.cpp line 141:
>
>> 139:
>> 140: // The Java call
On Fri, 7 Jul 2023 13:40:53 GMT, Sean Coffey wrote:
>> src/java.base/share/classes/sun/launcher/SecuritySettings.java line 123:
>>
>>> 121: }
>>> 122:
>>> 123: ostream.println(INDENT + "Security TLS configuration:");
>>
>> What about also noting the name of the TLS/JSSE provide
> In java.time packages, clarify timeline order javadoc to mention "before" and
> "after" in the value of the `compareTo` method return values.
> Add javadoc @see tags to isBefore and isAfter methods
>
> Replace use of "negative" and positive with "less than zero" and "greater
> than zero" in j
On Thu, 6 Jul 2023 21:40:38 GMT, Brian Burkhalter wrote:
> Add a disclaimer to `java.io.DataOutputStream` to the effect that it makes no
> guarantee as to how the underlying output stream actually writes the bytes
> provided to it.
src/java.base/share/classes/java/io/DataOutputStream.java line
On Fri, 7 Jul 2023 10:32:54 GMT, Jorn Vernee wrote:
>> sid8606 has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Address Amit's review comments
>
> test/jdk/java/foreign/TestClassLoaderFindNative.java line 63:
>
>> 61: public void tes
Thanks for laying out your thinking, Joe. I will watch your talks.
If I understood your response correctly, you are ok making such a change,
especially since it is semantically equivalent? If that’s the case, is JDK 21
past the point of feature release, or should the change target only 22? It
On Thu, 6 Jul 2023 14:03:12 GMT, Sean Mullan wrote:
>> Sean Coffey has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 15 additional
>> commits sinc
On Thu, 6 Jul 2023 18:43:41 GMT, Roger Riggs wrote:
>> Sean Coffey has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 15 additional
>> commits sinc
On Thu, 6 Jul 2023 17:15:20 GMT, Mandy Chung wrote:
> > The changes make me wonder if `-XshowSetting:aardvark` should be an error
> > rather than default to print all settings. Something we should look at
> > again. Same thing for `-XshowSettings:system` on non-Linux, probably should
> > have
> New functionality in the -XshowSettings menu to display relevant information
> about JDK security configuration
Sean Coffey has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase. The
On Fri, 7 Jul 2023 13:27:47 GMT, Roger Riggs wrote:
>> Hi all,
>>
>> Clean backport for JDK-83210265.
>>
>> Thanks!
>
> Marked as reviewed by rriggs (Reviewer).
Thank you @RogerRiggs !
-
PR Comment: https://git.openjdk.org/jdk21/pull/103#issuecomment-1625435021
On Thu, 6 Jul 2023 19:42:08 GMT, Thomas Stuefe wrote:
> Hi all,
>
> Clean backport for JDK-83210265.
>
> Thanks!
This pull request has now been integrated.
Changeset: 6ef80168
Author:Thomas Stuefe
URL:
https://git.openjdk.org/jdk21/commit/6ef801683844e5cc06804d51060ed81b1e8f3cc5
S
On Thu, 6 Jul 2023 19:42:08 GMT, Thomas Stuefe wrote:
> Hi all,
>
> Clean backport for JDK-83210265.
>
> Thanks!
Marked as reviewed by rriggs (Reviewer).
-
PR Review: https://git.openjdk.org/jdk21/pull/103#pullrequestreview-1518889288
On Fri, 7 Jul 2023 10:01:20 GMT, sid8606 wrote:
>> Implementation of "Foreign Function & Memory API" for s390x.
>
> sid8606 has updated the pull request incrementally with one additional commit
> since the last revision:
>
> Address Amit's review comments
Overall looks great! I'd mostly like
Hi all,
Clean backport for JDK-83210265.
Thanks!
-
Commit messages:
- Backport 47d00a4cbeff5d757dda9c660dfd2385c02a57d7
Changes: https://git.openjdk.org/jdk21/pull/103/files
Webrev: https://webrevs.openjdk.org/?repo=jdk21&pr=103&range=00
Issue: https://bugs.openjdk.org/browse/J
> java.lang.runtime.ReferencedKeyMap was introduced to provide a concurrent
> caching scheme for Carrier objects. The technique used is generally useful
> for a variety of caching schemes and is being moved to be shared in other
> parts of the jdk. The MethodType interning case is one example.
On Wed, 5 Jul 2023 12:57:19 GMT, Pavel Rappo wrote:
> Unfortunately, we don't have mid-layer methods in between Arrays.hashCode and
> ArraysSupport.vectorizedHashCode like that of Arrays.mismatch and
> ArraysSupport.vectorizedMismatch. It's either all the null check but
> short-circuits or unc
On Fri, 7 Jul 2023 08:53:06 GMT, Amit Kumar wrote:
>> sid8606 has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Address Amit's review comments
>
> Will run test, maybe you want to adopt these changes. That's it for now.
Thank you @offamit
> Implementation of "Foreign Function & Memory API" for s390x.
sid8606 has updated the pull request incrementally with one additional commit
since the last revision:
Address Amit's review comments
-
Changes:
- all: https://git.openjdk.org/jdk/pull/14801/files
- new: https://g
On Fri, 7 Jul 2023 07:55:03 GMT, sid8606 wrote:
> Implementation of "Foreign Function & Memory API" for s390x.
Will run test, maybe you want to adopt these changes. That's it for now.
src/hotspot/cpu/s390/downcallLinker_s390.cpp line 2:
> 1: /*
> 2: * Copyright (c) 2022, Oracle and/or its aff
Implementation of "Foreign Function & Memory API" for s390x.
-
Commit messages:
- Fix whitespace errors and boilerplate text
- 8311630:[s390] Implementation of Foreign Function & Memory API (Preview)
Changes: https://git.openjdk.org/jdk/pull/14801/files
Webrev: https://webrevs.ope
Please review this patch which adds a "jmodless" jlink mode to the JDK.
Fundamentally this patch adds an option to use `jlink` even though your JDK
install might not come with the packaged modules (directory `jmods`). This is
particularly useful to further reduce the size of a jlinked runtime. A
On Sat, 1 Jul 2023 07:53:17 GMT, Swati Sharma wrote:
> The below benchmark files have scaling issues due to cache contention and
> leads to poor scaling when run on multiple threads. The patch sets the scope
> from benchmark level to thread level to fix the issue:
> - org/openjdk/bench/java/io/
On Wed, 21 Jun 2023 15:18:19 GMT, Matthias Baesken wrote:
> There are a few references to rt.jar in comments and in the codebase itself.
> Some of them might be removed or adjusted.
This pull request has now been integrated.
Changeset: 25cbe85d
Author:Matthias Baesken
URL:
https://
53 matches
Mail list logo
