On Wed, 9 Aug 2023 00:21:55 GMT, Weibing Xiao wrote:
>> com.sun.jndi.ldap.Connection::leanup does not close the underlying socket if
>> the is an IOException generation when the output stream was flushing the
>> buffer.
>>
>> Please refer to the bug
On Wed, 9 Aug 2023 00:21:55 GMT, Weibing Xiao wrote:
>> com.sun.jndi.ldap.Connection::leanup does not close the underlying socket if
>> the is an IOException generation when the output stream was flushing the
>> buffer.
>>
>> Please refer to the bug
Hello everyone,
My name is Ren Erdong, and I am a Java developer from China. It's a
pleasure to meet all of you, and I'm excited to join this community.
While reading the source code of the wrapper classes, I have identified
some areas that could potentially be optimized. However, I acknowledge
If your email was withheld for having a too large body, I recommend you to
send a summary to this core-libs-dev mailing list instead. Your current
topic lists no RFEs for optimization and thus is not helpful, so I wish to
see your summaries (as bullet points). You can talk about the details in
> Introducing a new formatting class for locale-dependent list patterns. The
> class is to provide the functionality from the Unicode Consortium's LDML
> specification for [list
> patterns](https://www.unicode.org/reports/tr35/tr35-general.html#ListPatterns).
> For example, given a list of
On Fri, 4 Aug 2023 19:09:58 GMT, Weibing Xiao wrote:
>> com.sun.jndi.ldap.Connection::leanup does not close the underlying socket if
>> the is an IOException generation when the output stream was flushing the
>> buffer.
>>
>> Please refer to the bug
> com.sun.jndi.ldap.Connection::leanup does not close the underlying socket if
> the is an IOException generation when the output stream was flushing the
> buffer.
>
> Please refer to the bug https://bugs.openjdk.org/browse/JDK-8313657.
Weibing Xiao has updated the pull request incrementally
> Introducing a new formatting class for locale-dependent list patterns. The
> class is to provide the functionality from the Unicode Consortium's LDML
> specification for [list
> patterns](https://www.unicode.org/reports/tr35/tr35-general.html#ListPatterns).
> For example, given a list of
On Tue, 8 Aug 2023 19:49:19 GMT, Roger Riggs wrote:
>> Naoto Sato has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains five additional
>> commits
On Tue, 8 Aug 2023 17:19:55 GMT, Naoto Sato wrote:
>> Introducing a new formatting class for locale-dependent list patterns. The
>> class is to provide the functionality from the Unicode Consortium's LDML
>> specification for [list
>>
On Tue, 8 Aug 2023 19:34:05 GMT, Jim Laskey wrote:
>> The last fragment of a string template does not get it's coder added to the
>> mix.
>
> Jim Laskey has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Requested by @cl4es
This works.
> The last fragment of a string template does not get it's coder added to the
> mix.
Jim Laskey has updated the pull request incrementally with one additional
commit since the last revision:
Requested by @cl4es
-
Changes:
- all: https://git.openjdk.org/jdk/pull/15195/files
On Tue, 8 Aug 2023 18:31:04 GMT, Jim Laskey wrote:
> The last fragment of a string template does not get it's coder added to the
> mix.
This pull request has now been integrated.
Changeset: 68644411
Author:Jim Laskey
URL:
On Tue, 8 Aug 2023 18:56:53 GMT, Claes Redestad wrote:
>> The last fragment of a string template does not get it's coder added to the
>> mix.
>
> src/java.base/share/classes/java/lang/invoke/StringConcatFactory.java line
> 1129:
>
>> 1127: }
>> 1128:
>> 1129:
On Tue, 8 Aug 2023 18:31:04 GMT, Jim Laskey wrote:
> The last fragment of a string template does not get it's coder added to the
> mix.
LGTM. This also adds an implicit null check on the last fragment.
src/java.base/share/classes/java/lang/invoke/StringConcatFactory.java line 1129:
> 1127:
On Tue, 1 Aug 2023 10:29:06 GMT, Jorn Vernee wrote:
> This patch contains the implementation of the foreign linker & memory API JEP
> for Java 22. The initial patch is composed of commits brought over directly
> from the [panama-foreign repo](https://github.com/openjdk/panama-foreign).
> The
The last fragment of a string template does not get it's coder added to the mix.
-
Commit messages:
- 8313809: String template fails with java.lang.StringIndexOutOfBoundsException
Changes: https://git.openjdk.org/jdk/pull/15195/files
Webrev:
On Tue, 8 Aug 2023 15:55:10 GMT, Roger Riggs wrote:
> The same copyright updates are needed in JDK21.
Marked as reviewed by naoto (Reviewer).
-
PR Review: https://git.openjdk.org/jdk21/pull/166#pullrequestreview-1567795009
> Introducing a new formatting class for locale-dependent list patterns. The
> class is to provide the functionality from the Unicode Consortium's LDML
> specification for [list
> patterns](https://www.unicode.org/reports/tr35/tr35-general.html#ListPatterns).
> For example, given a list of
> Please review this patch which adds a "jmodless" jlink mode to the JDK.
> Fundamentally this patch adds an option to use `jlink` even though your JDK
> install might not come with the packaged modules (directory `jmods`). This is
> particularly useful to further reduce the size of a jlinked
On Tue, 8 Aug 2023 15:55:10 GMT, Roger Riggs wrote:
> The same copyright updates are needed in JDK21.
+1
-
Marked as reviewed by bpb (Reviewer).
PR Review: https://git.openjdk.org/jdk21/pull/166#pullrequestreview-1567674852
The same copyright updates are needed in JDK21.
-
Commit messages:
- Backport 53ca75b18ea419d469758475fac8352bf915b484
Changes: https://git.openjdk.org/jdk21/pull/166/files
Webrev: https://webrevs.openjdk.org/?repo=jdk21=166=00
Issue: https://bugs.openjdk.org/browse/JDK-8313312
> This pull request updates Classfile API snippets and examples and adds
> missing javadoc.
>
> Please review.
>
> Thanks,
> Adam
Adam Sotona has updated the pull request incrementally with one additional
commit since the last revision:
removed extra lines
-
Changes:
- all:
On Mon, 7 Aug 2023 14:40:42 GMT, Jorn Vernee wrote:
> Fix these -Wconversion warnings in the foreign benchmarks:
>
>
> ./test/micro/org/openjdk/bench/java/lang/foreign/libQSortJNI.c: In function
> ‘Java_org_openjdk_bench_java_lang_foreign_QSort_jni_1qsort_1optimized’:
>
On Mon, 7 Aug 2023 14:40:42 GMT, Jorn Vernee wrote:
> Fix these -Wconversion warnings in the foreign benchmarks:
>
>
> ./test/micro/org/openjdk/bench/java/lang/foreign/libQSortJNI.c: In function
> ‘Java_org_openjdk_bench_java_lang_foreign_QSort_jni_1qsort_1optimized’:
>
On Mon, 7 Aug 2023 14:40:42 GMT, Jorn Vernee wrote:
> Fix these -Wconversion warnings in the foreign benchmarks:
>
>
> ./test/micro/org/openjdk/bench/java/lang/foreign/libQSortJNI.c: In function
> ‘Java_org_openjdk_bench_java_lang_foreign_QSort_jni_1qsort_1optimized’:
>
On Fri, 4 Aug 2023 14:51:35 GMT, Sergey Tsypanov wrote:
> In `publish0()`, `flush0()` and `flushAndClose()`methods of `StreamHandler`
> we read multiple times from volatile writer. The access number can be reduced
> by reading the field into local variable once.
LGTM
-
Marked as
On Thu, 13 Jul 2023 17:57:16 GMT, Andrey Turbanov wrote:
> Couple of static fields in Math are used only once and can be replaced with
> literals `0x1p512`/`0x1p-512 `
This pull request has now been integrated.
Changeset: 41bdcded
Author:Andrey Turbanov
URL:
On Tue, 8 Aug 2023 05:39:04 GMT, sid8606 wrote:
>> Implementation of "Foreign Function & Memory API" for s390x (Big Endian).
>
> sid8606 has updated the pull request incrementally with one additional commit
> since the last revision:
>
> Fix indentation
>
> Signed-off-by: Sidraya
I
On Tue, 8 Aug 2023 05:39:04 GMT, sid8606 wrote:
>> Implementation of "Foreign Function & Memory API" for s390x (Big Endian).
>
> sid8606 has updated the pull request incrementally with one additional commit
> since the last revision:
>
> Fix indentation
>
> Signed-off-by: Sidraya
On Mon, 7 Aug 2023 19:44:48 GMT, Andrey Turbanov wrote:
>> Couple of static fields in Math are used only once and can be replaced with
>> literals `0x1p512`/`0x1p-512 `
>
> Andrey Turbanov has updated the pull request incrementally with one
> additional commit since the last revision:
>
>
On Tue, 8 Aug 2023 05:39:04 GMT, sid8606 wrote:
>> Implementation of "Foreign Function & Memory API" for s390x (Big Endian).
>
> sid8606 has updated the pull request incrementally with one additional commit
> since the last revision:
>
> Fix indentation
>
> Signed-off-by: Sidraya
On Mon, 7 Aug 2023 19:44:48 GMT, Andrey Turbanov wrote:
>> Couple of static fields in Math are used only once and can be replaced with
>> literals `0x1p512`/`0x1p-512 `
>
> Andrey Turbanov has updated the pull request incrementally with one
> additional commit since the last revision:
>
>
On Mon, 7 Aug 2023 19:44:48 GMT, Andrey Turbanov wrote:
>> Couple of static fields in Math are used only once and can be replaced with
>> literals `0x1p512`/`0x1p-512 `
>
> Andrey Turbanov has updated the pull request incrementally with one
> additional commit since the last revision:
>
>
On Tue, 8 Aug 2023 05:39:04 GMT, sid8606 wrote:
>> Implementation of "Foreign Function & Memory API" for s390x (Big Endian).
>
> sid8606 has updated the pull request incrementally with one additional commit
> since the last revision:
>
> Fix indentation
>
> Signed-off-by: Sidraya
On Tue, 8 Aug 2023 08:42:05 GMT, Raffaello Giulietti
wrote:
>> Andrey Turbanov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8313875: Make fields final in java.util.Math: twoToTheDoubleScaleUp,
>> twoToTheDoubleScaleDown
>>
>>
On Mon, 7 Aug 2023 19:44:48 GMT, Andrey Turbanov wrote:
>> Couple of static fields in Math are used only once and can be replaced with
>> literals `0x1p512`/`0x1p-512 `
>
> Andrey Turbanov has updated the pull request incrementally with one
> additional commit since the last revision:
>
>
> This PR suggests refining the `@implSpec` for the SegmentAllocator::allocate
> methods as well as clarifying the docs a bit more. Also, a local variable is
> renamed.
Per Minborg has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes
38 matches
Mail list logo
