On Tue, 8 Aug 2023 05:39:04 GMT, sid8606 <d...@openjdk.org> wrote: >> Implementation of "Foreign Function & Memory API" for s390x (Big Endian). > > sid8606 has updated the pull request incrementally with one additional commit > since the last revision: > > Fix indentation > > Signed-off-by: Sidraya <sidraya.jayag...@ibm.com>
src/hotspot/cpu/s390/downcallLinker_s390.cpp line 95: > 93: > 94: static const int native_invoker_code_base_size = 384; > 95: static const int native_invoker_size_per_args = 8; Sizes were taken from PPC64. Are they correct for s390? src/hotspot/cpu/s390/downcallLinker_s390.cpp line 156: > 154: #endif > 155: > 156: int allocated_frame_size = 0; Line not needed. src/hotspot/cpu/s390/downcallLinker_s390.cpp line 163: > 161: assert(!_needs_return_buffer, "unexpected needs_return_buffer"); > 162: RegSpiller out_reg_spiller(_output_registers); > 163: int spill_offset = -1; Line not needed. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/14801#discussion_r1286895276 PR Review Comment: https://git.openjdk.org/jdk/pull/14801#discussion_r1286897339 PR Review Comment: https://git.openjdk.org/jdk/pull/14801#discussion_r1286897502
