Re: RFR: 8314169: Combine related RoundingMode logic in j.text.DigitList

On Fri, 11 Aug 2023 18:27:47 GMT, Justin Lu wrote: > Please review this PR which is a broad clean up of the DigitList class (used > by Format classes in j.text). > > This PR is intended to be a portion of a bigger change (split up to make > reviewing easier). > > The main change combines

Re: RFR: JDK-8266431: Dual-Pivot Quicksort improvements (Radix sort) [v7]

On Thu, 15 Jun 2023 09:21:13 GMT, Laurent Bourgès wrote: >> * improved mixed insertion sort (makes whole sorting faster) >> * introduced Radix which sort shows several times boost of performance and >> has linear complexity instead of n*ln(n) >> * improved merging sort for almost sorted data

Integrated: 8313904: [macos] All signing tests which verifies unsigned app images are failing

On Thu, 10 Aug 2023 22:58:18 GMT, Alexander Matveev wrote: > - This is regression from > [JDK-8298488](https://bugs.openjdk.org/browse/JDK-8298488). > - Since JDK-8298488 unsigned app bundles are ad-hoc signed and `codesign` > will report that app bundle is signed and thus our tests failed. >

Re: [External] : Re: RFR: 8313904: [macos] All signing tests which verifies unsigned app images are failing

> On Aug 11, 2023, at 3:55 PM, Alexander Matveev > wrote: > > Hi Michael, > >> On Aug 10, 2023, at 10:48 PM, Michael Hall > > wrote: >> >> I assume done with jpackage by indicating something like —mac-sign only? If wrong feel free to correct. >>>

Re: [External] : Re: RFR: 8313904: [macos] All signing tests which verifies unsigned app images are failing

Hi Michael, On Aug 10, 2023, at 10:48 PM, Michael Hall mailto:mik3h...@gmail.com>> wrote: I assume done with jpackage by indicating something like —mac-sign only? If wrong feel free to correct. No, it is always done if —mac-sign is NOT specified and we doing ad-hoc signing on app bundle

Re: RFR: 8313657 : com.sun.jndi.ldap.Connection.cleanup does not close connections on SocketTimeoutErrors [v5]

On Wed, 9 Aug 2023 12:52:35 GMT, Weibing Xiao wrote: >> com.sun.jndi.ldap.Connection::leanup does not close the underlying socket if >> the is an IOException generation when the output stream was flushing the >> buffer. >> >> Please refer to the bug

RFR: 8314169: Combine related RoundingMode logic in j.text.DigitList

Please review this PR which is a broad clean up of the DigitList class (used by Format classes in j.text). This PR is intended to be a portion of a bigger change (split up to make reviewing easier). The main change combines related Rounding Mode logic in `shouldRoundUp()` - (_CEILING/FLOOR_,

Re: RFR: 8312522: Implementation of Foreign Function & Memory API [v4]

On Fri, 11 Aug 2023 12:37:59 GMT, Jorn Vernee wrote: >> This patch contains the implementation of the foreign linker & memory API >> JEP for Java 22. The initial patch is composed of commits brought over >> directly from the [panama-foreign >> repo](https://github.com/openjdk/panama-foreign).

Re: RFR: 8312522: Implementation of Foreign Function & Memory API [v3]

On Thu, 10 Aug 2023 23:31:57 GMT, Chen Liang wrote: > Just curious, what's the rationale for finalizing the API when there are > significant changes from the last preview? A preview API is finalized when it is ready. The preview process, as outlined by [JEP

Re: RFR: 8313904: [macos] All signing tests which verifies unsigned app images are failing

On Thu, 10 Aug 2023 22:58:18 GMT, Alexander Matveev wrote: > - This is regression from > [JDK-8298488](https://bugs.openjdk.org/browse/JDK-8298488). > - Since JDK-8298488 unsigned app bundles are ad-hoc signed and `codesign` > will report that app bundle is signed and thus our tests failed. >

Re: RFR: 8314120: Add tests for FileDescriptor.sync [v2]

On Fri, 11 Aug 2023 14:32:29 GMT, Alan Bateman wrote: >> Aleksey Shipilev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Review comments > > test/jdk/java/io/FileDescriptor/Sync.java line 36: > >> 34: * @requires vm.continuations >>

Re: RFR: 8314120: Add tests for FileDescriptor.sync [v2]

> When backporting [JDK-8312127](https://bugs.openjdk.org/browse/JDK-8312127), > I realized there are no targeted tests for `FileDescriptor.sync` that can be > used to qualify the changes in that area. > > Additionally, we use `FD.sync` for durability in Java databases, and we want > to make

Re: RFR: 8314120: Add tests for FileDescriptor.sync

On Thu, 10 Aug 2023 15:45:12 GMT, Aleksey Shipilev wrote: > When backporting [JDK-8312127](https://bugs.openjdk.org/browse/JDK-8312127), > I realized there are no targeted tests for `FileDescriptor.sync` that can be > used to qualify the changes in that area. > > Additionally, we use

Re: RFR: 8312522: Implementation of Foreign Function & Memory API [v4]

> This patch contains the implementation of the foreign linker & memory API JEP > for Java 22. The initial patch is composed of commits brought over directly > from the [panama-foreign repo](https://github.com/openjdk/panama-foreign). > The main changes found in this patch come from the

Re: RFR: 8310813: Simplify and modernize equals, hashCode, and compareTo for BigInteger [v6]

On Thu, 10 Aug 2023 11:38:08 GMT, Pavel Rappo wrote: >> Pavel Rappo has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 13 additional >> commits

Re: RFR: 8310813: Simplify and modernize equals, hashCode, and compareTo for BigInteger [v6]

On Wed, 9 Aug 2023 22:54:28 GMT, Pavel Rappo wrote: >> Please review this PR to use modern APIs and language features to simplify >> equals, hashCode, and compareTo for BigInteger. If you have any performance >> concerns, please raise them. >> >> This PR is cherry-picked from a bigger,