Re: RFR: 8315373: Change VirtualThread to unmount after freezing, re-mount before thawing [v2]

2023-09-09 Thread Alan Bateman
On Wed, 6 Sep 2023 05:01:38 GMT, Serguei Spitsyn wrote: > The fix looks okay to me. From JVMTI point of view this transition is hidden, > so no inconsistency can be observed. However, I wonder if the > AsyncGetStackTraces may have similar issue as the JFR had. Unfortunately we > do not have

Re: RFR: 8315585: Optimization for decimal to string [v13]

2023-09-09 Thread 温绍锦
> BigDecimal is a commonly used class in business development, It is often > necessary to perform toString or toPlainString operations on BigDecimal. > > The current version uses StringBuilder resulting in multiple memory > allocations, I made a modification to improve performance. > > Because

RFR: 8314891: Additional Zip64 extra header validation

2023-09-09 Thread Lance Andersen
Please review this PR which improves the Zip64 extra header validation: - Throw a ZipException If the extra len field is 0 and : -- size, csize, or loc offset are not set to 0x -- disk starting number is not set to 0x - We have a valid size for the Zip64 extra header but we are

Re: RFR: 8288899: java/util/concurrent/ExecutorService/CloseTest.java failed with "InterruptedException: sleep interrupted" [v27]

2023-09-09 Thread Doug Lea
> Addresses Jdk 8288899 : java/util/concurrent/ExecutorService/CloseTest.java > failed with "InterruptedException: sleep interrupted" and related issues. > > This is a major ForkJoin update (and hard to review -- sorry) that finally > addresses incompatibilities between ExecutorService and

Re: RFR: 8287843: File::getCanonicalFile doesn't work for \?\C:\ style paths DOS device paths [v2]

2023-09-09 Thread Alan Bateman
On Fri, 8 Sep 2023 01:07:17 GMT, Brian Burkhalter wrote: >> In the Windows implementation of java.io.File.getCanonicalPath, strip any >> long path or UNC prefix before canonicalizing the remainder of the pathname. > > Brian Burkhalter has updated the pull request incrementally with one >

Re: RFR: JDK-8314272: Improve java.util.prefs.BackingStoreException: Couldn't get file lock. [v2]

2023-09-09 Thread Alan Bateman
On Fri, 8 Sep 2023 18:45:02 GMT, Brent Christian wrote: > I would also like to see what a FileChannel implementation looks like. Am I > right that this would allow the `prefs` native library to be removed entirely? Yes. FileChannel.open can be called with the file permissions to atomically set

Re: RFR: 8311207: Cleanup for Optimization for UUID.toString [v14]

2023-09-09 Thread 温绍锦
On Sat, 9 Sep 2023 07:11:01 GMT, Claes Redestad wrote: >> src/java.base/share/classes/java/util/HexDigits.java line 42: >> >>> 40: * hex relative to its index, for example: >>> 41: * >>> 42: * 0 -> '00' -> '0' | ('0' << 8) -> 0x3030 >> >> AFAICT this is now a copy of

Re: RFR: 8315585: Optimization for decimal to string [v12]

2023-09-09 Thread 温绍锦
> BigDecimal is a commonly used class in business development, It is often > necessary to perform toString or toPlainString operations on BigDecimal. > > The current version uses StringBuilder resulting in multiple memory > allocations, I made a modification to improve performance. > > Because

Re: RFR: 8311207: Cleanup for Optimization for UUID.toString [v14]

2023-09-09 Thread Claes Redestad
On Sat, 9 Sep 2023 07:08:07 GMT, Claes Redestad wrote: >> 温绍锦 has updated the pull request incrementally with one additional commit >> since the last revision: >> >> lo | hi => hi | lo > > src/java.base/share/classes/java/util/HexDigits.java line 42: > >> 40: * hex relative to its

Re: RFR: 8311207: Cleanup for Optimization for UUID.toString [v14]

2023-09-09 Thread Claes Redestad
On Fri, 8 Sep 2023 20:36:31 GMT, 温绍锦 wrote: >> [PR 14578 ](https://github.com/openjdk/jdk/pull/14578) still has unresolved >> discussions, continue to make improvements. >> >> # Benchmark Result >> >> >> sh make/devkit/createJMHBundle.sh >> bash configure --with-jmh=build/jmh/jars >> make

Re: RFR: 8311207: Cleanup for Optimization for UUID.toString [v14]

2023-09-09 Thread Claes Redestad
On Fri, 8 Sep 2023 23:49:04 GMT, Chen Liang wrote: >> src/java.base/share/classes/java/util/HexDigits.java line 66: >> >>> 64: */ >>> 65: @Stable >>> 66: private static final short[] DIGITS; >> >> Maybe it should be `char[]` instead since it’s encoded using unsigned 16‑bit  >>