On Tue, 12 Sep 2023 01:36:34 GMT, Brian Burkhalter wrote:
>> On Windows, do not return `true` from the `java.io.File` methods
>> `setReadable(boolean, boolean)` and `setExecutable(boolean, boolean)` if the
>> file does not exist.
>
> src/java.base/windows/native/libjava/WinNTFileSystem_md.c lin
On Wed, 20 Apr 2022 00:32:25 GMT, Brent Christian wrote:
> Please review this change to replace the finalizer in
> `AbstractLdapNamingEnumeration` with a Cleaner.
>
> The pieces of state required for cleanup (`LdapCtx homeCtx`, `LdapResult
> res`, and `LdapClient enumClnt`) are moved to a stat
On Thu, 31 Aug 2023 10:02:45 GMT, chenggwang wrote:
>> Sorry, my description in Issue JDK-8314194(which I submitted) is ambiguous
>> and makes you think of Phaser. My intention is that each generation of
>> CyclicBarrier barrierCommand can change. Let me give you a scenario
>> For example, the
On Mon, 11 Sep 2023 22:22:47 GMT, Brian Burkhalter wrote:
> On Windows, do not return `true` from the `java.io.File` methods
> `setReadable(boolean, boolean)` and `setExecutable(boolean, boolean)` if the
> file does not exist.
src/java.base/windows/native/libjava/WinNTFileSystem_md.c line 479:
> improve date toString performance, includes:
>
> java.util.Date.toString
> java.util.Date.toGMTString
> java.time.Instant.toString
> java.time.LocalDate.toString
> java.time.LocalDateTime.toString
> java.time.LocalTime.toString
温绍锦 has updated the pull request incrementally with one additional
> improve date toString performance, includes:
>
> java.util.Date.toString
> java.util.Date.toGMTString
> java.time.Instant.toString
> java.time.LocalDate.toString
> java.time.LocalDateTime.toString
> java.time.LocalTime.toString
温绍锦 has updated the pull request incrementally with two additional
> improve date toString performance, includes:
>
> java.util.Date.toString
> java.util.Date.toGMTString
> java.time.Instant.toString
> java.time.LocalDate.toString
> java.time.LocalDateTime.toString
> java.time.LocalTime.toString
温绍锦 has updated the pull request with a new target base due to a me
> Some codes in core libs are duplicated, including:
> java.util.DecimalDigits::DIGITS -> java.lang.StringLatin1.PACKED_DIGITS
> java.util.DecimalDigits::size -> java.lang.Long.stringSize
>
> We can reduce duplication through JavaLangAccess, which is also needed in
> other places, such as:
> http
On Tue, 12 Sep 2023 00:06:41 GMT, 温绍锦 wrote:
>> Some codes in core libs are duplicated, including:
>> java.util.DecimalDigits::DIGITS -> java.lang.StringLatin1.PACKED_DIGITS
>> java.util.DecimalDigits::size -> java.lang.Long.stringSize
>>
>> We can reduce duplication through JavaLangAccess, whic
> Some codes in core libs are duplicated, including:
> java.util.DecimalDigits::DIGITS -> java.lang.StringLatin1.PACKED_DIGITS
> java.util.DecimalDigits::size -> java.lang.Long.stringSize
>
> We can reduce duplication through JavaLangAccess, which is also needed in
> other places, such as:
> http
> Some codes in core libs are duplicated, including:
> java.util.DecimalDigits::DIGITS -> java.lang.StringLatin1.PACKED_DIGITS
> java.util.DecimalDigits::size -> java.lang.Long.stringSize
>
> We can reduce duplication through JavaLangAccess, which is also needed in
> other places, such as:
> http
> Some codes in core libs are duplicated, including:
> java.util.DecimalDigits::DIGITS -> java.lang.StringLatin1.PACKED_DIGITS
> java.util.DecimalDigits::size -> java.lang.Long.stringSize
>
> We can reduce duplication through JavaLangAccess, which is also needed in
> other places, such as:
> http
On Sat, 9 Sep 2023 14:33:53 GMT, Lance Andersen wrote:
> Please review this PR which improves the Zip64 extra header validation:
>
> - Throw a ZipException If the extra len field is 0 and :
> -- size, csize, or loc offset are set to 0x
> -- disk starting number is set to 0x
>
> - We
On Mon, 11 Sep 2023 18:57:58 GMT, Roger Riggs wrote:
>> If this PR is split into two PRs, the other two PRs I submitted #15658
>> #1 cannot be based on this PR.
>
> I agree, do the package move separate from the refactoring.
> The other PRs can wait a bit or be committed as is and take part
On Mon, 11 Sep 2023 19:03:45 GMT, Claes Redestad wrote:
>> src/java.base/share/classes/jdk/internal/util/DecimalDigits.java line 1:
>>
>>> 1: /*
>>
>> Can git be convinced to show this as a rename instead of a delete and add?
>> The history will be cleaner.
>
> I just looked it up and git actua
> Some codes in core libs are duplicated, including:
> java.util.DecimalDigits::DIGITS -> java.lang.StringLatin1.PACKED_DIGITS
> java.util.DecimalDigits::size -> java.lang.Long.stringSize
>
> We can reduce duplication through JavaLangAccess, which is also needed in
> other places, such as:
> http
> Some codes in core libs are duplicated, including:
> java.util.DecimalDigits::DIGITS -> java.lang.StringLatin1.PACKED_DIGITS
> java.util.DecimalDigits::size -> java.lang.Long.stringSize
>
> We can reduce duplication through JavaLangAccess, which is also needed in
> other places, such as:
> http
> Some codes in core libs are duplicated, including:
> java.util.DecimalDigits::DIGITS -> java.lang.StringLatin1.PACKED_DIGITS
> java.util.DecimalDigits::size -> java.lang.Long.stringSize
>
> We can reduce duplication through JavaLangAccess, which is also needed in
> other places, such as:
> http
> Some codes in core libs are duplicated, including:
> java.util.DecimalDigits::DIGITS -> java.lang.StringLatin1.PACKED_DIGITS
> java.util.DecimalDigits::size -> java.lang.Long.stringSize
>
> We can reduce duplication through JavaLangAccess, which is also needed in
> other places, such as:
> http
On Fri, 8 Sep 2023 23:02:02 GMT, Justin Lu wrote:
> Please review this change which adjusts the pattern syntax specification for
> the two classes to represent the actual behavior. That is, U+FFFE and U+
> are allowed in the suffix/prefix. (Additionally; 'Unicode' is dropped from
> the def
On Mon, 11 Sep 2023 21:17:27 GMT, Per Minborg wrote:
> This PR proposes to use hexadecimal representation for a memory segment
> address rather than a decimal one.
Marked as reviewed by mcimadamore (Reviewer).
src/java.base/share/classes/jdk/internal/foreign/AbstractMemorySegmentImpl.java
lin
On Mon, 11 Sep 2023 22:22:47 GMT, Brian Burkhalter wrote:
> On Windows, do not return `true` from the `java.io.File` methods
> `setReadable(boolean, boolean)` and `setExecutable(boolean, boolean)` if the
> file does not exist.
Unfortunately, reformatting caused there to appear to be a lot of c
On Windows, do not return `true` from the `java.io.File` methods
`setReadable(boolean, boolean)` and `setExecutable(boolean, boolean)` if the
file does not exist.
-
Commit messages:
- 8316000: File.setExecutable silently fails if file does not exist
Changes: https://git.openjdk.or
On Fri, 8 Sep 2023 05:33:49 GMT, Alan Bateman wrote:
> Would it be possible to provide a clear summary on why libx86_64_sort is
> being added? I'm trying to understand why these weren't linked into libjvm.
Hello Alan,
Initially, the reason behind adding libx86_64 (now renamed to libsimdsort in
On Mon, 11 Sep 2023 21:17:27 GMT, Per Minborg wrote:
> This PR proposes to use hexadecimal representation for a memory segment
> address rather than a decimal one.
Seems more natural.
-
Marked as reviewed by rriggs (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/15670#pul
This PR proposes to use hexadecimal representation for a memory segment address
rather than a decimal one.
-
Commit messages:
- Use hexadecimal encoding in MemorySegment::toString
Changes: https://git.openjdk.org/jdk/pull/15670/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&p
On Mon, 11 Sep 2023 15:37:11 GMT, Jorn Vernee wrote:
>> This patch contains the implementation of the foreign linker & memory API
>> JEP for Java 22. The initial patch is composed of commits brought over
>> directly from the [panama-foreign
>> repo](https://github.com/openjdk/panama-foreign).
> Addresses Jdk 8288899 : java/util/concurrent/ExecutorService/CloseTest.java
> failed with "InterruptedException: sleep interrupted" and related issues.
>
> This is a major ForkJoin update (and hard to review -- sorry) that finally
> addresses incompatibilities between ExecutorService and ForkJ
On Fri, 8 Sep 2023 18:10:33 GMT, Srinivas Vamsi Parasa wrote:
>> The goal is to develop faster sort routines for x86_64 CPUs by taking
>> advantage of AVX512 instructions. This enhancement provides an order of
>> magnitude speedup for Arrays.sort() using int, long, float and double arrays.
>>
On Mon, 11 Sep 2023 17:58:20 GMT, Pavel Rappo wrote:
> Please review this trivial PR.
Marked as reviewed by iris (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/15667#pullrequestreview-1620730522
On Mon, 11 Sep 2023 17:58:20 GMT, Pavel Rappo wrote:
> Please review this trivial PR.
Marked as reviewed by naoto (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/15667#pullrequestreview-162068
On Mon, 11 Sep 2023 18:58:56 GMT, Roger Riggs wrote:
>> 温绍锦 has updated the pull request incrementally with one additional commit
>> since the last revision:
>>
>> revert code format
>
> src/java.base/share/classes/jdk/internal/util/DecimalDigits.java line 1:
>
>> 1: /*
>
> Can git be convi
On Mon, 11 Sep 2023 16:36:55 GMT, 温绍锦 wrote:
>> src/java.base/share/classes/jdk/internal/util/DecimalDigits.java line 143:
>>
>>> 141: * code after loop unrolling.
>>> 142: */
>>> 143: public static int stringSize(int x) {
>>
>> I suggest splitting the moves of `stringSize` `getCh
On Mon, 11 Sep 2023 15:57:22 GMT, 温绍锦 wrote:
>> Some codes in core libs are duplicated, including:
>> java.util.DecimalDigits::DIGITS -> java.lang.StringLatin1.PACKED_DIGITS
>> java.util.DecimalDigits::size -> java.lang.Long.stringSize
>>
>> We can reduce duplication through JavaLangAccess, whic
On Mon, 11 Sep 2023 15:57:22 GMT, 温绍锦 wrote:
>> Some codes in core libs are duplicated, including:
>> java.util.DecimalDigits::DIGITS -> java.lang.StringLatin1.PACKED_DIGITS
>> java.util.DecimalDigits::size -> java.lang.Long.stringSize
>>
>> We can reduce duplication through JavaLangAccess, whic
The vote for Lance Andersen [1] is now closed.
Yes: 10
Veto: 0
Abstain: 0
|According to the Bylaws definition of Lazy Consensus, this is
sufficient to approve the nomination. Roger Riggs [1]
https://mail.openjdk.org/pipermail/core-libs-dev/2023-August/110853.html |
The vote for Michael McMahon [1] is now closed.
Yes: 10
Veto: 0
Abstain: 0
|According to the Bylaws definition of Lazy Consensus, this is
sufficient to approve the nomination. Roger Riggs [1]
https://mail.openjdk.org/pipermail/core-libs-dev/2023-August/110854.html |
The vote for Daniel Fuchs [1] is now closed.
Yes: 10
Veto: 0
Abstain: 0
|According to the Bylaws definition of Lazy Consensus, this is
sufficient to approve the nomination. Roger Riggs [1]
https://mail.openjdk.org/pipermail/core-libs-dev/2023-August/110852.html |
On Fri, 8 Sep 2023 18:10:33 GMT, Srinivas Vamsi Parasa wrote:
>> The goal is to develop faster sort routines for x86_64 CPUs by taking
>> advantage of AVX512 instructions. This enhancement provides an order of
>> magnitude speedup for Arrays.sort() using int, long, float and double arrays.
>>
On Mon, 11 Sep 2023 17:58:20 GMT, Pavel Rappo wrote:
> Please review this trivial PR.
Marked as reviewed by bpb (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/15667#pullrequestreview-1620550935
Please review this trivial PR.
-
Commit messages:
- Initial commit
Changes: https://git.openjdk.org/jdk/pull/15667/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=15667&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8316038
Stats: 7 lines in 2 files changed: 0 ins;
> Typically it will find the caller class at the second stack frame from the
> frame of executing `StackWalker::getCallerClass`. The initial size of the
> buffer can be changed from 8 to 4 (the top 2 elements are reserved for
> implementation use). If it fetches another batch, `getCallerClas
> Typically it will find the caller class at the second stack frame from the
> frame of executing `StackWalker::getCallerClass`. The initial size of the
> buffer can be changed from 8 to 4 (the top 2 elements are reserved for
> implementation use). If it fetches another batch, `getCallerClas
> Typically it will find the caller class at the second stack frame from the
> frame of executing `StackWalker::getCallerClass`. The initial size of the
> buffer can be changed from 8 to 4 (the top 2 elements are reserved for
> implementation use). If it fetches another batch, `getCallerClas
On Mon, 11 Sep 2023 12:18:42 GMT, Volker Simonis wrote:
>> Mandy Chung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review feedback
>
> src/java.base/share/classes/java/lang/StackStreamFactory.java line 758:
>
>> 756: * So s
On Mon, 11 Sep 2023 17:27:15 GMT, Mandy Chung wrote:
>> Typically it will find the caller class at the second stack frame from the
>> frame of executing `StackWalker::getCallerClass`. The initial size of the
>> buffer can be changed from 8 to 4 (the top 2 elements are reserved for
>> impleme
On Mon, 11 Sep 2023 16:54:30 GMT, Doug Lea wrote:
>> Addresses Jdk 8288899 : java/util/concurrent/ExecutorService/CloseTest.java
>> failed with "InterruptedException: sleep interrupted" and related issues.
>>
>> This is a major ForkJoin update (and hard to review -- sorry) that finally
>> addr
> Addresses Jdk 8288899 : java/util/concurrent/ExecutorService/CloseTest.java
> failed with "InterruptedException: sleep interrupted" and related issues.
>
> This is a major ForkJoin update (and hard to review -- sorry) that finally
> addresses incompatibilities between ExecutorService and ForkJ
On Wed, 2 Aug 2023 23:22:56 GMT, Naoto Sato wrote:
> Introducing a new formatting class for locale-dependent list patterns. The
> class is to provide the functionality from the Unicode Consortium's LDML
> specification for [list
> patterns](https://www.unicode.org/reports/tr35/tr35-general.htm
On Mon, 11 Sep 2023 14:28:28 GMT, Chen Liang wrote:
>> 温绍锦 has updated the pull request incrementally with one additional commit
>> since the last revision:
>>
>> move java.lang.StringLatin1::getChars to
>> jdk.internal.util.DecimalDigits::getCharsLatin1
>
> src/java.base/share/classes/jdk/i
> improve date toString performance, includes:
>
> java.util.Date.toString
> java.util.Date.toGMTString
> java.time.Instant.toString
> java.time.LocalDate.toString
> java.time.LocalDateTime.toString
> java.time.LocalTime.toString
温绍锦 has updated the pull request with a new target base due to a me
On Sat, 9 Sep 2023 08:32:44 GMT, Alan Bateman wrote:
> For `\\\?\`, the normalization will drop the trailing slash so the path
> string is actually `\\\?`. I think that case is okay.
This results in "Bad pathname" with both the master and the change.
> For input such as `\\\?\\foo` and `\\\?\\
On Mon, 11 Sep 2023 14:42:33 GMT, Claes Redestad wrote:
>> this place doesn't need off++
>
> It was a suggestion, implicitly paired with removing ` + (year < 0 ? 1 : 0)`
> from line 2188.
The reason for not using off++ is that it can be executed out of order, which
may result in better perform
On Mon, 11 Sep 2023 14:44:24 GMT, 温绍锦 wrote:
>> improve date toString performance, includes:
>>
>> java.util.Date.toString
>> java.util.Date.toGMTString
>> java.time.Instant.toString
>> java.time.LocalDate.toString
>> java.time.LocalDateTime.toString
>> java.time.LocalTime.toString
>
> 温绍锦 has u
> Some codes in core libs are duplicated, including:
> java.util.DecimalDigits::DIGITS -> java.lang.StringLatin1.PACKED_DIGITS
> java.util.DecimalDigits::size -> java.lang.Long.stringSize
>
> We can reduce duplication through JavaLangAccess, which is also needed in
> other places, such as:
> http
> Some codes in core libs are duplicated, including:
> java.util.DecimalDigits::DIGITS -> java.lang.StringLatin1.PACKED_DIGITS
> java.util.DecimalDigits::size -> java.lang.Long.stringSize
>
> We can reduce duplication through JavaLangAccess, which is also needed in
> other places, such as:
> http
On Fri, 8 Sep 2023 01:07:17 GMT, Brian Burkhalter wrote:
>> In the Windows implementation of java.io.File.getCanonicalPath, strip any
>> long path or UNC prefix before canonicalizing the remainder of the pathname.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additi
> Some codes in core libs are duplicated, including:
> java.util.DecimalDigits::DIGITS -> java.lang.StringLatin1.PACKED_DIGITS
> java.util.DecimalDigits::size -> java.lang.Long.stringSize
>
> We can reduce duplication through JavaLangAccess, which is also needed in
> other places, such as:
> http
> This patch contains the implementation of the foreign linker & memory API JEP
> for Java 22. The initial patch is composed of commits brought over directly
> from the [panama-foreign repo](https://github.com/openjdk/panama-foreign).
> The main changes found in this patch come from the followin
On Mon, 11 Sep 2023 14:54:57 GMT, 温绍锦 wrote:
>> src/java.base/share/classes/java/time/Instant.java line 1355:
>>
>>> 1353: @Override
>>> 1354: public String toString() {
>>> 1355: return DateTimeFormatter.ISO_INSTANT.format(this);
>>
>> Have you considered potentially more gener
On Mon, 11 Sep 2023 13:29:14 GMT, Claes Redestad wrote:
>> 温绍锦 has updated the pull request incrementally with one additional commit
>> since the last revision:
>>
>> fix LocalDate.getChars offset
>
> src/java.base/share/classes/java/time/Instant.java line 1355:
>
>> 1353: @Override
>> 1
On Mon, 11 Sep 2023 14:38:28 GMT, 温绍锦 wrote:
>> src/java.base/share/classes/java/time/LocalDate.java line 2181:
>>
>>> 2179: if (yearAbs < 1000) {
>>> 2180: if (year < 0) {
>>> 2181: buf[off] = '-';
>>
>> `buf[off++] = '-';`
>
> this place doesn't need off++
> improve date toString performance, includes:
>
> java.util.Date.toString
> java.util.Date.toGMTString
> java.time.Instant.toString
> java.time.LocalDate.toString
> java.time.LocalDateTime.toString
> java.time.LocalTime.toString
温绍锦 has updated the pull request incrementally with one additional
On Mon, 11 Sep 2023 13:50:30 GMT, Claes Redestad wrote:
>> 温绍锦 has updated the pull request incrementally with one additional commit
>> since the last revision:
>>
>> fix LocalDate.getChars offset
>
> src/java.base/share/classes/java/time/LocalDate.java line 2181:
>
>> 2179: if (year
On Mon, 11 Sep 2023 14:24:31 GMT, Martin Doerr wrote:
>@offamitkumar, @deepa181, @JoKern65, @TOatGithub: You may want to check
>performance impact on s390x and AIX.
@TheRealMDoerr Testing on s390 is not possible for now, as build is broken due
to field resolution changes.
-
PR Co
On Mon, 11 Sep 2023 12:23:36 GMT, 温绍锦 wrote:
>> Some codes in core libs are duplicated, including:
>> java.util.DecimalDigits::DIGITS -> java.lang.StringLatin1.PACKED_DIGITS
>> java.util.DecimalDigits::size -> java.lang.Long.stringSize
>>
>> We can reduce duplication through JavaLangAccess, whic
On Fri, 8 Sep 2023 20:36:31 GMT, 温绍锦 wrote:
>> [PR 14578 ](https://github.com/openjdk/jdk/pull/14578) still has unresolved
>> discussions, continue to make improvements.
>>
>> # Benchmark Result
>>
>>
>> sh make/devkit/createJMHBundle.sh
>> bash configure --with-jmh=build/jmh/jars
>> make tes
On Mon, 11 Sep 2023 13:32:07 GMT, Martin Doerr wrote:
>> 温绍锦 has updated the pull request incrementally with one additional commit
>> since the last revision:
>>
>> lo | hi => hi | lo
>
> I have run a couple of tests on linux Big Endian. They have passed. So, it's
> probably correct. However
On Mon, 11 Sep 2023 13:45:43 GMT, 温绍锦 wrote:
> After PR #15651 is merged, changes will be made based on the new API. Until
> then, you can help review other changes.
I mean, OpenJDK's GitHub bots has a special handling system that allows you to
include code from #15651 in this PR:
1. Merge yo
On Mon, 11 Sep 2023 13:53:19 GMT, Martin Doerr wrote:
> Shouldn't this get optimized by the JIT compilers? Why is
> `ByteArrayLittleEndian` supposed to be faster? Note that there are still
> several Big Endian platforms: AIX, s390x and old linux ppc64 (still kept
> alive)
And none of these ar
On Thu, 31 Aug 2023 22:48:30 GMT, Aleksei Efimov wrote:
> The change proposed in this PR improves the behavior of the JDK JNDI/LDAP
> provider when running in a virtual thread. Currently, when an LDAP operation
> is performed from a virtual thread context a pinned carrier thread is
> detected:
On Mon, 11 Sep 2023 07:13:07 GMT, 温绍锦 wrote:
>> https://bugs.openjdk.org/browse/JDK-8310929
>>
>> @TheRealMDoerr Feedback:
>>
>>
>> We're getting test failures on AIX:
>> compiler/intrinsics/Test8215792.java
>> compiler/intrinsics/string/TestStringIntrinsics.java
>> runtime/CompactStrings/Test
On Sun, 10 Sep 2023 18:54:33 GMT, Roger Riggs wrote:
>> 温绍锦 has updated the pull request incrementally with one additional commit
>> since the last revision:
>>
>> lo | hi => hi | lo
>
> Given the endian-ness issues with https://git.openjdk.org/jdk/pull/14699.
> I'll need to run a more comple
On Mon, 11 Sep 2023 12:12:17 GMT, 温绍锦 wrote:
> improve date toString performance, includes:
>
> java.util.Date.toString
> java.util.Date.toGMTString
> java.time.Instant.toString
> java.time.LocalDate.toString
> java.time.LocalDateTime.toString
> java.time.LocalTime.toString
As @liach says this
On Mon, 11 Sep 2023 07:13:07 GMT, 温绍锦 wrote:
>> https://bugs.openjdk.org/browse/JDK-8310929
>>
>> @TheRealMDoerr Feedback:
>>
>>
>> We're getting test failures on AIX:
>> compiler/intrinsics/Test8215792.java
>> compiler/intrinsics/string/TestStringIntrinsics.java
>> runtime/CompactStrings/Test
On Mon, 11 Sep 2023 13:42:30 GMT, Chen Liang wrote:
> I think you should make this a dependent of #15651, so you can change the
> base branch of pr to `openjdk:pr/15651` and you can base your work off that
> pull request too.
After PR #15651 is merged, changes will be made based on the new API
On Mon, 11 Sep 2023 12:50:43 GMT, Martin Doerr wrote:
> Your earlier version didn't work. The one which I have successfully tested is
> after 2nd commit.
I think this looks OK.
This patch probably reverts performance numbers on little-endian on some
measures to pre-JDK-8310929 levels. A follo
On Sun, 10 Sep 2023 16:39:30 GMT, 温绍锦 wrote:
> https://bugs.openjdk.org/browse/JDK-8310929
>
> @TheRealMDoerr Feedback:
>
>
> We're getting test failures on AIX:
> compiler/intrinsics/Test8215792.java
> compiler/intrinsics/string/TestStringIntrinsics.java
> runtime/CompactStrings/TestMethodNam
On Mon, 11 Sep 2023 07:13:07 GMT, 温绍锦 wrote:
>> https://bugs.openjdk.org/browse/JDK-8310929
>>
>> @TheRealMDoerr Feedback:
>>
>>
>> We're getting test failures on AIX:
>> compiler/intrinsics/Test8215792.java
>> compiler/intrinsics/string/TestStringIntrinsics.java
>> runtime/CompactStrings/Test
On Mon, 11 Sep 2023 12:12:17 GMT, 温绍锦 wrote:
> improve date toString performance, includes:
>
> java.util.Date.toString
> java.util.Date.toGMTString
> java.time.Instant.toString
> java.time.LocalDate.toString
> java.time.LocalDateTime.toString
> java.time.LocalTime.toString
I think you should m
On Fri, 8 Sep 2023 20:36:31 GMT, 温绍锦 wrote:
>> [PR 14578 ](https://github.com/openjdk/jdk/pull/14578) still has unresolved
>> discussions, continue to make improvements.
>>
>> # Benchmark Result
>>
>>
>> sh make/devkit/createJMHBundle.sh
>> bash configure --with-jmh=build/jmh/jars
>> make tes
On Fri, 8 Sep 2023 16:57:14 GMT, Mandy Chung wrote:
> Typically it will find the caller class at the second stack frame from the
> frame of executing `StackWalker::getCallerClass`. The initial size of the
> buffer can be changed from 8 to 4 (the top 2 elements are reserved for
> implementati
On Mon, 11 Sep 2023 07:13:07 GMT, 温绍锦 wrote:
>> https://bugs.openjdk.org/browse/JDK-8310929
>>
>> @TheRealMDoerr Feedback:
>>
>>
>> We're getting test failures on AIX:
>> compiler/intrinsics/Test8215792.java
>> compiler/intrinsics/string/TestStringIntrinsics.java
>> runtime/CompactStrings/Test
On Mon, 11 Sep 2023 12:12:17 GMT, 温绍锦 wrote:
> improve date toString performance, includes:
>
> java.util.Date.toString
> java.util.Date.toGMTString
> java.time.Instant.toString
> java.time.LocalDate.toString
> java.time.LocalDateTime.toString
> java.time.LocalTime.toString
@cl4es can you help
On Mon, 11 Sep 2023 12:12:17 GMT, 温绍锦 wrote:
> improve date toString performance, includes:
>
> java.util.Date.toString
> java.util.Date.toGMTString
> java.time.Instant.toString
> java.time.LocalDate.toString
> java.time.LocalDateTime.toString
> java.time.LocalTime.toString
@liach can you help
On Mon, 11 Sep 2023 10:33:10 GMT, 温绍锦 wrote:
>> These weren't in `java.util.DecimalDigits` but have been copied from
>> `java.lang.StringLatin1` - part of an unfinished refactoring? There's no
>> clear-cut answer where these best fits but it seems reasonable to keep them
>> in `StringLatin1` a
> Some codes in core libs are duplicated, including:
> java.util.DecimalDigits::DIGITS -> java.lang.StringLatin1.PACKED_DIGITS
> java.util.DecimalDigits::size -> java.lang.Long.stringSize
>
> We can reduce duplication through JavaLangAccess, which is also needed in
> other places, such as:
> http
improve date toString performance, includes:
java.util.Date.toString
java.util.Date.toGMTString
java.time.Instant.toString
java.time.LocalDate.toString
java.time.LocalDateTime.toString
java.time.LocalTime.toString
-
Commit messages:
- improve date toString performance, includes:
Ch
On Fri, 8 Sep 2023 15:31:02 GMT, Aleksey Shipilev wrote:
> @RogerRiggs asked for this. The moves are mechanical, so nothing should be
> lost. Tell me if other things need to be sorted as well.
>
> I would wait a little to see if there are any more JDK-8304913 followups.
This pull request has n
On Fri, 8 Sep 2023 15:31:02 GMT, Aleksey Shipilev wrote:
> @RogerRiggs asked for this. The moves are mechanical, so nothing should be
> lost. Tell me if other things need to be sorted as well.
>
> I would wait a little to see if there are any more JDK-8304913 followups.
Thank you!
---
On Fri, 8 Sep 2023 15:31:02 GMT, Aleksey Shipilev wrote:
> @RogerRiggs asked for this. The moves are mechanical, so nothing should be
> lost. Tell me if other things need to be sorted as well.
>
> I would wait a little to see if there are any more JDK-8304913 followups.
This looks fine to me.
On Mon, 11 Sep 2023 08:47:03 GMT, Martin Doerr wrote:
>> 温绍锦 has updated the pull request incrementally with one additional commit
>> since the last revision:
>>
>> remove ByteArrayLittleEndian
>
> This helps. I'll run more tests.
@TheRealMDoerr
Can you also help test the version Webrevs 0
On Mon, 11 Sep 2023 07:13:07 GMT, 温绍锦 wrote:
>> https://bugs.openjdk.org/browse/JDK-8310929
>>
>> @TheRealMDoerr Feedback:
>>
>>
>> We're getting test failures on AIX:
>> compiler/intrinsics/Test8215792.java
>> compiler/intrinsics/string/TestStringIntrinsics.java
>> runtime/CompactStrings/Test
On Tue, 5 Sep 2023 22:49:41 GMT, Erik Joelsson wrote:
> There are a number of files in the `test` directory that have an incorrect
> copyright header, which includes the "classpath" exception text. This patch
> removes that text from all test files that I could find it in. I did this
> using a
On Mon, 11 Sep 2023 09:38:44 GMT, Claes Redestad wrote:
>> src/java.base/share/classes/jdk/internal/util/DecimalDigits.java line 201:
>>
>>> 199: * @return index of the most significant digit or minus sign, if
>>> present
>>> 200: */
>>> 201: public static int getChars(int i, int
On Fri, 8 Sep 2023 20:36:31 GMT, 温绍锦 wrote:
>> [PR 14578 ](https://github.com/openjdk/jdk/pull/14578) still has unresolved
>> discussions, continue to make improvements.
>>
>> # Benchmark Result
>>
>>
>> sh make/devkit/createJMHBundle.sh
>> bash configure --with-jmh=build/jmh/jars
>> make tes
On Mon, 11 Sep 2023 08:49:18 GMT, Andrey Turbanov wrote:
>> 温绍锦 has updated the pull request incrementally with two additional commits
>> since the last revision:
>>
>> - remove duplicate stringSize
>> - update related comments
>
> src/java.base/share/classes/jdk/internal/util/DecimalDigits.j
On Fri, 8 Sep 2023 15:31:02 GMT, Aleksey Shipilev wrote:
> @RogerRiggs asked for this. The moves are mechanical, so nothing should be
> lost. Tell me if other things need to be sorted as well.
>
> I would wait a little to see if there are any more JDK-8304913 followups.
Any other reviews neede
On Mon, 11 Sep 2023 04:00:34 GMT, 温绍锦 wrote:
>> Some codes in core libs are duplicated, including:
>> java.util.DecimalDigits::DIGITS -> java.lang.StringLatin1.PACKED_DIGITS
>> java.util.DecimalDigits::size -> java.lang.Long.stringSize
>>
>> We can reduce duplication through JavaLangAccess, whic
On Mon, 11 Sep 2023 07:13:07 GMT, 温绍锦 wrote:
>> https://bugs.openjdk.org/browse/JDK-8310929
>>
>> @TheRealMDoerr Feedback:
>>
>>
>> We're getting test failures on AIX:
>> compiler/intrinsics/Test8215792.java
>> compiler/intrinsics/string/TestStringIntrinsics.java
>> runtime/CompactStrings/Test
1 - 100 of 103 matches
Mail list logo
