Re: RFR: 8317634: Introduce the ability to exclude modules from dedup-legal-notices plugin of jlink [v3]

2023-10-05 Thread Alan Bateman
On Fri, 6 Oct 2023 02:22:52 GMT, Jaikiran Pai wrote: >> Can I please get a review of this change which proposes to implement the >> enhancement request noted in https://bugs.openjdk.org/browse/JDK-8317634? >> >> The change in this commit introduces a new `exclude-modules` argument to the >>

Re: RFR: 8317634: Introduce the ability to exclude modules from dedup-legal-notices plugin of jlink [v3]

2023-10-05 Thread Jaikiran Pai
On Fri, 6 Oct 2023 02:22:52 GMT, Jaikiran Pai wrote: >> Can I please get a review of this change which proposes to implement the >> enhancement request noted in https://bugs.openjdk.org/browse/JDK-8317634? >> >> The change in this commit introduces a new `exclude-modules` argument to the >>

Re: RFR: 8317634: Introduce the ability to exclude modules from dedup-legal-notices plugin of jlink [v3]

2023-10-05 Thread Alan Bateman
On Fri, 6 Oct 2023 02:22:52 GMT, Jaikiran Pai wrote: >> Can I please get a review of this change which proposes to implement the >> enhancement request noted in https://bugs.openjdk.org/browse/JDK-8317634? >> >> The change in this commit introduces a new `exclude-modules` argument to the >>

Re: RFR: 8317515: Unify the code of the parse*() families of methods in j.l.Integer and j.l.Long [v2]

2023-10-05 Thread Quan Anh Mai
On Thu, 5 Oct 2023 10:31:31 GMT, Raffaello Giulietti wrote: >> See the [JBS issue](https://bugs.openjdk.org/browse/JDK-8317515) for the >> details. > > Raffaello Giulietti has updated the pull request incrementally with one > additional commit since the last revision: > > Avoid localized

Re: RFR: 8317515: Unify the code of the parse*() families of methods in j.l.Integer and j.l.Long [v2]

2023-10-05 Thread Quan Anh Mai
On Thu, 5 Oct 2023 10:31:31 GMT, Raffaello Giulietti wrote: >> See the [JBS issue](https://bugs.openjdk.org/browse/JDK-8317515) for the >> details. > > Raffaello Giulietti has updated the pull request incrementally with one > additional commit since the last revision: > > Avoid localized

Re: RFR: 8317634: Introduce the ability to exclude modules from dedup-legal-notices plugin of jlink [v3]

2023-10-05 Thread Jaikiran Pai
> Can I please get a review of this change which proposes to implement the > enhancement request noted in https://bugs.openjdk.org/browse/JDK-8317634? > > The change in this commit introduces a new `exclude-modules` argument to the > `dedup-legal-notices` jlink plugin. This optional argument

Re: RFR: 8317634: Introduce the ability to exclude modules from dedup-legal-notices plugin of jlink [v2]

2023-10-05 Thread Jaikiran Pai
> Can I please get a review of this change which proposes to implement the > enhancement request noted in https://bugs.openjdk.org/browse/JDK-8317634? > > The change in this commit introduces a new `exclude-modules` argument to the > `dedup-legal-notices` jlink plugin. This optional argument

RFR: 8317634: Introduce the ability to exclude modules from dedup-legal-notices plugin of jlink

2023-10-05 Thread Jaikiran Pai
Can I please get a review of this change which proposes to implement the enhancement request noted in https://bugs.openjdk.org/browse/JDK-8317634? The change in this commit introduces a new `exclude-modules` argument to the `dedup-legal-notices` jlink plugin. This optional argument takes a

Re: RFR: 8309130: x86_64 AVX512 intrinsics for Arrays.sort methods (int, long, float and double arrays) [v41]

2023-10-05 Thread Vladimir Kozlov
On Thu, 5 Oct 2023 23:39:20 GMT, Srinivas Vamsi Parasa wrote: >> In general it looks good. I have some code style comments and file name >> change request. >> After you fix that I will need to rerun testing for it before approval. > >> In general it looks good. I have some code style comments

Re: RFR: 8309130: x86_64 AVX512 intrinsics for Arrays.sort methods (int, long, float and double arrays) [v42]

2023-10-05 Thread Srinivas Vamsi Parasa
> The goal is to develop faster sort routines for x86_64 CPUs by taking > advantage of AVX512 instructions. This enhancement provides an order of > magnitude speedup for Arrays.sort() using int, long, float and double arrays. > > This PR shows upto ~7x improvement for 32-bit datatypes (int,

Re: RFR: 8309130: x86_64 AVX512 intrinsics for Arrays.sort methods (int, long, float and double arrays) [v41]

2023-10-05 Thread Srinivas Vamsi Parasa
On Thu, 5 Oct 2023 18:46:46 GMT, Vladimir Kozlov wrote: > In general it looks good. I have some code style comments and file name > change request. After you fix that I will need to rerun testing for it before > approval. Hello Vladimir (@vnkozlov), Thank you for the suggestions related to

Integrated: 8317443: StackOverflowError on calling ListFormat::getInstance() for Norwegian locales

2023-10-05 Thread Naoto Sato
On Wed, 4 Oct 2023 17:17:57 GMT, Naoto Sato wrote: > Please review the fix to the subject issue. This was found during upgrading > CLDR to v44, in which some list patterns are missing (thus to be inherited > from parents) in Norwegian locales which could end up with infinite parent > lookup.

Withdrawn: 8303762: [vectorapi] Intrinsification of Vector.slice

2023-10-05 Thread duke
On Tue, 7 Mar 2023 18:23:42 GMT, Quan Anh Mai wrote: > `Vector::slice` is a method at the top-level class of the Vector API that > concatenates the 2 inputs into an intermediate composite and extracts a > window equal to the size of the inputs into the result. It is used in vector >

Re: RFR: 8317471: ListFormat::parseObject() spec can be improved on parsePosition valid values

2023-10-05 Thread Joe Wang
On Thu, 5 Oct 2023 17:57:00 GMT, Naoto Sato wrote: > Adding IOOBE clause to clarify the behavior on an invalid `parsePos` argument > on calling `ListFormat::parseObject()`. A corresponding CSR has also been > drafted. Marked as reviewed by joehw (Reviewer). - PR Review:

RFR: JDK-8317631: Refactor ChoiceFormat tests to use JUnit

2023-10-05 Thread Justin Lu
Please review this PR which refactors the ChoiceFormat tests to use JUnit. - Commit messages: - init Changes: https://git.openjdk.org/jdk/pull/16065/files Webrev: https://webrevs.openjdk.org/?repo=jdk=16065=00 Issue: https://bugs.openjdk.org/browse/JDK-8317631 Stats: 141 lines

Re: RFR: 8317471: ListFormat::parseObject() spec can be improved on parsePosition valid values

2023-10-05 Thread Lance Andersen
On Thu, 5 Oct 2023 17:57:00 GMT, Naoto Sato wrote: > Adding IOOBE clause to clarify the behavior on an invalid `parsePos` argument > on calling `ListFormat::parseObject()`. A corresponding CSR has also been > drafted. Marked as reviewed by lancea (Reviewer). - PR Review:

Re: RFR: 8316704: Regex-free parsing of Formatter and FormatProcessor specifiers [v16]

2023-10-05 Thread 温绍锦
> @cl4es made performance optimizations for the simple specifiers of > String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the > same idea, I continued to make improvements. I made patterns like %2d %02d > also be optimized. > > The following are the test results based on

Re: RFR: 8317471: ListFormat::parseObject() spec can be improved on parsePosition valid values

2023-10-05 Thread Iris Clark
On Thu, 5 Oct 2023 17:57:00 GMT, Naoto Sato wrote: > Adding IOOBE clause to clarify the behavior on an invalid `parsePos` argument > on calling `ListFormat::parseObject()`. A corresponding CSR has also been > drafted. Documents existing behaviour. Associated CSR also Reviewed. -

Re: RFR: 8309130: x86_64 AVX512 intrinsics for Arrays.sort methods (int, long, float and double arrays) [v41]

2023-10-05 Thread Vladimir Kozlov
On Fri, 22 Sep 2023 16:53:21 GMT, Srinivas Vamsi Parasa wrote: >> The goal is to develop faster sort routines for x86_64 CPUs by taking >> advantage of AVX512 instructions. This enhancement provides an order of >> magnitude speedup for Arrays.sort() using int, long, float and double arrays.

RFR: 8317471: ListFormat::parseObject() spec can be improved on parsePosition valid values

2023-10-05 Thread Naoto Sato
Adding IOOBE clause to clarify the behavior on an invalid `parsePos` argument on calling `ListFormat::parseObject()`. A corresponding CSR has also been drafted. - Commit messages: - initial commit Changes: https://git.openjdk.org/jdk/pull/16063/files Webrev:

Re: RFR: 8316996: Catalog API Enhancement: add a factory method

2023-10-05 Thread Naoto Sato
On Wed, 4 Oct 2023 22:56:28 GMT, Joe Wang wrote: > Add a new factory method so that a CatalogResolver can be created with a > resolve property on top of the Catalog object. src/java.xml/share/classes/javax/xml/catalog/CatalogManager.java line 101: > 99: * and {@code ignore}. {@code null}

Re: RFR: 8316704: Regex-free parsing of Formatter and FormatProcessor specifiers [v15]

2023-10-05 Thread Raffaello Giulietti
On Thu, 28 Sep 2023 21:40:17 GMT, 温绍锦 wrote: >> @cl4es made performance optimizations for the simple specifiers of >> String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the >> same idea, I continued to make improvements. I made patterns like %2d %02d >> also be optimized.

Re: RFR: 8316704: Regex-free parsing of Formatter and FormatProcessor specifiers [v15]

2023-10-05 Thread Raffaello Giulietti
On Thu, 28 Sep 2023 21:40:17 GMT, 温绍锦 wrote: >> @cl4es made performance optimizations for the simple specifiers of >> String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the >> same idea, I continued to make improvements. I made patterns like %2d %02d >> also be optimized.

Re: RFR: 8308753: Class-File API transition to Preview [v15]

2023-10-05 Thread Adam Sotona
> Classfile API is an internal library under package `jdk.internal.classfile`  > in JDK 21. > This pull request turns the Classfile API into a preview feature and moves it > into `java.lang.classfile`. > It repackages all uses across JDK and tests and adds lots of missing Javadoc. > > This PR

Re: RFR: 8303374: Compiler Implementation for Primitive types in patterns, instanceof, and switch (Preview) [v11]

2023-10-05 Thread Aggelos Biboudis
> This is the first draft of a patch for Primitive types in patterns, > instanceof, and switch (Preview). > > Draft spec here: > https://cr.openjdk.org/~abimpoudis/instanceof/instanceof-20230913/specs/instanceof-jls.html Aggelos Biboudis has updated the pull request with a new target base due

Re: RFR: 8317515: Unify the code of the parse*() families of methods in j.l.Integer and j.l.Long [v2]

2023-10-05 Thread Claes Redestad
On Thu, 5 Oct 2023 10:31:31 GMT, Raffaello Giulietti wrote: >> See the [JBS issue](https://bugs.openjdk.org/browse/JDK-8317515) for the >> details. > > Raffaello Giulietti has updated the pull request incrementally with one > additional commit since the last revision: > > Avoid localized

Re: RFR: 8303374: Compiler Implementation for Primitive types in patterns, instanceof, and switch (Preview) [v3]

2023-10-05 Thread Aggelos Biboudis
On Thu, 5 Oct 2023 08:14:53 GMT, Aggelos Biboudis wrote: >> Aren't there cases here where the type of the expr is unconditional w.r.t. >> the type of the pattern (and so, no test is required) ? Perhaps the case I'm >> thinking of is dealt with one of the ifs at the beginning of this method.

Re: RFR: 8303374: Compiler Implementation for Primitive types in patterns, instanceof, and switch (Preview) [v10]

2023-10-05 Thread Aggelos Biboudis
> This is the first draft of a patch for Primitive types in patterns, > instanceof, and switch (Preview). > > Draft spec here: > https://cr.openjdk.org/~abimpoudis/instanceof/instanceof-20230913/specs/instanceof-jls.html Aggelos Biboudis has updated the pull request incrementally with one

Re: RFR: 8317515: Unify the code of the parse*() families of methods in j.l.Integer and j.l.Long [v2]

2023-10-05 Thread Raffaello Giulietti
On Thu, 5 Oct 2023 10:31:31 GMT, Raffaello Giulietti wrote: >> See the [JBS issue](https://bugs.openjdk.org/browse/JDK-8317515) for the >> details. > > Raffaello Giulietti has updated the pull request incrementally with one > additional commit since the last revision: > > Avoid localized

Re: RFC: 8309726: Reader::readString

2023-10-05 Thread Aleksei Ivanov
Hi Markus, You posted it to the wrong list, it belongs on core-libs-dev. -- Regards, Alexey On 10/06/2023 12:35, Markus Karg wrote: By analyzing several existing applications I noticed that many of them need to read a String from an input source (be it an input stream or a reader), and

Re: RFR: 8317515: Unify the code of the parse*() families of methods in j.l.Integer and j.l.Long [v2]

2023-10-05 Thread 温绍锦
On Thu, 5 Oct 2023 10:31:31 GMT, Raffaello Giulietti wrote: >> See the [JBS issue](https://bugs.openjdk.org/browse/JDK-8317515) for the >> details. > > Raffaello Giulietti has updated the pull request incrementally with one > additional commit since the last revision: > > Avoid localized

Re: RFR: JDK-8315026: java/lang/ProcessHandle/TreeTest.java fails intermittent on AIX in TreeTest.test5

2023-10-05 Thread Matthias Baesken
On Thu, 5 Oct 2023 10:02:05 GMT, Joachim Kern wrote: > We see rather often failures in java/lang/ProcessHandle/TreeTest.java on AIX > in TreeTest.test5. > > test TreeTest.test5(): failure > java.lang.AssertionError: expected direct children expected [2] but found [3] > at

Re: RFR: 8303374: Compiler Implementation for Primitive types in patterns, instanceof, and switch (Preview) [v8]

2023-10-05 Thread Aggelos Biboudis
On Thu, 5 Oct 2023 09:58:52 GMT, Maurizio Cimadamore wrote: >> Aggelos Biboudis has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Declutter Lower.visitTypeTest > > src/java.base/share/classes/java/lang/runtime/ExactnessMethods.java line

Re: RFR: 8303374: Compiler Implementation for Primitive types in patterns, instanceof, and switch (Preview) [v9]

2023-10-05 Thread Aggelos Biboudis
> This is the first draft of a patch for Primitive types in patterns, > instanceof, and switch (Preview). > > Draft spec here: > https://cr.openjdk.org/~abimpoudis/instanceof/instanceof-20230913/specs/instanceof-jls.html Aggelos Biboudis has updated the pull request incrementally with one

RFR: JDK-8315026: java/lang/ProcessHandle/TreeTest.java fails intermittent on AIX in TreeTest.test5

2023-10-05 Thread Joachim Kern
We see rather often failures in java/lang/ProcessHandle/TreeTest.java on AIX in TreeTest.test5. test TreeTest.test5(): failure java.lang.AssertionError: expected direct children expected [2] but found [3] at org.testng.Assert.fail(Assert.java:99) at

Re: RFR: 8317515: Unify the code of the parse*() families of methods in j.l.Integer and j.l.Long [v2]

2023-10-05 Thread Raffaello Giulietti
> See the [JBS issue](https://bugs.openjdk.org/browse/JDK-8317515) for the > details. Raffaello Giulietti has updated the pull request incrementally with one additional commit since the last revision: Avoid localized integers in radix-out-of-range exception messages. - Changes:

Re: RFR: 8303374: Compiler Implementation for Primitive types in patterns, instanceof, and switch (Preview) [v8]

2023-10-05 Thread Maurizio Cimadamore
On Thu, 5 Oct 2023 08:20:58 GMT, Aggelos Biboudis wrote: >> This is the first draft of a patch for Primitive types in patterns, >> instanceof, and switch (Preview). >> >> Draft spec here: >> https://cr.openjdk.org/~abimpoudis/instanceof/instanceof-20230913/specs/instanceof-jls.html > >

Re: RFR: 8303374: Compiler Implementation for Primitive types in patterns, instanceof, and switch (Preview) [v8]

2023-10-05 Thread Maurizio Cimadamore
On Thu, 5 Oct 2023 08:20:58 GMT, Aggelos Biboudis wrote: >> This is the first draft of a patch for Primitive types in patterns, >> instanceof, and switch (Preview). >> >> Draft spec here: >> https://cr.openjdk.org/~abimpoudis/instanceof/instanceof-20230913/specs/instanceof-jls.html > >

Re: RFR: 8303374: Compiler Implementation for Primitive types in patterns, instanceof, and switch (Preview) [v8]

2023-10-05 Thread Maurizio Cimadamore
On Thu, 5 Oct 2023 08:20:58 GMT, Aggelos Biboudis wrote: >> This is the first draft of a patch for Primitive types in patterns, >> instanceof, and switch (Preview). >> >> Draft spec here: >> https://cr.openjdk.org/~abimpoudis/instanceof/instanceof-20230913/specs/instanceof-jls.html > >

RFR: 8317515: Unify the code of the parse*() families of methods in j.l.Integer and j.l.Long

2023-10-05 Thread Raffaello Giulietti
See the [JBS issue](https://bugs.openjdk.org/browse/JDK-8317515) for the details. - Commit messages: - 8317515: Unify the code of the parse*() families of methods in j.l.Integer and j.l.Long Changes: https://git.openjdk.org/jdk/pull/16050/files Webrev:

Re: RFR: 8303374: Compiler Implementation for Primitive types in patterns, instanceof, and switch (Preview) [v8]

2023-10-05 Thread Aggelos Biboudis
> This is the first draft of a patch for Primitive types in patterns, > instanceof, and switch (Preview). > > Draft spec here: > https://cr.openjdk.org/~abimpoudis/instanceof/instanceof-20230913/specs/instanceof-jls.html Aggelos Biboudis has updated the pull request incrementally with one

Re: RFR: 8303374: Compiler Implementation for Primitive types in patterns, instanceof, and switch (Preview) [v3]

2023-10-05 Thread Aggelos Biboudis
On Tue, 3 Oct 2023 08:54:57 GMT, Maurizio Cimadamore wrote: >> Aggelos Biboudis has updated the pull request with a new target base due to >> a merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains four additional

Re: RFR: 8303374: Compiler Implementation for Primitive types in patterns, instanceof, and switch (Preview) [v3]

2023-10-05 Thread Aggelos Biboudis
On Tue, 3 Oct 2023 09:05:17 GMT, Maurizio Cimadamore wrote: >> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Lower.java line 2982: >> >>> 2980: // => >>> 2981: // if (let tmp$123 = v; >>> ExactnessChecks.int_float(tmp$123)) >>> 2982:

Re: RFR: 8308753: Class-File API transition to Preview [v14]

2023-10-05 Thread Adam Sotona
On Wed, 4 Oct 2023 09:30:16 GMT, Adam Sotona wrote: >> Classfile API is an internal library under package `jdk.internal.classfile`  >> in JDK 21. >> This pull request turns the Classfile API into a preview feature and moves >> it into `java.lang.classfile`. >> It repackages all uses across JDK